PQR - Rotation Bot

[Kinky]

@osbornx22: Okay. Let me try and rephrase my previous post.

You're not dispelling yourself because your solo environment is not defined. Just setting your group to solo does nothing.
The same goes for dispelling yourself in a raid or group environment, because you're not counted among the returns of GetNumGroupMembers().

Secondly, it's not working because you're using some lua-only references, such as type for instance causing an endless loop through members without acquiring a target to dispel.

Thirdly, you wanted to know if there is some faster way of doing what you're trying to achieve. If it looks more pretty than your code, be that as it may, it's still 119% faster and allows you to quickly populate and update a spell debuff list, a debuff blacklist and dispel types without having to do any major rewriting to the code as new tiers are released or you want to add more debuffs to the blacklist.

-- Dispel to use
PQ_Cleanse = 4987

-- Group setting
if IsInRaid() then group = "raid"
    elseif IsInGroup() then group = "party" end

if GetNumGroupMembers() > 0 then
    -- Loop party or raid members
    for i=1,GetNumGroupMembers() do
        local debuffCount = 0        -- Set the counter to zero
        local maxCount = 0            -- Max debuffs to look for
        local member = group..i
        PQR_CustomTarget = "player"    -- Set our default target to Player
        
        -- Do not dispel these spells
        local blackList = {33786,131736,30108,30108,124465,34914}
        
        -- Dispel Type
        local dispelType = {Magic,Disease,Poison}
        
        -- At any given time, we can only have a total of 40 debuffs
        for i=1,40 do
            -- Loop our dispelTypes
            for x=1,#dispelType do
                -- Only fetch debuffs matching dispelType
                if select(5,UnitDebuff(member,i)) == dispelType[x] then
                    -- If it's blacklisted, don't dispel it
                    for i=1,#blackList do
                        if UnitDebuff(member,blackList[i]) then return false end
                    end
                    
                    -- At this point, we have cross referenced everything - Proceed
                    -- Check if Cleanse is in range, off cooldown and not out of sight
                    if IsSpellInRange(GetSpellInfo(PQ_Cleanse),member) == 1
                        and not PQR_IsOutOfSight(member)
                        and PQR_SpellAvailable(PQ_Cleanse) then
                            -- Count debuffs
                            debuffCount = debuffCount + 1
                            
                            -- if the number of count is equal or greater to maxCount, return true
                            if debuffCount >= maxCount then
                                PQR_CustomTarget = member
                                return true
                            end
                    end
                end
            end
        end
    end
end 

This should properly count the amount of debuffs you have on you as well as setting your target properly. Again, I have no way of testing it as I don't have a high level Paladin to test it on.
Remember to set Spell ID to Cleanse's Spell ID and Target to Custom.

Alternatively, you can try and replace

for k = 1, 40 do            
                local name, rank, icon, count, type = UnitDebuff(mem,k)
                
                if type == "Poison"
                or type == "Disease"
                or type == "Magic"
                then
                    PQR_CustomTarget = mem
                    return true                    
                end                    
            end 

with this

            for k = 1, 40 do
                local dispelType = select(5,UnitDebuff(mem,k))
                
                if dispelType == "Poison"
                    or dispelType == "Disease"
                    or dispelType == "Magic"
                then PQR_CustomTarget = mem return true end
            end 

Hope that clears up any confusion and that I was of any help at all.
I updated the code for a Holy Paladin's Cleanse and tried to document every step in my own code.

[osbornx22]

Yes, thank you, i understand, but:

1.
With faster way i just mean the UnitDebuff function. I think they have Filter like UnitDebuff("target",1,"POSION") or "DISPELLABLE" but i dont see thing like this documented anywhere. I think its not possible and we just need to check dispelType.

2.
The keyword "type" is not a problem, because my code without counting works well. In notepad++ "type" is marked as lua-reserved-word, but it works, there is no problem with "type".

3.
The problem with "solo" and "speed" is not important. My main problem is: Where is the mistake in the code in my first post reffering to this cleanse problem. I dont need other code, i just want to know, where the mistake is And "type" is not the mistake.

But i will test your counting code also. Im know in a rated bg group, after this i will test your code in a random group.

Also i will take your blacklist etc. code, its better, but i want to know where the mistake in my code is There is no lua error ingame, i tested it.

PS: GetNumGroupMembers() counts the player self just in raid, but not in group or solo. If im in group or solo, i need to check myself additionally.

PPS: I changed the code a littly bit to find the problem:

--print("dispel start")

local group = "solo"

local black = {
33786,
131736,
30108,
124465,
34914
}

local dtypes = {
"Poison",
"Disease",
"Magic"
}

if IsInRaid() then
	group = "raid"
elseif IsInGroup() then
	group = "party"
end

--------------- IF SOLO OR GROUP -----------------

if group ~= "raid" then
	local mem = "player"
		
	if IsSpellInRange("Läuterung",mem) == 1
	and not PQR_IsOutOfSight(mem)
	and UnitDebuffID(mem, 33786) == nil
	and UnitDebuffID(mem, 131736) == nil
	and UnitDebuffID(mem, 30108) == nil	
	and UnitDebuffID(mem, 124465) == nil
	and UnitDebuffID(mem, 34914) == nil
	then
		for k = 1, 40 do			
			
			-- print("dispel "..mem)
			
			local name, rank, icon, count, dtype = UnitDebuff(mem,k)
			
			if dtype == "Poison"
			or dtype == "Disease"
			or dtype == "Magic"
			then
				
				-- print("type "..dtpye.." on "..mem)
				
				PQR_CustomTarget = mem
				return true
			end					
		end			
	end		
end

--------------- IF GROUP OR RAID -----------------

if group ~= "solo" then
	local maxMem = GetNumGroupMembers()	
	
	local count = 0
	local maxCount = 0
	local maxTar = "player"
		
	for num = 1, maxMem do	
		local mem = group..num
		
		if IsSpellInRange("Läuterung",mem) == 1
		and not PQR_IsOutOfSight(mem)
		and UnitDebuffID(mem, 33786) == nil
		and UnitDebuffID(mem, 131736) == nil
		and UnitDebuffID(mem, 30108) == nil		
		and UnitDebuffID(mem, 124465) == nil
		and UnitDebuffID(mem, 34914) == nil
		then			
			count = 0
			
			-- print("dispel "..mem)
				
			for k = 1, 40 do			
				local name, rank, icon, count, dtype = UnitDebuff(mem,k)
				
				if dtype == "Poison"
				or dtype == "Disease"
				or dtype == "Magic"
				then					
					count = count + 1						
					
					-- print("type "..dtype.." on "..mem.." and count "..count)
				end					
			end		
		
			if count > maxCount then
			
				print("count "..count.." > maxCount "..maxCount.." on "..mem)
				maxTar = mem
				maxCount = count
			end			
		end				
	end
	
	if maxCount > 0 then
	
		print("maxCount "..maxCount.." on "..maxTar)
		PQR_CustomTarget = maxTar
		return true
	end	
end

if i run this code, i get prints for:

dispel mem -> OK
type dtype .... -> OK
count count maxCount ... -> NOT OK

Why?

[Kinky]

@osbornx22: I'll try and help you where I can:
First off, join a party with anyone, then do this /script print(GetNumGroupMembers())

Last time I checked, yesterday, it returns the number of people in your Raid or Party.
docs/api/GetNumGroupMembers - World of Warcraft Programming: A Guide and Reference for Creating WoW Addons

UnitDebuff() filters are also quite well-documented here:
UnitDebuff - World of Warcraft Programming: A Guide and Reference for Creating WoW Addons

I'm not exactly sure where you're going wrong: Try removing the second count = 0 statement after checking the debuffs and if Cleanse is in range.

Also, why are you first setting maxCount to 0, then count to 0, then setting count to 0 again, then setting maxCount to the value of count, then outside the loop, checking if maxCount is higher than 0?

To better help you, could you try and describe your process of thought and essentially what you want to achieve? It'd be a lot easier to help you.

[evlow]

mentally is correct, GetNumGroupMembers() works in raid or party. I just tested it myself, and solo it would always return 0.

[osbornx22]

Ok, sry for GetNumGroupMembers(), i thought in party this doesnt count player self. I invite one player to a party. Now we are two player in a party. Then GetNumGroupMembers() return 2. My fail sry. But now i cant get player by party1 or party2. Just party1 is the other one in the group

However, this is no problem. Let party and solo cases out. Just the raid case is important, because normally i just do raid pvp.

After reading mentallys code, i do this:

local blacklist = {
33786,
131736,
30108,
124465,
34914
}

local dispelTypes = {
"Poison",
"Disease",
"Magic"
}

local function hasDontDispel(tar)
	for x = 1, #blacklist do
		if UnitDebuffID(tar,blacklist[x]) ~= nil then
			return true
		end
	end
	
	return false
end

local function numDispelDebuff(tar)
	local count = 0
	
	for x = 1, 40 do
		local dtype = select(5,UnitDebuff(tar,x))
		
		for y = 1, #dispelTypes do
			if dtype == dispelTypes[y] then
				count = count + 1
			end
		end
	end
	
	return count
end

local maxMem = GetNumGroupMembers()
local maxDebuffs = 0
local maxTar = "player"

for x = 1, maxMem do
	local mem = "raid"..x	
	
	if IsSpellInRange("Läuterung",mem) == 1
	and not PQR_IsOutOfSight(mem)	
	and not hasDontDispel(mem)	
	then
		local temp = numDispelDebuff(mem)
		
		if temp > maxDebuffs then
			maxDebuffs = temp
			maxTar = mem
		end
	end
end

if maxDebuffs > 0 then
	PQR_CustomTarget = maxTar
	return true
end

The most of this code is copied from mentally, but i move the functions and statics to external lua file (PQR_LoadLua.....).

I tested it and now it dispells. I think its works correctly, but im not 100% sure, because its very difficult to check, if its dispells the one with the most debuffs. The complete rotations works very fast and has many conditions. I will test it in a couple more bgs and try to see, if more then one has a dispellable debuff and no debuff from the blacklist, if its correctly dispelling the one with more debuffs.

Thank you very much for your help.

PS: And of course, sry for my bad english

[Kinky]

Glad I was of any help! And if it turns out good, then great!

[osbornx22]

Yes, i tested it a few times in bgs and it works great Most of the games i have 70%+ of overall dispells

[Edsaxe]

Anyone got an up to date list of what pvp profiles are working on the ptr?

[Kinkeh]

Anyone got an up to date list of what pvp profiles are working on the ptr?

Not possible, since there are no offsets for the current PTR build or even recent builds...though any profile for a class that hasn't had any major changes to how the structure of the profiles works will be fine or will be fine in a couple fixes.

[Timekill]

i am currently having some issues with a profile and would like to know where to start in figuring it out....is there a way to get a log of the actions performed?
I'm kinda new here and would like to be an active member in the community.... but have lots to learn lol

any suggestions would be greatly appreciated

[Kinkeh]

i am currently having some issues with a profile and would like to know where to start in figuring it out....is there a way to get a log of the actions performed?
I'm kinda new here and would like to be an active member in the community.... but have lots to learn lol

any suggestions would be greatly appreciated

Go to settings in PQR.

Then
Change the Debug Level to whichever you prefer, Basic is usually good and will display each ability that is being casted currently from the profile. Make sure messages in chat are enabled and click save.


OR

Download PQI(Addon for PQR, so place the folder inside your addons folder): PQInterface.zip
^^ This version was updated by Mentally but the future builds will most likely be maintained by Diesall.

[crystal_tech]

Updated SV Hunter:

link: http://goo.gl/K8tCW

notes:
talents are direbeast, glaive toss, AMOC

it has Nova_Frame added.
Its not on the Nova SVN yet.

I likes rep and feedback.

[paintpauller]

i have used PQR for some time and it has always worked, but after 2 months off wow i can no longer get it to activate.
what i mean by this is when i lunch PQR and select the wow instance it will look as if its working but when i go in-game and try to activate a profile nothing happens.
i have turned off all addons, even downloaded a fresh PQR and still nothing. PQinterface tells me that "PQR NOT LOADED" i really need this to work for tonight's raid any help would be much appreciated!


EDIT: got it working =D

[ashdale]

Hello everyone I'm just starting to work with PQR and mess with some of the great scripts and packages that authors have posted here. I'm not a coder by any means, but am trying to learn about it by basically hacking up some scripts and playing with the functions. I've got a question about a function that I have that isn't working and i'm not sure why, i'm sure its something easy, but I cant see it and would be great if someone could point me in the right direction plz.

if members[1].HP < 90
	and ( UnitPower("player", 9) > 0 or UnitBuffID("player",90174) )
	and IsSpellInRange(GetSpellInfo(114163), members[1].Unit) == 1
	and not PQR_IsOutOfSight(members[1].Unit, 1)
then
	PQR_CustomTarget = members[1].Unit
	CastSpellByName(GetSpellInfo(114163), PQR_CustomTarget)
    return true
end

Any ideas? Basically a holy pally function that should (at least I want it to) check holy power and if its above 0 or Divine Purpose has proced and the member is in range to cast it on and is not out of sight then set the target and cast EF on them.

[TheOzman]

Try

for memberId, member in pairs(members) do
    local healthPoints, holyPower, unit, divinePurpose, eternalFlame = member.HP, UnitPower("player", SPELL_POWER_HOLY_POWER), member.Unit, UnitBuffID("player",90174), GetSpellInfo(114163)
    if (healthPoints < 90) and (holyPower > 0 or divinePurpose) and (IsSpellInRange(eternalFlame, unit) == 1) and (not PQR_IsOutOfSight(unit, 1))
    then
        CastSpellByName(eternalFlame, unit)
        return true
    end
end