[BETA] PQRotation - an automated ability priority queue.

[Kinky]

@Firepong: a9058727 posted the updated code. (I was tired, my code had some stability issues with it!)

I re-uploaded an update to my previously released profile. Sat up til 6am working on it and on a fix for the issues posted.

Anyhow, if you're too lazy to go back a post to grab an update, you can find it here: Mentally's Shadowpriest Profile v5.2

Update - 17.03.2012:
- Fixed a return bug where a Unit previously affected with an immunity buff would still be tagged as immune.

Really sucks that I can't debug my own code in a raiding environment besides LFR for the moment, hopefully that changes soon enough!

[googlebee]

@googlebee: Basically you want to cast Pulverize only when Lacerate has 3+ stacks and 3 seconds left on the Pulverize buff?

local Lacerate = select(4,UnitDebuffID("target",33745))

if Lacerate and Lacerate >= 3 then
    local Pulverize = select(7,UnitBuffID("player",80951))
    if Pulverize then
        if Pulverize - GetTime() <= 3 then return true end
    else return true end
end

Not sure if it's the way you wanted it, basically, this returns true if Lacerate has 3 stacks and Pulverize has 3 seconds or less left on the buff or is not currently active.

Works Perfectly....thank you and Bub for the help on that.

+rep

[googlebee]

Just updating my bear profile (As i hadnt in a couple months now)

Just having an issue with Berserk now ( IN Bearform)

Basically I only want to trigger Berserk in bear, when the pulverize buff is active and has > 16 seconds remaining on the pulverize buff duration.

This will maximize dmg output for bears (+9% crit), but more importantly will proc savage defense absorbs nearly at a 90% uptime.

This whole timing thing has my head in circles.

Berserk Spell ID: (50334)
Pulverize Buff ID on player: (80951)

I was trying to get this to work before even adding in the pulverize buff duration and it wasnt working either.

local targetLevel = UnitLevel("target")
local playerPower = UnitPower("player")
local Pulverize = (UnitBuffID("player",80951)


        if playerPower > 20 and Pulverize ~= nil then
            return true
        end
    end
else
    if targetLevel == -1 or targetLevel >= 87 then
        if playerPower > 25 and Pulverize ~= nil then
            return true
        end
    end
end

This is the last adjustment needed to update my profile.... Any help greatly appreciated!

[bu_ba_911]

Just updating my bear profile (As i hadnt in a couple months now)

Just having an issue with Berserk now ( IN Bearform)

Basically I only want to trigger Berserk in bear, when the pulverize buff is active and has > 16 seconds remaining on the pulverize buff duration.

This will maximize dmg output for bears (+9% crit), but more importantly will proc savage defense absorbs nearly at a 90% uptime.

This whole timing thing has my head in circles.

Berserk Spell ID: (50334)
Pulverize Buff ID on player: (80951)

I was trying to get this to work before even adding in the pulverize buff duration and it wasnt working either.

local targetLevel = UnitLevel("target")
local playerPower = UnitPower("player")
local Pulverize = (UnitBuffID("player",80951)


        if playerPower > 20 and Pulverize ~= nil then
            return true
        end
    end
else
    if targetLevel == -1 or targetLevel >= 87 then
        if playerPower > 25 and Pulverize ~= nil then
            return true
        end
    end
end

This is the last adjustment needed to update my profile.... Any help greatly appreciated!

this isn't the whole code is it?

*edit*

bwahahaha who can help get Mentally 8 more rep, that would be 4-5 blue posters acquired from a single thread

[Deva]

I don't currently have a BearCat spec (though I will soon, for testing), but this... might work?

local targetLevel = UnitLevel("target")
local playerPower = UnitPower("player")
local PulverizeTimer = select(7,UnitBuffID("player",80951))
local PulverizeLeft = PulverizeTimer - GetTime()
local BerserkCD = select(2,GetSpellCooldown(50334))

if PulverizeTimer == nil then
	PQR_DebugP("Pulverize not up, halting.")
	return false
else
	local PulverizeLeft = PulverizeTimer - GetTime()
	if (BerserkCD > 0) then
		PQR_DebugP("Pulverize up, but Berserk on CD, halting.")
		return false 
	end
	if (BerserkCD == 0 and playerPower >= 20) then
		PQR_DebugP("Rage greater than or equal to 20 and Pulverize up.")
		if (PulverizeLeft >= 16) then
			PQR_DebugP("Greater than or equal to 16 seconds remaining on Pulverize.")
			return true 
		end
	elseif (BerserkCD == 0 and playerPower >= 25 and (targetLevel == -1 or targetLevel >= 87)) then
		PQR_DebugP("Rage greater than or equal to 25 and Pulverize up.")
		if (PulverizeLeft >= 16) then
			PQR_DebugP("Greater than or equal to 16 seconds remaining on Pulverize.")
			return true 
		end
	end
end

I put in some Profile Debug messages that should provide good feedback.

Edit: Well, crap... Mentally just came along and bitchslapped me with a much easier way to go about this, haha. Nicely done!

[Kinky]

@googlebee: That's really easy. To only allow Berserk to cast while Pulverize has 16+ seconds left, you could do something like this:

local Pulverize = select(7,UnitBuffID("player",80951))
if Pulverize and Pulverize - GetTime() >= 16 then
	if PQR_SpellAvailable(50334) then return true end
end

Checks if Pulverize is active, if it's active then it checks if Pulverize has 16 or more seconds left on the buff, if it does then it checks if Berserk is off cooldown, if it is, then the entire thing returns true.

[googlebee]

so in other words my other code I was attempting to get to work is useless lol

What exactly did I do wrong there anyway?

[LiquidAtoR]

*edit*

bwahahaha who can help get Mentally 8 more rep, that would be 4-5 blue posters acquired from a single thread

I'll see how much more I can still give to Mentally, as I gave already before.

Edit: You must spread some Reputation around before giving it to mentally again. Can't seems.

[Deva]

so in other words my other code I was attempting to get to work is useless lol

What exactly did I do wrong there anyway?

Well, the first thing that jumped out when I looked back at yours was that you had a few extra ends where there shouldn't have been. That's probably why bu_ba asked if that was the whole code. If there was something else above it that justified having them there, then nevermind. :P

if playerPower > 20 and Pulverize ~= nil then
	return true
-- extra ends were here
else
	if targetLevel == -1 or targetLevel >= 87 then
		if playerPower > 25 and Pulverize ~= nil then
			return true
		end
	end
end

[Kinky]

@googlebee: I updated the code I posted.... PQR_GetSpellAvailable doesn't exist, lmao. Changed it to PQR_SpellAvailable() as it should be.
Now, Let me show you what was wrong:

local targetLevel = UnitLevel("target")
local playerPower = UnitPower("player")
local Pulverize = (UnitBuffID("player",80951)

if playerPower > 20 and Pulverize ~= nil then
	return true
end
end
else
	if targetLevel == -1 or targetLevel >= 87 then
		if playerPower > 25 and Pulverize ~= nil then
			return true
		end
	end
end

The parts in Red are basically screwing your function over. Besides that, let's go over the logic:
IF we have more than 20 Energy and Pulverize is on target, then return true.
ELSE if the target is a boss or at/over level 87 THEN IF we have over 25 energy and Pulverize is on the target, then return true.
It also weren't checking for how long Pulverize had left on the buff duration.

You're basically ending the function 3 times, where it should be a continuous function. How you could fix the function and reduce the mount of global local variables, you could do:

local Pulverize = select(7,UnitBuffID("player",80951))
if UnitPower("player") > 20 and Pulverize then
	if Pulverize - GetTime() >= 16 and PQR_SpellAvailable(50334) then return true end
else
	if UnitLevel("target") == -1 or UnitLevel("target") >= 87 then
		if UnitPower("player") > 25 and Pulverize then
			if Pulverize - GetTime() >= 16 and PQR_SpellAvailable(50334) then return true end
		end
	end
end

What I did here was cutting down how many locals you have, to only selecting the expiration timer on the buff (return value 7), then went through your checks adding in the Pulverize timer. I also added in a check to execute if both the Pulverize timer was at or higher 16 seconds and Berserk was off-cooldown.
I did the same in your boss-check, as we don't want the ability to spam mindlessly even if Berserk is on Cooldown.

[googlebee]

Going to test yours now Mentally - Thank you!

Im slowly (very slowly) learning as I go here on PQR for the past 6 months. Really appreciate the help and the pointers.

This is the code i was trying to use in its entirety btw. - And it wasnt working either lol.

local _, _, _, BS = UnitBuffID("player", 50334)
local Pulverize = select(7,UnitBuffID("player",80951))
local BSstart, BSduration = GetSpellCooldown(50334)
local BScooldown = (BSstart + BSduration - GetTime())
local bsEnergy = UnitPower("player") / UnitPowerMax("player") * 100
local levelcheck = UnitLevel("target")

if BS ~= nil then
    return false
else
if bsEnergy < 25 then
    return false
else
if levelcheck == -1 or levelcheck <= 87 then
    if BScooldown > 0 then
        return false
    else
       if Pulverize and Pulverize - GetTime() >= 16 then
    if PQR_GetSpellReady(50334) then
     return true 
     end
end

Not exactly sure what I did there either that was causing it to not work.

[xNEC]

Here's my Unholy deakthnight PVP profile. I used bubba's code and added a few things, like strangulate to alt, deathstrikes when low hp, and death pact on low hp.
Read the notes for the rest of the info. :P
Enjoy.
Onion_DEATHKNIGHT_Abilities.xml
Onion_DEATHKNIGHT_Rotations.xml

"There was a problem with your download"

Link isn't working for me :/


/Edit

Now it is
I'll give this a try =)

[googlebee]

Your version works great mentally thank you again.

Will clean up the rotations and update it on the page 1 link asap.

[bu_ba_911]

Going to test yours now Mentally - Thank you!

Im slowly (very slowly) learning as I go here on PQR for the past 6 months. Really appreciate the help and the pointers.

This is the code i was trying to use in its entirety btw. - And it wasnt working either lol.

local BS, _, _, BScount = UnitBuffID("player", 50334)
local Pulverize = select(7,UnitBuffID("player",80951))
local BSstart, BSduration = GetSpellCooldown(50334)
local BScooldown = BSstart + BSduration - GetTime()
local bsEnergy = UnitPower("player")
local levelcheck = UnitLevel("target")

if BS ~= nil then
    return false
elseif bsEnergy < 25 then
    return false
elseif levelcheck == -1 or levelcheck <= 87 then
    if BScooldown > 0 then
        return false
    elseif Pulverize and Pulverize - GetTime() >= 16 then
        if PQR_GetSpellReady(50334) then
            return true 
         end
     end
end

Not exactly sure what I did there either that was causing it to not work.

i think i edited out the bugs..... i think

[googlebee]

sigh I knew I forgot something.......

In my previous release I had berserk checking for King of the Jungle Buff as well.

Having Pulverize trigger Enrage in the extra actions > then having Berserk with the Pulverize Timer check, Level check, and energy check + adding in a check to ensure KOTJ is on the player before being triggered.

So this is what I came up with.....will test in a sec.

local kotj = UnitBuffID("player", 51185)
local Pulverize = select(7,UnitBuffID("player",80951))
if UnitPower("player") > 20 and Pulverize and kotj then
    if Pulverize - GetTime() >= 16 and PQR_SpellAvailable(50334) then return true end
else
    if UnitLevel("target") == -1 or UnitLevel("target") >= 87 then
        if UnitPower("player") > 25 and Pulverize and kotj then
            if Pulverize - GetTime() >= 16 and PQR_SpellAvailable(50334) then return true end
        end
    end
end