[BETA] PQRotation - an automated ability priority queue.

[Noelpqr]

I dont know if what i have done is right or wrong but i did some change to the protection paladin by copying some codes from the paladin's profile i hope thw owner for them will not mind

1st i made this too abilities
1)

name : Avenger's Shield(Proc)
spellid: 31935
action:/startattack

local GrandCrusader = UnitBuffID("player", 98057)
if GrandCrusader ~= nil then
	RunMacroText("/startattack")
	return true
end

2)
name prot: Inquisition
spellid: 84963
action:/startattack

if UnitPower("player", 9) == 3 then
	return true
end

for Grand Crusader I add it in single target just below Shield of the Righteous and for aoe just below Hammer of the Righteous
and for prot: Inquisition I add it below Word of Glory < 60% for the aoe rotation
I hope some on will fix what I add or improve it and add them to the profile

[bu_ba_911]

woot woot, fixed beacon AND found the lua bombing ability in pve (hand of salvation is removed) AND added in auto crusader when mounted, with auto switch back to previous aura !!!!!

*edit*
if you want to try out Holy Arena, you're going to have to remove HolyPvP: Blessing from the rotation, as I have forgotten to do that myself since I last tested it


---------------Download-----------------
PvP_PvE_Holy_Paladin_RCv2.7_RELEASE.zip

[noxim]

Hi,

I'm using Sheron's combat rogue profile and noticing rupture never seems to trigger, anyone else with the same issue?

[bu_ba_911]

I dont know if what i have done is right or wrong but i did some change to the protection paladin by copying some codes from the paladin's profile i hope thw owner for them will not mind

1st i made this too abilities
1)

name : Avenger's Shield(Proc)
spellid: 31935
action:/startattack

local Grand Crusader = UnitBuffID("player", 98057)
if FreezingFog ~= nil then
	RunMacroText("/startattack")
	return true
end

2)
name prot: Inquisition
spellid: 84963
action:/startattack

if UnitPower("player", 9) == 3 then
	return true
end

for Grand Crusader I add it in single target just below Shield of the Righteous and for aoe just below Hammer of the Righteous
and for prot: Inquisition I add it below Word of Glory < 60% for the aoe rotation
I hope some on will fix what I add or improve it and add them to the profile

i look like you never declared what freezingfog was, so it can't run any checks against whether it is up or not. also don't have a space in Grand Crusader, make it GrandCrusader

[Zongfoo]

Agree, dont waste time dealing with old profiles. Takes few minutes to copy/paste from old client.

---------- Post added at 10:05 PM ---------- Previous post was at 09:57 PM ----------

Holy Priest (need PQR 1.0.12)

- fix Fortitude loop when other stamina buff is active

xeronpriest011011PQRProfiles.zip

Hey Sheuron... I have become quite good with customizing profiles and such, and I actually have a really sweet Holy Priest profile (altered from yours, previous to the release mentioned above). But just out of curiosity I tried the "011011" profile, and he just stood there in both PvE and PvP. I don't have the time to work through the code to see why this is, but I was wondering what would be so different between this and a previous release that would do that?

[sheuron]

Hi,

I'm using Sheron's combat rogue profile and noticing rupture never seems to trigger, anyone else with the same issue?

Rupture is used only when anyone in your party is providing bleed debuff on your target

[Noelpqr]

hmm I dont know how that part of the code have not being change >< Did Iu copy it from the wrong file when i update the paladin's profile after i updated to they new version of the bot , it could be..but thx for the point that for me and i think i changed so that it will work..
i never played my paladin for long time so i log it today and tried to test my code be4 post them again ..so i add the codes and change the rotation to the add the process for the single target ..and i notice that my paladin goes out of mana fast...(<---the idoit forget about that the talent that give mana after blocks or dodges and i was like what the heck so i remove the GrandCrusader from the rotation but still i got out of mana fast too and noticed that the holy warth is always fire be4 Avenger's Shield so i moved Avenger's Shield over it on the rotation and i felt that i dont need GrandCrusader but it will be nice for more dps and threats .. anyway back to the mana problem so i notice that there is Divine Plea but it is never used to return mana when it is needed so i looked at it and i notice that it is used to get 3 HP for WoG when the health is down so I change it to Indicate that it is for protection... and I add another Divine Plea code to return mana which also could be add to reti rotation
name ivine Plea
spell id:54428
target: player

local manapercent = 100 * UnitPower("player") / UnitPowerMax("player")

if manapercent <40  then
 return true
end

and even after using Divine Plea i still get out of mana fast so i looked at the paladin talents and i notice that talent ><

[bobo]

woot woot, fixed beacon AND found the lua bombing ability in pve (hand of salvation is removed) AND added in auto crusader when mounted, with auto switch back to previous aura !!!!!

*edit*
if you want to try out Holy Arena, you're going to have to remove HolyPvP: Blessing from the rotation, as I have forgotten to do that myself since I last tested it


---------------Download-----------------
PvP_PvE_Holy_Paladin_RCv2.7_RELEASE.zip

I'm getting an error with Beacon of Light on this release.

Message: [string "..."]:63: Usage: UnitBuff("unit", [index] or ["name", "rank"][, "filter"])
Time: 10/02/11 01:10:31
Count: 2
Stack: [C]: in function `UnitBuff'
[string "..."]:63: in function `UnitBuffID'
[string " function pqrFunc0() if IsLeftShiftKeyDown(..."]:56: in function `?'
[string "..."]:251: in function `PQR_NextAbility'
[string "..."]:154: in function `PQR_CastNext'
[string "..."]:143: in function `PQR_ExecuteBot'
[string "..."]:40: in function <[string "..."]:23>

Locals: (*temporary) = nil
(*temporary) = "Beacon of Light"

I know nothing of coding, but that is the error msg I'm getting. Prevents the Holy PVP from running as it hangs up there.

[bu_ba_911]

I'm getting an error with Beacon of Light on this release.

Message: [string "..."]:63: Usage: UnitBuff("unit", [index] or ["name", "rank"][, "filter"])
Time: 10/02/11 01:10:31
Count: 2
Stack: [C]: in function `UnitBuff'
[string "..."]:63: in function `UnitBuffID'
[string " function pqrFunc0() if IsLeftShiftKeyDown(..."]:56: in function `?'
[string "..."]:251: in function `PQR_NextAbility'
[string "..."]:154: in function `PQR_CastNext'
[string "..."]:143: in function `PQR_ExecuteBot'
[string "..."]:40: in function <[string "..."]:23>

Locals: (*temporary) = nil
(*temporary) = "Beacon of Light"

I know nothing of coding, but that is the error msg I'm getting. Prevents the Holy PVP from running as it hangs up there.

have you tried closing wow and restarting both pqr and wow?

worse case scenario, open up rotation editor, and remove the HolyPvP: Beacon of Light from the rotation and just manually cast it on targets always... i'll look into the problem tho

*edit*
i just healed finished healing an entire bg without it really bugging out on me (<3 dual monitors).... however thats not to say there aren't bugs in the profile, just means i didn't do what you did to make them show themselves lol

[bobo]

have you tried closing wow and restarting both pqr and wow?

worse case scenario, open up rotation editor, and remove the HolyPvP: Beacon of Light from the rotation and just manually cast it on targets always... i'll look into the problem tho

*edit*
i just healed finished healing an entire bg without it really bugging out on me (<3 dual monitors).... however thats not to say there aren't bugs in the profile, just means i didn't do what you did to make them show themselves lol

Yeah I even restarted my computer and disabled all addons and still have the problem. Removing Beacon from the list makes it work but for some reason it seems to heal a lot slower than the previous version I was using. I will continue to mess around with it and see if I can figure it out as well.

Also, just want to say thank you for the great profile. Been using pqr for about a month or 2 and I just love all the work xhelper, Sheuron and yourself have done. Keep it up.

[Kaolla]

My friends, I believe I've discovered a potential solution to our "PQR_IsOutOfSight()" problem. As Xelper noted in this post:

NOTE: You will only get a single "Target not in line of sight" per unit per 3-5 seconds depending on other red text errors that have popped up.

It appears that WoW throttles "Target is out of line of sight" messages to the UIErrorsFrame. While this is absolutely true, after a bit of testing, I've discovered that this throttling only occurs if the same ability is cast consecutively. What this means, in essence, is that an LoS error will always be displayed if differing abilities are cast in succession. My explanation isn't very clear, so hopefully the following example illustrates it better:

I set PQR to a 20ms Ability Check Delay. On my Shadow Priest, I made a simple rotation with four abilities:

[SPOILER]

Name: Mind Spike (LoS Test)
Spell ID: 73510
Cancel Channel: False
Delay: 0
Target: Target

if PQR_IsOutOfSight("target", "3") then
    return false
else
    return true
end

[/SPOILER][SPOILER]

Name: Mind Blast (LoS Test)
Spell ID: 8092
Cancel Channel: False
Delay: 0
Target: Target

if PQR_IsOutOfSight("target", "1.5") then
    return false
else
    return true
end

[/SPOILER][SPOILER]

Name: Shadow Word: Pain (LoS Test)
Spell ID: 589
Cancel Channel: False
Delay: 0
Target: Target

if PQR_IsOutOfSight("target", "0.1") then
    return false
else
    return true
end

[/SPOILER]The other ability simply returned true for Devouring Plague.

The rotation was set up like this:

Mind Spike (LoS test)
Mind Blast (LoS test)
Shadow Word: Pain (LoS Test)
Devouring Plague

In essence, my rotation would attempt to spam Mind Spike first unless the target had been out of LoS in the last 3000 ms, in which case it would attempt to cast Mind Blast (unless the target had been out of LoS in the last 1500 ms) or SW:P (unless out of LoS in the last 100 ms). In essence, it would basically try to cast these ranged abilities in sequence, but would almost immediately default to Devouring Plague(which had no LoS check) and Shadow Word: Pain (which had a very short LoS check, less than my ping), continually forcing the game to spam the Error Frame with "Target out of line of sight" messages. With some sneaky positioning, I was able to test this rotation against Target Dummies, and it behaved exactly as I expected. Given that the target was out of LoS until the instant I popped out from behind a tree, it first returned true for Devouring Plague, but then immediately cast SW:P on the dummy, then Mind Blast, and finally began spamming Mind Spike until I moved out of LoS once again.

Essentially, it cast the rotation from the inside-out, validating my theory; I checked the timings in my combat log, as well as with a stopwatch, and the numbers lined up. Besides confirming that we can easily force the game to check Line-of-Sight by simply placing something unconstrained by PQR_IsOutOfLoS beneath the abilities that are constrained by it, I think this is also our confirmation that PQR's LoS check can handle <3000ms values without a hiccup

I'm hoping that somebody else can confirm this, and that I didn't simply make a glaring mistake that invalidates these findings. To Xelper and all of our rotation editors, you guys are incredible. I hope my clumsy code or explanation didn't make you want to bleach your eyes out.

Edit: I first tried filling the combat log with "Testing" (courtesy of /run UIErrorsFrame:AddMessage("Testing", 1.0, 0.0, 0.0, 53, 5); ) and while this did fill up my log, it didn't affect the frequency of LoS updates. I feel dumb for ever trying that, but I originally thought that simply "spamming up" the log was the key to overcoming the throttle.

Edit2: I'm absolutely retarded when it comes to code, so I'm sure a lot of this seems laughably obvious to you guys.

Edit3: This message popped up in my chat frame ~5-7 times per second while 'Debug Mode' was enabled, which I think is something of a verification(?)
[SPOILER][01:26:22] <PQR> [DEBUG] Added LOS for unit Raider's Training Dummy at index 1
[01:26:23] <PQR> [DEBUG] Added LOS for unit Raider's Training Dummy at index 1
[01:26:23] <PQR> [DEBUG] Added LOS for unit Raider's Training Dummy at index 1
[01:26:23] <PQR> [DEBUG] Added LOS for unit Raider's Training Dummy at index 1
[01:26:23] <PQR> [DEBUG] Added LOS for unit Raider's Training Dummy at index 1
[01:26:23] <PQR> [DEBUG] Added LOS for unit Raider's Training Dummy at index 1
[01:26:23] <PQR> [DEBUG] Added LOS for unit Raider's Training Dummy at index 1
[01:26:24] <PQR> [DEBUG] Added LOS for unit Raider's Training Dummy at index 1
[01:26:24] <PQR> [DEBUG] Added LOS for unit Raider's Training Dummy at index 1[/SPOILER]

[Unasrage]

@bu_ba_911 : Hey m8 i know you been whid your hands full on the pala profile but today i tested the Blood Dk profila and something odd happent. The blood single target rotacion doest work at all it's just if the rotacion was not even there, if i change to aoe rotacion is works flawless same goes for the frost and unholy working flawless.

For some reason the single target blood profile just not working, no erros, no debug info since he doest even try to cast anyspell, really cant put my finger in it this time.

any help wold be apriciated ^^

------------Edit ---------------------

ok made a test on direbrew boss and it works there.... no idea why but mabe it was becouse i was testing it on Dummy 1º's few tests

[sheuron]

Reading last forum reply about healing rotation im trying to figure whats happening but was unable to replicate the bug yet, didnt got stuck healing raids. If anyone stuck on healing rotation comment your experiences about how stop and continue healing again.

Most similar case happend when spamming an ability without global cooldown the server cast the spell but the UI do not register this and show the ability out of cooldown.

PvE Warrior Protection
PvE Warrior Fury
PvE Priest Holy
PvE Mage Arcane
PvP Mage Frost
PvE Rogue Combat
PvP Rogue Subtlety
PvE Hunter MM

http://www.mediafire.com/?p10vmjbwupb1wt7

[winkle21]

Reading last forum reply about healing rotation im trying to figure whats happening but was unable to replicate the bug yet, didnt got stuck healing raids. If anyone stuck on healing rotation comment your experiences about how stop and continue healing again.

Most similar case happend when spamming an ability without global cooldown the server cast the spell but the UI do not register this and show the ability out of cooldown.

While reading this I was watching in a dungeon and this is what exactly happen when it stopped working

*Heal x5 > *Flash Heal > *Prayer of Healing > *Circle of Healing > Instant Arcane Torrent - Program froze and just does Prayer of mending - Rotation never starts back up until new encounter. I do not know yet, but it seems somewhere between arcane torrent/circle of healing it alwyas wants to freeze but that could be just random..

[onya]

Just a tip - if you install gnosis castbars you can set up a gcd castbar to see what instants you're casting as well as spells with a cast time.