Armory Viewer

[Chris-h11]

Armory Viewer
Current Version: 1.0.9.1 [10/4/2009]

Requires .NET Framework 4.0 Beta 1
Note: Version 1.1 will only require .NET 3.5

Download

Description:
This is an application to view characters on the World of Warcraft Armory in a Windows form.

Coded in Visual C# 2010

Screenshots (old):

• Search
• Profile
• Reputation
• Item Tooltip

Known Issues:
- Reputation tab is broken (Fixed in future release 1.1)
- Loading a character from the guild form whose data is no longer available closes the guild form

If you find anymore bugs please post them as a reply to this thread or on the Codeplex issues page.

Download: Armory Viewer - Release: Armory Viewer 1.0.9.1

Donations accepted

[The-Eradicator]

Finally something original! I don't need it, but +Rep for the effort.

[Jadd]

Agreed, looks like you put a lot of time into this.

+Rep * 3.

[sticatto]

This is pretty awesome. Good job! +Rep

[Apoc]

Great job with the app. However, I'm going to nitpick your code.

LINQ was introduced in 3.0 (or was it actually 3.5?) to give you easier XML reading/writing. Learn to use it. (There's absolutely no need to use the old XmlReader/Writer.)

Example (From ArmoryDataMobile/Main.cs):

var guildInfo = from g in xmlDoc.Elements("guild") select g;

guildInfo now holds an IEnumerable<XElement> of the 'guild' element stuff. (Hard to make a really good... erm... explanation for that. But I think you get it.)

You're using WinForms, so you should really begin to use the Settings that is built in. (This will not only save you tons of time, but tons of headaches. Not to mention buttloads of code, as you'll never have to write any event code to save a t/f for a checkbox setting.)

From a maintainability standpoint: refactor your code so your GUI code is JUST GUI code. (Minus the obvious required code for special logic.)

In other words: If the code isn't GUI specific, put it in it's own logical class.

Example:

Armory Viewer
- Classes
-- ArmoryProfile <Handles the 'bulk' reading and provides the following as instances>
---Tooltip (possibly in a Dictionary<ItemSlot, string> for URLs to the icon)
---Character info (name/race/bg group/rep/etc. Fairly self explanatory.)
---Guild (should hold a 'pointer' to another armory profile, not actual data. 1 entry per guildie)
---Talents (read when needed)

Then it's as simple as passing around an ArmoryProfile object, and displaying whatever info on the GUI.

Also, for the localization issues; Use UTF-8 encoding. ASCII doesn't support the required characters. (Plus, WoW uses UTF-8 for everything [in and out of game])

[Jadd]

<Snip>

WoW uses UTF-8 for everything [in and out of game]

Yep...

Seems to make my bot cry sometimes :P

[s3ph1roth]

Finally something original! I don't need it, but +Rep for the effort.

Same for me

[barthen]

Great tool!

[Robske]

Very nice, might I ask what documentation you used for the Armory XML layout? (I only get to work on my own Armory class once every 2 weeks because the router in this building blocks it)

[Chris-h11]

Very nice, might I ask what documentation you used for the Armory XML layout? (I only get to work on my own Armory class once every 2 weeks because the router in this building blocks it)

I just used view source at the armory with firefox and it showed all the XML, although now it seems to show HTML instead...

Great job with the app. However, I'm going to nitpick your code.

LINQ was introduced in 3.0 (or was it actually 3.5?) to give you easier XML reading/writing. Learn to use it. (There's absolutely no need to use the old XmlReader/Writer.)

Example (From ArmoryDataMobile/Main.cs):

var guildInfo = from g in xmlDoc.Elements("guild") select g;

guildInfo now holds an IEnumerable<XElement> of the 'guild' element stuff. (Hard to make a really good... erm... explanation for that. But I think you get it.)

You're using WinForms, so you should really begin to use the Settings that is built in. (This will not only save you tons of time, but tons of headaches. Not to mention buttloads of code, as you'll never have to write any event code to save a t/f for a checkbox setting.)

From a maintainability standpoint: refactor your code so your GUI code is JUST GUI code. (Minus the obvious required code for special logic.)

In other words: If the code isn't GUI specific, put it in it's own logical class.

Example:

Armory Viewer
- Classes
-- ArmoryProfile <Handles the 'bulk' reading and provides the following as instances>
---Tooltip (possibly in a Dictionary<ItemSlot, string> for URLs to the icon)
---Character info (name/race/bg group/rep/etc. Fairly self explanatory.)
---Guild (should hold a 'pointer' to another armory profile, not actual data. 1 entry per guildie)
---Talents (read when needed)

Then it's as simple as passing around an ArmoryProfile object, and displaying whatever info on the GUI.

Also, for the localization issues; Use UTF-8 encoding. ASCII doesn't support the required characters. (Plus, WoW uses UTF-8 for everything [in and out of game])

Wow thank you a lot for all of this, I'm not very advanced so some of it is confusing to me but I'm sure with some research I can figure it out. I already knew that I needed to clean it up and make it more professional but I've had a lot of homework.

Edit: Oh and the built-in settings... I had a reason for not using it. Just can't remember. Might have had something to do with making it portable.

Also, thanks everyone for the comments and rep

[Romulis2000]

wow very nice, easy on the eyes ui, on the stats for me at least its not showing the *hit* stat and personally cant wait for further updates on this this will be very promising and useful congrats and keep it up.

[Chris-h11]

wow very nice, easy on the eyes ui, on the stats for me at least its not showing the *hit* stat and personally cant wait for further updates on this this will be very promising and useful congrats and keep it up.

Thanks, and the hit stat I'll look into that next time I get a chance to work on it.

[Apoc]

I just used view source at the armory with firefox and it showed all the XML, although now it seems to show HTML instead...



Wow thank you a lot for all of this, I'm not very advanced so some of it is confusing to me but I'm sure with some research I can figure it out. I already knew that I needed to clean it up and make it more professional but I've had a lot of homework.

Edit: Oh and the built-in settings... I had a reason for not using it. Just can't remember. Might have had something to do with making it portable.

Also, thanks everyone for the comments and rep

Only reason to avoid the built-in settings, is if you're not planning to use an installer. (As the settings are 'location' specific. They don't save if you move the exe location) IIRC, it has no effect on mobile stuff whatsoever.

[Chris-h11]

Only reason to avoid the built-in settings, is if you're not planning to use an installer. (As the settings are 'location' specific. They don't save if you move the exe location) IIRC, it has no effect on mobile stuff whatsoever.

Oh yeah, I remember now. Since I'm using an installer now I'll go back to using the built-in settings. Thanks again.

[Kissy]

Nice, I've wanted something like this for alittle while now, +rep

And to Apoc, Helpful as always, instead of flaming people your always trying to help and improve personal projects, +rep aswell.