if function error

[lolicon123]

Ì started reading in a book about c++ today and it seems quite interesting so I tried to make a simple calculator however the compiler is complaining about my code i get the following errors on the code below

1>.\mini.cpp(11) : error C2059: syntax error : ')'
1>.\mini.cpp(15) : error C2059: syntax error : ')'
1>.\mini.cpp(19) : error C2059: syntax error : '/'
1>.\mini.cpp(23) : error C2059: syntax error : ')'

                         if (TS = +);
		{
		    Resultat = Första + Andra;
		}
		if (TS = -);
		{
			Resultat = Första - Andra;
		}
		if (TS = / );
		{
			Resultat = Första / Andra;
		}
		if (TS = *);
		{
			Resultat = Första * Andra;
		}

any help is appreciated

note: not the whole code just the part i'm getting error from

[lolfire]

                         if (TS == +)
		{
		    Resultat = Första + Andra;
		}
		if (TS == -)
		{
			Resultat = Första - Andra;
		}
		if (TS == / )
		{
			Resultat = Första / Andra;
		}
		if (TS == *)
		{
			Resultat = Första * Andra;
		}

You forgot some == in in the if's. You had ; after if() which is wrong.

I'm not sure if you can use åäö as variables and I think else if instead of just bunch of ifs.


NOTE: Could be wrong though, only worked with C++ for 2 days.

You could also do them as switches:

switch (TS)
{
    case -:
    Resultat = Forsta - Andra;
    break;

    case +:
    Resultat = Forsta + Andra;
    break;

    case /:
    Resultat = Forsta / Andra;
    break;

    case *:
    Resultat = Forsta * Andra;
    break;
}

[lolicon123]

ah i see so cases don't require == or '+' ?

[lolfire]

ah i see so cases don't require == or '+' ?

switch (TS)
{
    case -:
    Resultat = Forsta - Andra;
    break;

Is basically

if(TS == -)
{
    Resultat = Forsta - Andra;
}

It's better when using many conditions.

[Apoc]

Try creating actual strings, and not just typing the character you're looking for. The compiler is stupid. It only does what you tell it to.

[Dal]

Just to make sure its perfectly clear since I can see you possibly not understanding what they're saying.

This is what you have after the first response:

        if (TS = +)
		{
		    Resultat = Första + Andra;
		}
		if (TS = -)
		{
			Resultat = Första - Andra;
		}
		if (TS = / )
		{
			Resultat = Första / Andra;
		}
		if (TS = *)
		{
			Resultat = Första * Andra;
		}

This is what it should be:

        if (TS == "+")
		{
		    Resultat = Första + Andra;
		}
        if (TS == "-")
		{
			Resultat = Första - Andra;
		}
        if (TS == "/" )
		{
			Resultat = Första / Andra;
		}
        if (TS == "*")
		{
			Resultat = Första * Andra;
		}

First off as the first reply mentioned, to compare values in the manner you have above you use ==. This is because just using the = sign is the operator for assignment within the compiler.

Secondly, what you intend to do is compare string values (or perhaps chars, but I doubt it =) ). For Strings, you have to use double quotes around them. This is how the compiler knows that its using a string.

Also as a bonus tip. If you have just one line after an if or for statement, you do not need to have brackets around the code. For example, you can also write this as.

        if (TS == "+")
		    Resultat = Första + Andra;
        if (TS == "-")
	               Resultat = Första - Andra;
        if (TS == "/" )
		    Resultat = Första / Andra;
        if (TS == "*")
		    Resultat = Första * Andra;

Good Luck.