Hangman (Help!)

[Nikentic]

#include <cstdio>
#include <cstdlib>
#include <iostream>
using namespace std;
int main(int nNumberofArgs, char* pszArgs[])
{
cout <<"Let's play Hangman!\n";
int wrong;
int letters;
wrong = 1;


cin >> letters;

if(letters == 'b' || 'i' || 'r' || 'd')
{
           cout<<"Correct!";
           }
else
{
    cout <<"Wrong!";
    wrong++;
}
if(wrong <=5)
{
         cout<<"You Lost!";
         }
if(letters == 'bird')
{
           cout<<"You win!";
           }
system("pause");
return 0;


}

Int can't be used for letters. What else could i use?

[Cromon]

Der are 3 major things that are wrong.

1. (this is not wrong, but not really good readable) Formatting: Dont use "using namespace std;". As soon as you use the header algorithm you get in trouble cause there are functions as count or sort which pretty soon may interfere with your functions. so keep using namespace where it should be: in the hell! Use always std::cout, std::cin, ... . Use more and consequent spacing: std::cout << "..." and not std::cout<<"...". Its just more readable. Also make correct tabulators.

2. Check the datatypes. "int wrong; ... wrong = 1;". First you could use char wrong cause it will not have to hold more then 127. That saves you 3 bytes. Second write it as "int wrong = 1;". Saves you code. "int letters". You dont want to read an 4 byte Integer from the input, you want to read a character and because std:stream& operator<< decides from the type how it reads from the inputqueue its important that you define letters as char.

3. The if-statement cannot be done this way, you need to write:
if(letters == 'b' || letters == 'i' || letters == 'r' || letters == 'd')

Otherways the compiler treats it as:
if(letters == 'b' || 'i' != 0 || 'r' != 0 || 'd' != 0) which is obviously always true because the character i is not 0.

[dwarfhitman]

the problem is you are using letters a bit haphazardly. You first try to use it for character comparison (letters == b|| i|| r||d) then attempt to do a string comparison of some sort.

Some things you will need to do:
Change letters to char but you must also realize that if letters is a character variable then you will not be able to do a comparison like you've attempted in the end "letters == 'bird'. This is a string comparison (should be double quotes) of some sort.