[Question] Domain Manager?

[-Ryuk-]

Hi guys,

Im using Apoc's Domain Manager which was posted on here.

The code can be found at http://www.ownedcore.com/forums/worl...ml#post1915992 (.Net Managed Assembly Removal)

The problem im having is in the

CurrentDomain_AssemblyResolve

event.

On my English OS this works fine. However on my German OS(or any none-english) it fails to load, and results in a Stack Overflow.

The args that cause the stack overflow are:

mscorlib.resources, Version=4.0.0.0, Culture=de-DE, PublicKeyToken=b77a5c561934e089

Ive searched here on OC & Google and cant see why.

Any ideas?

EDIT: On my English OS if I search for mscorlib.resources it doesn't exist... yet on German it does.

[TOM_RUS]

I had same problem when using it on Windows with Russian locale and decided to hack fix it with:

if (args.Name.Contains("mscorlib.resources"))
    return null;

in CurrentDomain_AssemblyResolve event handler.

Proper fix would be according to docs:

When loading an assembly, the event handler must not use any of the AppDomain.Load or Assembly.Load method overloads that can cause the AssemblyResolve event to be raised recursively, because this can lead to a stack overflow.

And that bug probably caused by this breaking change:

Beginning with the .NET Framework 4, the ResolveEventHandler event is raised for all assemblies, including resource assemblies. In earlier versions, the event was not raised for resource assemblies. If the operating system is localized, the handler might be called multiple times: once for each culture in the fallback chain.

[-Ryuk-]

I had same problem when using it on Windows with Russian locale and decided to hack fix it with:

if (args.Name.Contains("mscorlib.resources"))
    return null;

in CurrentDomain_AssemblyResolve event handler.

Proper fix would be according to docs:
[quite]
When loading an assembly, the event handler must not use any of the AppDomain.Load or Assembly.Load method overloads that can cause the AssemblyResolve event to be raised recursively, because this can lead to a stack overflow.

[/QUOTE]


I had thought about that... Is it just that one file?

[Bananenbrot]

If you use the RelativeAssemblyResolver I PM'd you, it loads only those files it can resolve. No Assembly.Load is used, only Assembly.LoadFrom, and if the file doesn't exist in the folder of the currently executing assembly, it just returns null.
If you don't do any other subscribing and messing around with AssemblyResolve, it should just work.
For everyone else to profit: #3311249 - Pastie
Just a static readonly instance in your EntryPoint class and forget about it.