[LUA/macro] Another "need help" thread, easy rep.

[Ssateneth]

Aight, heres one for some of you guys that work well with making macros/addons (but I prefer it to be posted in the form of a macro as I don't know how to turn addon code into a macro) What I need is wrote down below.

If enemy HP < 20% and in Battle Stance then cast berserker Stance
If enemy HP > 20% and (my own copy of rend on the target has <3 seconds left or I don't have rend on the target or Overpower is usable) and I'm in berserker stance then cast Battle Stance elseif none of the previous and I'm in battle stance and I have 50 or less rage then cast Berserker Stance.

/run if UnitHealth("target")/UnitHealthMax("target")<0.2 and GetShapeshiftForm()==1 then CastSpellByName("Berserker Stance") end
/run if UnitHealth("target")/UnitHealthMax("target")>0.2 then if ***(my own copy of rend on the target has <3 seconds left or I don't have rend on the target*** or IsUsableSpell("Overpower")) and GetShapeshiftForm()==3 then CastSpellByName("Battle Stance") elseif ***none of the previous*** and GetShapeshiftForm()==1 and UnitPower("player")<51 then CastSpellByName("Berserker Stance") end end

-Why?-
Basically, with the new tactical mastery and the new stance bonuses, it's worth it to switch stances to berserker stance for the extra 5% damage bonus when casting your regular arms warrior abilities, but Rend and Overpower requires you to be in battle stance, and those two abilities are a pretty big chunk of the arms warrior's damage. It's a gimmicky way of increasing damage output, but I'll take anything I can get.

edit: used some proper syntax for the parts I have figured out, but put stars around and bolded the parts I couldn't.

Will +rep for successful macro.

[Ssateneth]

Nobody at all?

[nightcracker]

I will try, but I don't really get what you want yet.

Please describe more carefully what the macro should do, in a step diagram:

step 1. check if duration rend < 3, if true cast rend
step 2. etc

[Ssateneth]

I will try, but I don't really get what you want yet.

Please describe more carefully what the macro should do, in a step diagram:

step 1. check if duration rend < 3, if true cast rend
step 2. etc

Will try my best.
1. If enemy health is below 20%, go into berserker stance if not already in that stance and remain in berserker stance for the duration that the enemy is below 20% (I got this part already covered I believe)
2. If I am in Berserker Stance and enemy health is above 20% and...
>>a. if I don't have my own copy of the debuff "Rend" on the current target --OR--
>>b. if my own copy of the debuff "Rend" Has less than 3 seconds left in it's duration on the current target --OR--
>>c. My ability "Overpower" is a usable spell (It light's up from either an enemy dodge or the taste for blood buff on the player, but the cause is irrelevant)
... then cast Battle Stance.
3. If I am in Battle Stance and enemy health is above 20% and I have more than 50 rage AND...
>>a. I have my own copy of the debuff "Rend" on the current target --AND--
>>b. my own copy of the debuff "Rend" has more than 3 seconds left in it's duration on the current target --AND--
>>c. My ability "Overpower" is NOT a usable spell
... then cast Berserker Stance


I hope I made that clear enough.

[Ultraviolence]

Wouldn't this work? Seems pretty simple to me. I don't know if there's a way to tell if it's your Rend on the target, though.

/run if UnitHealth("target")/UnitHealthMax("target")<0.2 and GetShapeshiftForm()==1 then CastSpellByName("Berserker Stance") elseif UnitHealth("target")/UnitHealthMax("target")>0.2 and UnitDebuff("target", "Rend")<3 or not UnitDebuff("target", "Rend") or IsUsableSpell("Overpower")==1 and GetShapeshiftForm()==3 then CastSpellByName("Battle Stance") elseif GetShapeshiftForm()==1 and UnitHealth("target")/UnitHealthMax("target")>0.2 and UnitPower("player")>50 and UnitDebuff("target", "Rend")>3 and IsUsableSpell("Overpower")==0 then CastSpellByName("Berserker Stance") end

[CrazyCactuaR]

Sorry for the retard question but how the hell do you run lua commands since LuaNinja got canned? So out of date.

[Ultraviolence]

I guess you'll have to develop your own method until someone decides to release something to the public.

[Ssateneth]

No ultraviolence. That wouldn't work. It doesn't have the all-important rend-checking code in there. UnitDebuff - World of Warcraft Programming: A Guide and Reference for Creating WoW Addons

Thanks for trying anyways. Any other takers?

[Ultraviolence]

Then maybe UnitDebuff("target", "Rend", "player")? That should let it recognize your own Rend.

[Ssateneth]

Then maybe UnitDebuff("target", "Rend", "player")? That should let it recognize your own Rend.

Just checked the available filters and syntax. Might work, but I can't test it right now. will try later. If it does work out, it'll eliminate the need to do a while loop and check all the debuffs on an enemy if you have your own copy of a certain debuff.

[nightcracker]

Took me some time, but here it comes:

if UnitHealth"target"/UnitMaxHealth"target" < .2 then
	if not GetShapeshiftForm()==3 then
		CastSpellByName"Berserker Stance"
	end
elseif GetShapeshiftForm()==3 and ((not UnitDebuff("target", "Rend", "", "PLAYER") or (select(6, UnitDebuff("target", "Rend", "", "PLAYER")) < 3) or IsUsableSpell"Overpower") then
	CastSpellByName"Battle Stance"
elseif GetShapeshiftForm()==1 and UnitPower("player") > 50 and (UnitDebuff("target", "Rend", "", "PLAYER") and select(6, UnitDebuff("target", "Rend", "", "PLAYER")) > 3 and not IsUsableSpell"Overpower") then
	CastSpellByName"Berserker Stance"
end

[Ssateneth]

Thanks, I'll test it once NoAddiction is updated for 4.0.3. It would appear that the extra argument for UnitDebuff will prove powerful as far as making my head hurt less and making some of my macros shorter. Can convert all those nasty while checks into something like..

 ..and not d(t,"Rend","",p) then c("Rend") elseif..

Implying that I'll store the commonly used terms like UnitDebuff, "target", "player", and CastSpellByName into variables like d, t, p, and c respectively.

Will rep you once I can test it. Just a question though. Do you have to set the 3rd argument even though spells don't have ranks now?

edit: I went about testing the extra arguments. Doing..

/run if UnitDebuff("target", "Rend", "", "PLAYER") then print("a") end

should print a in the main chat window, but nothing comes up. Makes me think the arguments are a bit different. Checking the debuff via index like this works, but then it doesn't check if it's rend :P

/run if UnitDebuff("target", 1, "PLAYER") then print("a") end

EDIT2: Did a little bit of poking around. UnitDebuff's second output is the "rank" of the spell, so I did a /dump on UnitDebuff("target","Rend"). There is still a "rank" but not like I thought. It outputs this string: "Battle, Defensive Stance". So I put that in as the third argument of the UnitDebuff and ran the following. It indeed printed "a" when I had Rend up on the target.

/run if UnitDebuff("target", "Rend", "Battle, Defensive Stance", "player") then print("a") end

Soooooo.. fixing the above macro for when NA gets updated, we get..

if UnitHealth"target"/UnitMaxHealth"target" < .2 then
	if not GetShapeshiftForm()==3 then
		CastSpellByName"Berserker Stance"
	end
elseif GetShapeshiftForm()==3 and ((not UnitDebuff("target", "Rend", "Battle, Defensive Stance", "PLAYER") or (select(6, UnitDebuff("target", "Rend", "Battle, Defensive Stance", "PLAYER")) < 3) or IsUsableSpell"Overpower") then
	CastSpellByName"Battle Stance"
elseif GetShapeshiftForm()==1 and UnitPower("player") > 50 and (UnitDebuff("target", "Rend", "Battle, Defensive Stance", "PLAYER") and select(6, UnitDebuff("target", "Rend", "Battle, Defensive Stance", "PLAYER")) > 3 and not IsUsableSpell"Overpower") then
	CastSpellByName"Berserker Stance"
end

[Ssateneth]

I finally got what I needed. Says I must spread my rep around before I give it to you again night :/ i'll try to give you rep again soon.

#STANCEDANCE
/run if UnitHealth("target")/UnitHealthMax("target")<0.2 and GetShapeshiftForm()==1 then CastSpellByName("Berserker Stance") end
/run t="target" p="player" rc="Battle, Defensive Stance" r="Rend" b=UnitBuff d=UnitDebuff gs=GetShapeshiftForm() c=CastSpellByName if UnitHealth(t)/UnitHealthMax(t)>0.2 then if gs==3 and ((not d(t,r,rc,p) or select(7,d(t,r,rc,p))-GetTime()<2.9 or (b(p,"Taste for Blood") and GetSpellCooldown("Mortal Strike")~=0))) then c("Battle Stance") elseif gs==1 and UnitPower(p)<50 and d(t,r,rc,p) and select(7,d(t,r,rc,p))-GetTime()>2.9 and not IsUsableSpell("Overpower") then c("Berserker Stance") end end

There were some errors in your code (UnitMaxHealth instead of UnitHealthMax, missed a ) before a then somewhere, and probably one other thing) but I managed to figure out what happened. Also an error on my part, meant the rage check to be <51 rage, not >50 rage

[qbasasa]

Hi guys I need something to enprotect my lua codes, without it my super duper macros doesnt work.

[nightcracker]

Hi guys I need something to enprotect my lua codes, without it my super duper macros doesnt work.

Make a new thread.