[Lua Help] Undead Quest

[BanzBoyz77]

Hello Mmowned,

I recently created a small script. The transforming part works perfect but the demorphing doesn't. Any idea why, and if anymore could, could u add :PlaySpellVisual(guid, spell) to be cast onto the player by id: 93150 on the demorph. A spell i would like is like one with a green ray to it. Not too long though like 2 seconds long.

Script:
[spoiler]function OnFirstEnterWorld(event, pPlayer)
local race = pPlayer:GetPlayerRace()
if race == 5 then
pPlayer:SetModel(10979)
end
end

RegisterServerHook(3, "OnFirstEnterWorld")

function OnQuestFinished(event, pPlayer, questId, pQuestGiver)
if pPlayer:HasFinishedQuest(93150) then
pPlayer:DeMorph()
end
end

RegisterServerHook(22, "OnQuestFinished")[/spoiler]

Thanks

[Facerolling]

if pPlayer:HasFinishedQuest(93150) then

You are asking if this is something, then not said what.

if pPlayer:HasFinishedQuest(93150) == 1 then

[stoneharry]

Print to make sure the function is being called, remove the if statement from on quest finished to test if that is the issue.

If it's not being called it all, OnQuestFinished hook is still broken as it always has been (I haven't tested in ages though so it might work).

edit: Facerolling, you can't be more wrong! HasFinishedQuest(x) returns as a boolean (true/false). To be technical, it should be:

if pPlayer:HasFinishedQuest(93150) == true then

However, you do not need the == true and in most languages a ! can be added before the statement to reverse the boolean.

[BanzBoyz77]

KK am testing now

edit
-----------------------
Gives an error when I delete the if, says unexpected symbol near "Then", like then isn't suppose to be there anymore.

[Facerolling]

Just realised, I was treating it as a Get function D:

[stoneharry]

KK am testing now

edit
-----------------------
Gives an error when I delete the if, says unexpected symbol near "Then", like then isn't suppose to be there anymore.

...You did delete the end that goes with it, right?

function OnQuestFinished(event, pPlayer, questId, pQuestGiver)
pPlayer:DeMorph()
print("Function called")
if pPlayer:HasFinishedQuest(93150) then
print("player has finished 93150")
end
end

[BanzBoyz77]

yep i deleted the end and it says same thing

[stoneharry]

function OnFirstEnterWorld(event, pPlayer)
	if pPlayer:GetPlayerRace() == 5 then
		pPlayer:SetModel(10979)
	end
end

RegisterServerHook(3, "OnFirstEnterWorld")

function OnQuestFinished(event, pPlayer, questId, pQuestGiver)
	pPlayer:DeMorph()
	print("on quest finished function called")
	if pPlayer:HasFinishedQuest(93150) == true then
		print("Player has finished quest 93150")
	end
end

RegisterServerHook(22, "OnQuestFinished")

[BanzBoyz77]

Na, the script above didn't work. But then again, don't every race have a displayid that when you transform into them, it basicly does same thing as demorph? Since morphing seems to work.

[stoneharry]

Na, the script above didn't work. But then again, don't every race have a displayid that when you transform into them, it basicly does same thing as demorph? Since morphing seems to work.

Are you actually receiving the prints into console? Or is the function not firing at all?

[BanzBoyz77]

Works, just takes a few seconds to take effect (2-3 seconds). Although Stoneharry, are you able to add that Spell visual thing, seems odd that the player just suddenly changes back into an undead without any visuals to help them understand whats going on ( Trying for most blizzlike scripts as possible, with least amount of help, sadly theres still much i dont no)

[Facerolling]

pPlayer:PlaySpellVisual(pPlayer:GetGUID(pPlayer), spell)

Unit Commands - ArcEmu-wiki

[BanzBoyz77]

I no what the command is, just dont no how to use it.

[Facerolling]

I just did it for you, you just have to fill the spellid in ._.

[BanzBoyz77]

Your command works, but i need the npc ( id 91351) to cast it on the player, here the guy casts it on himself, and it looks so weird.