Command

[BinaryX]

bbool ChatHandler::HandleGivePointsCommand(const char * args, WorldSession * m_session)
{
    if(!*args) return false;

	Player* targetPlr = objmgr.GetPlayer(args[0]);
	if(targetPlr) {
	targetPlr->mPoints += (int32)args[1];
	GreenSystemMessage(m_session, "Changed points to %s of player %s.", args[1], args[0]);
	} else {
	RedSystemMessage(m_session, "This user (%s) does not exist.", args[0] );
	return true;
	}
	return true;
	
}

Instant crash upon usage.

[Pharcide]

%u is used on uints, try using %s instead. That's the only problem I see (You could also change (targetPlayer == NULL) to just (!targetPlayer))

[BinaryX]

Thanks ...

---------- Post added at 02:09 AM ---------- Previous post was at 01:45 AM ----------

Edited first post with new code, still the instant crashing.

[Pharcide]

args is already a char array so you don't have to cast it, and you don't check to see if targetPlr isn't null. You also could get rid of targetPlayer and just use targetPlr. The only other thing I can see is you are dereferencing args in the null check instead of checking the pointer itself (If you're doing that on purpose ignore me)

[BinaryX]

Updated code again, same problem.

[Pharcide]

Try changing (!*args) to (!args), I don't think that would cause a crash (unless returning false crashes the world), if that doesn't work I wouldn't think this section of code is the problem (Or I'm blind and missing something obvious)

[BinaryX]

Uhm i tried to enter a non existant character and it crashed instead of showing me the RedSystemMessage.

{ "givepoints",          'z', &ChatHandler::HandleGivePointsCommand,       "",                                                                                                                  NULL, 0, 0, 0 },
bool HandleGivePointsCommand(const char * args, WorldSession * m_session);

{CLIENT} Packet: (0x0095) CMSG_MESSAGECHAT PacketSize = 35 stamp = 21408656 accountid = 1
|------------------------------------------------|----------------|
|00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F |0123456789ABCDEF|
|------------------------------------------------|----------------|
|01 00 00 00 07 00 00 00 2E 63 68 61 72 61 63 74 |.........charact|
|65 72 20 67 69 76 65 70 6F 69 6E 74 73 20 64 61 |er givepoints nonexistant|
|20 31 00                                        | 1.             |
-------------------------------------------------------------------

[Zymus]

Try this:

bool ChatHandler::HandleGivePointsCommand(const char *args, WorldSession *m_session)
{
	if(!*args) return false;
	Player* targetPlr = objmgr.GetPlayer(args[0]);
	if(!targetPlr)
	{
		RedSystemMessage(m_session, "This user (%s) does not exist.", args[0]);
		return false;
	}
	targetPlr->mPoints += (int32) args[1];
	GreenSystemMessage(m_session, "Changed points to %s of player %s.", args[1], args[0]);
	return true;
}

[BinaryX]

Same result, wtf?

---------- Post added at 03:19 AM ---------- Previous post was at 03:05 AM ----------

Crashdump: http://binaryx.nl/dump-arcemu-world....18-58-6176.rar

---------- Post added at 03:23 AM ---------- Previous post was at 03:19 AM ----------

With the debugger attached this gets printed when the process crashes:

The thread 'Win32 Thread' (0x127c) has exited with code 0 (0x0).
The thread 'Win32 Thread' (0x2710) has exited with code 0 (0x0).
First-chance exception at 0x555714cf (msvcr100d.dll) in arcemu-world.exe: 0xC0000005: Access violation reading location 0x0000004c.
'arcemu-world.exe': Loaded 'C:\Windows\System32\powrprof.dll', Cannot find or open the PDB file
'arcemu-world.exe': Loaded 'C:\Windows\System32\setupapi.dll', Cannot find or open the PDB file
'arcemu-world.exe': Loaded 'C:\Windows\System32\cfgmgr32.dll', Cannot find or open the PDB file
'arcemu-world.exe': Loaded 'C:\Windows\System32\oleaut32.dll', Cannot find or open the PDB file
'arcemu-world.exe': Loaded 'C:\Windows\System32\ole32.dll', Cannot find or open the PDB file
'arcemu-world.exe': Loaded 'C:\Windows\System32\devobj.dll', Cannot find or open the PDB file
'arcemu-world.exe': Unloaded 'C:\Windows\System32\powrprof.dll'
'arcemu-world.exe': Unloaded 'C:\Windows\System32\setupapi.dll'
'arcemu-world.exe': Unloaded 'C:\Windows\System32\devobj.dll'
'arcemu-world.exe': Unloaded 'C:\Windows\System32\oleaut32.dll'
'arcemu-world.exe': Unloaded 'C:\Windows\System32\ole32.dll'
'arcemu-world.exe': Unloaded 'C:\Windows\System32\cfgmgr32.dll'
The thread 'Win32 Thread' (0x18cc) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1c70) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1acc) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x14c0) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x18a0) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x7dc) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1814) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1c9c) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1870) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x2634) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x11c0) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x261c) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x79c) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1e84) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x21e8) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1fd8) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0xdac) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1eb8) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x208c) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x20c4) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x210c) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x14e8) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x2480) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1c8c) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x2570) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0xd14) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x9e4) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x2548) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0xd58) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x17ac) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x9f4) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x27e8) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1788) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x10d0) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1ae4) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1350) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1ea8) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x844) has exited with code 1 (0x1).
The thread 'Win32 Thread' (0x1cfc) has exited with code 1 (0x1).
The program '[9708] arcemu-world.exe: Native' has exited with code 1 (0x1).

[Zymus]

First-chance exception at 0x555714cf (msvcr100d.dll) in arcemu-world.exe: 0xC0000005: Access violation reading location 0x0000004c

[BinaryX]

Yeah? what am i supposed to do, i already tried replacing the dll in both the system32 dir and server dir.
When i just do a SystemMessage in the command, it works fine and doesnt crash so the problem is somewhere in the code.

[Dynashock]

Ehm, args is a c-style string (thus an array) and contains every letter of the arguments in a new element. args[0] won't return the player name but rather the first letter of the player name.

I'd recommend using sscanf() instead, like:

char pName[20];
int32 points;

if (sscanf(args, "%s, %d", pName, &points) < 2)
    return false;
Player * pPlayer = objmgr.GetPlayer((const char*)pName);
if (pPlayer)
{
     // do stuff
}

[BinaryX]

Ok, now it tells me incorrect syntax and i assume that is because it returns false.
So sscanf is not returning an value greater than 1.

---------- Post added at 12:00 PM ---------- Previous post was at 11:56 AM ----------

I changed it to:

	if (sscanf(args, "%s, %d", pName, &points) < 1)

And now the server crashed again.

---------- Post added at 12:07 PM ---------- Previous post was at 12:00 PM ----------

Ok after more debugging, the second argument which is supposed to be points (int32) returns a negative character such as: -8371513.
This happens everytime even if i enter 5 or 10.

---------- Post added at 01:34 PM ---------- Previous post was at 12:07 PM ----------

bump ..

[Dynashock]

Try changing "%s, %d" to "%s %d" and declaring int32 as int32 = 0; to make sure it's initialized even if sscanf didn't return something to it.

[BinaryX]

Instant crash, what the ****?

bool ChatHandler::HandleGivePointsCommand(const char *args, WorldSession *m_session)
{
	if(!*args) return false;

	char pName[20];
	int32 points = 0;

	if (sscanf(args, "%s %d", pName, &points) < 1)
		return false;

	Player * pPlayer = objmgr.GetPlayer(pName);

	if (!pPlayer)
	{
		RedSystemMessage(m_session, "This user (%s) does not exist.", pName);
		return false;
	}
	pPlayer->mPoints += points;
	GreenSystemMessage(m_session, "Changed points to %s of player %s.", points, pName);
	return true;
}