What's Wrong?

[choweyiii]

I wanted to make a script for my private server, about a friend from retail that got Kingslayer, with a very low gearscore, and everyone makes fun of him because he was carried by the 30% buff, I made a boss-like npc, but he isn't listening, there's somthing wrong with the phase, but for the life of me, I cannot figure it out, here is the script:

function Menion_OnCombat(pUnit, Event)
local RandomTalk=math.random(1, 4);
if RandomTalk == 1 then
pUnit:SendChatMessage(14, 0, "I'm going to be a Kingslayer!") 
elseif RandomTalk == 2 then
pUnit:SendChatMessage(14, 0, "It's title time!")
elseif RandomTalk == 3 then
pUnit:SendChatMessage(14, 0, "I need more buffs!")
elseif RandomTalk == 4 then
pUnit:SendChatMessage(14, 0, "Ok, heal me, I'm going to be taking tons of damage!")
pUnit:RegisterEvent("Menion_DivineProtection)
end
end

function Menion_DivineProtection(pUnit, Event)
if pUnit:GetHealthPct() <= 60 then
pUnit:SendChatMessage(14, 0, "Heal me, y'all")
pUnit:CastSpell(498) --Divine Protection
end
end

function Menion_OnDied(pUnit, Event)
pUnit:SendChatMessage(14, 0, "They should make it 50%...")
pUnit:RemoveEvents()
end

RegisterUnitEvent(900014, 1, "Menion_OnCombat")
RegisterUnitEvent(900014, 4, "Menion_OnDied")
end

Also, if anyone knows where I can find the correct syntax for the commands, I would really appreciate a link.

[covert_cat]

I can't tell what's wrong with it.. I have problems with my boss scripts too. But the best place for Lua help has got to be the arcemu wiki.

[DarkVanir]

Or post your question here. They will help. In WoW-V there are some very professional lua scripters.

[Kaidos]

function Menion_OnCombat(pUnit, Event)
  pUnit:RegisterEvent("Menion_DivineProtection", 1000, 0) --checks every second if the boss is at 60%
    local RandomTalk=math.random(1, 4);
    if RandomTalk == 1 then
    pUnit:SendChatMessage(14, 0, "I'm going to be a Kingslayer!")
    elseif RandomTalk == 2 then
    pUnit:SendChatMessage(14, 0, "It's title time!")
    elseif RandomTalk == 3 then
    pUnit:SendChatMessage(14, 0, "I need more buffs!")
    elseif RandomTalk == 4 then
    pUnit:SendChatMessage(14, 0, "Ok, heal me, I'm going to be taking tons of damage!")
    end
end

function Menion_DivineProtection(pUnit, Event)
  if pUnit:GetHealthPct() <= 60 then
    pUnit:RemoveEvents() --remove the 1 second check function
    pUnit:SendChatMessage(14, 0, "Heal me, y'all")
    pUnit:CastSpell(498) --Divine Protection
  end
end

function Menion_OnDied(pUnit, Event)
  pUnit:SendChatMessage(14, 0, "They should make it 50%...")
  pUnit:RemoveEvents()
end

RegisterUnitEvent(900014, 1, "Menion_OnCombat")
RegisterUnitEvent(900014, 4, "Menion_OnDied")
end

[choweyiii]

Thanks alot, it works fine now! +Rep

[Trle94]

Why would you need an "end" after Register events? :S
it should be like this:

function Menion_OnCombat(pUnit, Event)
  pUnit:RegisterEvent("Menion_DivineProtection", 1000, 0) --checks every second if the boss is at 60%
    local RandomTalk=math.random(1, 4);
    if RandomTalk == 1 then
    pUnit:SendChatMessage(14, 0, "I'm going to be a Kingslayer!")
    elseif RandomTalk == 2 then
    pUnit:SendChatMessage(14, 0, "It's title time!")
    elseif RandomTalk == 3 then
    pUnit:SendChatMessage(14, 0, "I need more buffs!")
    elseif RandomTalk == 4 then
    pUnit:SendChatMessage(14, 0, "Ok, heal me, I'm going to be taking tons of damage!")
    end
end

function Menion_DivineProtection(pUnit, Event)
  if pUnit:GetHealthPct() <= 60 then
    pUnit:RemoveEvents() --remove the 1 second check function
    pUnit:SendChatMessage(14, 0, "Heal me, y'all")
    pUnit:CastSpell(498) --Divine Protection
  end
end

function Menion_OnDied(pUnit, Event)
  pUnit:SendChatMessage(14, 0, "They should make it 50%...")
  pUnit:RemoveEvents()
end

RegisterUnitEvent(900014, 1, "Menion_OnCombat")
RegisterUnitEvent(900014, 4, "Menion_OnDied")

[Kaidos]

Oh yeah right...the "end" at the end should be removed :P

[choweyiii]

Heh, I just started scripting the other day, noob mistake