Lua Script Problem

[stoneharry]

The reason it does it in parts is because it's doing this:
On combat, we check every few seconds if he has 90% or less health.
Once he has 90% or less health, we remove events stopping it checking, and then get it checking for 80%.
You need to change all the timers on RegisterEvents and remove the RemoveEvents() from each % to make it happen constently.

[Diemen]

How long should the timers be than ?

[stoneharry]

How long should the timers be than ?

pUnit:RegisterEvent("name", time, how many times)

The name is the name of the function we are registering, the timer is every <time> seconds we do the function, like 1000 would do the function every second, and the times is how many times we do it, 0 being until we remove events (like the script I linked) or 3 being do it 3 times.

[Diemen]

Lol i feel very Stupid know :P

My head begins to hurt of all this info :P

but i did what you said.

function Lucius_Phase8(Unit, Event)
if Unit:GetHealthPct() <15 then
Unit:SendChatMessage(14, 0, "NO NO NO! I WON'T DIE ! ,UNGREADIAL TRANSFORM !")
Unit:SetModel(10315)
Unit:RemoveEvents()
Unit:CastSpell(59159)
Unit:RegisterEvent("Lucius_Phase9", 2000, 0)
end
end

but i think it still looks the same

[stoneharry]

function Lucius_OnCombat(Unit, Event)
Unit:SendChatMessage(14, 0, "Die you foul humans !")
Unit:RegisterEvent("Lucius_Phase1", 2000, 0)
end

RegisterUnitEvent(210801, 1, "Lucius_OnCombat")

function Lucius_Phase1(Unit, Event)
if Unit:GetHealthPct() <= 90 then
Unit:SendChatMessage(14, 0, "TAKE THIS !")
Unit:CastSpell(42945)
Unit:RemoveEvents() -- Stop the last repeating
Unit:RegisterEvent("Lucius_Phase2", 2000, 0) -- next
end
end

function Lucius_Phase2(Unit, Event)
if Unit:GetHealthPct() <= 80 then
Unit:SendChatMessage(14, 0, "YOU ARE SO WEAK !")
Unit:FullCastSpellOnTarget(48127, Unit:GetMainTank(0)) -- You missed the closing )
Unit:RemoveEvents() -- Stop the last repeating
Unit:RegisterEvent("Lucius_Summon1", 12000, 1) -- missed the closing ) again
end
end

function Lucius_Summon1(Unit, Event)
local x = Unit:GetX()
local y = Unit:GetY()
local z = Unit:GetZ() -- We don't need ; this isn't C++
local o = Unit:GetO()
Unit:SpawnCreature (210803, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SpawnCreature (210803, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000) -- npcid, x, y, z, o, faction, time (correct I think)
Unit:SpawnCreature (210803, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SendChatMessage(12, 0, "Let's see if you can handle this !")
Unit:RegisterEvent("Lucius_Phase3", 30000, 0) -- 200000 is a VERY long time, shortened it
end

function Lucius_Phase3(Unit, Event)
if Unit:GetHealthPct() <= 70 then
Unit:RemoveEvents() -- Stop last register repeating
Unit:SendChatMessage(14, 0, "KNEEL FOR ME YOU STUPID HUMANS")
Unit:CastSpell(42921)
Unit:RegisterEvent("Lucius_Phase4", 30009, 1)
end
end

function Lucius_Phase4(Unit, Event)
if Unit:GetHealthPct() <= 60 then
Unit:RemoveEvents()
Unit:SendChatMessage(14, 0, "Enough of this ! , UNGREADIAL TRANSFORM !")
Unit:SetModel(14508)
Unit:SetScale(2)
Unit:CastSpell(42926)
Unit:RegisterEvent("Lucius_Phase5", 2000, 0)
end
end

function Lucius_Phase5(Unit, Event)
if Unit:GetHealthPct() <= 50 then
Unit:RemoveEvents()
Unit:SendChatMessage(14, 0, "NO ONE CAN STOP ME !")
Unit:CastSpell(42950)
Unit:RegisterEvent("Lucius_Summon2", 12000, 0)
end
end

function Lucius_Summon2(Unit, Event)
Unit:RemoveEvents()
local x = Unit:GetX()
local y = Unit:GetY()
local z = Unit:GetZ() -- Again this isn't C++ no ;
local o = Unit:GetO()
Unit:SpawnCreature (210804, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SpawnCreature (210804, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SpawnCreature (210804, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:RegisterEvent("Lucius_Phase6", 2000, 0)
end

function Lucius_Phase6(Unit, Event)
if Unit:GetHealthPct() <= 40 then
Unit:RemoveEvents()
Unit:SendChatMessage(12, 0, "UNGREADIAL TRANSFORM !")
Unit:SetModel(1126)
Unit:SetScale(3)
Unit:CastSpell(42931)
Unit:RegisterEvent("Lucius_Phase7", 2000, 0) -- You missed a 0 on 200
end
end

function Lucius_Phase7(Unit, Event)
if Unit:GetHealthPct() <= 25 then
Unit:RemoveEvents()
Unit:SendChatMessage(14, 0, "FEEL THE POWER OF A TRUE GOD !")
Unit:FullCastSpellOnTarget(5, Unit:GetMainTank(0)) -- Missed the closing )
Unit:RegisterEvent("Lucius_Phase8", 20000, 0)
end
end


function Lucius_Phase8(Unit, Event)
if Unit:GetHealthPct() <= 25 then
Unit:SendChatMessage(14, 0, "NO NO NO! I WON'T DIE ! ,UNGREADIAL TRANSFORM !")
Unit:SetModel(10315)
Unit:RemoveEvents()
Unit:CastSpell(59159)
Unit:RegisterEvent("Lucius_Phase8", 2000, 0)
end
end

function Lucius_Phase9(Unit, Event)
if Unit:GetHealthPct() <= 5 then
Unit:RemoveEvents()
Unit:SendChatMessage(14, 0, "THIS CAN'T BE TRUE ! NOOOOOOOO.....")
Unit:CastSpell(61721)
end
end


function Lucius_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents() 
Unit:SendChatMessage(12, 0, "Haha you weaklings !")
end

RegisterUnitEvent(210801, 2, "Lucius_OnLeaveCombat")

function Lucius_OnKilledTarget(Unit, Event)
Unit:SendChatMessage(12, 0, "Kneel for your god !") 
end

RegisterUnitEvent(210801, 3, "Lucius_OnKilledTarget")

function Lucius_OnDied(Unit, Event)
Unit:SendChatMessage(14, 0, "No..... SARCIUS !!!!!!!")
Unit:RemoveEvents()
end
RegisterUnitEvent(210801, 4, "Lucius_OnDied")

This script should work perfectly, in terms of doing each part 1 at a time, but you have to delete the removeevents lines and change the timers to make it keep doing them, but move ALL the register events to on combat because otherwise it will do this:

RegisterEvent on 90% or less in 3 seconds
90% or less: register event in 5 seconds

See the problem?
The register in 3 seconds will happen again before the 5 second one is called, meaning the 5 second timer will go back to 0 seconds and resulting it in never happening.

[Diemen]

This must be it than

function Lucius_OnCombat(Unit, Event)
Unit:SendChatMessage(14, 0, "Die you foul humans !")
Unit:RegisterEvent("Lucius_Phase1", 5000, 0)
end

RegisterUnitEvent(210801, 1, "Lucius_OnCombat")

function Lucius_Phase1(Unit, Event)
if Unit:GetHealthPct() <90 then
Unit:SendChatMessage(14, 0, "TAKE THIS !")
Unit:CastSpell(42945)
Unit:RegisterEvent("Lucius_Phase2", 5000, 0) -- next
end
end

function Lucius_Phase2(Unit, Event)
if Unit:GetHealthPct() <80 then
Unit:SendChatMessage(14, 0, "YOU ARE SO WEAK !")
Unit:FullCastSpellOnTarget(48127, Unit:GetMainTank(0)) -- You missed the closing )
Unit:RegisterEvent("Lucius_Summon1", 12000, 1) -- missed the closing ) again
end
end

function Lucius_Summon1(Unit, Event)
local x = Unit:GetX()
local y = Unit:GetY()
local z = Unit:GetZ() -- We don't need ; this isn't C++
local o = Unit:GetO()
Unit:SpawnCreature (210803, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SpawnCreature (210803, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000) -- npcid, x, y, z, o, faction, time (correct I think)
Unit:SpawnCreature (210803, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SendChatMessage(12, 0, "Let's see if you can handle this !")
Unit:RegisterEvent("Lucius_Phase3", 5000, 0) -- 200000 is a VERY long time, shortened it
end

function Lucius_Phase3(Unit, Event)
if Unit:GetHealthPct() <70 then
Unit:SendChatMessage(14, 0, "KNEEL FOR ME YOU STUPID HUMANS")
Unit:CastSpell(42921)
Unit:RegisterEvent("Lucius_Phase4", 5000, 0)
end
end

function Lucius_Phase4(Unit, Event)
if Unit:GetHealthPct() <60 then
Unit:SendChatMessage(14, 0, "Enough of this ! , UNGREADIAL TRANSFORM !")
Unit:SetModel(14508)
Unit:SetScale(2)
Unit:CastSpell(42926)
Unit:RegisterEvent("Lucius_Phase5", 5000, 0)
end
end

function Lucius_Phase5(Unit, Event)
if Unit:GetHealthPct() <50 then
Unit:SendChatMessage(14, 0, "NO ONE CAN STOP ME !")
Unit:CastSpell(42950)
Unit:RegisterEvent("Lucius_Summon2", 5000, 0)
end
end

function Lucius_Summon2(Unit, Event)
local x = Unit:GetX()
local y = Unit:GetY()
local z = Unit:GetZ() -- Again this isn't C++ no ;
local o = Unit:GetO()
Unit:SpawnCreature (210804, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SpawnCreature (210804, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SpawnCreature (210804, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:RegisterEvent("Lucius_Phase6", 5000, 0)
end

function Lucius_Phase6(Unit, Event)
if Unit:GetHealthPct() <40 then
Unit:SendChatMessage(12, 0, "UNGREADIAL TRANSFORM !")
Unit:SetModel(1126)
Unit:SetScale(3)
Unit:CastSpell(42931)
Unit:RegisterEvent("Lucius_Phase7", 5000, 0)
end
end

function Lucius_Phase7(Unit, Event)
if Unit:GetHealthPct() <25 then
Unit:SendChatMessage(14, 0, "FEEL THE POWER OF A TRUE GOD !")
Unit:FullCastSpellOnTarget(5, Unit:GetMainTank(0))
Unit:RegisterEvent("Lucius_Phase8", 5000, 0)
end
end


function Lucius_Phase8(Unit, Event)
if Unit:GetHealthPct() <15 then
Unit:SendChatMessage(14, 0, "NO NO NO! I WON'T DIE ! ,UNGREADIAL TRANSFORM !")
Unit:SetModel(10315)
Unit:CastSpell(59159)
Unit:RegisterEvent("Lucius_Phase9", 5000, 0)
end
end

function Lucius_Phase9(Unit, Event)
if Unit:GetHealthPct() <5 then
Unit:SendChatMessage(14, 0, "THIS CAN'T BE TRUE ! NOOOOOOOO.....")
Unit:CastSpell(61721)
end
end


function Lucius_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents() 
Unit:SendChatMessage(12, 0, "Haha you weaklings !")
end

RegisterUnitEvent(210801, 2, "Lucius_OnLeaveCombat")

function Lucius_OnKilledTarget(Unit, Event)
Unit:SendChatMessage(12, 0, "Kneel for your god !")
end

RegisterUnitEvent(210801, 3, "Lucius_OnKilledTarget")

function Lucius_OnDied(Unit, Event)
Unit:SendChatMessage(14, 0, "No..... SARCIUS !!!!!!!")
Unit:RemoveEvents()
end

RegisterUnitEvent(210801, 4, "Lucius_OnDied")

[stoneharry]

function Lucius_OnCombat(Unit, Event)
Unit:SendChatMessage(14, 0, "Die you foul humans !")
Unit:RegisterEvent("Lucius_Phase1", 5000, 0)
Unit:RegisterEvent("Lucius_Phase2", 5000, 0) -- next
Unit:RegisterEvent("Lucius_Phase9", 5000, 0)
Unit:RegisterEvent("Lucius_Summon1", 12000, 1)
Unit:RegisterEvent("Lucius_Phase3", 5000, 0)
Unit:RegisterEvent("Lucius_Phase4", 5000, 0)
    Unit:RegisterEvent("Lucius_Phase5", 5000, 0)
   Unit:RegisterEvent("Lucius_Summon2", 5000, 0)
  Unit:RegisterEvent("Lucius_Phase6", 5000, 0)
 Unit:RegisterEvent("Lucius_Phase7", 5000, 0)
Unit:RegisterEvent("Lucius_Phase8", 5000, 0)
end

RegisterUnitEvent(210801, 1, "Lucius_OnCombat")

function Lucius_Phase1(Unit, Event)
if Unit:GetHealthPct() <90 then
Unit:SendChatMessage(14, 0, "TAKE THIS !")
Unit:CastSpell(42945)
end
end

function Lucius_Phase2(Unit, Event)
if Unit:GetHealthPct() <80 then
Unit:SendChatMessage(14, 0, "YOU ARE SO WEAK !")
Unit:FullCastSpellOnTarget(48127, Unit:GetMainTank(0)) -- You missed the closing )
end
end

function Lucius_Summon1(Unit, Event)
local x = Unit:GetX()
local y = Unit:GetY()
local z = Unit:GetZ() -- We don't need ; this isn't C++
local o = Unit:GetO()
Unit:SpawnCreature (210803, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SpawnCreature (210803, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000) -- npcid, x, y, z, o, faction, time (correct I think)
Unit:SpawnCreature (210803, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SendChatMessage(12, 0, "Let's see if you can handle this !")
end

function Lucius_Phase3(Unit, Event)
if Unit:GetHealthPct() <70 then
Unit:SendChatMessage(14, 0, "KNEEL FOR ME YOU STUPID HUMANS")
Unit:CastSpell(42921)
end
end

function Lucius_Phase4(Unit, Event)
if Unit:GetHealthPct() <60 then
Unit:SendChatMessage(14, 0, "Enough of this ! , UNGREADIAL TRANSFORM !")
Unit:SetModel(14508)
Unit:SetScale(2)
Unit:CastSpell(42926)
end
end

function Lucius_Phase5(Unit, Event)
if Unit:GetHealthPct() <50 then
Unit:SendChatMessage(14, 0, "NO ONE CAN STOP ME !")
Unit:CastSpell(42950)
end
end

function Lucius_Summon2(Unit, Event)
local x = Unit:GetX()
local y = Unit:GetY()
local z = Unit:GetZ() -- Again this isn't C++ no ;
local o = Unit:GetO()
Unit:SpawnCreature (210804, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SpawnCreature (210804, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
Unit:SpawnCreature (210804, 10149.490234, 2551.358887, 1321.909180, 3.536894, 14 ,120000)
end

function Lucius_Phase6(Unit, Event)
if Unit:GetHealthPct() <40 then
Unit:SendChatMessage(12, 0, "UNGREADIAL TRANSFORM !")
Unit:SetModel(1126)
Unit:SetScale(3)
Unit:CastSpell(42931)
end
end

function Lucius_Phase7(Unit, Event)
if Unit:GetHealthPct() <25 then
Unit:SendChatMessage(14, 0, "FEEL THE POWER OF A TRUE GOD !")
Unit:FullCastSpellOnTarget(5, Unit:GetMainTank(0))
end
end


function Lucius_Phase8(Unit, Event)
if Unit:GetHealthPct() <15 then
Unit:SendChatMessage(14, 0, "NO NO NO! I WON'T DIE ! ,UNGREADIAL TRANSFORM !")
Unit:SetModel(10315)
Unit:CastSpell(59159)
end
end

function Lucius_Phase9(Unit, Event)
if Unit:GetHealthPct() <5 then
Unit:SendChatMessage(14, 0, "THIS CAN'T BE TRUE ! NOOOOOOOO.....")
Unit:CastSpell(61721)
end
end


function Lucius_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents() 
Unit:SendChatMessage(12, 0, "Haha you weaklings !")
end

RegisterUnitEvent(210801, 2, "Lucius_OnLeaveCombat")

function Lucius_OnKilledTarget(Unit, Event)
Unit:SendChatMessage(12, 0, "Kneel for your god !")
end

RegisterUnitEvent(210801, 3, "Lucius_OnKilledTarget")

function Lucius_OnDied(Unit, Event)
Unit:SendChatMessage(14, 0, "No..... SARCIUS !!!!!!!")
Unit:RemoveEvents()
end

RegisterUnitEvent(210801, 4, "Lucius_OnDied")

Like that but change to the timers you want, at the moment it's going to do everything at once every 5 seconds.

[Diemen]

The Timers are getting me a bit confused :S

Do i need to Have different timers ? or what ?

The timers are the "Checks" to check the Mob his Health for the phases right ?

[stoneharry]

The Timers are getting me a bit confused :S

Do i need to Have different timers ? or what ?

The timers are the "Checks" to check the Mob his Health for the phases right ?

The timers you can be anything you want it to be, currently each timer is doing this:
In 5 seocnds we check for the mobs hp, if the mobs hp is what were checking for then cast the spells and then repeat again in 5 seconds.
So it is lasting forever till the mob dies/leaves combat.
You need to change the timers to when you want it to do the spells, before doing the spells it checks for the health. So if you change it to 1000 from 5000 it will do the spells every second if it has the required amount of health.
Understand now?

[Diemen]

Yeah

My idea was to do The Spell once or twice in each Phase so it would look like this right ?

Unit:RegisterEvent("Lucius_Phase1", 10000, 2)

This will make it use the Spell twice in 10 Sec right ?

[stoneharry]

Yeah

My idea was to do The Spell once or twice in each Phase so it would look like this right ?

Unit:RegisterEvent("Lucius_Phase1", 10000, 2)

This will make it use the Spell twice in 10 Sec right ?

Yes but you forget your doing the checks, so it will on combat check two times whether it has less than 50% hp for example, after the 2nd time it will stop checking so it may never cast the spell.

[Diemen]

Oh haha , So How much Checking would you recommand ?

[stoneharry]

Oh haha , So How much Checking would you recommand ?

I would of done it so that:
Check for 90% forever.
When 90% is reached remove events and register this event AGAIN for 2 times, and register the next event forever.
And so on.
If that makes sense.

[Diemen]

So Like this ?

Unit:RegisterEvent("Lucius_Phase1", 5000, 0)
Unit:RemoveEvents()
Unit:RegisterEvent("Lucius_Phase1", 5000, 2)
Unit:RegisterEvent("Lucius_Phase2", 5000, 0)
Unit:RemoveEvents()
Unit:RegisterEvent("Lucius_Phase2", 5000, 2)

[stoneharry]

So Like this ?

Unit:RegisterEvent("Lucius_Phase1", 5000, 0)
Unit:RegisterEvent("Lucius_Phase1", 5000, 2)
Unit:RegisterEvent("Lucius_Phase2", 5000, 0)
Unit:RegisterEvent("Lucius_Phase2", 5000, 2)

function X_OnCombat(Unit, Event)
Unit:RegisterEvent("Lucius_Phase1", 5000, 0)
end

function Lucius_Phase1(Unit, Event)
if Unit:GetHealthPct() < 90 then
Unit:RemoveEvents()
Unit:RegisterEvent("Lucius_Phase1", 5000, 2)
end
end

This will keep checking to see when it has less than 90% hp and then when it does have less than 90% it will cast the spells two times.