[LUA] Spells/Phases Not Occuring

[trinityunit]

I'm having an issue with my LUA scripts, and it will do like one spell and say the OnCombat text it's supposed to, and then nothing else.

I don't know if it's my DLL or not, but here are my scripts:

function HellfireMagus_OnCombat(Unit, Event)
Unit:SendChatMessage(14, 0, "You musn't betray the king!")

function HellfireMagus_Spell1(Unit, Event)
Unit:FullCastSpellOnTarget(61572, Unit:GetRandomPlayer(0))
end

function HellfireMagus_Spell2(Unit, Event)
Unit:FullCastSpellOnTarget(40598, Unit:GetMainTank())
end

function HellfireMagus_Spell3(Unit, Event)
Unit:CastSpell(25697)
end

Unit:RegisterEvent("HellfireMagus_Spell1", 3000, 1)
Unit:RegisterEvent("HellfireMagus_Spell2", 3000, 1)
Unit:RegisterEvent("HellfireMagus_Spell3", 3000, 3)
end

RegisterUnitEvent(999997, 1, "HellfireMagus_OnCombat")

function Zyxis_OnCombat(Unit, Event)
Unit:SendChatMessage(14, 0, "This won't take very long...")

function Zyxis_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents()
end

function Zyxis_Spell1(Unit, Event)
Unit:FullCastSpellOnTarget(24435, Unit:GetRandomPlayer(0))
end

function Zyxis_OnDied(Unit, Event)
Unit:RemoveEvents()
end

function Zyxis_OnKilledTarget(Unit, Event)
end

function Zyxis_Phase1(Unit, Event)
if Unit:GetHealthPct() <=75 then
Unit:FullCastSpellOnTarget(28405, Unit:GetMainTank())
Unit:FullCastSpellOnTarget(36843, Unit:GetMainTank())
Unit:FullCastSpellOnTarget(38535, Unit:GetMainTank())
end
end

function Zyxis_Phase2(Unit, Event)
if Unit:GetHealthPct() <=50 then
Unit:SendChatMessage(14, 0, "Ugh....")
Unit:CastSpell(24647)
Unit:FullCastSpellOnTarget(61673, Unit:GetRandomPlayer(0))
end
end

function Zyxis_Phase3(Unit, Event)
if Unit:GetHealthPct() <=20 then
Unit:SendChatMessage(14, 0, "What is happening?!")
Unit:SetModel(24993)
Unit:SetScale(2)
end
end

function Zyxis_Phase4(Unit, Event)
if Unit:GetHealthPct() <=10 then
Unit:CastSpell(47496)
end
end

Unit:RegisterEvent("Zyxis_Spell1", 60000, 2)
Unit:RegisterEvent("Zyxis_Phase1", 8000, 1)
Unit:RegisterEvent("Zyxis_Phase2", 8000, 1)
Unit:RegisterEvent("Zyxis_Phase3", 1000, 1)
Unit:RegisterEvent("Zyxis_Phase4", 1000, 1)
end

RegisterUnitEvent(999999, 1, "Zyxis_OnCombat")

[Kaidos]

function HellfireMagus_OnCombat(Unit, Event)
Unit:SendChatMessage(14, 0, "You musn't betray the king!")
Unit:RegisterEvent("HellfireMagus_Spell1", 3000, 1) -- Spell1 after 3s
Unit:RegisterEvent("HellfireMagus_Spell2", 6000, 1) -- spell2 after 6s, 
Unit:RegisterEvent("HellfireMagus_Spell3", 9000, 3) -- spell3 after 9
end

function HellfireMagus_Spell1(Unit, Event)
Unit:FullCastSpellOnTarget(61572, Unit:GetRandomPlayer(0))
end

function HellfireMagus_Spell2(Unit, Event)
Unit:FullCastSpellOnTarget(40598, Unit:GetMainTank())
end

function HellfireMagus_Spell3(Unit, Event)
Unit:CastSpell(25697)
end

RegisterUnitEvent(999997, 1, "HellfireMagus_OnCombat")

[/code]

function Zyxis_OnCombat(Unit, Event)
Unit:SendChatMessage(14, 0, "This won't take very long...")
Unit:RegisterEvent("Zyxis_Spell1", 60000, 2)
Unit:RegisterEvent("Zyxis_Phase1", 1000, 0) -- checks every 1000 miliseconds if he get under 75%
end

function Zyxis_Spell1(Unit, Event)
Unit:FullCastSpellOnTarget(24435, Unit:GetRandomPlayer(0))
end

function Zyxis_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents()
end

function Zyxis_OnDied(Unit, Event)
Unit:RemoveEvents()
end

function Zyxis_OnKilledTarget(Unit, Event)
end

function Zyxis_Phase1(Unit, Event)
if Unit:GetHealthPct() <=75 then
Unit:RemoveEvents() -- Remove all Phases before
Unit:RegisterEvent("Zyxis_Phase2", 1000, 0)
Unit:FullCastSpellOnTarget(28405, Unit:GetMainTank())
Unit:FullCastSpellOnTarget(36843, Unit:GetMainTank())
Unit:FullCastSpellOnTarget(38535, Unit:GetMainTank())
end
end

function Zyxis_Phase2(Unit, Event)
if Unit:GetHealthPct() <=50 then
Unit:RemoveEvents()
Unit:SendChatMessage(14, 0, "Ugh....")
Unit:CastSpell(24647)
Unit:FullCastSpellOnTarget(61673, Unit:GetRandomPlayer(0))
Unit:RegisterEvent("Zyxis_Phase3", 1000, 0)
end
end

function Zyxis_Phase3(Unit, Event)
if Unit:GetHealthPct() <=20 then
Unit:RemoveEvents() 
Unit:SendChatMessage(14, 0, "What is happening?!")
Unit:SetModel(24993)
Unit:SetScale(2)
Unit:RegisterEvent("Zyxis_Phase4", 1000, 0)
end
end

function Zyxis_Phase4(Unit, Event)
if Unit:GetHealthPct() <=10 then
Unit:RemoveEvents() 
Unit:CastSpell(47496)
end
end

RegisterUnitEvent(999999, 1, "Zyxis_OnCombat")

I marked the red things.

At the Hellfire Magus, 3000, 6000 and 9000 are the times, when he will cast the spells. Ex: Every 3 seconds he will cast Spell1. Every 6 seconds he will cast Spell2 and so on.

Edit: Normally he would cast every 3 sec, 6sec but you have a "1" after the Time, he will cast the Spell only one time

The 1 after the seconds is how often he use the spell. Is this right, that he should only cast Spell1 one time? And Spell3 three times?

And a question to the second script, should he cast Spell1 only in the OnCombat Phase?

[trinityunit]

I haven't tested the first script you gave me yet, but that seems correct, I didn't know the spells happened in rotation, I thought they were cast whenever.

On the second script, no, I'd prefer he did it every sixty second.

Thanx for your help anyway, +Rep

[Kaidos]

Yeah, np. Test the script, see what happens. And if you want change it, tell me

[trinityunit]

Hey, cool yeah, the first one works

And ty again for helping me understand certain things.
I was reading a guide, and I misunderstood what certain things meant xD

The second one works too! Except I need to choose some other spells for the phases xD.

[trinityunit]

I am, again, having issues with LUA.

Here is the script:

function Zyxis_OnCombat(Unit, Event)
Unit:SendChatMessage(14, 0, "This won't take very long...")
Unit:RegisterEvent("Zyxis_Phase1", 500, 0)
Unit:RegisterEvent("Zyxis_Phase2", 500, 0)
Unit:RegisterEvent("Zyxis_Phase3", 500, 0)
Unit:RegisterEvent("Zyxis_Phase4", 500, 0)
Unit:RegisterEvent("Zyxis_Phase5", 500, 0)
end

function Zyxis_Phase1(Unit, Event)
if Unit:GetHealthPct() <=75 then
Unit:RemoveEvents()
Unit:RegisterEvent("Zyxis_Spell1", 1000, 1) --Cast "Mass Polymorph (29963)"
elseif Unit:GetHealthPct() <=74 then
Unit:RemoveEvents()
elseif Unit:GetHealthPct() <=73 then
end
end

function Zyxis_Phase2(Unit, Event)
if Unit:GetHealthPct() <=50 then
Unit:CastSpell(42745) --Casts "Enrage"
elseif Unit:GetHealthPct() <=49 then
Unit:RemoveEvents()
elseif Unit:GetHealthPct() <=48 then
end
end

function Zyxis_Phase3(Unit, Event)
if Unit:GetHealthPct() <=30 then
Unit:RegisterEvent("Zyxis_Spell3", 1000, 1) --Casts "Sunder Armor (25051)"
elseif Unit:GetHealthPct() <=29 then
Unit:RemoveEvents()
elseif Unit:GetHealthPct() <=28 then
end
end

function Zyxis_Phase4(Unit, Event)
if Unit:GetHealthPct() <=20 then
Unit:SendChatMessage(14, 0, "What is happening?!")
Unit:SetModel(828)
Unit:SetScale(4)
elseif Unit:GetHealthPct() <=19 then
Unit:RemoveEvents()
elseif Unit:GetHealthPct() <=18 then
end
end

function Zyxis_Phase5(Unit, Event)
if Unit:GetHealthPct() <=15 then
Unit:SendChatMessage(14, 0, "If I die, I'm taking you with me!")
Unit:RegisterEvent("Zyxis_Spell4", 1000, 1) --Cast "Self Destruct (9879)"
elseif Unit:GetHealthPct() <=14 then
Unit:RemoveEvents()
elseif Unit:GetHealthPct() <=13 then
end
end

--[Spells]--

function Zyxis_Spell1(Unit, Event)
Unit:CastSpell(29963)
end

function Zyxis_Spell2(Unit, Event)
Unit:CastSpell(43418)
end

function Zyxis_Spell3(Unit, Event)
Unit:FullCastSpellOnTarget(25051,
Unit:GetMainTank(0))
end

function Zyxis_Spell4(Unit, Event)
Unit:FullCastSpellOnTarget(9879,
Unit:GetRandomPlayer(0))
end

function Zyxis_Spell5(Unit, Event)
Unit:FullCastSpellOnTarget(24435,
Unit:GetRandomPlayer(0))
end

--[Misc]--

function Zyxis_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents()
end

function Zyxis_OnKilledTarget(Unit, Event)
Unit:SendChatMessage(14, 0, "Hahahaha...")
end

function Zyxis_OnDied(Unit, Event)
Unit:RemoveEvents()
end


--[RegisterEvents]--

RegisterUnitEvent(999999, 1, "Zyxis_OnCombat")
RegisterUnitEvent(999999, 2, "Zyxis_OnLeaveCombat")
RegisterUnitEvent(999999, 3, "Zyxis_OnKilledTarget")
RegisterUnitEvent(999999, 4, "Zyxis_OnDied")

It will do the first phase, but that's it, could someone tell me what has gone wrong?

[Dynashock]

In phase 1 you do Unit:RemoveEvents() which means you remove all previous events, including the Zyxis_OnCombat function! So once it enters phase 1 it won't check every 0.5 seconds if he can enter the next phase anymore.
Just remove all the Unit:RemoveEvents() and you should be fine. Or you could put Unit:RegisterEvent("Zyxis_Phase2", 500, 0) at the end of phase 1 so it still gets registered after all previous events have been removed.