[HELP] Tokebn System

[Mizuki90]

Ok ... so im using ACDB's token system with some modifications ... now I need some help ... I dont knwo how to make badge of justice Add to every person in the party can someone help me with it please ...

#include "StdAfx.h"
#include "Setup.h"

void onPvpKill(Player* plr, Player* victim)
{
    int itemID;
    uint32 tokenItem = Config.MainConfig.GetInt("NCDB", "PvPTokenID", &itemID);

    //sLog.outColor(TGREEN,"n[NCDB] (%u)%s killed (%u)%s", plr->getLevel(), plr->GetName(), victim->getLevel(), victim->GetName());
    char onkill[1024];
    snprintf((char*)onkill, 1024, "[PVP] %s has killed %s", plr->GetName(), victim->GetName());
    //sWorld.SendWorldWideScreenText(onkill);

	if(plr->getLevel() >= 70 && victim->getLevel() >= 70 && plr->GetGUID() != victim->GetGUID() && plr->GetZoneId() != 357)
    {
		sWorld.SendWorldWideScreenText(onkill);
        //sLog.outColor(TGREEN,"n[NCDB] Adding token to %s", plr->GetName());
        //sLog.outColor(TNORMAL,"n");
        ItemPrototype *proto = ItemPrototypeStorage.LookupEntry(itemID);
        if(!proto) return;
        SlotResult slotresult;
        slotresult = plr->GetItemInterface()->FindFreeInventorySlot(proto);

        if(!slotresult.Result)
        {
            plr->GetItemInterface()->BuildInventoryChangeError(NULL, NULL, INV_ERR_INVENTORY_FULL);
        }
        else
        {
            Item *itm = objmgr.CreateItem(itemID, plr);
            plr->GetItemInterface()->SafeAddItem(itm,slotresult.ContainerSlot, slotresult.Slot);
            itm->m_isDirty = true;
        }
    }
    else
    {
        //sLog.outColor(TGREEN,"n[NCDB] Not adding token since they both are not level 80");
        //sLog.outColor(TNORMAL,"n");
    }
}


void SetupPvPToken(ScriptMgr * mgr)
{
    mgr->register_hook(SERVER_HOOK_EVENT_ON_KILL_PLAYER, onPvpKill);
}

As you can see the item just gets added to 1 person :S ... I need it to add to the whole group Hope someoen can help ... I already tried checking the HonorManager.cpp but I cant get anything to work

OMG : TOKEBN >.>

[TheSpidey]

You'll need to iterate over all party members. Check how it's done in the core
(Hint: The core iterates over party members when you join a BG as a group. Also, when you get gold from a mob while in a party)

Good luck

[Mizuki90]

I checked the core in the Honor Handler section -.- I dint get very far
LOL With my knowledge of C++ I should think u need a loop to check every party member ... and thats where I get terribly confused :s .. First gotta google iterate ^.^' -> OHNOOOZ I HATE LOOPS!

Spidey ... would it be this ?
Ok this is what I made ... it dompiled successfully *Dint expect it to* and now ima test it

If you see something wrong please tell me ... goin onto a live serevr with 100 + ppl ... dun want crashes xD

#include "StdAfx.h"
#include "Setup.h"

void onPvpKill(Player* plr, Player* victim)
{
    int itemID;
    uint32 tokenItem = Config.MainConfig.GetInt("NCDB", "PvPTokenID", &itemID);

    //sLog.outColor(TGREEN,"n[NCDB] (%u)%s killed (%u)%s", plr->getLevel(), plr->GetName(), victim->getLevel(), victim->GetName());
    char onkill[1024];
    snprintf((char*)onkill, 1024, "[PVP] %s has killed %s", plr->GetName(), victim->GetName());
    //sWorld.SendWorldWideScreenText(onkill);

	if(plr->getLevel() >= 70 && victim->getLevel() >= 70 && plr->GetGUID() != victim->GetGUID() && plr->GetZoneId() != 357)
    {

		sWorld.SendWorldWideScreenText(onkill);
        //sLog.outColor(TGREEN,"n[NCDB] Adding token to %s", plr->GetName());
        //sLog.outColor(TNORMAL,"n");
        ItemPrototype *proto = ItemPrototypeStorage.LookupEntry(itemID);


        if(!proto) return;
        SlotResult slotresult;
        slotresult = plr->GetItemInterface()->FindFreeInventorySlot(proto);

        if(!slotresult.Result)
        {
            plr->GetItemInterface()->BuildInventoryChangeError(NULL, NULL, INV_ERR_INVENTORY_FULL);
        }
        else
        {
            Item *itm = objmgr.CreateItem(itemID, plr);
            plr->GetItemInterface()->SafeAddItem(itm,slotresult.ContainerSlot, slotresult.Slot);

			set<Player*> contributors;
			for(set<Player*>::iterator itr = contributors.begin(); itr != contributors.end(); itr++)
			{
				Player * pAffectedPlayer = (*itr);
				if(!pAffectedPlayer) continue;
					Item *itm = objmgr.CreateItem(itemID, plr);
					pAffectedPlayer->GetItemInterface()->SafeAddItem(itm,slotresult.ContainerSlot, slotresult.Slot);
			}



            itm->m_isDirty = true;
        }
    }
    else
    {
        //sLog.outColor(TGREEN,"n[NCDB] Not adding token since they both are not level 80");
        //sLog.outColor(TNORMAL,"n");
    }
}


void SetupPvPToken(ScriptMgr * mgr)
{
    mgr->register_hook(SERVER_HOOK_EVENT_ON_KILL_PLAYER, onPvpKill);
}

Still doesnt work -.- I need help here can soemoen plz fix it :S It gives tokens to individuals ... but it doesnt work when givin tokens to a party ... Even though I added the part from the honor handler /cry

[TheSpidey]

Almost there mate!
[qupte]Item *itm = objmgr.CreateItem(itemID, plr); pAffectedPlayer->GetItemInterface()->SafeAddItem(itm,slotresult.ContainerSlot, slotresult.Slot);[/quote]

The new item you make for each player has plr as its owner instead of pAffectedPlayer.
Also, slotresult comes from plr's inventory, not from pAffectedPlayer

[Mizuki90]

Ah I see Il try again

Trying again ...

#include "StdAfx.h"
#include "Setup.h"

void onPvpKill(Player* plr, Player* victim)
{
    int itemID;
    uint32 tokenItem = Config.MainConfig.GetInt("NCDB", "PvPTokenID", &itemID);

    //sLog.outColor(TGREEN,"n[NCDB] (%u)%s killed (%u)%s", plr->getLevel(), plr->GetName(), victim->getLevel(), victim->GetName());
    char onkill[1024];
    snprintf((char*)onkill, 1024, "[PVP] %s has killed %s", plr->GetName(), victim->GetName());
    //sWorld.SendWorldWideScreenText(onkill);

	if(plr->getLevel() >= 70 && victim->getLevel() >= 70 && plr->GetGUID() != victim->GetGUID() && plr->GetZoneId() != 357)
    {

		sWorld.SendWorldWideScreenText(onkill);
        //sLog.outColor(TGREEN,"n[NCDB] Adding token to %s", plr->GetName());
        //sLog.outColor(TNORMAL,"n");
        ItemPrototype *proto = ItemPrototypeStorage.LookupEntry(itemID);


        if(!proto) return;
        SlotResult slotresult;
        slotresult = plr->GetItemInterface()->FindFreeInventorySlot(proto);

        if(!slotresult.Result)
        {
            plr->GetItemInterface()->BuildInventoryChangeError(NULL, NULL, INV_ERR_INVENTORY_FULL);
        }
        else
        {
            Item *itm = objmgr.CreateItem(itemID, plr);
            plr->GetItemInterface()->SafeAddItem(itm,slotresult.ContainerSlot, slotresult.Slot);

			set<Player*> contributors;
			for(set<Player*>::iterator itr = contributors.begin(); itr != contributors.end(); itr++)
			{
				Player * pAffectedPlayer = (*itr);

				Item *itmG = objmgr.CreateItem(itemID, pAffectedPlayer);
				slotresult = plr->GetItemInterface()->FindFreeInventorySlot(proto);
				

				if(!pAffectedPlayer) continue;
					Item *itm = objmgr.CreateItem(itemID, plr);
					pAffectedPlayer->GetItemInterface()->SafeAddItem(itmG,slotresult.ContainerSlot, slotresult.Slot);
			}



            itm->m_isDirty = true;
        }
    }
    else
    {
        //sLog.outColor(TGREEN,"n[NCDB] Not adding token since they both are not level 80");
        //sLog.outColor(TNORMAL,"n");
    }
}


void SetupPvPToken(ScriptMgr * mgr)
{
    mgr->register_hook(SERVER_HOOK_EVENT_ON_KILL_PLAYER, onPvpKill);
}

Still not ... How do I make the lotresult come from pAffectedPlayer ? coz Then I cant put it where it is in the script coz of " if(!slotresult.Result)" that could make problems :S

[TheSpidey]

Well now you got too far away.
Here's the pseudocode:

When Plr kills Victim:
Check for honorable kill, Plr's level as opposed to Victim's one.
If the kill was dishonorable, return.
Find a free slot in Plr's inventory.
If there's a free slot:
    Create Item pItem with Plr as owner.
    Add pItem to Plr's inventory using the slot we found.
For each pMember in Plr's group:
    Find a free slot in pMember's inventory.
    If there's a free slot:
        Create Item pItem with pMember as owner.
        Add pItem to pMember's inventory using the slot we found
end.

[Mizuki90]

Trying this ... LOL :

set<Player*> contributors;
			for(set<Player*>::iterator itr = contributors.begin(); itr != contributors.end(); itr++)
			{
				Player * pAffectedPlayer = (*itr);
			
				slotresult = pAffectedPlayer->GetItemInterface()->FindFreeInventorySlot(proto);
			
				if(!slotresult.Result)
				 {
					  pAffectedPlayer->GetItemInterface()->BuildInventoryChangeError(NULL, NULL, INV_ERR_INVENTORY_FULL);
				 }

				
				else
				{
				

					if(!pAffectedPlayer) continue;
					Item *itm = objmgr.CreateItem(itemID, pAffectedPlayer);
					pAffectedPlayer->GetItemInterface()->SafeAddItem(itm,slotresult.ContainerSlot, slotresult.Slot);
				}

Still ..... not .... :s

[Mizuki90]

Ok now that works but I need some help on the following ... coz that adds to every player in the group ... wether he helped or not ... so heres this I need to know if im doing this right ... I dunno how to check if the player was healing :s

if(pAffectedPlayer->GetZoneId() != 357)
				{	
					int itemID = 29434;
					ItemPrototype *proto = ItemPrototypeStorage.LookupEntry(itemID);
					SlotResult slotresult;

					if(pAffectedPlayer->GetTarget() == pPlayer->GetTarget())
					{
					//PVP Token
				    slotresult = pAffectedPlayer->GetItemInterface()->FindFreeInventorySlot(proto);
					Item *itm = objmgr.CreateItem(itemID, pAffectedPlayer);
				    pAffectedPlayer->GetItemInterface()->SafeAddItem(itm,slotresult.ContainerSlot, slotresult.Slot);
					}else if (pAffectedPlayer->GetTarget() == pPlayer->GetGUID()) //..How do I check if someone was healing the killer ... ?
					{
				    slotresult = pAffectedPlayer->GetItemInterface()->FindFreeInventorySlot(proto);
					Item *itm = objmgr.CreateItem(itemID, pAffectedPlayer);
				    pAffectedPlayer->GetItemInterface()->SafeAddItem(itm,slotresult.ContainerSlot, slotresult.Slot);
					}

Theres my code ...could someone plz fix it for me or HELP me fix it ? Please ... The person must only get a token IF he helped kill or helped heal :s