Can you guys correct my C++ script?

[guitargod218]

Alright guys, I've been working on this, and I thought I had done this perfectly, but I guess I messed up somewhere. Here is my script:

#include "StdAfx.h"
#include "Setup.h"

class Orb_of_Translocation : public GameObjectAIScript
{
public:
Orb_of_Translocation(GameObject* goinstance) : GameObjectAIScript(goinstance) {}
static GameObjectAIScript *Create(GameObject * GO) { return new Orb_of_Translocation(GO); }

void OnActivate(Player * pPlayer)
{
if(Plr->getRace() == RACE_HUMAN)
pPlayer->SafeTeleport(0, 0, -8949.95, -132.493, 83.5312)
}
else if(Plr->getRace() == RACE_ORC)
pPlayer->SafeTeleport(1, 0, -618.518, -4251.67, 38.71
}
else if(Plr->getRace() == RACE_DWARF)
pPlayer->SafeTeleport(0, 0, -6240.32, 331.033, 382.75
}
else if(Plr->getRace() == RACE_NIGHTELF)
pPlayer->SafeTeleport(1, 0, 10311.3, 832.463, 1326.41)
}
else if(Plr->getRace() == RACE_UNDEAD)
pPlayer->SafeTeleport(0, 0, 1676.35, 1677.45, 121.67)
}
else if(Plr->getRace() == RACE_TAUREN)
pPlayer->SafeTeleport(10, 0, -2917.58, -257.98, 52.996
}
else if(Plr->getRace() == RACE_GNOME)
pPlayer->SafeTeleport(0, 0, -6240.32, 331.033, 382.75
}
else if(Plr->getRace() == RACE_TROLL)
pPlayer->SafeTeleport(1, 0,-618.518, -4251.67, 38.71
}
else if(Plr->getRace() == RACE_BLOODELF)
pPlayer->SafeTeleport(530, 0, 10349.6, -6357.29, 33.4026)
}
else if(Plr->getRace() == RACE_DRAENEI)
pPlayer->SafeTeleport(530, 0, -3961.64, -13931.2, 100.615)
}
}
};

void SetupOrb_of_Translocation(ScriptMgr * mgr)
{
mgr->register_gameobject_script(910000, &Orb_of_Translocation::Create);
}

I dunno what's wrong with it.

By the way, the name of the object is Orb of Translocation, so if the problem is that I put the underscore there, just let me know.

[doublehex]

 			 				#include "StdAfx.h"
#include "Setup.h"
 
class Orb_of_Translocation : public GameObjectAIScript
{
public:
Orb_of_Translocation(GameObject* goinstance) : GameObjectAIScript(goinstance) {}
static GameObjectAIScript *Create(GameObject * GO) { return new Orb_of_Translocation(GO); }
 
void OnActivate(Player * Plr)
{
	if(Plr->getRace() == RACE_HUMAN)
	pPlayer->SafeTeleport(0, 0, -8949.95, -132.493, 83.5312);
	else
{
 if(Plr->getRace() == RACE_ORC)
	pPlayer->SafeTeleport(1, 0, -618.518, -4251.67, 38.718);
	else
{
if(Plr->getRace() == RACE_DWARF)
	pPlayer->SafeTeleport(0, 0, -6240.32, 331.033, 382.758);
	else 
{
if(Plr->getRace() == RACE_NIGHTELF)
	pPlayer->SafeTeleport(1, 0, 10311.3, 832.463, 1326.41);
else 
{
if(Plr->getRace() == RACE_UNDEAD)
	pPlayer->SafeTeleport(0, 0, 1676.35, 1677.45, 121.67);
else
{
 if(Plr->getRace() == RACE_TAUREN)
	pPlayer->SafeTeleport(10, 0, -2917.58, -257.98, 52.9968);
else
{
if(Plr->getRace() == RACE_GNOME)
	pPlayer->SafeTeleport(0, 0, -6240.32, 331.033, 382.758);
else
{
if(Plr->getRace() == RACE_TROLL)
	pPlayer->SafeTeleport(1, 0,-618.518, -4251.67, 38.718);
else
{
if(Plr->getRace() == RACE_BLOODELF)
	pPlayer->SafeTeleport(530, 0, 10349.6, -6357.29, 33.4026);
else
{
 if(Plr->getRace() == RACE_DRAENEI)
	pPlayer->SafeTeleport(530, 0, -3961.64, -13931.2, 100.615);
else
{
Plr->BroadcastMessage("Error! You are an incorrect race!");
}}}}}}}}
};
 
void SetupOrb_of_Translocation(ScriptMgr * mgr)
{
mgr->register_gameobject_script(910000, &Orb_of_Translocation::Create);
}

try that and if you get errors post them here.

[Deamie]

Whats is it for? I dont know jack about this stuff =P

[doublehex]

its just his gameobject that teleport a player to their start area.

[guitargod218]

Okay, it doesn't work, and I used what doublehex told me to use. The type of gameobject was input as 10, which is goober. Is that the problem?

[guitargod218]

Alright, I'm thinking the problem is with the type of gameobject. What should it be?

[doublehex]

the type should be 10

[guitargod218]

So then what could be the problem? The script is in the scripts folder, copied exactly the way it should be. I must know, hah; whatever, I'll check for the answer tomorrow.

[TheSpidey]

Of course it won't work.
The original script, the player pointer is pPlayer. You're trying to refer to Plr, which doesn't exist in this scope.

Edit: Wait, scripts folder? Nonono, you need to compile this and place the dll in script_bin.

[guitargod218]

Okay, so do I make the code become:

plr->SafeTeleport(0, 0, -8949.95, -132.493, 83.5312);

Also, when I compile this, where do I put it? Into the folder with the rest of the C++ scripts?

[Gastricpenguin]

Anywhere you see "Plr", change it to say "pPlayer".
Compile the script as a release, then put it in the script_bin folder.

[guitargod218]

Okay, I'm so confused....so the original script from doublehex was correct? And all I needed to do was compile it? Wow, I feel so retarded right now. Thanks everyone for the help!

[TheSpidey]

No, doublehex's script had a couple of errors as well.
No { after else, referring to Plr as pPlayer

[guitargod218]

Wait, gastric says change it to pPlayer, and Spidey says not to....

[Power of Illuminati]

I think both mean that it should be pPlayer

And thespidey

I think he got all } after else. He has just built it up with if, then an else with if in. And conintues with that

So all } of the else are in the end

}}}}}}}}