DoString("CastSpellByName()") Crashes Randomly.

[cenron]

Hey guys I got the DoString ( what I think is dostring ) function working for casting spell, but I keep running into a problem with it crashing.

The situation is I got a rogue that I set up a simple loop( to call "Hemorrhage" every 2 seconds, it does this perfectly a couple times and then issues a "Error Reading 0xADDRESS" then crashes.

Instruction at "0x00A9..." refrenced memory at "0x0000000024".

I can't figure out what the conditions are that cause this crash. Sometimes it will only call the spell once before it crashes, other times I can go 2-3 minutes of mob killing before it crashes.

I check to make sure, I have a target, and its attackable, and the target is attacking me before making these calls but it still just crashes RANDOMLY....

This is the code for everything

if( targetObj->GetTargetGUID() == player->GetGUID() && player->IsStealth() == false ) {
    if( this->timerPtr_->IsRunning(1337) == false ) {
        LOG_INF( "Casting: Hemorrphage" << std::endl );
        player->GetSpellBook()->CastSpellByName( "Hemorrhage");
    }
} 

LUA_DO_STRING = 0x4FD26 

typedef void (__cdecl *pDoString) ( const char *spellName_1, const char *spellName_2, int un_1 );
pDoString oDoString = reinterpret_cast< pDoString >( doStringAddr->GetFullAddress() );
oDoString( str.c_str(), str.c_str(), 0 ); 

[JuJuBoSc]

Are you calling it from main thread ?

[cenron]

Are you calling it from main thread ?

No, I am calling it from a thread I created.....do you have to? I use to work with WoW....back when they use to store the object manager in the TlsIndex, so you either patched your TlsIndex, Hook EndScene, or Hook the MainThread to make any calls.....

I thought that i read somewhere that they dont store the object manager in the TlsIndex. So I figured you didn't have to be selective about the threads you run your code in....

I guess the other question is, why does it work sometimes for 5 min continuously and then crash and then other times only work for 5 seconds.

I am always nervous about hooking any D3D functions, or threads cause of warden.....is there a patch I can do to my thread so that I can call stuff from it?

[JuJuBoSc]

It's not thread sade, so you have to call it from main thread, just hook any d3d function of your choice, if your project is private, you don't need to care about the warden at all.

[cenron]

It's not thread sade, so you have to call it from main thread, just hook any d3d function of your choice, if your project is private, you don't need to care about the warden at all.

Oooooohhhh that makes a lot of sense now....I was wondering why it was so random.