Clientcrash - but it works for several minutes

[streppel]

Hey all

(NOTE: NOT WOW RELATED)

so i got my bot base working so far and thought that i'd write a simple assistbot.
i'm calling the games function via blackmagics asm injection class. I tested all the functions i'm using for this and they all work fine.
The problem is: the bot works for several minutes, but suddenly the client crashes. i'm not sure why it crashes as,like i said, all the functions work correctly and for several minutes.

i made sure i free the memory i used too, so this shouldn't be the problem here either.

What could cause those crashes and how would i fix it?

thx for your help

[Cypher]

It would help if you actually provided your code, the relevant error information dumps, etc etc. Otherwise we'd just be guessing.

Alternatively, you could just wait for someone telepathic, but I think you'll be waiting a while...

[streppel]

well,there actually is no error dump, the client just crashes and my bot doesn't give me anything else then which function it was tyring to use when it crashed
this is the function that is called upon crash
public void AssistFight(uint id) { try { - Pastebin.com

this is the original game function:
[ASM (NASM)] .text:10022526 ; public: void __thiscall n3EngineClientAnarchy_t::N3Msg_AssistFi - Pastebin.com

this is the decompiled code ida gave me:
[C] int __stdcall n3EngineClientAnarchy_t__N3Msg_AssistFight(int a1) { int resul - Pastebin.com

like i said,it works for a few minutes and then all of the sudden crashes

[MaiN]

I'll bet you it's thread issues.

[streppel]

but why would it work for minutes then?

[schlumpf]

but why would it work for minutes then?

Because race conditions are race conditions, not crashs. If its ABABABABABABABAB für minutes, then A&B at the same time, it might **** things up.

[streppel]

EDIT:

you were so right,it was a threading problem
i did implement a solution to hijack the mainthread now and it ran for 15 minutes straight without any problem, so i guess this problem is fixed.
thank you guys, +rep

EDIT2:

ok with the help of this post http://www.mmowned.com/forums/world-...ndexecute.html
i managed to made my bot a little more stable
the problem is, that it still tends to crash after some time(before it was like 5 minutes,now half an hour but still not what i'd like here like several hours)
i tryed to implement the Thread WaitForSingleObject, but don't know if the implementation is correct this way, cause in the example of the code above it was a wait for 2 seconds, but if i'd pass those 2000ms to WaitForSingleObject it would always wait this long.

and this is my new code:
http://pastebin.com/K7YBJ6cq
to stresstest this i ran this function in a loop with a 100ms wait. it went well for about half a minute,then crashed again. (normally i'm doing like a 600ms wait there, what was when i got 30 minutes working, but it should work even with a 100ms wait,not?)

as always thanks for your help and sorry for me being not smart enough yet to find those problems myself.

[streppel]

*push*
sorry for bumping but as i wrote above, the problem still exists

[MaiN]

You can't wait for the main thread because it won't exit like the thread CreateRemoteThread created will when it is finished. Also, this is not the way to avoid sync issues because the main thread may be in the middle of the function when you hijack it.

[streppel]

so the other way would be like hooking endscene.
this is where i'd have a problem: the game is using directx7 /direct3d and some opengl. which function should i hook there?

[MaiN]

so the other way would be like hooking endscene.
this is where i'd have a problem: the game is using directx7 /direct3d and some opengl. which function should i hook there?

You can hook any game function that is pulsed every frame - doesn't have to be a DirectX or OpenGL one.

[streppel]

You can hook any game function that is pulsed every frame - doesn't have to be a DirectX or OpenGL one.

but one of those would be the best as they are called every frame, right?

[lanman92]

There has to be a function in the game that is called every frame. Find it and hook it. Alternatively, you could use an EndScene hook, which is easier. A lot easier.

[streppel]

There has to be a function in the game that is called every frame. Find it and hook it. Alternatively, you could use an EndScene hook, which is easier. A lot easier.

like i said,there is no endscene function i could hook. at least i don't find it with CheatEngine being attached and enumerating the dlls and symbols.

i found a function that is called "d3dkmtrender" and seems to be what i'd want.

EDIT:
ok,it works SOOOOO great, i can't thank you enough for your help aswell as RivalFr who i currently can't rep anymore

[streppel]

*push*
sorry for pushing such an old thread
i'm now trying to let my bot do it's stuff again, i hooked getcursorpos and some game render function(ofc jsut one at a time), still both of the methods don't seem to change anything as my bot crashes after several minutes again.
all methods i'm using ingame keep it running and work for sure, still it crashes, so i think it would be a race condition/threading issue once again. it would be great if one of you could help me on this one.

thanks again
streppel

EDIT:
ok,i'm stupid,i changed my hooking method from Hooking->Executing->Unhooking to Hooking at bot start and Unhooking at bot end...works great. thanks anyway