[C#] [Question] Running TraceLine from an Endscene Hook

[Kaziko.]

Hello everyone, over the past few days I have created a gathering bot and the only thing left to do is stop if from gathering underground nodes. Through reading this forum and others I have decided that the best way to do this is via TraceLine.

From my research I found out that CGWorldFrame__Intersect is actually the wrapper for TraceLine. Here is that function in IDA: (Thanks to TOM_RUS).

[SPOILER]

[/SPOILER]
ImageShack&#174; - Online Photo and Video Hosting <--- If it doesn't work.

I have tried to run the function on the bottom right in the picture (which I believe to be TraceLine) through my EndScene hook (I'm using iHook, thanks to Ryuk).

See my code here: #1513204 - Pastie

I am using the following Offset for TraceLine = 0x2851E0 (Thanks to RivalLfr).
And the flags from MaiN's post here:
http://www.mmowned.com/forums/world-...ml#post1687087

When I run this code WoW crashes and I get the error:
Could not write the specified bytes! 60D1CE09 [5]
(It points to Hook.Restore()

There is no errors with iHook as far as I can tell, I have used both the inbuilt and my own DoString() and GetLocalizedText() perfectly.

I have just a few questions about TraceLine (I have searched, this has kept me stuck for days).
Do I need to write the Point(0, 0, 0) for the return? Is this what is causing me the error?
Or is there something wrong with the string that I'm Injecting?

Thanks alot,

Kaziko.

[VexeRR]

I think the problem is that you're not calling the right function. I'm not very experienced with this though. Probably wrong :P

Im also trying to get it to work maybe we can work together?

[alynel]

The function you're calling (0x2851E0) is CGWorldFrame__Intersect. TraceLine is at 0x2BFBE0. TraceLine is stdcall, so it'll clean up the stack for you, but if you're gonna use CGWorldFrame__Intersect, you'll have to do it yourself. Either way you shouldn't have the "pop ebp" after the call. Either use TraceLine and get rid of it, or use CGWorldFrame__Intersect and replace it with "add esp, 0x18".

Oh and it shouldn't be '[ebp+" + zeroCodeCave + "]' etc, just '[" + zeroCodeCave + "]'

1 more thing! I think it's the last one... for startCodeCave, result, and end, you just need '"mov eax, " + startCodeCave' since they're pointers, so you want to pass the address of your vectors rather than the x value of them...

[RivaLfr]

Look this code

 // protected delegate byte Traceline(ref WoWPoint end, ref WoWPoint start, ref WoWPoint result, ref float distance, uint flags, ref WoWPoint Optional)
				
		"push " + (int)0, //Optional
                "push " + (uint)hitFlags, //(CGWorldFrameHitFlags)
                "push " + (uint)distance,  //(0.9f)
                "push " + (uint)result, //(x=0;y=0;z=0)
                "push " + (uint)start, //(x;y;z)
                "push " + (uint)end, //(x;y;z)
                "call " + (uint)((uint)wowModule + (uint)TraceLine),
                "mov [" + (uint)result + "], al", // Move result to CodeCave result (bool)
                "add esp, " + (uint)0x18, //adjusting stack after all pushes
                "retn",

[Kaziko.]

Thank you and +rep to Rivalfr and alynel.

I now have the following code working without WoW crashing.

I am using TraceLine = 0x2851E0.

Pastie: #1514474 - Pastie
(still needs some cleaning up that alynel PM'd me about)

Now the only problem is the bool returned is always true even if my target is out of LoS or I aim the TraceLine below my feet.

I think this is a problem with the HitFlags. I have tried every one from
http://www.mmowned.com/forums/world-...ml#post1687087

But the bool returned is always true. Any Ideas?

I'll try to see what I get from distance and result.

[JuJuBoSc]

You pass the flag as pointer, which is not a pointer.

[Kaziko.]

Thanks JuJu,

I fixed my code up but it is still always returning true.

Heres my new code: #1516577 - Pastie

[RivaLfr]

Add line:

UInt32 resultRet = Memory.AllocateMemory(0x4);

Replace

"mov [" + (uint)resultCodeCave + "], al",

by

"mov [" + (uint)resultRet + "], al",

And replace

ret = Convert.ToBoolean(Hook.InjectAndExecute(asm));

by

Hook.InjectAndExecute(asm);
ret = Hook.Memory.ReadInt(resultRet) > 0;