Hook all events

[amadmonk]

So, I'm wondering if anyone has a clean(er) way to hook all events (specifically framescript events, but I wouldn't complain about glue events either). I did some reversing on this myself a long while ago (like pre 3.0) and it wasn't realistically possible because of the way the event handler worked; there wasn't a single call point that got called with every raw event. Rather it looked like there were a bestiary of event object types which got routed through a half dozen or so functions, and reversing/hooking/maintaining this would be prohibitive.

Right now, I capture all framescript events natively through a bit of injected Lua that hooks all events and pingpongs them back into the bot code. However, this is fragile and hacky and you need very special case handling for things like ReloadUI() and PLAYER_ENTERING_WORLD.

Is there a better way? Or am I to be stuck with my hack...

[Apoc]

What you're doing is the most stable way to deal with it.

Just keep checking every 'pulse' if your frame is available; if not, recreate it, and re-hook all the events. That's how its done in quite a few bots, and it works without issues. (You may miss an event or two, but usually nothing terribly important.)

Edit: Stay on topic people. I'm going to start handing out infractions and bans again. It's getting out of hand.

[ddebug]

So, I'm wondering if anyone has a clean(er) way to hook all events (specifically framescript events, but I wouldn't complain about glue events either). I did some reversing on this myself a long while ago (like pre 3.0) and it wasn't realistically possible because of the way the event handler worked; there wasn't a single call point that got called with every raw event. Rather it looked like there were a bestiary of event object types which got routed through a half dozen or so functions, and reversing/hooking/maintaining this would be prohibitive.

Right now, I capture all framescript events natively through a bit of injected Lua that hooks all events and pingpongs them back into the bot code. However, this is fragile and hacky and you need very special case handling for things like ReloadUI() and PLAYER_ENTERING_WORLD.

Is there a better way? Or am I to be stuck with my hack...

Why not take a look at FrameScript__SignalEvent? Just detour that function. It is signaled each time an event is handled.

[amadmonk]

Thanks, I'll take a look at that when I get home (at work now, so no WoW and no IDA). I think I looked at that last time and had the problems I mentioned -- no single point of signaling, all custom event object classes, etc. I'm lazy, so I was hoping it had gotten easier.

I'll see what I can see.

[ddebug]

Thanks, I'll take a look at that when I get home (at work now, so no WoW and no IDA). I think I looked at that last time and had the problems I mentioned -- no single point of signaling, all custom event object classes, etc. I'm lazy, so I was hoping it had gotten easier.

I'll see what I can see.

I don't understand. The first parameter of FrameScript__SignalEvent is an integer which corresponds to an enum list of the following events: http://www.wowwiki.com/Events_A-Z_(full_list). You can't really go easier than this. It's perfect.

e.g.

switch (nEventId) // Retrieved from first parameter of SignalEvent
{
   case CHAT_MSG_WHISPER:
       // Do something.
       break;
   case PLAYER_ENTERING_WORLD:
       // Do something.
       break;
}

[amadmonk]

What you're doing is the most stable way to deal with it.

Just keep checking every 'pulse' if your frame is available; if not, recreate it, and re-hook all the events. That's how its done in quite a few bots, and it works without issues. (You may miss an event or two, but usually nothing terribly important.)

Edit: Stay on topic people. I'm going to start handing out infractions and bans again. It's getting out of hand.

Thanks, Apoc. I was figuring that if there was a better way, I would have seen it. I still think it's hacky, but... it works (aside from last night when it got a little borked during a phase change in a heroic instance and ended up crashing my bot and killing my group. But who's counting? )

---------- Post added at 04:14 PM ---------- Previous post was at 04:13 PM ----------

I don't understand. The first parameter of FrameScript__SignalEvent is an integer which corresponds to an enum list of the following events: http://www.wowwiki.com/Events_A-Z_(full_list). You can't really go easier than this. It's perfect.

e.g.

switch (nEventId) // Retrieved from first parameter of SignalEvent
{
   case CHAT_MSG_WHISPER:
       // Do something.
       break;
   case PLAYER_ENTERING_WORLD:
       // Do something.
       break;
}

IIRC, the problem was getting the event params. It's not always as simple as just inspecting the Lua stack (again, IIRC -- it's been almost a year since I last looked at that code path).

[ddebug]

IIRC, the problem was getting the event params. It's not always as simple as just inspecting the Lua stack (again, IIRC -- it's been almost a year since I last looked at that code path).

The 3rd parameter has all the arguments (vargs_list).

For example, this is what I do for CHAT_MSG_WHISPER:

Program.MainForm.Log(Color.Purple, "Whisper from {0}{1}: {2}", args[5], args[1], args[0]);

MaiN has a nice article on how to do it from C#: http://www.mmowned.com/forums/world-...guments-c.html

If you are doing it from C++, it is much easier.

[ramey]

Latest [WoW] Events changed in v3.3.3

inb4 everyone criticizes!

[Robske]

Latest [WoW] Events changed in v3.3.3

inb4 everyone criticizes!

I'd be happy to.

std::clog << "WoWLink::CEvents: destructed." << std::endl;

The term you're looking for is 'deconstructed' or 'destroyed'.

(Too much of a monkey to critize other things)

On topic:

Using the lua frame approach does have alot of advantages. You get (most) frame-, glue- and combat-log events in one go and you do not have to maintain multiple offsets and handlers.
The down side is that it feels dirty in a way that you are basically taking a 'detour' through lua and you have to make extra arrangements to keep the 'detour' alive.

I have both available in my projects, but at the moment I use the lua-frame method.

[amadmonk]

...and you do not have to maintain multiple offsets and handlers...

Yeah, that's what I was trying to avoid. Sounds like I need to stick with the "route them all through Lua" method to avoid having to chase down the myriad different event type offsets.

Thanks, all, for the input.

[ramey]

I'd be happy to.



The term you're looking for is 'deconstructed' or 'destroyed'.

(Too much of a monkey to critize other things)

On topic:

Using the lua frame approach does have alot of advantages. You get (most) frame-, glue- and combat-log events in one go and you do not have to maintain multiple offsets and handlers.
The down side is that it feels dirty in a way that you are basically taking a 'detour' through lua and you have to make extra arrangements to keep the 'detour' alive.

I have both available in my projects, but at the moment I use the lua-frame method.

You are a ****.
x

[Cypher]

The term you're looking for is 'deconstructed' or 'destroyed'.

Actually 'destructed' is an acceptable term (its base obviously being 'destruct', which is a real word). Where do you think the term 'destructor' came from? I dunno what you crazy C# guys call it, but as far as C++ goes, his terminology is correct. When an object's destructor is called, the object is said to be 'destructed'.

Use of the term in popular reference material:
[11] Destructors, C++ FAQ

P.S. Sorry, but I wanted to join in on the nitpicking.

[ramey]

Actually 'destructed' is an acceptable term (its base obviously being 'destruct', which is a real word). Where do you think the term 'destructor' came from? I dunno what you crazy C# guys call it, but as far as C++ goes, his terminology is correct. When an object's destructor is called, the object is said to be 'destructed'.

Use of the term in popular reference material:
[11] Destructors, C++ FAQ

P.S. Sorry, but I wanted to join in on the nitpicking.

I knew I was right but wasn't sure. Did even do define: destruct in google!

[XTZGZoReX]

Actually 'destructed' is an acceptable term (its base obviously being 'destruct', which is a real word). Where do you think the term 'destructor' came from? I dunno what you crazy C# guys call it, but as far as C++ goes, his terminology is correct. When an object's destructor is called, the object is said to be 'destructed'.

Use of the term in popular reference material:
[11] Destructors, C++ FAQ

P.S. Sorry, but I wanted to join in on the nitpicking.

In C#, it's also called a destructor (though in the runtime, it's a finalizer). So yeah, his terminology is correct there too.

[MaiN]

FrameScript__SignalEvent calls an argument that takes a va_list as argument (natively, this is just a pointer to the first argument in the stack). Hook that function. The format is passed as well.