C++ can*t open process World of Warcraft ( error 5)

[lustikus12]

Hello i tray Memoryreading with c++ the first time ok her is my sourche :

// Memory.cpp: Hauptprojektdatei.

#include "stdafx.h"

using namespace System;

#define WIN32_LEAN_AND_MEAN  
#include <windows.h>
#include <iostream>
#include <tchar.h>
#include <string>
#pragma comment(lib, "user32.lib")
#pragma comment(lib, "kernel32.lib")
#define SE_DEBUG_NAME TEXT(*SeDebugPrivilege*)
//#pragma comment(lib, "gdi32.lib") 
using namespace std;

int _tmain(int argc, _TCHAR* argv[])// lol, ich nenns immer int main(int argc, char *argv[]) ^^
{ 
	HWND hWindow;
	DWORD dwProcId;
	DWORD rw=0;
	HANDLE hProcess;
	int ID;

	int puffer = 0;
	unsigned int adresse = 0x007E75E4;
	printf("Searching hWnd...\n");                                                                
	while(!(hWindow = FindWindow(NULL, L"World of Warcraft")));     //Das it ein LPWSTR (oder so ähnlich^^) da musst du ein L davorstellen
	{Sleep(50);}
	printf("hWnd: 0x%i\n",hWindow);
	if(!hWindow);
	printf("Searching PocessId...\n");
	do
	{GetWindowThreadProcessId(hWindow, &dwProcId);}while(!dwProcId);
        printf("dwProcId: 0x%i\n", dwProcId);

	printf("Searching Process Handle\n");
	hProcess = OpenProcess(PROCESS_QUERY_INFORMATION|PROCESS_VM_READ|PROCESS_TERMINATE,false,dwProcId);
	if (hProcess) 
                printf("Prozess opend!\n");
	else
		printf("Prozess not opend!\n");
        printf("Porcess Handle: 0x%i\n", hProcess);

       ReadProcessMemory(hProcess, (LPCVOID)adresse, &puffer, sizeof(puffer), &rw);
	   std::cout<< puffer;                                                            
       Sleep(2000);
	   CloseHandle(hProcess);   
	   std::cin >> ID ;
	   return 0;
}

ok i test it, it going until he should atach the Process. i think the best is if you test it by your own. It would be verry nice if you could help me sorry for my bad english =(

[grosfilsdepute]

You need to enable the debug mode privileges if you want to open wow.exe.

Take a look at MSDN : OpenProcessToken, LookupPrivilegeValue and AdjustTokenPrivileges functions.

[grigitokarz]

here u got some frags from my waypoint bot

#include <cstdlib>
#include <iostream>
#include <Windows.h>
#include <tlhelp32.h>
#include <string.h>
#include <vcclr.h>
BOOL SetDebugPrivileges()
{
   BOOL               bRET = FALSE;
   TOKEN_PRIVILEGES   tp;
   HANDLE             hToken;

   if (LookupPrivilegeValue(NULL, SE_DEBUG_NAME, &tp.Privileges[0].Luid))
   {
      if (OpenProcessToken(GetCurrentProcess(), TOKEN_ADJUST_PRIVILEGES, &hToken))
      {
         if (hToken != INVALID_HANDLE_VALUE)
         {
            tp.Privileges[0].Attributes = SE_PRIVILEGE_ENABLED;
            tp.PrivilegeCount = 1;
            if (AdjustTokenPrivileges(hToken, FALSE, &tp, 0, 0, 0))
               bRET = TRUE;
            CloseHandle(hToken);
         }
      }
   }
   return bRET;
}
DWORD ProcId = 0; 
void GetProcId(const char* chara)
{
    PROCESSENTRY32   pe32;
    HANDLE         hSnapshot = NULL;

    pe32.dwSize = sizeof( PROCESSENTRY32 );
    hSnapshot = CreateToolhelp32Snapshot( TH32CS_SNAPPROCESS, 0 );

    if( Process32First( hSnapshot, &pe32 ) )
    {
        do{
            if( strcmp( pe32.szExeFile, chara ) == 0 )
                break;
        }while( Process32Next( hSnapshot, &pe32 ) );
    }

    if( hSnapshot != INVALID_HANDLE_VALUE )
        CloseHandle( hSnapshot );

   ProcId= pe32.th32ProcessID;
}

than

SetDebugPrivileges();
	char chara[]="Wow.exe";
	GetProcId(chara);
	process = OpenProcess(PROCESS_ALL_ACCESS, FALSE, ProcId);
	ReadProcessMemory(process,(LPVOID)aClientConnection,(LPVOID)&connection,sizeof(DWORD),0);//client connection <- simply read

simply code which should help

[Cypher]

Don't use PROCESS_ALL_ACCESS. That flag is evil.

[KOS0937]

pleeeease get used to some spacing standards... there is absolutely no structure in your source code
e.g. write

if (condition) {
  do1;
  do2;
}

or

if (condition)
{
  do1;
  do2;
}

This will help you avoid lines like "if(!hWindow);" etc. and thus avoid bugs!