Float memory reading problem

[Lynie]

Greetings,

I'm trying to create the very beginning of a bot. That is just reading the X, Y, Z coördinates of the player. This is what I have at the moment:
Player.h

#define MEM_ADDR_PLAYERBASE_PTR 0x0127F13C
#define MEM_ADDR_PLAYERBASE_PTR_OFFSET1 0x30
#define MEM_ADDR_PLAYERBASE_PTR_OFFSET2 0x28

#define MEM_ADDR_PLAYERBASE_HEALTH_OFFSET 0x0
#define MEM_ADDR_PLAYERBASE_MANA_OFFSET 0x0
#define MEM_ADDR_PLAYERBASE_X_OFFSET 0x7D0
#define MEM_ADDR_PLAYERBASE_Y_OFFSET 0x7D4
#define MEM_ADDR_PLAYERBASE_Z_OFFSET 0x7D8
#define MEM_ADDR_PLAYERBASE_ROTATION_OFFSET 0x7E2

#define MEM_ADDR_PLAYERNAME_OFFSET 0x011CB348


//0127F13C
// + 30
// + 28
//= PlayerBase

//x = PlayerBase + 7D0
//y = PlayerBase + 7D4
//z = PlayerBase + 7D8
//rot = PlayerBase + 7E2

class Player
{
	HANDLE hProcess;
	
	int mana;
	int health;

	float posX;
	float posY;
	float posZ;
	float rotation;

public:
	int getMana();
	int getHealth();

	float getX();
	float getY();
	float getZ();
	float getRotation();

	void Rotate(float degrees);
	void Move(float x, float y);
	void Update();

	unsigned int baseAddress;

	Player(HANDLE hProcess);
	~Player();
};

Player.cpp

#include "stdafx.h"

Player::Player(HANDLE hProcess)
{
	unsigned int base_ptr1, base_ptr2, base;
	this->hProcess = hProcess;
	ReadProcessMemory(hProcess, (LPCVOID)(MEM_ADDR_PLAYERBASE_PTR), (LPVOID)&base_ptr1, sizeof(unsigned int), 0);
	ReadProcessMemory(hProcess, (LPCVOID)(base_ptr1 + MEM_ADDR_PLAYERBASE_PTR_OFFSET1), (LPVOID)&base_ptr2, sizeof(unsigned int), 0);
	ReadProcessMemory(hProcess, (LPCVOID)(base_ptr2 + MEM_ADDR_PLAYERBASE_PTR_OFFSET2), (LPVOID)&(this->baseAddress), sizeof(unsigned int), 0);
	
}

Player::~Player()
{
}

int Player::getMana()
{
	return this->mana;
}

int Player::getHealth()
{
	return this->health;
}

float Player::getX()
{
	return this->posX;
}

float Player::getY()
{
	return this->posY;
}

float Player::getZ()
{
	return this->posZ;
}

float Player::getRotation()
{
	return this->rotation;
}

void Player::Rotate(float degrees)
{
}

void Player::Move(float x, float y)
{
}

void Player::Update()
{
	ReadProcessMemory(hProcess, (LPCVOID)(this->baseAddress + MEM_ADDR_PLAYERBASE_X_OFFSET), (LPVOID)&(this->posX), sizeof(float), 0);
	ReadProcessMemory(hProcess, (LPCVOID)(this->baseAddress + MEM_ADDR_PLAYERBASE_Y_OFFSET), (LPVOID)&(this->posY), sizeof(float), 0);
	ReadProcessMemory(hProcess, (LPCVOID)(this->baseAddress + MEM_ADDR_PLAYERBASE_Z_OFFSET), (LPVOID)&(this->posZ), sizeof(float), 0);
}

And the generated UI.
In the UI I allocate some memory for the class player when the form loads, then I use the Update() function and set the text of textbox1 to the X position of the player using the getX() function

				 pPlayer = new Player(hProcess);
				 pPlayer->Update();
				 this->textBox1->Text = pPlayer->getX().ToString();
				 this->textBox2->Text = pPlayer->getY().ToString();
				 this->textBox3->Text = pPlayer->getZ().ToString();

But when I try this it always says -4,316021E+08 in the textbox and I don't why.

NOTE: I'm using 3.0.9

Could anyone help me fix this?

Thanks

[SKU]

I haven't looked at the code but many (all?) of your addresses are outdated assuming 3.1.2

[Lynie]

I haven't looked at the code but many (all?) of your addresses are outdated assuming 3.1.2

Thanks for the fast reply, I'm using 3.0.9 addresses at the moment but I also still have a 3.0.9 client for private servers.

[Cypher]

Managed C++ makes baby jesus cry.

[0_00_0]

use GetLastError(). It will help us a lot more! If there is no errors then you need to check your addresses, obviously. Its been too long since I've looked at 3.0.9.

[amadmonk]

But when I try this it always says -4,316021E+08 in the textbox and I don't why.

Assuming this isn't an uninitialized value, I'd say you're reading the float just fine. You're just reading the wrong float.

[amadmonk]

Managed C++ makes baby jesus cry.

What, you don't care for code that has all of the limitations and flaws of C++ as well as all the limitations and strictures of the CLR, along with its own unique set of syntactical quirks and oddness? What's WRONG with you?

In all seriousness, I've actually used MC++ for a couple of times where I didn't really want to write a native DLL just to do a function or two. But every time, I have to go re-look up the syntax, and every time I use it, I feel a little dirty. I just can't figure out whether I feel like I'm betraying C++, or betraying .Net...

I think I'll stick with Python for a while. That way nobody's gotta respect anybody in the morning.

[Cypher]

What, you don't care for code that has all of the limitations and flaws of C++ as well as all the limitations and strictures of the CLR, along with its own unique set of syntactical quirks and oddness? What's WRONG with you?

In all seriousness, I've actually used MC++ for a couple of times where I didn't really want to write a native DLL just to do a function or two. But every time, I have to go re-look up the syntax, and every time I use it, I feel a little dirty. I just can't figure out whether I feel like I'm betraying C++, or betraying .Net...

I think I'll stick with Python for a while. That way nobody's gotta respect anybody in the morning.

Rofl. Epic win.

[Lynie]

K, I found out what I did wrong, I didn't set my debug privileges yet. All thanks for the help!