PE LUA Help

[Tiger23078001]

I'm looking for some help making some LUA functions for my warlock profile. Looking to do two things:

Have a function that maintains a list of buffs (trinkets spell IDs, profession buffs, things like that), and another on that returns how many of said buffs the player has at any given time. This would allow me to use chaos bolt/shadowburn properly without having to code each buff into the PE rotation.

Any help appreciated!

[ProbablyEngine]

Due to some annoying limitations in Lua and the design of PE (but mostly limitations in Lua), this isn't really possible.

I did create a modification to PE to try this out and it doesn't work well, memory leaks all over the place.

[pcmdxx]

snapshot your stats on pull / before and check for changes infight

[Tiger23078001]

Due to some annoying limitations in Lua and the design of PE (but mostly limitations in Lua), this isn't really possible.

I did create a modification to PE to try this out and it doesn't work well, memory leaks all over the place.

Maybe I'm wording what I need wrong because there used to be a profile I used on the PE forums (I forget the author) that had exactly what I'm looking for. It was for destruction warlock and had a function.lua file that had two things in it. one was a list of all the proc spell IDs and another function that returned a value of how many of those buffs the player had. I was able to use that in my profiles for chaos bolt/shadowburn

[InternetExplorer]

So you want to have a table with a list of buffs, then use the table to track how many of the buffs the player currently has active? Or did I misunderstand

[Tiger23078001]

Yes. Here is how I would have used it in PE. Maybe that will help with what I'm after:

{ "116858", { -- Chaos Bolt
			"haveBuff(1),
			"target.health > 20",
			"player.embers >= 20"}
		},


{ "116858", { -- Chaos Bolt
			"haveBuff(2)",
			"target.health > 20",
			"player.embers >= 10"}
		},

[Soapbox]

Function:

function UnitBuffID(unit, spell, filter)
    if not unit or unit == nil or not UnitExists(unit) then 
        return false 
    end
    if spell then 
        spell = GetSpellInfo(spell) 
    else 
        return false 
    end
    if filter then 
        return UnitBuff(unit, spell, nil, filter) 
    else 
        return UnitBuff(unit, spell) 
    end
end

ProbablyEngine.condition.register("buffs",function()
local Procs = 0
local Buff1 = UnitBuffID("player", 012345) 
local Buff2 = UnitBuffID("player", 678910) 
    if Buff1 then
        Procs = Procs + 1
        else
        Procs = Procs
    end
    if Buff2 then
        Procs = Procs + 1
        else
        Procs = Procs
    end
return Procs
end) 

Call:

{"Chaos Bolt", "player.buffs > 1" }, 

I wouldn't make a table unless you run an update to purge it. This is probably the easiest way to achieve what you're looking for. You can even go into detail and compare the duration of the buff with the cast time of chaos bolt itself.

[Tiger23078001]

Function:

function UnitBuffID(unit, spell, filter)
    if not unit or unit == nil or not UnitExists(unit) then 
        return false 
    end
    if spell then 
        spell = GetSpellInfo(spell) 
    else 
        return false 
    end
    if filter then 
        return UnitBuff(unit, spell, nil, filter) 
    else 
        return UnitBuff(unit, spell) 
    end
end

ProbablyEngine.condition.register("buffs",function()
local Procs = 0
local Buff1 = UnitBuffID("player", 012345) 
local Buff2 = UnitBuffID("player", 678910) 
    if Buff1 then
        Procs = Procs + 1
        else
        Procs = Procs
    end
    if Buff2 then
        Procs = Procs + 1
        else
        Procs = Procs
    end
return Procs
end) 

Call:

{"Chaos Bolt", "player.buffs > 1" }, 

I wouldn't make a table unless you run an update to purge it. This is probably the easiest way to achieve what you're looking for. You can even go into detail and compare the duration of the buff with the cast time of chaos bolt itself.

With this I'd have to have all list all of my spell IDs as variables in the function though?

[Soapbox]

With this I'd have to have all list all of my spell IDs as variables in the function though?

Which is easy. You just have to do it, hell I will do it for you. You can't make it check your buffs, identify which are temporary, identify which are beneficial etc without doing a little work yourself. I spelled them out so you can see which ones I accounted for.

local Jade, _, _, _, _, _, JadeEndTime = UnitBuffID("player", 104993) 
local Yulon, _, _, _, _, _, YulonEndTime = UnitBuffID("player", 128985)
local Lightweave, _, _, _, _, _, LightweaveEndTime = UnitBuffID("player", 125487) 
local PotJadeSerpent, _, _, _, _, _, PotJadeSerpentEndTime = UnitBuffID("player", 105702) 
local CosmosTrinket, _, _, _, _, _, CosmosTrinketEndTime = UnitBuffID("player", 126577) 
local FlashFrozenTrinket, _, _, _, _, _, FlashFrozenTrinketEndTime = UnitBuffID("player", 126478) 
local ShockChargerTrinket, _, _, _, _, _, ShockChargerTrinketEndTime = UnitBuffID("player", 136082) 
local WushoolayTrinket, _, _, _, _, _, WushoolayTrinketEndTime = UnitBuffID("player", 138786) 
local ChayeEssenceTrinket, _, _, _, _, _, ChayeEssenceTrinketEndTime = UnitBuffID("player", 139134) 
local HydraTrinket, _, _, _, _, _, HydraTrinketEndTime = UnitBuffID("player", 138898) 
local PurifiedImmerseusTrinket, _, _, _, _, _, PurifiedImmerseusTrinketEndTime = UnitBuffID("player", 146046) 
local KardrisTrinket, _, _, _, _, _, KardrisTrinketEndTime = UnitBuffID("player", 148906) 
local DarkSoul, _, _, _, _, _, DarkSoulEndTime = UnitBuffID("player", 113858) 
local FrenziedCrystalTrinket, _, _, _, _, _, FrenziedCrystalTrinketEndTime = UnitBuffID("player", 148897) 
local BlackBloodTrinket, _, _, _, _, _, BlackBloodTrinketEndTime = UnitBuffID("player", 146184) 
local SkullBanner, _, _, _, _, _, SkullBannerEndTime = UnitBuffID("player", 114206) 
local TierBonus, _, _, _, _, _, TierBonusEndTime = UnitBuffID("player", 145164) 
local Dominance, _, _, _, _, _, DominanceEndTime = UnitBuffID("player", 126705)

Also, you can give certain buffs that you add, more of a priority, so you aren't blowing chaos bolts on a smaller proc. Will allow you to cast a chaos bolt on either one big buff, a combination of smaller buffs etc

if Yulon then 
	Procs = Procs + 1
				else
	Procs = Procs
end
if Lightweave then
	Procs = Procs + 0.3
				else
	Procs = Procs
end

[Tiger23078001]

Ok, I see what you're doing. So when WoD comes out and I want to add new buffs I would add the following into the function (assuming PE still functions in WoD:

local WoDBuff, _, _, _, _, _, WoDBuffEndTime = UnitBuffID("player", XXXXXXX) 
if WoDBuff then 
    Procs = Procs + 1
                else
    Procs = Procs
end 

[Soapbox]

Ok, I see what you're doing. So when WoD comes out and I want to add new buffs I would add the following into the function (assuming PE still functions in WoD:

{snip}

You got it

[Tiger23078001]

Thank you very much!

Is it possible to expand that same function to prevent PE from casting CB if the buff duration will end before the cast completes?

[Soapbox]

Thank you very much!

Is it possible to expand that same function to prevent PE from casting CB if the buff duration will end before the cast completes?

just add a line under where you check for the buff, comparing the spells cast time, chaos bolt in this case, with the buff duration. and if it is less than or equal to, + some milsecs for lag then return the Proc = Proc + 1 etc

[Tiger23078001]

just add a line under where you check for the buff, comparing the spells cast time, chaos bolt in this case, with the buff duration. and if it is less than or equal to, + some milsecs for lag then return the Proc = Proc + 1 etc

Ok, how do I get the cast time for a certain spell so I can setup the variable in the function?

Once I have that is this how I would implement?

ProbablyEngine.condition.register("haveBuffs",function()
local Procs = 0
local chaosBoltCastTime = SpellCastTime(116858)
local Beserk, _, _, _, _, _, BeserkEndTime = UnitBuffID("player", 33702)

    if Beserk then
        Procs = Procs + .5
        if chaosBoltCastTime > BeserkEndTime then
            Procs = Procs - .5
        else
        Procs = Procs
    end
    return Procs
end) 

Sorry in advance.

[RedRussian]

OP, for the purpose of DoT (or heavy casts like Chaos Bolt) snapshotting you might want to know only the present and future (I prefer to call it "projected") value of your stats. I use my custom rotation engine but I think the following approach could implemented in PE as well.

1. I use some abstract score of buff's utility called "Burst rating". The score for each buff of interest is set manually.
The table of such buffs of interest is as follows. I filled it with some sample content:

RRR_DB.bursts = {
--[<buff_id>] = { rating = <buff_burst_rating> },
--ratings are purely imaginary though they can be interpreted as "main stat value"
    --general INT
    [105702] = { rating = 4000 },    --potion MoP
    [104993] = { rating = 1650 },     --jade spirit
    [125487] = { rating = 2000 },    --lightweave INT
    [96230]  = { rating = 1920 },    --synapse springs INT
    [126705] = { rating = 6750 },    --pvp proc trinket INT
    [126683] = { rating = 5000 },    --pvp use trinket INT
    
    --druid
    [102560] = { rating = 9000 },    --incarnation
    [112071] = { rating = 9000 },    --celestial alignment
    [124974] = { rating = 4000 },    --nature's vigil
}

2. Then you need to store info of all buffs you get. How you do so is entirely of your choosing, but the result you should aim for is a table contating buff_id as keys and buff_info (table) as values, which would be updated on various events concerning your buffs.

3. Given the tables of bursts of interest and your current buffs, you need a function to calculate and project your burst rating.
Mine looks as follows:

function ProjectBurstRating(horizon)
--NOTE
--for every horizon, epsilon > 0 : ProjectBurstRating(horizon) >= ProjectBurstRating(horizon + epsilon)
    horizon = horizon or 0
    local current_time = GetTime()
    local burst_rating = 1
    local first_expiry_in = math.huge
    for id, burst_info in pairs(RRR_DB.bursts) do
        local buff = RRR_PlayerInfo.player_data.buffs[id] --it's the table of stored buffs
        if buff then
            burst_rating = burst_rating + burst_info.rating * buff.num_stacks
            local buff_expiry_in = buff.expiry_time - current_time
            if buff_expiry_in <= first_expiry_in then
                first_expiry_in = buff_expiry_in
            end
            if buff.expiry_time - current_time <= horizon then
                burst_rating = burst_rating - burst_info.rating * buff.num_stacks
            end
        end
    end
    return burst_rating, first_expiry_in
end

4. Given the knowledge of your current and future "power", it's easy to decide whether it's time to refresh your DoTs or cast a long yet powerful cast.
Chaos Bolt example:

local critical_ratio = 1.5
if ( ProjectBurstRating( CB_cast_time + 0.5 ) / ProjectBurstRating(0) ) >= critical_ratio then  --our bursts are about to expire!
   CastSpellByID(CB_id)
end