[PQR] Kuukuu's Brewmaster Profile Feedback and Suggestions

[kuukuu]

Ya that's why I shouldn't code at 7am.... Found the errors, I'll release the update as soon as I'm done. Tp spam should only be casting if nothing else does though, are you putting it at the bottom of the list?

EDIT: I'm also powerleveling my monk right now so there should be less and less untested code coming out.

[lantus]

Ya that's why I shouldn't code at 7am.... Found the errors, I'll release the update as soon as I'm done. Tp spam should only be casting if nothing else does though, are you putting it at the bottom of the list?

EDIT: I'm also powerleveling my monk right now so there should be less and less untested code coming out.

Yah, I have the Tiger Palm (spam) on the bottom of the list, I think its because once it kicks in, it just keep spamming it so other abilities doesn't get a chance to be used. Maybe you can set it to spam only to generate three stacks of Power Guard?

[kuukuu]

That's what Tiger Palm does, but sometimes you hit a point where you can't cast anything else so I was having tiger palm spam fill that gap... but like I said, just remove it if it's spamming too much.

[lantus]

That's what Tiger Palm does, but sometimes you hit a point where you can't cast anything else so I was having tiger palm spam fill that gap... but like I said, just remove it if it's spamming too much.

Yah, that's what I am doing lol. I'm manually doing Jab, Tiger Palm, and Elusive Brew. Everything else works fine

[kuukuu]

1.3d released now. Fixed the dumb typos I created when I should have been sleeping. Haha.

[domestecus]

1.3d seems to be causing lag when enabled.

[kuukuu]

1.3d seems to be causing lag when enabled.

Which ability? I've been running it for an hourish now with no lag, but I'm only 36 so maybe level related?

[shuklu]

Which ability? I've been running it for an hourish now with no lag, but I'm only 36 so maybe level related?

I've been running several heroics with no lagg and excellent performance. Love it!

[lantus]

Great job kuukuu, most of the abilities are working wonderfully now. I personally am having no lag issues, however, I can see someone with a slower computer who might; reason is because two of the abilities are still spitting out lua errors resulting in some framerate drops

Tiger Palm (spam) is getting this:

Message: [string "if PQR_Addon_Loaded == nil then..."]:760: attempt to call field '?' (a nil value)
Time: 10/09/12 19:56:28
Count: 121
Stack: [C]: in function `?'
[string "if PQR_Addon_Loaded == nil then..."]:760: in function `PQR_NextAbility'
[string "if PQR_Addon_Loaded == nil then..."]:533: in function `PQR_ExecuteRotation'
[string "if PQR_Addon_Loaded == nil then..."]:289: in function <[string "if PQR_Addon_Loaded == nil then..."]:214>


and Elusive Brew is encountering this:

Message: Usage: CastSpellByName(name[, target])
Time: 10/09/12 19:59:35
Count: 165
Stack: [C]: ?
[C]: ?
[C]: in function `CastSpellByName'
[string "local name,_,_,count = UnitBuffID("player",..."]:9: in function `?'
[string "if PQR_Addon_Loaded == nil then..."]:760: in function `PQR_NextAbility'
[string "if PQR_Addon_Loaded == nil then..."]:533: in function `PQR_ExecuteRotation'
[string "if PQR_Addon_Loaded == nil then..."]:289: in function <[string "if PQR_Addon_Loaded == nil then..."]:214>

[kuukuu]

Great job kuukuu, most of the abilities are working wonderfully now. I personally am having no lag issues, however, I can see someone with a slower computer who might; reason is because two of the abilities are still spitting out lua errors resulting in some framerate drops

Tiger Palm (spam) is getting this:

Message: [string "if PQR_Addon_Loaded == nil then..."]:760: attempt to call field '?' (a nil value)
Time: 10/09/12 19:56:28
Count: 121
Stack: [C]: in function `?'
[string "if PQR_Addon_Loaded == nil then..."]:760: in function `PQR_NextAbility'
[string "if PQR_Addon_Loaded == nil then..."]:533: in function `PQR_ExecuteRotation'
[string "if PQR_Addon_Loaded == nil then..."]:289: in function <[string "if PQR_Addon_Loaded == nil then..."]:214>


and Elusive Brew is encountering this:

Message: Usage: CastSpellByName(name[, target])
Time: 10/09/12 19:59:35
Count: 165
Stack: [C]: ?
[C]: ?
[C]: in function `CastSpellByName'
[string "local name,_,_,count = UnitBuffID("player",..."]:9: in function `?'
[string "if PQR_Addon_Loaded == nil then..."]:760: in function `PQR_NextAbility'
[string "if PQR_Addon_Loaded == nil then..."]:533: in function `PQR_ExecuteRotation'
[string "if PQR_Addon_Loaded == nil then..."]:289: in function <[string "if PQR_Addon_Loaded == nil then..."]:214>

Good to hear. Elusive Brew is missing the target for cast, should be fixed now. Tiger palm (spam) I just incorporated right into normal tiger palm since it's giving so many issues. Since that should all be stable now, I bumped release to 1.4 and it's available now for download. I'm back in school tomorrow so any updates will be a bit delayed so make sure to back up the old code just in case it decides to go all weird.

[lantus]

Thanks for all your hard work!

[jamieb19]

nice profile so far kuu, any chance you can make it so it dosnt always try to attack things when out of combat?

[lantus]

nice profile so far kuu, any chance you can make it so it dosnt always try to attack things when out of combat?

In the rotation editor check the box "Require Combat to Execute Rotation".

[shuklu]

I had to go back to your first release today, as the last update really messed things up. Fortifying brew is cast on CD, it seems, no matter situation (Even made me dismount and I fell to my death). And switching between AOE profile and normal profile a few times then it stop for a 10 - 20 second period of time.

Don't know how to get you any debug notes, sorry - But teach me how, and I will post it here.

[domestecus]

Which ability? I've been running it for an hourish now with no lag, but I'm only 36 so maybe level related?

It was not one specific ability, when i pressed my hot key to enable it, the framerate just dropped, if I turned it back off the frames came back. I will test again tonight, I was raiding so did not have time to look into it.