print function for lua testing.

[boxo]

So, I've been trying to create a few custom functions for healing, but they don't seem to work. I've asked some people for advice, and they've said use print functions.

Excellent advice... but i'm not sure how.

So, is there a way that I can create a print function that prints when a value for the function is registered, and then when the value changes? something like (and i'm totally making this up)

function(something)
if function(riptidetarget) = function(something) return false
if function(riptidetarget) != function(something) then function(something) = function(riptidetarget)
print function(something)

or... something?

[MrTheSoulz]

So, I've been trying to create a few custom functions for healing, but they don't seem to work. I've asked some people for advice, and they've said use print functions.

Excellent advice... but i'm not sure how.

So, is there a way that I can create a print function that prints when a value for the function is registered, and then when the value changes? something like (and i'm totally making this up)

function(something)
if function(riptidetarget) = function(something) return false
if function(riptidetarget) != function(something) then function(something) = function(riptidetarget)
print function(something)

or... something?

What exacly are you trying to do?

[boxo]

I am trying to write a function to cast riptide on the lowest hp target without riptide, and then create some chain heal logic. Stealing from current PE code, I came up with this:

local max = math.max
local GetSpellInfo = GetSpellInfo
local GetNumGroupMembers = GetNumGroupMembers
local IsInRaid = IsInRaid
local UnitCanAssist = UnitCanAssist
local UnitDebuff = UnitDebuff
local UnitExists = UnitExists
local UnitGetIncomingHeals = UnitGetIncomingHeals
local UnitGetTotalHealAbsorbs = UnitGetTotalHealAbsorbs
local UnitGroupRolesAssigned = UnitGroupRolesAssigned
local UnitHealth = UnitHealth
local UnitHealthMax = UnitHealthMax
local UnitInParty = UnitInParty
local UnitInRange = UnitInRange
local UnitIsConnected = UnitIsConnected
local UnitIsDeadOrGhost = UnitIsDeadOrGhost
local UnitIsFriend = UnitIsFriend
local UnitUsingVehicle = UnitUsingVehicle
local UnitBuff = UnitBuff

-- riptide logic

-- check whether units are able to be healed, and whether they have the riptide buff

local function missingRiptide(unit)
  if UnitExists(unit)
     and UnitCanAssist('player', unit)
     and UnitIsFriend('player', unit)
     and UnitIsConnected(unit)
     and not UnitIsDeadOrGhost(unit)
     and not UnitUsingVehicle(unit) then

     if UnitInParty(unit) and not UnitInRange(unit) then
       return false
     end
	 
	if UnitBuff("unit", GetSpellInfo(61295)) then
		return false
	end

     return true
  end

  return false
end

-- check for the lowest unit in party that doesn't have the riptide buff
needRiptide = function ()
  local lowestUnit = 'player'
  if missingRiptide('focus') then lowestUnit = 'focus' end

  local lowest = 100

  for _, unit in pairs(ProbablyEngine.raid.roster) do
    if missingRiptide(unit.unit) and unit.health and unit.health < lowest then
      lowest = unit.health
      lowestUnit = unit.unit
    end
  end

  return lowestUnit
end

-- allows PE to call the lowest unit in party without riptide as a target
if target == "shouldRiptide" then
	target = needRiptide()
	if target == false then return end
elseif target == "tank" then
	if UnitExists("focus") then
		target = "focus"
	else
		target = ProbablyEngine.raid.tank()
    end
end

-- chain heal

local function hasRiptide(unit)
  if UnitExists(unit)
     and UnitCanAssist('player', unit)
     and UnitIsFriend('player', unit)
     and UnitIsConnected(unit)
     and not UnitIsDeadOrGhost(unit)
     and not UnitUsingVehicle(unit) then

     if UnitInParty(unit) and not UnitInRange(unit) then
       return false
     end
	 
	if not UnitBuff(unit, GetSpellInfo(61295)) then
		return false
	end

     return true
  end

  return false
end

lowestRiptide = function ()
  local lowestUnit = 'player'
  if hasRiptide('focus') then lowestUnit = 'focus' end

  local lowest = 100

  for _, unit in pairs(ProbablyEngine.raid.roster) do
    if hasRiptide(unit.unit) and unit.health and unit.health < lowest then
	  lowest = unit.health
      lowestUnit = unit.unit
    end
  end

  return lowestUnit
end



if target == "shouldChain" then
	if lowestRiptide().heath - needsRiptide().health > 10 then
		target = needsRiptide() else
		target = lowestRiptide()
	end
		if target == false then return end
		elseif target == "tank" then
			if UnitExists("focus") then
				target = "focus"
					else
						target = ProbablyEngine.raid.tank()
      end
end

ProbablyEngine.library.register('Boxo_Healing', Boxo_Healing)

but that doesn't do anything. it doesn't throw errors, but if you put something like:

	{ "Riptide", {
		"@Boxo_Healing.shouldRiptide.health < 95",
		"focus.buff(Riptide).duration > 5",
	}, "@Boxo_Healing.shouldRiptide" },

in a rotation it doesn't cast.

So, I thought I might be able to identify whether or not, at different stages, the functions were registering targets, to find where the issue is

Most of the above code is taken from how PE defines "lowest".

[MrTheSoulz]

I could help you more if you explained how exactly you want RipTide to work, but will leave you this:

ProbablyEngine.library.register('Boxo_Healing', {

      -- Loops thru party/Raid members and casts RipTide on whoever dosent have its buff and bellow 95% health
      RipTide = function()
	    local prefix = (IsInRaid() and 'raid') or 'party'
	        for i = 1, GetNumGroupMembers() do
	            local target = prefix..i.."target"
	            	if not UnitIsDeadOrGhost(unit) then
		            	if not UnitBuff(target, GetSpellInfo(61295)) then
		            		if not unitHealth(target) < 95 then
		            			ProbablyEngine.dsl.parsedTarget = target
		            			return true
		            		end
		            	end
		            end
		    end
	end,

})

On top of the CR:

	{ "Riptide", "@Boxo_Healing.RipTide" },

Should be pretty easy for you to expand on this now.

[boxo]

riptide can't really blanket like pw:s, so casts have to be a little more direct.

I wanted to make it cast on the target with the lowest health that doesn't have riptide. so the idea was to make a second raid list, one that was made up of people without the riptide buff, by copying the PE function canHeal, but adding a check for the riptide buff:

local function missingRiptide(unit)
  if UnitExists(unit)
     and UnitCanAssist('player', unit)
     and UnitIsFriend('player', unit)
     and UnitIsConnected(unit)
     and not UnitIsDeadOrGhost(unit)
     and not UnitUsingVehicle(unit) then

     if UnitInParty(unit) and not UnitInRange(unit) then
       return false
     end
	 
	if UnitBuff("unit", GetSpellInfo(61295)) then
		return false
	end

     return true
  end

  return false
end

then, the theory was to isolate the lowest person on that list the same way as ProbablyEngine.raid.lowestHP, which targets the lowest person on the canHeal list:

needRiptide = function ()
  local lowestUnit = 'player'
  if missingRiptide('focus') then lowestUnit = 'focus' end

  local lowest = 100

  for _, unit in pairs(ProbablyEngine.raid.roster) do
    if missingRiptide(unit.unit) and unit.health and unit.health < lowest then
      lowest = unit.health
      lowestUnit = unit.unit
    end
  end

  return lowestUnit
end

Then, PE seems to create a "target" and creates "lowest" for use in rotations, which is what I copied here:

if target == "shouldRiptide" then
	target = needRiptide()
	if target == false then return end
elseif target == "tank" then
	if UnitExists("focus") then
		target = "focus"
	else
		target = ProbablyEngine.raid.tank()
    end
end

that was the thought process i had, at least. I don't know if it's something I can put together, but I suppose there could be a number of functions at different health thresholds, to kind of mimic that process.

[Mackdaddy2887]

Isnt basically the code I gave work the same?

in a CR the bot starts at the top and goes down until it hits a spell returns true, casts that spell, and starts back over from the top.

With that code, and using logic, you will see that the CR will always. ALWAYS chose to Riptide whoever the lowest is first, so if someone else takes damage, or if the previous 'lowest' gets healed, whoever meets that condition of 'lowest' will recieve riptide.

Now secondly, IF that target is already riptide on it, itll chose the tank/focus. (using the code example i supplied, you can take this out if you want).
Now, it casts riptide and starts back at the top. If there is a new 'lowest' it will choose them, if not, back down the list,

now the first list is an array of raid members 1-20, all below 30% hp. So if anyone is below 30% hp, it will riptide that target. then start back at the top, which will then give yet another opportunity to riptide the 'lowest', and if not, continue to riptide anyone below 30%.

Now you set similiar parameters for 60%, then 90%, as a fallthrough mechanic, setting prioirty to the 'lowest' first, then anyone under 30%, then 60%, then 90%.
If that is not a strong enough decision matrix, use 10, 20 ,30, 40, 50, 60, 70, 80, 90. Doesnt matter, just copy/paste. Its all logic.

Now for chain heal, do the same thing I did for swiftmend, and something very similiar to riptide:

{"chain heal", {"lowest.buff(Riptide)", "lowest.range <= 40", "lowest.area(15).friends > 5"}, "lowest"},
{"chain heal", {"tank.buff(Riptide)", "tank.range <= 40", "tank.area(15).friends > 5"}, "tank"},
{"chain heal", {"raid1.buff(Riptide)", "raid1.range <= 40", "raid1.area(15).friends > 5"}, "raid1"},
etc etc.

set w/e health threshold, and the correct code for unit.area (i cant remember off the top of my head)

Chain heal will ALWAYS chose lowest first if the have riptide, which riptide will almost always be on the lowest anyways. OR if the lowest doesnt meet w/e threshold, then possibly one of the other raid members with riptide will (one of them will, logically speaking)

[MrTheSoulz]

riptide can't really blanket like pw:s, so casts have to be a little more direct.

I wanted to make it cast on the target with the lowest health that doesn't have riptide. so the idea was to make a second raid list, one that was made up of people without the riptide buff, by copying the PE function canHeal, but adding a check for the riptide buff:

local function missingRiptide(unit)
  if UnitExists(unit)
     and UnitCanAssist('player', unit)
     and UnitIsFriend('player', unit)
     and UnitIsConnected(unit)
     and not UnitIsDeadOrGhost(unit)
     and not UnitUsingVehicle(unit) then

     if UnitInParty(unit) and not UnitInRange(unit) then
       return false
     end
	 
	if UnitBuff("unit", GetSpellInfo(61295)) then
		return false
	end

     return true
  end

  return false
end

then, the theory was to isolate the lowest person on that list the same way as ProbablyEngine.raid.lowestHP, which targets the lowest person on the canHeal list:

needRiptide = function ()
  local lowestUnit = 'player'
  if missingRiptide('focus') then lowestUnit = 'focus' end

  local lowest = 100

  for _, unit in pairs(ProbablyEngine.raid.roster) do
    if missingRiptide(unit.unit) and unit.health and unit.health < lowest then
      lowest = unit.health
      lowestUnit = unit.unit
    end
  end

  return lowestUnit
end

Then, PE seems to create a "target" and creates "lowest" for use in rotations, which is what I copied here:

if target == "shouldRiptide" then
	target = needRiptide()
	if target == false then return end
elseif target == "tank" then
	if UnitExists("focus") then
		target = "focus"
	else
		target = ProbablyEngine.raid.tank()
    end
end

that was the thought process i had, at least. I don't know if it's something I can put together, but I suppose there could be a number of functions at different health thresholds, to kind of mimic that process.

I guess you could loop thru the party/raid and add every unit that meets the conditions to a table then sort the table by missing health, if you look at my unit cache i already have what you need but im sorting it by distance.

[boxo]

Isnt basically the code I gave work the same?

Not... really? I mean, you could, theoretically, copy and paste an insane amount steps for every health level, but there should be a much more logical and less verbose way to do the same thing, which can then be used for a number of other applications. Create a table of players that fit a certain parameter, sort them, and then do something on the highest priority.

The chain heal priority would require even more steps. Check for not riptide, and check for riptide at different health levels. I appreciate there are other workarounds, but i can't help but think that there is an ideal solution out there somewhere.

[ImogenOC]

Not... really? I mean, you could, theoretically, copy and paste an insane amount steps for every health level, but there should be a much more logical and less verbose way to do the same thing, which can then be used for a number of other applications. Create a table of players that fit a certain parameter, sort them, and then do something on the highest priority.

The chain heal priority would require even more steps. Check for not riptide, and check for riptide at different health levels. I appreciate there are other workarounds, but i can't help but think that there is an ideal solution out there somewhere.

You've been around a long time; you know PE is very copypasta :3