[Lua] Father Christmas

[Ground Zero]

Santa NPC.

Really simple, change the configs to reward the Item ID of your choice to your players on Christmas day

--[ Made By Ground Zero of MMOwned ]--

-- Start Config

local enable = 1 -- Turn to 0 to Disable
local x1 = 0000 -- Change to the Item ID of Random Reward 1
local x2 = 0000 -- Change to the Item ID of Random Reward 2
local x3 = 0000 -- Change to the Item ID of Random Reward 3
local x4 = 0000 -- Change to the Item ID of Random Reward 4
local x5 = 0000 -- Change to the Item ID of Random Reward 5
local x6 = 0000 -- Change to the Item ID of Random Reward 6
local npcid = 80000

-- End Config

--- Do not Edit beyond this point. --

function Santagossip(pUnit, event, plr)
    pUnit:GossipCreateMenu(3429, plr, 0)
    pUnit:GossipMenuAddItem(7, "Merry Christmas Santa!", 300, 0)
    pUnit:GossipMenuAddItem(1, "Can I have my present please Santa?", 301, 0)
    pUnit:GossipMenuAddItem(7, "Goodbye", 302, 0)
    pUnit:GossipSendMenu(plr)
end

function Santa_onchat(pUnit, event, plr, id, intid, code)

    if (intid == 300) then
    pUnit:SendChatMessage(12, 0, "Merry Christmas to you too and have a Happy New Year!")
    end
    
    if (intid == 301) then
        if (enable == 1) then
            local choice = math.random(1.6)
            pUnit:SendBroadcastMessage("You have recieved a Christmas Present!")
            if choice == 1 then
                plr:AddItem(x1, 1)
                elseif
                choice == 2 then
                plr:AddItem(x2, 1)
                elseif
                choice == 3 then
                plr:AddItem(x3, 1)
                elseif
                choice == 4 then
                plr:AddItem(x3, 1)
                elseif
                choice == 5 then
                plr:AddItem(x5, 1)
                elseif
                choice == 6 then
                plr:AddItem(x6, 1)
            end
            else
            pUnit:SendBroadcastMessage("This feature is currently disabled!")
        end
    end
    
    if (intid == 302) then
    plr:GossipComplete()
    end
end
    
RegisterUnitGossipEvent(npcid, 1, "Santagossip")
RegisterUnitGossipEvent(npcid, 2, "Santa_onchat")

Lua pastebin - collaborative debugging tool

Enjoy.

[stoneharry]

You should add a cooldown to the script so that players can not spam the npc till they get all the rewards.

[Reflection]

ho ho ho ho

sorry, just had to!

[Confucius]

GJ what are the diff presents?

[Ground Zero]

What ever you want them to be Confucius.

Oh lawd Harry, I thought I did, meh did this script as 1am so was tired.

[RyeRye]

I actually did a Santa Boss fight, but I never felt like releasing it. But nice job.

[Dynashock]

Did you test the script, considering you have:

local choice = math.random(1.6)

Because of the dot the math.random() function will always return 1, thus ruining the whole point of randomisation. Obviously it's a small typo, but I thought testing a script before releasing it is common sense.

Not to mention without a cooldown some kind its randomisation is pointless anyway, like Stoneharry pointed out. Get those things fixed and clean up some code (your elseif's look messy, get them on the same line as that which it's compared with and use a tab for the next line; now it's not a big issue but it's a good habit for bigger scripts)

If you're interested it's possible to write it more dynamically and much shorter through a table, something like

player:AddItem(PresentTable[math.random(1, #PresentTable)], 1)

Much shorter and if someone wants to add an item it just needs to be added to the table, thus allowing for easier customisation without having to add a bunch of code.

Nonetheless I don't think it's a bad script per say, just lacking a few pointers. Improve above mentioned points and it's worth a few rep.

[adriann54]

wonderful!