[Request] Area Based PvP Tokens

[LTGH]

Hi im wondering if there is a LUA script that makes so if i kill someone in a special Area ( In this case, Azshara Crater ( Entry ID 37 )) you get an Item.
The character you kill must be from another faction, Same or higher level.
So, im searching for an script that gives you one PvP Token if you kill someone in Azshara crater with same or higher level and is from an different faction.

I would also want it to check if you have a quest. Lets say i have a quest calld ( Horde ), when i kill someone it checks if i have a quest calld ( Horde ) and if i have it i get the token and if i dont, i dont get a token. Hope you understand what im trying to say.

I hope someone can help me out cus this is needed for what im working on.
Thnx in future.

[TheSpidey]

I don't think you can do it with Lua, unless Lua++ added hook support to Lua.
C++ is the way

Hang on, i'll hook you up with something

Edit: Here we go

#include "StdAfx.h"
#include "Setup.h"

//This function is taken from Spectre's PvP Script, which can be seen at the AspireScripts SVN
// svn://svn.aspiredev.org/AspireDev
//<3
void AddItem(Player* Plr, const uint32 &ItemID, const uint32 &Amt, const bool &Stack)
{
	Item *ItemToAdd;
	SlotResult Slot;
	
	if(Plr == NULL)
		return;
	if(Stack)
	{
		ItemToAdd = Plr->GetItemInterface()->FindItemLessMax(ItemID, Amt, false);
		if(ItemToAdd != NULL)
		{
			ItemToAdd->ModUnsigned32Value(ITEM_FIELD_STACK_COUNT, Amt);
			ItemToAdd->m_isDirty = true;
			Plr->BroadcastMessage("%s%s x%u Awarded", MSG_COLOR_GOLD, ItemToAdd->GetProto()->Name1, Amt);
			return;
		}
			
	}
	for(uint32 i = 1;i <= Amt;i++)
	{
		ItemToAdd = objmgr.CreateItem(ItemID, Plr);
		
		if(ItemToAdd == NULL)
			return; // failed creation, no memory to allocate, or invalid item id

		Slot = Plr->GetItemInterface()->FindFreeInventorySlot(ItemToAdd->GetProto());

		if(Slot.Result)
		{
			Plr->GetItemInterface()->SafeAddItem(ItemID, Slot.ContainerSlot, Slot.Slot);
			Plr->BroadcastMessage("%s%s x1 Awarded", MSG_COLOR_GOLD, ItemToAdd->GetProto()->Name1);
		}
		else
			Plr->BroadcastMessage("No free inventory slots could be located, aborting");
	}

}

void OnKill(Player* pPlayer, Player* pVictim)
{
	if(pPlayer->GetMapId() != 37 || pVictim->GetMapId() != 37)
		return; //Both players need to be at map 37
	
	if(pPlayer->GetLowGUID() == pVictim->GetLowGUID())
		return; //No award for suicide
	
	if(pVictim->getLevel() < pPlayer->getLevel())
		return; //Only kill your own level and above
	
	if(pPlayer->GetTeam() == pVictim->GetTeam())
		return; //Only kill from the other faction
	
	//Now we check if pPlayer has the quest in his log
	for(int i = 0; i < 25; i++)
	{
		if(pPlayer->m_questlog[i]->GetQuest()->id == 12345)
		{
			//Found the quest, let's add the item
			AddItem(pPlayer, 12345, 1, true);
			//The function's parameters are, by order:
			//Player pointer, Item ID, Amount to give, Do we stack the item
			return;
		}
	}
}

void SetupPVPScript(ScriptMgr* mgr)
{
	mgr->register_hook(SERVER_HOOK_EVENT_ON_PLAYER_KILL, (void*)&OnKill);
}

[LTGH]

Omfg. This is so epix, i love you
+rep

Edit:
I've tryed it and it doesnt work, im 100% sure im done something wrong so could you please check what i've done wrong?
( I removed the Quest Part Becouse the quest doesnt exist yet )

#include "StdAfx.h"
#include "Setup.h"

//This function is taken from Spectre's PvP Script, which can be seen at the AspireScripts SVN
// svn://svn.aspiredev.org/AspireDev
//<3
void AddItem(Player* Plr, const uint32 &ItemID, const uint32 &Amt, const bool &Stack)
{
	Item *ItemToAdd;
	SlotResult Slot;
	
	if(Plr == NULL)
		return;
	if(Stack)
	{
		ItemToAdd = Plr->GetItemInterface()->FindItemLessMax(999000, 1, false);
		if(ItemToAdd != NULL)
		{
			ItemToAdd->ModUnsigned32Value(ITEM_FIELD_STACK_COUNT, Amt);
			ItemToAdd->m_isDirty = true;
			Plr->BroadcastMessage("%s%s x%u Awarded", MSG_COLOR_GOLD, ItemToAdd->GetProto()->Name1, Amt);
			return;
		}
			
	}
	for(uint32 i = 1;i <= Amt;i++)
	{
		ItemToAdd = objmgr.CreateItem(999000, Plr);
		
		if(ItemToAdd == NULL)
			return; // failed creation, no memory to allocate, or invalid item id

		Slot = Plr->GetItemInterface()->FindFreeInventorySlot(ItemToAdd->GetProto());

		if(Slot.Result)
		{
			Plr->GetItemInterface()->SafeAddItem(ItemID, Slot.ContainerSlot, Slot.Slot);
			Plr->BroadcastMessage("%s%s x1 Awarded", MSG_COLOR_GOLD, ItemToAdd->GetProto()->Name1);
		}
		else
			Plr->BroadcastMessage("No free inventory slots could be located, aborting");
	}

}

void OnKill(Player* pPlayer, Player* pVictim)
{
	if(pPlayer->GetMapId() != 37 || pVictim->GetMapId() != 37)
		return; //Both players need to be at map 37
	
	if(pPlayer->GetLowGUID() == pVictim->GetLowGUID())
		return; //No award for suicide
	
	if(pVictim->getLevel() < pPlayer->getLevel())
		return; //Only kill your own level and above
	
	if(pPlayer->GetTeam() == pVictim->GetTeam())
		return; //Only kill from the other faction
	
	
}

void SetupPVPScript(ScriptMgr* mgr)
{
	mgr->register_hook(SERVER_HOOK_EVENT_ON_PLAYER_KILL, (void*)&OnKill);
}

BTW: i only have to save it as an .LUA file and save it in scripts, right? First time i used a script so im not sure how to do.

[TheSpidey]

First of all, this is C++ and not Lua. You need to compile it and place the dll in the scripts_bin folder. There are plenty of guides explaining how to do so.

Second, when you removed the quest part you also removed the line that actually gave the attacker the token, AddItem

[LTGH]

Ohh.. Okey thnx for the information. I was really confused cus i never used something like this. Im only working with the SQL Database and such.
Anyway, the quest is added now so i guess i just have to compile it.
Another guide, another problem.
Thnx for the help ^^

Edit: Readed Sectorsevens guide and i didnt understand a single part of it..
I guess its cus im tired... 0:30AM... Time to sleep and try to figure it out tomorrow...

[Fan Boi]

You've gotta know how to compile your core before scripts.

[LTGH]

okey...?
I have never ever used a script... so i think this will be hard...

Edit: I got "Microsoft Visual C++ 2008 Express Edition" 30 days some months ago so i have no idea what to do now :'(
Is it possible to compile without MV C++ 2008, in an easy way?.. cus i dont wanna spend to much time of my project in this.

edit 2: this maybe is a stupid question, but i wonder if anyone could fix so it check if you killed a specefic race, like, you have to kill a tauren to get the token.
Thnx in future.

[TheSpidey]

if(pVictim->getRace() != RACE_TAUREN)
return;

[LTGH]

Thnx ^_^
Now i just have to figure out if its possible to compile without Visual C++...
Cus i do not want download a cracked version of it...
Stupid 30 days try t_t

[Power of Illuminati]

Microsoft is offering it for free, search for the free version.

[LTGH]

Ohh, really
Thnx. ^^ +rep if i find it.

[arley]

u can find it here Visual Studio 2008 Express Editions

[LTGH]

it was there i downloaded it and after 30 days, i have to pay. :S

[Fan Boi]

No, you just register and its still free.

[TheSpidey]

No you don't. You need to register, which is totally free.