[Solved]'Cannot implicitly convert type 'string' to 'bool' ?

[-Ryuk-]

Hello, well I have a problem in C# I don't want to have to make a new function for diffrent colours, so I thought the below would work:

To call it:

msg("0", "hi");

The function:

        public void msg(string msgtype, string Message)
        {

            if (msgtype = "o")//0=Red|1=Green|2=Black
            {
                String res = Message;
                int selectionStart = richTextBox1.TextLength;
                richTextBox1.AppendText(res + Environment.NewLine);
                // OR rtbTestResult.Text += res + Environment.NewLine;
                richTextBox1.SelectionStart = selectionStart;
                richTextBox1.SelectionLength = res.Length;
                richTextBox1.SelectionColor = Color.Red;
            }
        }

I get the error Error 'Cannot implicitly convert type 'string' to 'bool'

Any ideas?

[warsheep]

Doesn't it say at which line the error appears?

edit:

nvm. Listen to Reid, he actually knows how to read through code. >_>
Annoyed I didn't see it myself though, rather obvious.

[ReidE96]

if (msgtype == "o")//0=Red|1=Green|2=Black

You need two == to compare, that way it returns True or False.

[-Ryuk-]

if (msgtype == "o")//0=Red|1=Green|2=Black

You need two == to compare, that way it returns True or False.

Thanks I also noticed that "o" should be "0".

+Rep

[ReidE96]

Thanks I also noticed that "o" should be "0".

+Rep

Well, there's that too, but wasn't so much the issue But there's some optimisation you could do to your code: Use switch (making expandability easier) and set the corresponding colour to a variable. Then just do all your settings at the end, rather than repeating code (and use the new variable).

Anyway, glad I could help out