patch 1.08,all offset changed

[boredevil]

at 0x108 is a int16 maxIndex. it´s -1 if the container is empty.
at 0x10C is a int32 numEntrys

so if there are 3 entrys, maxIndex is 2.

[KillerJohn]

at 0x108 is a int16 maxIndex. it´s -1 if the container is empty.
at 0x10C is a int32 numEntrys

so if there are 3 entrys, maxIndex is 2.

are you sure that maxIndex is int16?

[enigma32]

It is indeed Int16, explains a comment I found in my code (ignore it being named count)
// NOTE: Count should be short?? Invalid count gives short.MaxValue (0x0000FFFF)

[KillerJohn]

at 0x108 is a int16 maxIndex. it´s -1 if the container is empty.
at 0x10C is a int32 numEntrys

so if there are 3 entrys, maxIndex is 2.

are you sure that maxIndex is int16?

for me:

int wtfIsThis1 = MR.ReadInt(addr_actors_container + 0x100 ); // =1024
int wtfIsThis2 = MR.ReadInt(addr_actors_container + 0x104 ); // =1068
int maxIndex = MR.ReadInt(addr_actors_container + 0x108 ); // =153
int wtfIsThis3 = MR.ReadInt(addr_actors_container + 0x10C ); // =136

and it seems the proper way to handle the for loop is:

for (int i = 0; i <= maxIndex; i++)

[enigma32]

If it goes to -1 you suddenly loop 65536 times! So make sure you handle it as Int16

[KillerJohn]

If it goes to -1 you suddenly loop 65536 times! So make sure you handle it as Int16

there is a range check around it ("if maxIndex > 0", you know)
so, how can be that 0x10C give me a lot smaller number instead of maxIndex-1 ?

[enigma32]

there is a range check around it ("if maxIndex > 0", you know)
so, how can be that 0x10C give me a lot smaller number instead of maxIndex-1 ?

If you treat maxIndex as Int32 (when it is Int16) then you'll always get positive values as 0x0000FFFF is nowhere near negative.
I'm also enumerating using maxIndex, since I didn't understand why 0x10C wasn't maxIndex-1.

public IEnumerable<Actor> EnumerateActors()
{
    var container = ObjectManager.Storage.Actors;
    int sizeOf = container.SizeOf;
    int current = Memory.Read<int>(container.List);
    for (int i = 0; i <= container.MaxIndex; i++)
    {
        yield return new Actor(Memory, current);
        current += sizeOf;
    }
}

Your wtfIsThis1 is the container limit and wtfIsThis2 is the item size.

[boredevil]

oh yeah you are right john. numEntrys can be smaller. my guess is, that 0x10C is the count of entrys with valid guid.

[Nesox]

One is the highest index the other one is the count, not every actor is valid tho.
Take a look at any of the funcs that iterate acd's or RActors.

[Dolphe]

Do you have the new offset for 1.0.8a ?