Problem with my C++ script

[XxCyanidexX]

Hi, I wrote a GM event system in C++ today when I found out that the reason all of the others werent working was because it had to be changed to a bool. Well, I am having two major problems with it in-game:

1. When I join the event, instead of teleporting me to the set coordinates, it teleports me really high up in the sky and I fall to death.

2. My whole block of code starting from if(Message == end && pPlayer->GetSession()->CanUseCommand('a')) does not work in-game but I am getting no errors compiling.

If someone can tell me what is wrong with this, I would give you +Rep and I will release it to mmowned.

//EventSystem coded by Cyanide
//Copyright (c) Cyanide 2009

   #include "StdAfx.h"
   #include "Setup.h"
   #include <string>
   #include <iostream>

	using namespace std;
	static string infoHelp, join, start, end;
	float sx,sy,sz;
	uint32 smapid;
	bool evon;

bool EventSystem(Player * pPlayer, uint32 Type, uint32 Lang, const char * Message, const char * Misc)
{
	join = "#join";
	start = "#eventstart";
	end = "#eventend";

	if(Message == join)
	{
		if(evon)
		{
			if(pPlayer->CombatStatus.IsInCombat())
			{
				pPlayer->BroadcastMessage("You cannot teleport in combat.");
				return true;
			}
			else
			{
				pPlayer->EventTeleport(smapid, sx, sy, sz);
				return true;
			}
			return false;
		}
		else
		{
			return true;
		}
		return false;
	}
	if(Message == start && pPlayer->GetSession()->CanUseCommand('a'))
	{
		if(evon)
		{
			pPlayer->BroadcastMessage("There is already an event summoning wait for it to finish.");
			return true;
		}
		else
		{
			evon = true;
			char Msg[255];
			sprintf(Msg, "|cff0066cc[Event System]|r |cff00ff00%s has started an event! Type #join to join!|r", pPlayer->GetName());
			sWorld.SendWorldText(Msg);
			return true;
			sx = pPlayer->GetPositionX();
			sy = pPlayer->GetPositionY();
			sz = pPlayer->GetPositionZ();
			smapid = pPlayer->GetMapId();
			return true;
		}
		return false;
	}
	else
	{
		return true;
	}
	if(Message == end && pPlayer->GetSession()->CanUseCommand('a'))
	{
		if(evon)
		{
			evon = false;
			char Msg[255];
			sprintf(Msg, "|cff0066cc[Event System]|r |cff00ff00%s has ended summons to the event.", pPlayer->GetName());
			sWorld.SendWorldText(Msg);
			return true;
		}
		else
		{
			pPlayer->BroadcastMessage("There is no event summoning going on right now.");
			return true;
		}
		return false;
	}
	else
	{
		return true;
	}
	return false;
}

void SetupEventCmd(ScriptMgr * mgr)
{
 evon = false;
 mgr->register_hook(SERVER_HOOK_EVENT_ON_CHAT, (bool *) EventSystem);
}

Well there ya go, hope you can help me

Thanks

[Herleybob]

What core? Arcemu im guessing?

[XxCyanidexX]

Yeah, rev 2468 I believe.

[Herleybob]

For the teleport, you should probably use SafeTeleport, and maby try making them a float if needed.

[XxCyanidexX]

float sx,sy,sz;

And doesn't safe teleport have different arguments?

[Herleybob]

ah, yea SafeTeleport uses mapid, instanceid, x, y, z, o.

//EventSystem coded by Cyanide
//Copyright (c) Cyanide 2009

   #include "StdAfx.h"
   #include "Setup.h"
   #include <string>
   #include <iostream>

    using namespace std;
    static string infoHelp, join, start, end;
    float sx,sy,sz,so;
    uint32 smapid,sinstanceid;
    bool evon;

bool EventSystem(Player * pPlayer, uint32 Type, uint32 Lang, const char * Message, const char * Misc)
{
    join = "#join";
    start = "#eventstart";
    end = "#eventend";

    if(Message == join)
    {
        if(evon)
        {
            if(pPlayer->CombatStatus.IsInCombat())
            {
                pPlayer->BroadcastMessage("You cannot teleport in combat.");
                return true;
            }
            else
            {
                pPlayer->SafeTeleport(smapid, sinstanceid, sx, sy, sz, so);
                return true;
            }
            return false;
        }
        else
        {
            return true;
        }
        return false;
    }
    if(Message == start && pPlayer->GetSession()->CanUseCommand('a'))
    {
        if(evon)
        {
            pPlayer->BroadcastMessage("There is already an event summoning wait for it to finish.");
            return true;
        }
        else
        {
            evon = true;
            char Msg[255];
            sprintf(Msg, "|cff0066cc[Event System]|r |cff00ff00%s has started an event! Type #join to join!|r", pPlayer->GetName());
            sWorld.SendWorldText(Msg);
            return true;
            sx = pPlayer->GetPositionX();
            sy = pPlayer->GetPositionY();
            sz = pPlayer->GetPositionZ();
            so = pPlayer->GetOrientation();
            smapid = pPlayer->GetMapId();
            sinstanceid = pPlayer->GetInstanceID();
            return true;
        }
        return false;
    }
    else
    {
        return true;
    }
    if(Message == end && pPlayer->GetSession()->CanUseCommand('a'))
    {
        if(evon)
        {
            evon = false;
            char Msg[255];
            sprintf(Msg, "|cff0066cc[Event System]|r |cff00ff00%s has ended summons to the event.", pPlayer->GetName());
            sWorld.SendWorldText(Msg);
            return true;
        }
        else
        {
            pPlayer->BroadcastMessage("There is no event summoning going on right now.");
            return true;
        }
        return false;
    }
    else
    {
        return true;
    }
    return false;
}

void SetupEventCmd(ScriptMgr * mgr)
{
 evon = false;
 mgr->register_hook(SERVER_HOOK_EVENT_ON_CHAT, (bool *) EventSystem);
}

[XxCyanidexX]

Alright, I'll try that out.

But what about that block of code that wasn't working.

EDIT: Damn, that didn't work, I still fall out of the sky. I fall out in Dalaran Crater if that is relevant. Maybe it's my rev of ArcEmu?

Seems like it is trying to teleport me to Alterac Valley, because that is where my corpse releases.

EDIT 2: I fixed the teleport part, it was because I had return true before the part where you get the coordinates, so it cut it off there. As far as the part of the code that is not working, I am confused :P

[xX EPIC Xx]

you did not make this script lol

[1ns0mnia]

you did not make this script lol

irrelevant

goodluck with the script.

[xX EPIC Xx]

yes it is XD
i don't like people that steal things :O

[XxCyanidexX]

I made it myself.

[Clain]

No, no you didn't. Coolmanbob did and you just edited and renamed some variables. >_<

[Jotox]

>_> This thread is frustrating to watch.

Here's a fixed version of your code.

#include "StdAfx.h"
#include "Setup.h"
#include <string>
#include <iostream>

using namespace std;
static string infoHelp, join, start, end;
static float sx,sy,sz,so;
static uint32 smapid,sinstanceid;
static bool evon;

bool EventSystem(Player * pPlayer, uint32 Type, uint32 Lang, const char * Message, const char * Misc)
{
	
    if(Message == join)
    {
        if(evon)
        {
            if(pPlayer->CombatStatus.IsInCombat())
                pPlayer->BroadcastMessage("You cannot teleport in combat.");
            else
                pPlayer->SafeTeleport(smapid, sinstanceid, sx, sy, sz, so);
        }
		return true;
    }
    if(Message == start && pPlayer->GetSession()->CanUseCommand('a'))
    {
        if(evon)
            pPlayer->BroadcastMessage("There is already an event summoning wait for it to finish.");
        else
        {
            evon = true;
            char Msg[255];
            sprintf(Msg, "|cff0066cc[Event System]|r |cff00ff00%s has started an event! Type #join to join!|r", pPlayer->GetName());
            sWorld.SendWorldText(Msg);
            sx = pPlayer->GetPositionX();
            sy = pPlayer->GetPositionY();
            sz = pPlayer->GetPositionZ();
            so = pPlayer->GetOrientation();
            smapid = pPlayer->GetMapId();
            sinstanceid = pPlayer->GetInstanceID();
        }
		return true;
    }

    if(Message == end && pPlayer->GetSession()->CanUseCommand('a'))
    {
        if(evon)
        {
            evon = false;
            char Msg[255];
            sprintf(Msg, "|cff0066cc[Event System]|r |cff00ff00%s has ended summons to the event.", pPlayer->GetName());
            sWorld.SendWorldText(Msg);
        }
        else
            pPlayer->BroadcastMessage("There is no event summoning going on right now.");
        return true;
    }

    return false;
}

void SetupEventCmd(ScriptMgr * mgr)
{
	join = "#join";
	start = "#eventstart";
	end = "#eventend";
	evon = false;

	mgr->register_hook(SERVER_HOOK_EVENT_ON_CHAT, (bool *) EventSystem);
}

I neatened it up a lot, as well.

[Jotox]

Your error was that you returned before setting the coordinates, and you had a number of unnecessary else{return false;} statements which prevented proper execution.

[XxCyanidexX]

No, no you didn't. Coolmanbob did and you just edited and renamed some variables. >_<

Shutup, I have seen coolmanbobs script ,and his is written with a void, which would disable chat all together. If you are smart enough to look at my script, you would see it's written with a bool, which makes it very different from his, and I wrote it from scratch, so stfu? kthxbai.

and @Jotox1: That disabled my whole chat system.