PQR - Rotation Bot

[Kinky]

@pdey:

local mana = UnitPower("player") / UnitPowerMax("player") * 100

-- Halo
if IsPlayerSpell(120517) and mana >= 35 then
	CastSpellByName(GetSpellInfo(120517),nil)
	return true
end

-- Battle Horn
if GetItemCooldown(86565) == 0 and mana >= 25 then
	UseItemByName(5512)
	return true
end

-- Dispersion
if mana < 50 then
	CastSpellByName(GetSpellInfo(47585),"player")
	return true
end

It's very simple, though, you might want to add a cooldown check on Dispersion, I've not included one here.

@scuzi: It'd be a lot more useffull if you post which kind of profile you're using before we can help you! I assume you've put yourself in combat and activated the profile using the key combination in PQR?

[reapagedk]

also scuzi some of the gylphs change spell ids so that could also be messing it up.

[Pdey]

@pdey:

local mana = UnitPower("player") / UnitPowerMax("player") * 100

-- Halo
if IsPlayerSpell(120517) and mana >= 35 then
	CastSpellByName(GetSpellInfo(120517),nil)
	return true
end

-- Battle Horn
if GetItemCooldown(86565) == 0 and mana >= 25 then
	UseItemByName(5512)
	return true
end

-- Dispersion
if mana < 50 then
	CastSpellByName(GetSpellInfo(47585),"player")
	return true
end

It's very simple, though, you might want to add a cooldown check on Dispersion, I've not included one here.

@scuzi: It'd be a lot more useffull if you post which kind of profile you're using before we can help you! I assume you've put yourself in combat and activated the profile using the key combination in PQR?

didnt he autmaticaly skip the abillity if it has a cooldown? if not.. the Halo needs a cooldowncheck too

Edit Dispersion and Halo works.. i simply abused the *recast delay* for cooldown but the battle horn wont work.. i tried already everything ...

at last :

local mana = UnitPower("player") / UnitPowerMax("player") * 100
if mana < 25 then
	UseItemByName(Schlachthorn)
	return true 
  end

Whats wrong?

[Kinky]

@Pdey: UseItemByName require a item ID or a Item Name. I most likely got the item ID of the Battle Horn wrong. But I'm glad you got it all to work!

[Pdey]

@Pdey: UseItemByName require a item ID or a Item Name. I most likely got the item ID of the Battle Horn wrong. But I'm glad you got it all to work!

i'm sorry.. the battle horn wont work..

the *schlachthprn* is just the german name for the Battle horn

anyway it wont work..

may you had a tip for me?

[evlow]

try UseItemByName(86565) vs. UseItemByName(5512)

[Pdey]

try UseItemByName(86565) vs. UseItemByName(5512)

what the hell.. it worked..

i already tryd this one before because the 5512 was a mana gem...
THX!!

[hordesucks1]

Thanks! i will be using this

[WWF]

free rep ([PQR] Monk - Brewmaster and Windwalker)

[monopoly8]

hey i still cant find the ptr offsets Xelper said he poted, if somebody could link to where he posted it would be nice, ive been searching this thread all day and i only see him saying he posted it. or pm me with it, much appreciated! for PTR

[Kinky]

@monopoly8: You don't mind them, you open PQR and when selecting your WoW process, click the button "Download Offsets"

If you've done this already and PQR still can't detect World of Warcraft in your processes list, the version of WoW you're running doesn't have offsets yet.

[monopoly8]

Alright, i guess the ptr version right now doesnt have offsets made yet cause of the changes they keep doing. thank you

[osbornx22]

i try to make dispel ability, but it doenst dispel anything and i dont know why. no lua error

ability: dispel any friendly player in range and line of sight without "dont-dispel-debuffs". if there are more of these in range, dispel the one with most dispellable debuffs.

local group = "solo"

if IsInRaid() then
	group = "raid"
elseif IsInGroup() then
	group = "party"
end

if group ~= "solo" then
	local max = GetNumGroupMembers()	
	
	local count = 0
	local maxCount = 0
	local maxTar = "player"
		
	for num = 1, max do	
		local mem = group..num
		
		if IsSpellInRange("Läuterung",mem) == 1
		and not PQR_IsOutOfSight(mem)
		and UnitDebuffID(mem, 33786) == nil
		and UnitDebuffID(mem, 131736) == nil
		and UnitDebuffID(mem, 30108) == nil
		and UnitDebuffID(mem, 30108) == nil
		and UnitDebuffID(mem, 124465) == nil
		and UnitDebuffID(mem, 34914) == nil
		then			
			count = 0
				
			for k = 1, 40 do			
				local name, rank, icon, count, type = UnitDebuff(mem,k)
				
				if type == "Poison"
				or type == "Disease"
				or type == "Magic"
				then
					count = count + 1					
				end					
			end		
		
			if count > maxCount then
				maxTar = mem
				maxCount = count				
			end			
		end				
	end
	
	if maxCount > 0 then		
		PQR_CustomTarget = maxTar
		return true
	end	
end

where is the problem?

PS: is there any faster way to get just dispellable debuffs?

PPS: in group or solo (means not raid) this code doesnt dispel the player self, i know it is not finished yet

[Kinky]

@osbornx22: It's not working because "solo" is not a defined environment. Also, you're endlessly looping the dispel function without it ever returning true.
You're also leaking memory by stacking count way too high without ever depleting the variable.

I believe this function should let you do it:

-- Group setting
if IsInRaid() then group = "raid"
    elseif IsInGroup() then group = "party" end

if GetNumGroupMembers() > 0 then
    -- Loop party or raid members
    for i=1,GetNumGroupMembers() do
        local member = group..i
        
        -- Do not dispel these spells
        local blackList = {}
        
        -- Dispel Type
        local dispelType = {Magic,Disease}
        
        -- At any given time, we can only have a total of 40 debuffs
        for i=1,40 do
            -- Loop our dispelTypes
            for x=1,#dispelType do
                -- Only fetch debuffs matching dispelType
                if select(5,UnitDebuff(member,i)) == dispelType[x] then
                    -- If it's blacklisted, don't dispel it
                    for i=1,#blackList do
                        if UnitDebuff(member,blackList[i]) then return false end
                    end
                    
                    -- At this point, we've cross referenced everything - Proceed
                    return true
                end
            end
        end
    end
end  

I've tried to document every step on the way for you, alternatively you could save some CPU power by hard-coding dispelType instead or looping a list of dispelTypes.
Remember that you absolutely need to set dispelType correctly, or you will dispel debuffs that you can't do and endlessly loop the function. Also, if you have some debuffs you DO NOT want to dispel, place their spell ID inside the blackList list, separate with comma. Just something I quickly created just for you that allows you to customize it to your liking without having to add and mess around with the code too much.

Also, make sure you set the correct Spell ID in the Spell ID box on the PQR ability, and I would recommend setting the recast delay to 1000 do simply don't spam the ability endlessly.

[osbornx22]

thank you for this mentally, but i think solo is not the problem, because this is working correctly:

local group = "solo"

if IsInRaid() then
	group = "raid"
elseif IsInGroup() then
	group = "party"
end

if group ~= "solo" then
	local max = GetNumGroupMembers()	
		
	for num = 1, max do	
		local mem = group..num	
		
		if IsSpellInRange("Läuterung",mem) == 1
		and not PQR_IsOutOfSight(mem)
		and UnitDebuffID(mem, 33786) == nil
		and UnitDebuffID(mem, 131736) == nil
		and UnitDebuffID(mem, 30108) == nil
		and UnitDebuffID(mem, 30108) == nil
		and UnitDebuffID(mem, 124465) == nil
		and UnitDebuffID(mem, 34914) == nil
		then				
			for k = 1, 40 do			
				local name, rank, icon, count, type = UnitDebuff(mem,k)
				
				if type == "Poison"
				or type == "Disease"
				or type == "Magic"
				then
					PQR_CustomTarget = mem
					return true					
				end					
			end					
		end							
	end	
end

your code is also ok i think, but i want to dispel the one with the most dispellable debuffs, not the first i found. After extending my code here above with the count-thing, they dispel nothing and i dont know why

your code also doesnt count this is not what i search. your code is just more "beautiful" but doenst do more then my code

what do you mean with "solo is not a defined environment"? i just checking if its a string "solo" or not.