[LUA Request] Help needed

[Ultraviolence]

I'm developing my warrior lua script but I'm having a small problem. I have EquipItemByName on all the main skills so I can quickly re-equip my 2h wep after using a sword and board for anything. But that's the problem, 'cause when I do need to go defensive it will immediately unequip my shield and I'll lose my Shield Block/Shield Wall.

I'd like to have my 2h equipped at all times, unless I'm in def stance (and more efficiently, without needing EquipItemByName on all skills). If anybody can help me, please do. Thanks.

[nightcracker]

Just put the following line on the top of the macro?

/use [noform:2] Name of 2h

[Ultraviolence]

Well that was pretty simple, and it works. Thanks buddy. +Rep ofc. edit: have to "spread some rep around first" -.-

I had another idea, but I just can't get it to work properly. I want to be able to charge, then if my target goes out of melee range, switch to zerker stance and intercept, but switching back to battle stance immediately after intercept.

All I've got atm is this:

if IsSpellInRange("Charge","target")==1 and GetSpellCooldown("Charge")==0 then CastSpellByName("Charge")

if not UnitDebuff("target", "Charge Stun") and not UnitBuff("target", "Divine Shield","Hand of Protection","Ice Block") and IsSpellInRange("Intercept","target")==1 and GetSpellCooldown("Charge")>0 and GetSpellCooldown("Intercept")==0 then CastSpellByName("Berserker Stance") CastSpellByName("Intercept")

Another problem I have is that it likes to cast charge/intercept even though I told it not to do so if the target has any kind of immunity.

[nightcracker]

From the top of my head, might still be buggy:

if IsSpellInRange("Charge", "target")==1 and GetSpellCooldown("Charge")==0 then
    CastSpellByName("Charge")
elseif not UnitDebuff("target", "Charge Stun") and not UnitBuff("target", "Divine Shield") and not UnitBuff("target", "Hand of Protection") and not UnitBuff("target", "Ice Block") and IsSpellInRange("Intercept", "target")==1 and GetSpellCooldown("Charge") > 0 and GetSpellCooldown("Intercept") == 0 then
    CastSpellByName("Berserker Stance")
    CastSpellByName("Intercept")
end

[Ultraviolence]

Well that should take care of the charging while target is bubbled. Could we get it to switch to Battle Stance immediately after Intercept?

[Ssateneth]

Probably something along the lines of...

if GetSpellCooldown("Intercept")~=0 and GetShapeshiftForm()==3 then CastSpellByName("Battle Stance")

In the meantime, I've been getting a headache recoding my protection warrior macro. One of the new biggest annoyances is the new queueing system, so if I need to cast a low priority filler ability that has no cooldown (Slam and Devastate come to mind), I have to compare it's cooldown to the other main abilities such as Mortal Strike or Shield Slam, otherwise it just spams the filler ability, though that might just be a change with how GetSpellCooldown works; it seems to return information based on the global cooldown now instead of the ability's actual cooldown.

The other large annoyance is working the talent Blood and Thunder into protection, which also is playing havoc with Thunder Clap debuff maintenance checks. So far, I got it casting a rend prior to Thunder Clapping on AOE, then it just spams Thunder Clap to retain AOE threat while keeping rend alive. Took a good 2 hours to finally get it to do what I want. Single target is another story though; The damage of 6 ticks of rend seems competitive compared to other abilities, but ..... Now that I think about it, I really don't need any maintenance checks for TC debuff, since I'll be casting it before the debuff falls off to refresh rend, which also refreshes the debuff as well, though I was also checking for any other melee slows as well (Infected wounds, scarlet fever, etc). Sure helps me sometimes to type about my problem for some reason. 0.o

[Ultraviolence]

^ That's it. Works perfect Blehmeh, thanks!

[Ultraviolence]

One other problem I have with this is that it will charge and switch to zerker stance immediately. Now, I put the if not UnitDebuff("target", "Charge Stun") to avoid this but it's buggy. Sometimes it doesn't switch to zerker stance after a charge, but most of the time it does (bad).

So basically, I need this:

1. Charge if unit is in range (making sure not to switch to Berserker Stance during or after a Charge, i.e., within the first second or two after Charge)
2. Switch to Berserker Stance and Intercept if Charge is on cooldown
3. Switch back to Battle Stance only after an Intercept

Also, because Charge/Intercept have a minimum 8 yd range, it would be nice to check the distance of my target before charging so the macro doesn't change stances unnecessarily (sometimes it's better to just run to the target). Tried CheckInteractDistance but no luck. I'm probably just using it wrong.

Thanks in advance!

[Ssateneth]

So you're saying that you need a 'cooldown' between charge and intercept? Just need to confirm before I write something. Thinking about something along the lines of comparing the existing cooldown of charge to your current time to determine if you should start stance dancing to intercept, probably something when charge has used up 2 seconds of it's 20 second (in arms) cooldown.

[Ultraviolence]

Yes, I think that's exactly what I need. Sometimes I will Charge, and in the time my char is moving toward the target it will change stances, wasting rage (and sometimes even using Intercept within a Charge, weird).

[Ultraviolence]

bump ^^

...