[Eluna] [3.3.5a] [TrinityCore] Whats wrong with this LUA script?

[Togggy]

local NPC_ID = 43285

function OnDamageTaken(pUnit, event)
if creature:GetHealthPct() < 75 then
creature:RemoveEvents();
creature:SendUnitSay( "TESTING TESTING 123", 0 )
creature:RemoveEvents();
end
end

RegisterUnitEvent(NPC_ID, 23, OnDamageTaken)

[stoneharry]

Quite a few things:

Eluna API

RegisterUnitEvent is not a valid Eluna function - are you trying to use the ArcEmu API?

I suspect you want: Global:RegisterCreatureEvent - Eluna

CREATURE_EVENT_ON_DAMAGE_TAKEN = 9, // (event, creature, attacker, damage)

Now this documents different parameters and parameter order to what you have specified.

Also you have called a parameter pUnit but you are refering to 'creature' in your script. 'creature' is not defined anywhere, you need to rename one or the other.

You are called RemoveEvents twice - why? RemoveEvents is when you want to remove all events that have been registered with the RegisterEvent function on the object.

I suspect you want something more like:

local NPC_ID = 43285

local function OnDamageTaken(event, creature, attacker, damage)
    if creature:GetHealthPct() < 75 then
        creature:SendUnitSay("TESTING TESTING 123", 0)
    end
end

RegisterCreatureEvent(NPC_ID, 9, OnDamageTaken)

But this is going to happen every time the creature takes damage while the health is less than 75%. I suspect you want something more like:

local NPC_ID = 43285

local function CheckHealthPct(_, _, _, creature)
    if creature:GetHealthPct() < 75 then
        creature:RemoveEvents()
        creature:SendUnitSay("TESTING TESTING 123", 0)
    end
end

local function CreatureEvents(event, creature)
    if event == 1 then
        pUnit:RegisterEvent(CheckHealthPct, 1000, 0)
    else
        pUnit:RemoveEvents()
    end
end

RegisterCreatureEvent(NPC_ID, 1, CreatureEvents) -- OnCreatureEnterCombat
RegisterCreatureEvent(NPC_ID, 2, CreatureEvents) -- OnCreatureLeaveCombat
RegisterCreatureEvent(NPC_ID, 4, CreatureEvents) -- OnCreatureDied

[Togggy]

It didnt seem to do anything.
trying to get creature to talk - YouTube

[stoneharry]

It didnt seem to do anything.
trying to get creature to talk - YouTube

Have you checked your Eluna log file for any errors?

[Togggy]

local function CreatureEvents(event, creature)
    if event == 1 then
        pUnit:RegisterEvent(CheckHealthPct, 1000, 0)
    else
        pUnit:RemoveEvents()
    end
end

the pUnit in this section was showing as an error, I replaced both pUnits with creature and it work as intended now. Much thanks!

[Togggy]

So now it looks like this

local NPC_ID = 43285

local function CheckHealthPct(_, _, _, creature)
    if creature:GetHealthPct() < 75 then
        creature:RemoveEvents()
        creature:SendUnitSay("You are unable to change destiny.", 0)
    end
end

local function CreatureEvents(event, creature)
    if event == 1 then
        creature:RegisterEvent(CheckHealthPct, 1000, 0)
    else
        creature:RemoveEvents()
    end
end

RegisterCreatureEvent(NPC_ID, 1, CreatureEvents) -- OnCreatureEnterCombat
RegisterCreatureEvent(NPC_ID, 2, CreatureEvents) -- OnCreatureLeaveComat
RegisterCreatureEvent(NPC_ID, 4, CreatureEvents) -- OnCreatureDied

[stoneharry]

the pUnit in this section was showing as an error, I replaced both pUnits with creature and it work as intended now. Much thanks!

Ok great, I've been using pUnit for so many years now that it's muscle memory. It's not a particularly good naming convention, 'pointer to a unit' is more hungarian notation which is not that popular in modern software.