Boss Scripting Question

[Trakesor]

Hey i was wondering if this was the right format for a boss script; as in will it work?

I have 2 bosses setup in the same area and one of them summons a spawn(Dont worry bout that ill fix it later tho).

BOSS SCRIPT 1: Azeron

function Azeron_OnCombat(Unit, Event)
Unit:RegisterEvent("Azeron_Strike", 10000, 0)
Unit:SendChatMessage(14, 0, "My children, fresh meat!")
Unit:RegisterEvent("Azeron_Summon", 90000, 1)
end
function Azeron_Strike(Unit, Event)
Unit:FullCastSpellOnTarget(33813, Unit:GetClosestPlayer())
end
function Azeron_1(Unit, Event)
if Unit:GetHealthPct() <= 80 then
pUnit:RemoveEvents();
Unit:SendChatMessage(14, 0, "I shall kill you!")
Unit:CastSpell(27082)
Unit:RegisterEvent("Azeron_2",1000, 0)
Unit:RegisterEvent("Azeron_Fire",7000, 1)
end
end
function Azeron_2(Unit, Event)
if Unit:GetHealthPct() <= 75 then
Unit:RemoveEvents();
Unit:SetScale(1.25)
Unit:SendChatMessage(14, 0, "Burn!")
Unit:FullCastSpellOnTarget(40239, Unit:GetRandomPlayer(0))
Unit:CastSpell(36300)
Unit:RegisterEvent("Azeron_3",1000, 0)
Unit:RegisterEvent("Azeron_Fire",7000, 1)
end
end
function Azeron_3(Unit, Event)
if Unit:GetHealthPct() <= 50 then
pUnit:RemoveEvents();
Unit:SetScale(1.5)
Unit:SendChatMessage(14, 0, "Fire... Hurts doesn't it?")
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:CastSpell(36300)
Unit:RegisterEvent("Azeron_4",1000, 0)
Unit:RegisterEvent("Azeron_Fire",7000, 1)
end
end
function Azeron_4(Unit, Event)
if Unit:GetHealthPct() <= 25 then
pUnit:RemoveEvents();
Unit:SetScale(1.75)
Unit:SendChatMessage(14, 0, "You fight fair. No matter.")
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:CastSpell(36300)
Unit:RegisterEvent("Azeron_5",1000, 0)
Unit:RegisterEvent("Azeron_Fire",7000, 1)
end
end
function Azeron_5(Unit, Event)
if Unit:GetHealthPct() <= 10 then
pUnit:RemoveEvents();
Unit:SetScale(2)
Unit:SendChatMessage(14, 0, "Don't make me angry!")
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:CastSpell(36300)
Unit:CastSpell(36300)
Unit:CastSpell(36300)
Unit:CastSpell(36300)
Unit:RegisterEvent("Azeron_Fire",7000, 1)
end
end
function Azeron_Fire(Unit, Event)
Unit:CastSpell(36876)
end
function Azeron_Summon(Unit, Event)
local x = Unit:GetX();
local y = Unit:GetY();
local z = Unit:GetZ();
local o = Unit:GetO();
Unit:SpawnCreature (TheNpcYouWantSummondEntryID, x, y, z, o, 14 ,90000);
print "Azeron summons whelps"
end
function Azeron_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents()
end
function Azeron_OnKilledTarget(Unit, Event)
Unit:SendChatMessage(14, 0, "Tasty fleshlings!")
Unit:CastSpell(36300)
end
function Azeron_OnDied(Unit, Event)
Unit:SendChatMessage(14, 0, "My master will not be pleased..")
Unit:RemoveEvents()
end
RegisterUnitEvent(9995, 1, "Azeron_OnCombat")
RegisterUnitEvent(9995, 2, "Azeron_OnLeaveCombat")
RegisterUnitEvent(9995, 3, "Azeron_OnKilledTarget")
RegisterUnitEvent(9995, 4, "Azeron_OnDied")

BOSS SCRIPT 2: Lerithik

function Lerithik_OnCombat(Unit, Event)
Unit:CastSpell(34341)
Unit:RegisterEvent("Lerithik_Roar", 30000, 0)
Unit:RegisterEvent("Lerithik_Cone", 15000, 0)
Unit:RegisterEvent("Lerithik_Enrage", 10000, 0)
end
function Lerithik_1(Unit, Event)
if Unit:GetHealthPct() <= 75 then
Unit:RemoveEvents();
Unit:SendChatMessage(14, 0, "Lets turn up the heat")
Unit:FullCastSpellOnTarget(40239, Unit:GetRandomPlayer(0))
Unit:FullCastSpell(23316)
Unit:RegisterEvent("Lerithik_2",1000, 0)
Unit:RegisterEvent("Lerithik_Cone",7000, 1)
end
function Lerithik_2(Unit, Event)
if Unit:GetHealthPct() <= 50 then
Unit:RemoveEvents();
Unit:SendChatMessage(14, 0, "Suffer!")
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:RegisterEvent("Lerithik_3",1000, 0)
Unit:RegisterEvent("Lerithik_Cone",7000, 1)
end
function Lerithik_3(Unit, Event)
if Unit:GetHealthPct() <= 25 then
Unit:RemoveEvents();
Unit:SendChatMessage(14, 0, "Suffer!")
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:RegisterEvent("Lerithik_Cone",7000, 1)
Unit:RegisterEvent("Lerithik_Enrage",2000, 0)
end
function Lerithik_Enrage(Unit, Event)
Unit:FullCastSpell(42705)
end
function Lerithik_Roar(Unit, Event)
print "Roar"
Unit:FullCastSpell(22686)
Unit:SendChatMessage(14, 0, "Tremble before me!")
end
function Lerithik_Cone(Unit, Event)
print "Fire Debuff"
Unit:CastSpell(22539)
Unit:FullCastSpellOnTarget(22682, Unit:GetRandomPlayer(0))
end
function Lerithik_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents()
end
function Lerithik_OnKilledTarget(Unit, Event)
end
function Lerithik_OnDied(Unit, Event)
Unit:SendChatMessage(14, 0, "Too soon.. Too soon...")
Unit:RemoveEvents()
RegisterUnitEvent(9995, 1, "Lerithik_OnCombat")
RegisterUnitEvent(9995, 2, "Lerithik_OnLeaveCombat")
RegisterUnitEvent(9995, 3, "Lerithik_OnKilledTarget")
RegisterUnitEvent(9995, 4, "Lerithik_OnDied")

Summoned Mob(Not in effect atm)

function Minion_OnCombat(Unit, Event)
Unit:CastSpell(34341)
Unit:RegisterEvent("Minion_Strike", 10000, 0)
Unit:RegisterEvent("Minion_Rend", 5000, 0)
Unit:RegisterEvent("Minion_Lash", 30000, 0)
end
function Minion_Rend(Unit, Event)
Unit:FullCastSpellOnTarget(40481, Unit:GetMainTank())
end
function Minion_Strike(Unit, Event)
Unit:FullCastSpellOnTarget(41178, Unit:GetMainTank())
function Minion_Lash(Unit, Event)
Unit:FullCastSpellOnTarget(43267, Unit:GetMainTank())
function Minion_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents()
end
function Minion_OnKilledTarget(Unit, Event)
end
function Minion_OnDied(Unit, Event)
Unit:SendChatMessage(14, 0, "Too soon.. Too soon...")
Unit:RemoveEvents()
RegisterUnitEvent(9995, 1, "Minion_OnCombat")
RegisterUnitEvent(9995, 2, "Minion_OnLeaveCombat")
RegisterUnitEvent(9995, 3, "Minion_OnKilledTarget")
RegisterUnitEvent(9995, 4, "Minion_OnDied")

so thats all i have for now. Im new to scripting but i think im getting better. If anyone could please read over it and fix it or tell me the problems that would be greatly appreciated. Once again please don't comment bad crap as of i know this isn't perfect and im new. Thanks

[gangstagreen]

I was skimming and looks good, but I was just skimming. Check for unneeded or miss-punctuation and other such details. The basic code looks good and I like the name Azeron lawl.

[Trakesor]

Ok thanks. Will rep if possibly for me.

[TheZaronz]

Do you get any errors at start up? In that case what errors do you get?
EDIT cleaned up the script for you this may would fix it as well.

function Azeron_OnCombat(Unit, Event)
Unit:RegisterEvent("Azeron_Strike", 10000, 0)
Unit:SendChatMessage(14, 0, "My children, fresh meat!")
Unit:RegisterEvent("Azeron_Summon", 90000, 1)
end

function Azeron_Strike(Unit, Event)
Unit:FullCastSpellOnTarget(33813, Unit:GetClosestPlayer())
end

function Azeron_1(Unit, Event)
if Unit:GetHealthPct() <= 80 then
pUnit:RemoveEvents();
Unit:SendChatMessage(14, 0, "I shall kill you!")
Unit:CastSpell(27082)
Unit:RegisterEvent("Azeron_2",1000, 0)
Unit:RegisterEvent("Azeron_Fire",7000, 1)
end
end

function Azeron_2(Unit, Event)
if Unit:GetHealthPct() <= 75 then
Unit:RemoveEvents();
Unit:SetScale(1.25)
Unit:SendChatMessage(14, 0, "Burn!")
Unit:FullCastSpellOnTarget(40239, Unit:GetRandomPlayer(0))
Unit:CastSpell(36300)
Unit:RegisterEvent("Azeron_3",1000, 0)
Unit:RegisterEvent("Azeron_Fire",7000, 1)
end
end

function Azeron_3(Unit, Event)
if Unit:GetHealthPct() <= 50 then
pUnit:RemoveEvents();
Unit:SetScale(1.5)
Unit:SendChatMessage(14, 0, "Fire... Hurts doesn't it?")
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:CastSpell(36300)
Unit:RegisterEvent("Azeron_4",1000, 0)
Unit:RegisterEvent("Azeron_Fire",7000, 1)
end
end

function Azeron_4(Unit, Event)
if Unit:GetHealthPct() <= 25 then
pUnit:RemoveEvents();
Unit:SetScale(1.75)
Unit:SendChatMessage(14, 0, "You fight fair. No matter.")
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:CastSpell(36300)
Unit:RegisterEvent("Azeron_5",1000, 0)
Unit:RegisterEvent("Azeron_Fire",7000, 1)
end
end

function Azeron_5(Unit, Event)
if Unit:GetHealthPct() <= 10 then
pUnit:RemoveEvents();
Unit:SetScale(2)
Unit:SendChatMessage(14, 0, "Don't make me angry!")
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(40255, Unit:GetRandomPlayer(0))
Unit:CastSpell(36300)
Unit:CastSpell(36300)
Unit:CastSpell(36300)
Unit:CastSpell(36300)
Unit:RegisterEvent("Azeron_Fire",7000, 1)
end
end

function Azeron_Fire(Unit, Event)
Unit:CastSpell(36876)
end

function Azeron_Summon(Unit, Event)
local x = Unit:GetX();
local y = Unit:GetY();
local z = Unit:GetZ();
local o = Unit:GetO();
Unit:SpawnCreature (TheNpcYouWantSummondEntryID, x, y, z, o, 14 ,90000);
print "Azeron summons whelps"
end

function Azeron_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents()
end

function Azeron_OnKilledTarget(Unit, Event)
Unit:SendChatMessage(14, 0, "Tasty fleshlings!")
Unit:CastSpell(36300)
end

function Azeron_OnDied(Unit, Event)
Unit:SendChatMessage(14, 0, "My master will not be pleased..")
Unit:RemoveEvents()
end

RegisterUnitEvent(9995, 1, "Azeron_OnCombat")
RegisterUnitEvent(9995, 2, "Azeron_OnLeaveCombat")
RegisterUnitEvent(9995, 3, "Azeron_OnKilledTarget")
RegisterUnitEvent(9995, 4, "Azeron_OnDied")

BOSS SCRIPT 2: Lerithik

function Lerithik_OnCombat(Unit, Event)
Unit:CastSpell(34341)
Unit:RegisterEvent("Lerithik_Roar", 30000, 0)
Unit:RegisterEvent("Lerithik_Cone", 15000, 0)
Unit:RegisterEvent("Lerithik_Enrage", 10000, 0)
end

function Lerithik_1(Unit, Event)
if Unit:GetHealthPct() <= 75 then
Unit:RemoveEvents();
Unit:SendChatMessage(14, 0, "Lets turn up the heat")
Unit:FullCastSpellOnTarget(40239, Unit:GetRandomPlayer(0))
Unit:FullCastSpell(23316)
Unit:RegisterEvent("Lerithik_2",1000, 0)
Unit:RegisterEvent("Lerithik_Cone",7000, 1)
end
end

function Lerithik_2(Unit, Event)
if Unit:GetHealthPct() <= 50 then
Unit:RemoveEvents();
Unit:SendChatMessage(14, 0, "Suffer!")
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:RegisterEvent("Lerithik_3",1000, 0)
Unit:RegisterEvent("Lerithik_Cone",7000, 1)
end
end

function Lerithik_3(Unit, Event)
if Unit:GetHealthPct() <= 25 then
Unit:RemoveEvents();
Unit:SendChatMessage(14, 0, "Suffer!")
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:FullCastSpellOnTarget(23309, Unit:GetRandomPlayer(0))
Unit:RegisterEvent("Lerithik_Cone",7000, 1)
Unit:RegisterEvent("Lerithik_Enrage",2000, 0)
end
end

function Lerithik_Enrage(Unit, Event)
Unit:FullCastSpell(42705)
end
function Lerithik_Roar(Unit, Event)
print "Roar"
Unit:FullCastSpell(22686)
Unit:SendChatMessage(14, 0, "Tremble before me!")
end

function Lerithik_Cone(Unit, Event)
print "Fire Debuff"
Unit:CastSpell(22539)
Unit:FullCastSpellOnTarget(22682, Unit:GetRandomPlayer(0))
end

function Lerithik_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents()
end

function Lerithik_OnKilledTarget(Unit, Event)
end

function Lerithik_OnDied(Unit, Event)
Unit:SendChatMessage(14, 0, "Too soon.. Too soon...")
Unit:RemoveEvents()
RegisterUnitEvent(9995, 1, "Lerithik_OnCombat")
RegisterUnitEvent(9995, 2, "Lerithik_OnLeaveCombat")
RegisterUnitEvent(9995, 3, "Lerithik_OnKilledTarget")
RegisterUnitEvent(9995, 4, "Lerithik_OnDied")

-- Summoned Mob(Not in effect atm)

function Minion_OnCombat(Unit, Event)
Unit:CastSpell(34341)
Unit:RegisterEvent("Minion_Strike", 10000, 0)
Unit:RegisterEvent("Minion_Rend", 5000, 0)
Unit:RegisterEvent("Minion_Lash", 30000, 0)
end
end

function Minion_Rend(Unit, Event)
Unit:FullCastSpellOnTarget(40481, Unit:GetMainTank())
end

function Minion_Strike(Unit, Event)
Unit:FullCastSpellOnTarget(41178, Unit:GetMainTank())
end

function Minion_Lash(Unit, Event)
Unit:FullCastSpellOnTarget(43267, Unit:GetMainTank())
end

function Minion_OnLeaveCombat(Unit, Event)
Unit:RemoveEvents()
end

function Minion_OnKilledTarget(Unit, Event)
end

function Minion_OnDied(Unit, Event)
Unit:SendChatMessage(14, 0, "Too soon.. Too soon...")
Unit:RemoveEvents()
RegisterUnitEvent(9995, 1, "Minion_OnCombat")
RegisterUnitEvent(9995, 2, "Minion_OnLeaveCombat")
RegisterUnitEvent(9995, 3, "Minion_OnKilledTarget")
RegisterUnitEvent(9995, 4, "Minion_OnDied")
end

[Trakesor]

Thanks. No i didn't try it yet because for some reason the server im currently a secondary admin is offline. I will as soon as the server comes back online. Thanks n +rep