BfaCore 8.3.7.35662 Repack

**Varjgard** · 10-24-2020

-BfaCore Discord-

**Varjgard** · 10-24-2020

Greetings everyone.

We have some previews from the future of our core development.
On the future we will have 2 cores, BfaCore and ShadowCore.

BfaCore will be for battle for azeroth 8.3.7 and
ShadowCore will be for shadowlands 9.0.1.

There is still a long long long way to go before we can release a repack for shadowlands, but we are working on it.

Here is some preview screenshots for you from our team

-BfaCore Team

**ThordekkDev** · 10-26-2020

GitHub - welder1976/bfacore: repo thordekk

**Varjgard** · 10-26-2020

Originally Posted by ThordekkDev

GitHub - welder1976/bfacore: repo thordekk

it is not current bfacore at any level.

and here is some real leaks for you

Projects . Varjgard / smartai-COOLER-SAI . GitLab
Projects . Varjgard / LatinCore . GitLab

changes after that so called "leak":

Code:

* DB/Spells: Frozen Orb

* Fix syntax in sql/updates/world/2020_10_23_09_fix_playercreateinfo_action_monk.sql

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore

* Core/AlliedRaces: Handle Dark Iron Dwarf intro

* Fix for syntax in sql/updates/world/2020_10_23_10_fix_playercreateinfo_action_druid.sql

* DB/World: Fix Death Knight Action Bar on new char creation

* DB/World: Fix Druid Action Bar on new char creation

* DB/World: Fix Monk Action Bar on new char creation

* DB/World: Fix Warlock Action Bar on new char creation

* DB/Spells: Assign Shadowbolt script (Affliction)

* Core/Spells: Shadow Embrace

* Core/Spells: Cataclysm

* Core/Spells: Soul Fire

* Core/Spells: Eradication

* DB/SAI: Combat scripts Uldir & Eternal Palace

* DB/World: Fix Mage Action Bar on new char creation

* DB/World: Fix Shaman Action Bar on new char creation

* DB/World: Fix Priest Action Bar on new char creation

* DB/World: Fix Rogue Action Bar on new char creation

* DB/World: Fix Hunter Action Bar on new char creation

* DB/World: Fix Paladin Action Bar on new char creation

* DB/World: Fix Warrior Action Bar on new char creation

* DB\World: Delete custom vendor.

* DB\World: Fix Quest: No Better Than the Zombies
Fix issue: https://www.bfacore.com/d/220-quest-no-better-than-the-zombies

* Core/Creature: Rewrite prehistoric script for quest Fear No Evil

* DB/Quest: Fear no Evil

* DB\World: Fix Quest Fizzled (Quest_ID: 25260)
Close issue: https://www.bfacore.com/d/224-quest-bug-fizzled

* Core/Defines: Enum Currencies

* Core/Transmog: Add remaining hidden appearances (tc cherry-pick).

* Core/Pet: Calculate Chi-Ji base melee damage

* Merge branch 'master' of https://gitlab.com/Varjgard/bfacore_PRIVATE

* Core/Spells: Rising Mist

* DB/Spells: Assign Essence Font

* Core/Spells: Essence Font

* Core/Spells: Mystic Touch

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE

* Core/Linux Fix Linux build yet again

* DB\Hotfixes: Final hotfixes for 35662 from tc.

* Fix compile

* Core/Spells: Awakening, Register

* Core/Spells: Awakening

* DB/Hotfixes: Update hotfixes to final 35662. (tc cherry-pick)

* Fix syntax on 2020_10_20_fix_rigor_mortis.sql

* DB/Spells: Fix Rigor Mortis on new Undead char creation (thx Damieninabox)

* Core/Spells: Judgment of Light

* Core/Pet: Fix attack speed of pets

* Core/Spells: Define Ring of Peace knockback

* DB\Base: Update database to BFADB_837_2020_10_19 and archive old updates.

* DB/Spells: Assign Ring of Peace

* Core/Spells: Ring of Peace

* Core/Spells: Soothing Mist casted by statue will now properly target owner's target

* DB/Creature: Jade Serpent Statue

* Core/Spells: Despawn Jade Serpent Statue if owner change spec

* Core/Spells: Soothing Mist

* DB/Quests: Finding a Foothold, For the Aliiance! Kill whitespace

* Core/Areatrigger: Set custom id range

* Core/Areatrigger: Areatrigger visuals are now properly removed together with areatrigger

* DB/Quests: Finding a Foothold, For the Aliiance!

* Core/Scripts: For the Alliance!

* Core/Scripts: Finding a Foothold

* Merge branch 'master' of https://gitlab.com/Varjgard/bfacore_PRIVATE

* Core/Spells: Darkness

* DB\Hotfixes: Item 23472 - Rugged Trappers Boots.

* DB\Hotfixes: Fix syntax on 2020_10_18_00_quest_missing_itemes_errorlogs.sql

* DB\Hotfixes: Fix data on 2020_10_18_00_quest_missing_itemes_errorlogs.sql

* DB\Misc: Move update to right database.

* Core/Garrison Implement GarrisonSwapBuildings opcode without handled more search needed

* DB\World: Creature scripts

* DB\Hotifx: Fix quest errors with missing items from db :P

* Core\Scripts: Clean a little. :)

* Core\Scripts: Final adjustment to "onlegionarrival".

* Core\Scripts: Fix check on "onlegionarrival".

* Core\Script: Adjust "onlegionarrival" for demonhunters.

* Core\Scripts: Handle OnLegionArrival correctly for demonhunters.
(block OnLegionArrival script in dh starting areas if questline is not finished enough).

* DB\World: Mardum spirit healer.

* Core\Scripts: Destroy "legion banner - gob 259043, 250560" for player after use (block multiuse).
Core\Scripts: Destroy "legion communicator - gob 244439, 244440" for player after use (block multiuse).

NOTE TO DEVS:
gameobject_template "type 10" "data20" is broken (questobject multiuse 1\0).

* DB\World: Fix all mardum boss stats.

* DB\World: Fix all mardum quest objective texts to blizzlike.

* DB\Hotfixes, DB\World: TC Bruteforce 35662.

DB: 35662 zhTW bruteforce
DB: 35662 zhCN bruteforce
DB: 35662 ptBR bruteforce
DB: 35662 koKR bruteforce
DB: 35662 itIT bruteforce
DB: 35662 frFR bruteforce
DB: 35662 esMX bruteforce
DB: 35662 esES bruteforce
DB: 35662 deDE bruteforce

* Added a more scripts, mostly creature, to the db.

Also consolidated duplicate scripts in several files.

* Few small fixes in stonetalon moutains

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE into master

* DB\World: Remove broken and obsolete sai. and fix bpet sql syntax.

* Core/BattlePet Reverse Ability

* Core/Packets Scripts Update Instance Encounter Packets and implement it

* Added many creature and spell missing scripts to the db

* typoooos

* DB\World: Clean database from obsolete quests.
all of these quests have been removed from world of warcraft in previous expansions.
trinity added them to "disables", but they are just waste of space in reality.
(all of these are obsolete quests removed by blizzard.)

* DB\World: Update 2020_10_17_01_world_delete_obsolete_quests.sql

* DB\World: dberror fixes for broken conditions.

* Core/Creature: Script Dread Admiral Tattersail to allow players set sail to BfA zones

* DB\World: dberror fixes.

* ...

* typo

* DB\World: update 2020_10_17_01_world_delete_obsolete_quests.sql a little.

* DB\World: Delete obsolete quests that give error and have been removed from game.

* DB/Creature: Dread-Admiral Tattersail

* QuestID: 26464 The Lost Gem - fixes issue for quest item dropping even if you do not have the quest.

* Fixed a couple typos that were causing an issue.

* DB\World: Fix all rest of the model errors. manually from wowhead :D

* DB\World: add TC 35662 bruteforce data to db, cleaned poi errors after that, fix syntax on 2020_10_16_00_cleanup_error_log_invalid_creatures.sql.

* DB/WarCampaign: Dark Iron Mole Machine

* DB\World: Modify 2020_10_16_00_cleanup_error_log_invalid_creatures.sql
(3300000000000000 are mechagon spawns so we cant delete them, they are working on bfadb.)

* Git please, don't do it.

* Core/WarCampaign: The Fury of the Zandalari

* DB/WarCampaign: The Fury of the Zandalari

* DB\World: Cleanup error log for invalid creatures spawn (not spawned actually cuz they don't exists :P )

* Fixes for warrior spells Devastate and Frothing Berserker

* Fix warrior spell Odyns Fury (Warrior only weapon)

* Fixes for the warrior spells Sudden Death and Victorious

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE into master

* DB\World: Creature display models - Laur.

* DB\World: Fix inhabittype on Stormwind Gryphon Rider.

* COre\Scripts: Comment out 2 crashes from "freehold" dungeon. (these scripts on freehold are shit, full of crashes).

* DB\World: dberror fixes.

* Fixes for the following warrior spells.

Shield Slam
Sword and Board
Bloodbath
Shield Block

* DB\World: Nazjatar Graveyards (all) Added World Safe Locs (In case some one have them missing. Also delete the one created by Varjgard) + Fix Typo (again.. silly me :D )

* DB\World: Nazjatar Graveyards (all) Added World Safe Locs (In case some one have them missing. Also delete the one created by Varjgard)

* DB\World: Nazjatar Graveyards (all) Fix typo :P

* DB\World: Graveyards Nazjatar (all of them) :P

* DB\World: Dberror fixes.

* Update 2020_10_15_00_world_nazjatar_graveyard.sql

TODO: add graveyard to both factions, this sql is set so that both factions tele to allied side when dying.

* DB\World: Nazjatar gameobject_template entries.

* DB\World: Nazjatar creature and gameobject spawns. danke für damien für sniffs.

* DB/War Campaign: The Fury of the Zandalari 8.1
DB/War Campaign: Lost Honor 8.1

* DB\World: Allied DK graveyard.

* DB\World: Nazjatar graveyard.

* Core\Scripts: Add Nazjatar alliance intro movie (quest Send the Fleet 56043).

* DB/Conditions: Remove not-working Darkshore terrain swap

* DB/Creature: Assign Grand Admiral Jes-Tereth scriptname

* Core/Creature: Script Grand Admiral Jes-Tereth to allow players set sail to BfA zones

* DB/Quests: Wrath of the Zandalari, fix chains (Thanks to Damien)

* Core/Misc: Revert back to using boost::regex, std::wregex doesn't work for name validation.
(tc cherry-pick)

* Core/battlepet implement EffectGrantBattlePetLevel

* Core/Spells: Shattered Souls, final form

* Core/Spells: Shattered Souls - Healing below pct hp 100

* DB/Spells: Cleanup of spellscripts which we don't need anymore

* Core/Spells: Shattered Souls

* Revert "DB\World: Fix Fishing profession."

This reverts commit 528baf90e6d59264c8d208ec1211b11766ebca18

* DB/Creature: Translate Toki's text to English

* DB\World:Fix Portal spells Stormwind

* Core/Quest: Ride of the Zandalari, improve scripts and finish

* DB/Creature: Some random fixes for Nazmir

* DB\World: Fix Fishing profession.

* Core\Battleground: Fix signed\unsigned mismatch warning.

* DB/BattlePet Fix learn spell revive battle pet

* Core/packet implement SMSG_BATTLEGROUND_POINTS structure

* Core/packet Implement SMSG_BATTLEGROUND_INIT and fix Mistake structure WargameRequestSuccessfullySentToOpponent

* Core/Packet implement CMSG_QUERY_COUNTDOWN_TIMER

* Core/Battlepet Rewrite battlepet_npc_team_member

* DB\Base: Update database to BFADB_2020_10_12 and archive old updates.

* DB\World: Add Vault of wardens graveyard zone and ".tele vaultofwardens".

* DB\World: Adjust mardum and VoW mana stats and fix fel lord caza stats.
TODO: adjust stats of all mardum and VoW bosses with "fel lord caza" query template.

* DB\World: Fix mardum cryptic hollow invisible npcs attacking player.
(they had just invisible aura).

* DB\World, Core\Unit.

DB\World: Fix npc hp and damage on mardum and VoW.
DB\World: Engineering trainer fixes.
Core\Unit: Clean "Void DealDamageMods" and "Void DealDamage".
Core\Unit: Remove legacy buff... it is legacy, just like the shit script.

* DB/Creature: Creature texts for Trade Prince Gallywix, used in Opulence encounter

* Merge branch 'master' of https://gitlab.com/Varjgard/bfacore_PRIVATE

* DB/Quest: Ride of the Zandalari
Corrected creature templates, weren't updated
Fixed gossip data
Fixed spawns

* DB\World: Fix battlepet_npc_team_member missing columns.
DB\World: Revert mardum npc damage fix (i will push something more permanent today, it is the whole world, not only mardum).

* DB/Creature: Model data (Damien)

* Core/LFGList rewrite LowType Guid to getcounter

* Core/Fix send cinematic on first login

* DB/Update allied race to 8.3.7

* Core/Script, update allied race to 8.3.7

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE

* DB/Creature: Assign scriptname for Captain Rezokun

* Create 2020_10_11_04_update_battle_pet_data.sql

* Core/Fix cleanup and fix OpenAlliedRaceDetails GOSSIP

* Core/Quest: Enum Send the Fleet, Ride of the Zandalari

* DB/Creature: Captain Rez'okun gossip menu option

* Core/Quest: Script Captain Rezokon for quest Send the Fleet, including movie and first part Ride of the Zandalari

* DB/AlliancePortalRoom: Update phases by areaID

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE

* DB/AlliancePortalRoom: (Thanks Damien for sniffs)
Cleanup old stuff
Adjust guids
Corrected UNKNOWN columns
Corrected Creature templates
Corrected Creature models

* Core/Cleanup & set actif SMSG_ALLIED_RACE_DETAILS ... mistake?

* Core/GameTable fix loading

* Core/Update Verify/Rename adventure map poi packet

* DBError.log Creature_loot_template fixed.

* Core/Cleanup in PrepareGossipMenu

* Core/LFGList small update and cleanup

* Core/cleanup

* DB/Mardum: Creatures there should deal to players +- 50% reduced damage (i checked some retail videos)
Note: It's not definitely blizzike fix :P

* Core/Debug AdventureJournal

* Core/update bg code and set unhandled SMSG_REQUEST_SCHEDULED_PVP_INFO_RESPONSE opcode (he's not coded correcly)

* Core/PacketIO Implement correcly wargame packets

* Core/Opcode Set status unhandled where Handle_NULL

* Core/Cleanup Group finder work now correcly

* Core/ fix load db2

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE

* DB/Creature: Assign missing scriptname for Dreadstalkers

* Core/Spells: Update at id for Freezing Trap

* DB/Spells: Assign Freezing Trap

* DB/Spells: Assign script for Lingering Insanity

* Core/Spells: Lingering Insanity

* Core/DB2 Fixed 6 db2 structures loading

i test it before push total commit

* More quest ender fixes.

* Many fixes for quest starters/enders

* DB/Spells: Fix some Feral spells learning when you switch spec

* Core/Spells: Call Dreadstalkers

* DB/Creature: Assign Wild Imp script

* Core/Spells: Wild Imp is now scaled based on caster's hitpoints

* Core/Spells: Void Reaver
Force target to get base points directly from spell effect

* DB/Spells: Assign Void Reaver

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE

* Misc. dberror.log fixes.

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE into master

* More creature_loot_template fixes

* Core/BattlePet temporary fix battlepet delete pet

* Core/update guild challenge system work & flags for rename is implemented

* Core\Typo: Fix linux build (again :P) damn linux CasESensiTive :D

* Core/PacketIO update/Remove duplicate function in guild challenge update

* CORE/Datbase Fix my mistake, sorry

* Core/Implement Guild Invite Declined

* Core\Typo | Fix linux build again :P

* Core/Implement Guild Shift Rank and update code for opcode SMSG_GUILD_EVENT_RANKS_UPDATED

* Core/Implement Guild flag for rename

* Core/PacketIO Implement Guild Change Name opcode

* Core/Quest: Speaker of the Horde, hardcode and fix another parts of the quest to core

* Core/Quest: Speaker of the Horde, fix movement, gossip flag, crash

* Core/Typo: Fix Linux build

* Core/Quest: Rastakhan, fix killcredit, scene, blackscreen

* Core/Quest: Rastakhan, fixed escortAI

* Core/Quest: Fixed quest Welcome to Zuldazar

* Core/Scenario: Improve Stormwind Extraction skip a little

* DB/Spells: Assign some mage scriptnames and data

* Core/Spells: Update at id for mage meteor

* More creature_loot_template fixes

* Many more creature_loot_template fixes

* Model fixes by Damieninabox

* Many creature_loot_template fixes

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE

* Core/Spells: Searing Touch

* Core/Kezan: Goblins can leave Kezan now and are bound to Lost Isles

* Core/PacketIO update SMSG_NEUTRAL_PLAYER_FACTION_SELECT_RESULT

* Core\Opcodes: SMSG_INTERRUPT_POWER_REGEN

* DB/Creature: Prevent Darnell to be attackable

* Core/Kezan: Goblins can leave Kezan now and are bound to Lost Isles

* DB\World: Fix Quest In the blink of an Eye (Quest ID: 44663)

* DB\World: Object (Portal to Orgrimmar)

* DB\ModelData: add 107 models to db. (By DamienInABox).

* Core\Scripts: Move "onarrival" temp fix scripts to proper place.

RegisterPlayerScript(OnLegionArrival); // TEMP FIX! Quest 40519 and 43926 - "legion returns". remove it when legion start quests are properly fixed.
RegisterPlayerScript(On110Arrival); // TEMP FIX! Quest 43341 - "uniting the isles".
RegisterPlayerScript(OnBfaArrival); // TEMP FIX! remove it when lordaeron battle is properly fixed.

* CoreScripts: Fix npc_eoa_call_the_seas::npc_eoa_call_the_seas_AI::UpdateAI crash.

* Core\Spells: Fix spell_rog_saber_slash::HandleOnHit crash.

* Core\Functions: Remove broken "HandleOverrideZonePVPType" and implement "HandleModOverrideZonePVPType".

* Core\Functions: Implement "bool IsPvPRealm()".
Core\Players: Corrected logic determining contested/friendly/hostile area types. (TC cherry-pick)

* Core\Handlers: Fix BattleGroundHandler.

* Core\Opcodes: Fix, rename, and add opcodes for 8.3.7. :)

* Core/PacketIO: Renamed a bunch of opcodes based on more research (only those added after 6.0)
https://github.com/TrinityCore/TrinityCore/commit/f922c6e7a46a7c712daaaef9b1a72ca865fbe94b
https://github.com/TrinityCore/TrinityCore/commit/1d04d5859a59caf286d71f78a18ec4ed05feb7c2

* More dberror.log fixes (loot templates)

* More dberror.log fixes (quests)

* Continuing the dberror.log fixes campaign

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE into master

* Core/Opcode Rewrite QueryQuestReward to QueryTreasurePicker World Quest rework after complete first quest

* Various DBError.log fixes.

* DB\Loading: Fix 27000+ loading errors.

* DBError.log fixes. Cleaned up lots of abandoned entries in creature_template_addon table

* Core\Scripts: Fix operation mechagon file names.

* Core\Script: Fix operation mechagon build error.

* Fix sql syntax.

* Core/Operation Mechagon: Rename header

* DB/Operation Mechagon: Assign instance script

* Core/Operation Mechagon: Scriptloader

* Core/Operation Mechagon: Tusle Tonks

* Core/Operation Mechagon: Trixie && Naeno && Mechacycle

* Core/Operation Mechagon: KUJO

* Core/Operation Mechagon: King Mechagon

* Core/Operation Mechagon: HK8

* Core/Operation Mechagon: Head machinist Sparkflux

* Core/Operation Mechagon: Instance

* Core/Operation Mechagon: Gunker

* Core/Operation Mechagon: King Gobbamak

* Core/Operation Mechagon: Header

* Rename Mechagon to Operation Mechagon

* DB/Dungeon: Operation Mechagon
Flags
Texts
Creature AI
Loot
Misc

* Cleaned out some abandoned gameobject_template_addon records.

* Spell fix. Druid Maul spell# 6807

* DB\Base: Merge missing data, revert some dberror fixes, update bases.

* Merge missing data from 837 TDB (411 quests, creatures, gameobjects etc...).
* Fix old world dberror fixes from 2020_08_06-2020_09_17 (removed all mass "deletes" and kept only "updates" and "fixes").
* Update database to BFADB_2020_10_03 and archive old updates.

I will start again the dberror fixes.
This time only obsolete\bad data will be removed from database, rest of the errors will be fixed properly.

NOTE:
Drop your world db and hotfixes db, and import fresh base sql files from sql\base.

* Core\Misc:

change tc_log_debug to tc_log_error on hotfix_blob, we need that info for db fixes.
change tc_log_info to tc_log_error on gametables.cpp, we need that info for gt structure fixes.
fix datatype warning on creature.cpp (int\uint).

* typo

* DB\Misc: Rename some npcs with "0" as name.

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE

* DB/WQ: Removed wq 51581, causing worldserver to stuck for eternity

* Fix battlepay locale loading

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE

* DB\World: Fix spell Consecreation (by Splose) + added some missing queries :P

* DB\World: Fix spell Retribution (By Splose)

* DB\World: Fix spell Blizzard - Mage (by Splose) also a fix file extension (pardon me :P )

* DB\World: Fix spell Blizzard - Mage (By Splose)

* DB/Fix load battlepey display info

* Core/Big update for implement bases groupFinder, somes modifications of battlepay, rewrite somes Opcodes

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE

* Core/Areatrigger: Prevent custom areatriggers to be removed from the world after one 'use'

* Core/SmartAI Fix Void function

* Core/SmartAI: allow SMART_ACTION_SEND_GOSSIP_MENU to override default gossip

* Core/BattlePet Fix show level of battle pets

* Core/Freehold: Removed unneeded lines, causing also crashes

* update bugtracker address.

* Core\Misc: discord ad

* DB\Base: Update database to BFADB_837_2020_10_01 and archive old updates.
(drop hotfixes db, and world db, and import fresh clean base files.)

* Map/Difficulty: IsNormal

* Map/Difficulty: IsNormal define

* Core/Areatrigger: Fixed quest Jasperlode Mine

* DB/Areatrigger: Assign script for at 87

* DB/Areatrigger: Assign script for at 88

* Core/Areatrigger: Fixed quest Fargodeep Mine

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE into master

* Core/Update criteria for battle pet

* Some dberroe.log clean up.

Garothi spell scripts added/corrected effects.

* Core/Spells: Fixed Saber Slash chance

* Core/ClassHall: Fixed scene for quest - You Can't Take the Sky from Me

* Core/ClassHall: Rename script for Thisalee Crow

* DB/Creature: Rename script for Thisalee Crow

* DB/Creature: Lunarwing form chain start/end && misc

* Rename throne_of_thunder sql

* Core/ClassHall: Tempfixed chain for Lunarwing form

* DB/Creature/Gameobject: Throne of Thunder spawns

* A few DBError.log fixes.

* Rename spell script name from spell_pri_dispel_magic to spell_pri_purify

* Renamed spell script name from spell_pri_circle_of_healing to spell_pri_holy_word_sanctify

* World/DB Fix temp battlepet info level before create parser

* Core/Unit: Fixed function Unit::RemoveAllAreaTriggers()

* Core/BattlePet fix end battle. work correcly

* Core/battlePet somes fix

* Core Fix battlePet, can battle with a pet now

Soms bugs for quit, i will work on

* Core/Opcode implement HandleBattlePetClearFanfare and change somes bad procces

* Core/LFG update Ride Type

* Core->Init files for LFGGroup Finder

* Core/Spells: Fixed Saber clash crash

* DB/Areatriggers: Fixed entrance and exit for Throne of Thunder

* Spell fix. Priest Holy Word Chastise Only Holy Spec get 4 sec GCD when casting smite.

* Spell fix: Priest Holy Word Sanctity (Renew now reduces GDC by 2 sec.) Bug ID 213

* The current OnEffectAborb uses a hardcoded SPELL_AURA_SCHOOL_ABSORB for the effect name.

Per the SpellEffect.dbc different spells can now have different EffIndex and EffName so the hardcoded name prevented the OnEffectAbsorb from firing.
I created a new class and function to allow passing the EffIndex and the EffName. The new one is modeled very close to the current.

It works much like any other functions that call the effect index and name.

Example:
OnEffectNameAbsorb += AuraEffectNameAbsorbFn(spell_pri_guardian_spirit_AuraScript::Absorb, EFFECT_0, SPELL_EFFECT_HEAL);

Since there are spells that still use the SPELL_AURA_SCHOOL_ABSORB, this includes bosses, I decided to keep the original class clean and unaltered instead of defining a macro with variable paramaters.

* DB/Creature: Fixed flags for npc controller in RtK

* Core/Scripts: Updated RtK instance script to current code standards

* Core/Scripts: Renamed new Kharazan as ReturnToKhazaran

* DB/SAI: Return to Kharazan

* DB/Creature: Fixed templates (levels, factions, ai assign) for all creatures in Return to Kharazan

* Rename RtK spawns

* DB/Creature/Gameobject: Fixed spawns for Return to Kharazan

* Core/Scenarios: Added scenario objectives for RtK (Lower Kharazan)

* DB/Areatriggers: Fixed portal to Return to Kharazan

* Core/Creature: Fixed quest Welcome to Zuldazar

* DB/Areatriggers: Fixed Dark Portal to Outland

* Core/Spells: Updated spell Shadowfiend to new code standards

* DB/SAI: Waycrest Manor AI

* CORE/Battle pet Update final, need opcode structure or sniff in 8.3.7 for end this work

* DB\Quest: Fix quest 9403 (Blood Elf starting zone)

* DB\World: Fix Quest POI 9064 (Blood Elf starting zone)

* DB\World: Fix QuestPOI for quest 8895 (BloodElf starting zone)

* Helps to remove the faulty script when you add the corrected version <face palm>

* Working with ingocnito to troubleshoot and correct his previous tol_dager_ai commit the was being problematic

* Looks like an update from commit 8500fd6 was put in the wrong place. Moved it to the updates\world folder.

* DB/Gameobject: Mechagon gameobject spawns

* DB/Creature: Mechagon spawns

* DB/Creature/Gameobject: Fixed phases for 1800 spawns

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE into master

* DB/Creature: Some minor stuff which i found

* Core/Creature: Creatures are not supposed to asist another creature to attack player if they have flag UNIT_FLAG_IMMUNE_TO_PC

* Reload all creature, creature_addon, gameobject and gameobject_addon for map id's 1642 and 1643 from ADB 8.2.0.

Lastly reapply Incognitos mechagon commit.
Note: this was a collaborative effort between incognito and myself but all credit goes to incognito for the idea.

* DB\World: Added missing NPC Darnell (NPC ID: 49425)

* Fix my mistakes

* DB/Tol Dagor: AI

* DB/Fix battle pet save

* CORE/BattlePet -> Fix objectaccessor ...

* CORE/BattlePet -> Fix objectaccessor

need more work for fix it completly

* CORE/BattlePet -> Fix loading/saving battlepet And some opcodes updates structure to 8.3.7

need more work for fix it completly

* Core/FIX DB2 storage sBattlePetSpeciesStore

* DB\World: Fix Quest: Solanian's Belogings (Blood-Elf Starting Zone)

* DB\World: Fix Quest: The Shrine of Dath'Remar (Blood Elf starting zone)

* DB/Creature: Fixed quest - Looks like a tauren pirate to me, A Nation United, The Emerald Dreamcatcher && Freehold AI

* Added missing declaration QUEST_NATION_UNITED

* Spell fix Priest - Holy Word: Sanctify Spell# 55675 (Formerly Circle of Healing)

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE into master

* DB\World: Fix Quest POI: What You May Regret

* DB\World: Fix Quest chain: The Pride of Kul Tiras

* Core/Tiragarde Sound: Fixed quest - A Nation United

* Spell fix Priest - Power Word Fortitude spell# 21562

* Spell fix. Priest Vampiric Embrace Spell# 15286

Removed secondary buff spell# 15290

* Merge branch 'master' of https://gitlab.com/Varjgard/bfacore_PRIVATE

* Core fix my mistake

* COre\Misc: Fix compile warning and some comments.

* Core/Player: SaveBattlePets trans //

* Core/Spells: Some 'new' spell definitions

* Core/Deadmines: Prevent heroic version of Enraged worgens to be spawned on normal difficulty

* Core/Deadmines: Prevent heroic foe-reapers to be spawned on normal difficulty

* Core/Deadmines: Heroic version of Glubtok isn't supposed to be there on normal difficulty

* DB/Deadmines: Phase some spawns in wrong places

* DB/Gameobject: Fixed gameobjects for quest Solanian's Belongings
DB/Spells: Assigned Feral Frenzy script

* Core/Spells: Scripted Feral Frenzy

* Core Update battlePay structure . need sniff retail for fix it

* CORE update battle pet

* DB/Spells: Assign Ancestors Call

* Core/Spells: Fixed racial spell - Ancestral Call

* Spell fix. Priest Renew spell# 139

* Spell fix Purify (formerly called Dispel Magic) Priest spell# 527

* DB/Conditions: Fixed Arathi Highlands swapping and some more related to BfA

* Core/Creature: Gossip workaround crash

* Core/Highmountain: Properly moved scene script where it's supposed to be

* Core/Scene: HM scene should not be there

* Core/Scripts: Add mising go include in King's Rest pt2

* Core/Scripts: Add mising go include in King's Rest

* DB/RBAC: Command movie, permissions

* DB/World: Command movie play

* Core/Commands: Scriptloader

* Core/Commands: Implemented command movie play

* Core/RBAC: Permissions defines for command movie play

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE

* A few quest starter, flags and duplicate fixes

* Spell fix Warlock Shadow Bulwark (Voidwalker) Spell# 17767

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE into master

* Spell fix. Spell# 19505 (Devour Magic - Felhunter)

* Core/DB-> Init all battle pet system

need more work, more search with sniffer

* DB\World: Fix Quest: The Wakening (Undead starting zone)

* DB\World: FIX Quest: The Suffering of Shen-zin Su
Close issue: 125 + rename sql file :P

* DB\World: Quest [The Suffering of Shen-zin Su]
Close issue: 125

* Core/Spells: Enum Azerite Traits for mage

* Core/Spells: Warrior - Optimized script and partially fixed Anger Management

* DB\World: Fix Lazz of Leisure FLight Master (Mechagon Horde)

* DB\World: FIX Cog Captain Winklespring - Flight Master (Mechagon Alliance) (forgot again to remove the ` from the query :P )

* DB\World FIX Cog Captain Winklespring - Flight Master (Mechagon Alliance) (forgot to add the spawn query :P)

* DB\World: FIX Cog Captain Winklespring - Flight Master (Mechagon Alliance)

* DB\World: FIX Cog Captain Winklespring - Flight Master (Mechagon Alliance) (Close issue 43)

* Core/Pandaria: Fixed - The Lesson of the Burning Scroll

* DB\World: Fix Portal to Silithus

* DB/Spells: Assigned missing sn for mirror image

* Core/Spells: Fixed Mage - Blizzard

* DB/Areatriggers: Assigned missing ats for blizzard, frozen orb

* DB/Areatriggers: Fixed Consecration at

* DB\Base: Update database to BFADB_837_2020_09_21 and archive old updates.

* DB\Base: Recreate hotfix db and archive old updates. (clean trinity 35662 hotfdb + missing tables from ashamane + custom boost items from bfacore).

NOTE:
Delete your "wow\retail\cache" folder.

* DB\Hotfixes: Fix custom items (789001-789004).

* DB\World: Hackfix gameobject for Quest: Defender of Azeroth (Quest ID: 58903/58902)

* DB\World -> Quest: Dteaht Comes From On High (Quest ID: 12641)

* DB/Dungeon: Corrected spawndifficulties/requirements for Operation Mechagon

* Added jewel crafting spells to trainer Farii in The Exodar

* Spell fix Warrior Last Stand (id 12975)

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore_PRIVATE into master

* DB\Spawns: Operation mechagon (by incognito).

* Core/Spells: Fixed Rogue- Saber Slash

* Core/Spells: Fixed Rogue - Shadowstrike

* Core/Spells: Fixed Mage - Icicle

* Core/Spells: Mage - Nova

* Core/Spells: Fixed Sha - Lava Lash

* Core/Spells: Fixed DK - Icy Touch

* Core/Spells: Fixed Warr - Bloodthirst

* Core/Spells: Fixed Warr - Slam

* Core/Spells: Fixed Dru - Brutal Slash

* Core/Spells: Fixed Dru - Blessing of Elune

* Core/Spells: Fixed Hun - Piercing Shot

* Core/Spells: Fixed Warr - Rampage

* Core/Spells: Fixed DH - Soul Cleave

* Spell fixes Warrior Blade Storm Off Hand (id 95738) and Rallying Cry (id 97262)

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore into master

* Core\Mods: Adjust singleplayer hpmod.

* Core\Mods: Addeed singleplayer hp mod.
Core\Misc: adjusted sql query for creature and gameobject respawns on crash.
Core\Mods: Disable solocraft by default if no config option available.

#######################################################################
# SinglePlayer.HPMOD.Enabled
# Description: Enable\Disable hp mod of player.
# Mod for singleplayer or low populated servers.
# Default: 0 - (Disabled)
# 1 - (Enabled)

SinglePlayer.HPMOD.Enabled = 0

# SinglePlayer.HPMOD
# Description: Set amount of hp for player.
# (base_hp * X.X).
# Default: 1.0 - 100% hp
# 0.5 - 50% hp
# 0.01 - 1% hp
# 5.0 - 500% hp

SinglePlayer.HPMOD = 5.0
#######################################################################

* Spell fix Siphon Life spell id 63106

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore into master

* DB\Creature: Fix fel spreader faction.

* add missing delete to 2020_09_17_00_world_dberrors.sql

* DB\Misc: Fix more dberrors.

* Spell fix Divine Storm spell id 53385

* Fixed backstab spell effect.

* Fixed module name to better describe what is does.

Updated worldserver.conf to remove unimplimented level ranges.

* Added weekend XP rate module that allows default server XP rates to be changed dynamically by level range for Friday, Saturday and Sunday. Disabled by default. Enable and change rates by level range in worldserver.conf

* DB\Misc: Refresh creature table hp, mana and waypoint entries. (basically a respawn, fixes some wrong hp's etc).

* DB\Misc: Fix more dberrors and remove broken\obsolete sai.

* DB\Misc: Fix some dberrors.

* Core\Opcodes: Remove double opcode.

* Revert "Core\Opcodes: Remove double opcode."

This reverts commit 5b0a3e0636ac79004f7ab744df9f68e9913066ca

* Merge branch 'master' of https://gitlab.com/Varjgard/bfacore

* Fixed clam loot templates to address bugtracker ID's 2, 7 and 8

* Core\Opcodes: Remove double opcode.

* Fix some DB errors and change wrong tc_log_error types to tc_log_info.

* Added OPCODE's to get guild bank working so items can be added/removed. Verified log is also working for items deposit/withdraws

* Core/Spells: Fixed Mastery:Ignite

* Creature aura fixes

* DB\Base: Update database to BFADB_2020_09_12 and archive old updates.

* Core\Config: Update worldserver.conf.dist.

* Core/Defines: Enum PowerColorOverride

* Fixed fishing loot in Stormwinf City, Elwynn Forest, Ironfoge City and Dun Morogh zones.

* DB\Misc: Fix 7000+ dberrors.

* DB\Hotfixes: Fix all hotfix db errors (remove data from hotfix db that is already loaded from db2).

NOTE: Delete "wow\retail_\cache" folder!

* DB\Dungeon: Add Ny'alotha graveyard and ".tele Nyalotha".

* remove temp file

* DB\Misc: Fix toldagor first boss scale etc.
DB\Spawns: Fix some spawn guids from old sql updates (drop and re-import full world db...).
DB\Factions: Fix some more factions on old updates....
DB\Base: Update world db to BFADB_2020_09_11 and archive old updates.

* DB\Word: Quest Evacuate the Merchant Square

* DB/World: Added Mechagon spawns & areatriggers

* DB\World: Quest Break Gong (Pandaren starting zone)

* Update siege_of_boralus.h

* Merge branch 'master' of https://gitlab.com/Varjgard/bfacore

* Core/Scripts: Fixed event Corrupted Gold spawning

* Core\Scripts: Add SiegeOfBoralus instance scripts (needs db work).

* DB\Base: Update database to BFADB_2020_09_10 and archive old updates.
DB\Misc: Fix 10000+ factions (caused by a bad commit on sql updates. drop your world db and re-import it.)
DB\Misc: Fixed factions also on sql\old\updates.rar.

* DB\Misc: Clean world sql folder and add hotfix updates.

* Core/Scripts: Fixed Rezan compile error

* DB\World: [Quest] The Sun Pearl (Pandaren starting zone)

* Now the boss razan when he dies launches boss conversation yazma with the history of ataldazar

* Fixing a typo

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore into master

* Added Blizzlike Introductory Conversation of Boss Yazma in Dungeons Bataldazar

* Fixed dead frostmane troll so they are properly dead :)

Addresses bug report #19

* Fixed incorrect spawn for Glenn Greymane in Stormwind Keep. H is no longer hostile to Alliance players

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore

* Add missing spawn Marshal Gryan Stoutmantle in Westfall

* DB\World: Quest Evacuate the Merchant Square (missing .sql file extension :P )

* DB\World: Quest "Evacuate the Merchant Square"

* DB\World: NPC 7Legon Magus (fix faction)

* Update 2020_09_04_world_fix_portalroom_stormwind.sql

* DB\World: Fix Portal Room Stormwind

* Fixed typo

* Added more pickpocketing_loot & skinning_loot to BfA zones

* Added gameobject_loot, skinning_loot and pickpocketing_loot to all BfA zones

* Fixed Fear No Evil quests to address bug report ID#263

* DB\Base: Update database to BFADB_837_2020_09_06 and archive old updates.

* Fix sql error.

* Added quest_starter, quest_ender, npc_vendor and creature_model_data for BfA zones.

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore into master

* Core\Scripts: Fix mardum phase 169 (should be active always).

* Add SoloCraft custom script module. This adjust player stats for dungeon/raids based on party size. Disable by default in worldserver.conf.

* Core\Misc, DB\Misc. lot of fixes.

* Hotfixes 8.3.7.35662
* Fix motherlode mytic+ loot
* Fix motherlode last boss count
* Fix spell pet warlock and scriptmgr
* Fix get scenario by id
* Fix areatrigger error, add missing data to creature
* Fix mutilate and Backstab
* missing scripts
* rewrite dalaran legion
* script class hall
* add some opcodes
* Fix some creature scaling level 200+
* Uldir: Scriptloader
* Uldir: Fetid Devourer base
* Uldir: Mother base
* Uldir: Taloc base
* Uldir: Update uldir.h
* The MOTHERLODE!! Creature Loot
* Siege Of Boralus Creature Loot
* Fix errors and DB errors
* Warrior Fix Spell 5246 Intimidating Shout
* Shaman Fix Spell 5394 Healing Stream Totem
* Hunter: Fix Spell 34026 Kill Command
* Fix error in spell validation:_SpellScript::ValidateSpellInfo: Spell 65219 does not exist.
* Fix error in spell validation:Spell `100`
* Fix error in spell validation:Spell `100`
* Fix error in spell validation:Spell `2823`
* Fix error in spell validation:Spell `36554`
* Fix error in spell validation:Spell `31790`
* Fix error in spell validation:Spell `49376`
* Fix error in spell validation:Spell `82828`
* Fix error in spell validation:Spell `79830`
* Fix error in spell validation:Spell `102417`
* Fix error in spell validation:Spell `100950`
* Fix error in spell validation: _SpellScript::ValidateSpellInfo: Spell 65219 does not exist. Spell `193549` Spell `195457` Spell `195457` Spell `198304` Spell `198304` Spell `198337` Spell `198337` Spell `198758`

+ lots of other fixes.

* Fix hero callboard Stormwind

* DB\Instance: Spawn toldagor in normal, heroic and mythic difficulties. + fix all phases.

* DB\Spawns: Add more data to Nazjatar.

* DB\Spawns: Add more gameobjects and creatures to Nazjatar.

* core/ missing constant to fix wod garrisson, war campaign and class halls

* clean

* Core\Misc, DB\Misc: Nazjatar starting questline (alliance).

fix quest 56031 - The Wolf's Offensive
fix quest script for quest 42769 - the old knight
fix quest 56043 - Send the Fleet
fix quest 55095 - Upheaval
add ".tele Nazjatar"

* Update 2020_08_30_01_world_Toldagor_spawns_etc.sql

* DB\Misc: Update toldagor sql.

* Merge branch 'master' of https://gitlab.com/Varjgard/bfacore

* Fix syntax 2020_08_31_01_creature_model_data.sql

* DB\Misc: Add TolDagor graveyard.

* Core/ script scene

* ..

* move file

* DB/Creature: Creature model data 8.2

* Updated faction, npcflag and npc_vendor table for Nazjatar

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore

* DB\Misc: Add TolDagor spawns etc.

* DB\Misc: Add Nazjatar spawns.

* Nazjatar questender and starter

* Fix starting quests for Nazjatar, add correct quest adding as soon as the player hits lvl 120

* Update allowed build to 8.3.7.35662.

* Core\Scripts: Fix AtalDazar crash.

* mod scriptloader

* Core/ starting work of boss taloc

* Corrected script linking

* Removed unused spell scripts

* Removed unused spell scripts and adjusted already existing ones with wrong id's

* Removed unused spell scripts from priests.

* Merge branch 'master' of https://gitlab.com/Varjgard/BfaCore

* Core\Commands: Fix crash when ".mod currency" is used without an amount.
(who the fuck wrote this shit originally? hahaha :D )

* Core\Scripts: FreeHold crash temp fix.
needs a rewrite on:
boss_ring_of_booty.cpp
boss_council_o_captains.cpp
boss_harlan_sweete.cpp

**Varjgard** · 10-28-2020

UPDATE:

Greetings everyone.

Donator repack got updated to version 2020_10_28.

BfaCore 8.3.7 Free Repack:
Free repack is not updated, no bug fixes, no support.
Advertisement on login, limited to 3 players.
Updates and bug fixes are available only to donator repacks.

BfaCore 8.3.7 Donator Repack:
Donator Repack will get all the latest fixes and updates.
No advertisements, no player limits.
Minimum donation is 25€ for donator repack (1 time donation).

ShadowCore 9.0.1 Donator Repack:
-Not released yet-

-BfaCore Team

Join our discord channel for downloads and updates, and donate to get even more!

-BfaCore Discord-
-Make a PayPal Donation-

-BfaCore Team

Changelog:

Code:

BfaCore 8.3.7 Donator Repack 2020_10_28.
Complete changelog after Free Repack was released on 2020_10_01.
None of these changes are on free repack.
----------------------------------------------------------------

* Core/AlliedRaces: Info about Allied Races cinematics

* Core/CharacterHandler: Fix Allied DK intro scene

* DB/TerrainSwap: Delete Uldum terrain swapping which isn't working

* Core/AlliedRaces: Fix Allied DK intro scene

* Core/CharacterHandler: Fix mistake

* Core/CharacterHandler: Use script package instead of PlayScene to play scene for Allied Races + Fix Allied DK scene

* Core/AlliedRaces: Delete some cinematics

* DB\Base: Update database to BFADB_837_2020_10_27 and archive old updates.

* DB/AlliedRaces: Correct start positions for 'new' Allied Races

* Core/Quest: Out Like Flynn

* DB/Spells: Frozen Orb

* Fix syntax in sql/updates/world/2020_10_23_09_fix_playercreateinfo_action_monk.sql

* Changed rename table to create new table and transfer data

* Revamp the profession trainers.

Removed the legacy npc_creatures table use.
Switched over to the creature_trainer.
Trainers are now assigned a trainerid and menuid. These id's are then used with the trainer and trainer_spell tables for the greeting and the skills/spells they have to teach. This means that for a group of trains that all have the same skills/spells to available, only a single listing of the skills/spells is needed as each trainer can be assigned to the same trainerid.
* Core/AlliedRaces: Handle Dark Iron Dwarf intro

* Core/AlliedRaces: Handle Dark Iron Dwarf intro

* Fix for syntax in sql/updates/world/2020_10_23_10_fix_playercreateinfo_action_druid.sql

* DB/World: Fix Death Knight Action Bar on new char creation

* DB/World: Fix Druid Action Bar on new char creation

* DB/World: Fix Monk Action Bar on new char creation

* DB/World: Fix Warlock Action Bar on new char creation

* DB/Spells: Assign Shadowbolt script (Affliction)

* Core/Spells: Shadow Embrace

* Core/Spells: Cataclysm

* Core/Spells: Soul Fire

* Core/Spells: Eradication

* DB/SAI: Combat scripts Uldir & Eternal Palace

* DB/World: Fix Mage Action Bar on new char creation

* DB/World: Fix Shaman Action Bar on new char creation

* DB/World: Fix Priest Action Bar on new char creation

* DB/World: Fix Rogue Action Bar on new char creation

* DB/World: Fix Hunter Action Bar on new char creation

* DB/World: Fix Paladin Action Bar on new char creation

* DB/World: Fix Warrior Action Bar on new char creation

* DB\World: Delete custom vendor.

* DB\World: Fix Quest: No Better Than the Zombies
Fix issue: https://www.bfacore.com/d/220-quest-no-better-than-the-zombies
* Core/Creature: Rewrite prehistoric script for quest Fear No Evil

* DB/Quest: Fear no Evil

* DB\World: Fix Quest Fizzled (Quest_ID: 25260)
Close issue: https://www.bfacore.com/d/224-quest-bug-fizzled
* Core/Defines: Enum Currencies

* Core/Transmog: Add remaining hidden appearances (tc cherry-pick).

* Core/Pet: Calculate Chi-Ji base melee damage

* Core/Spells: Rising Mist

* DB/Spells: Assign Essence Font

* Core/Spells: Essence Font

* Core/Spells: Mystic Touch

* Core/Linux Fix Linux build yet again

* DB\Hotfixes: Final hotfixes for 35662 from tc.

* Fix compile

* Core/Spells: Awakening, Register

* Core/Spells: Awakening

* DB/Hotfixes: Update hotfixes to final 35662. (tc cherry-pick)

* Fix syntax on 2020_10_20_fix_rigor_mortis.sql

* DB/Spells: Fix Rigor Mortis on new Undead char creation (thx Damieninabox)

* Core/Spells: Judgment of Light

* Core/Pet: Fix attack speed of pets

* Core/Spells: Define Ring of Peace knockback

* DB\Base: Update database to BFADB_837_2020_10_19 and archive old updates.

* DB/Spells: Assign Ring of Peace

* Core/Spells: Ring of Peace

* Core/Spells: Soothing Mist casted by statue will now properly target owner's target

* DB/Creature: Jade Serpent Statue

* Core/Spells: Despawn Jade Serpent Statue if owner change spec

* Core/Spells: Soothing Mist

* DB/Quests: Finding a Foothold, For the Aliiance! Kill whitespace

* Core/Areatrigger: Set custom id range

* Core/Areatrigger: Areatrigger visuals are now properly removed together with areatrigger

* DB/Quests: Finding a Foothold, For the Aliiance!

* Core/Scripts: For the Alliance!

* Core/Scripts: Finding a Foothold

* Core/Spells: Darkness

* DB\Hotfixes: Item 23472 - Rugged Trappers Boots.

* DB\Hotfixes: Fix syntax on 2020_10_18_00_quest_missing_itemes_errorlogs.sql

* DB\Hotfixes: Fix data on 2020_10_18_00_quest_missing_itemes_errorlogs.sql

* DB\Misc: Move update to right database.

* Core/Garrison Implement GarrisonSwapBuildings opcode without handled more search needed

* DB\World: Creature scripts

* DB\Hotifx: Fix quest errors with missing items from db :P

* Core\Scripts: Clean a little. :)

* Core\Scripts: Final adjustment to "onlegionarrival".

* Core\Scripts: Fix check on "onlegionarrival".

* Core\Script: Adjust "onlegionarrival" for demonhunters.

* Core\Scripts: Handle OnLegionArrival correctly for demonhunters.
(block OnLegionArrival script in dh starting areas if questline is not finished enough).
* DB\World: Mardum spirit healer.

* Core\Scripts: Destroy "legion banner - gob 259043, 250560" for player after use (block multiuse).
Core\Scripts: Destroy "legion communicator - gob 244439, 244440" for player after use (block multiuse).

NOTE TO DEVS:
gameobject_template "type 10" "data20" is broken (questobject multiuse 1\0).
* DB\World: Fix all mardum boss stats.

* DB\World: Fix all mardum quest objective texts to blizzlike.

* DB\Hotfixes, DB\World: TC Bruteforce 35662.

DB: 35662 zhTW bruteforce
DB: 35662 zhCN bruteforce
DB: 35662 ptBR bruteforce
DB: 35662 koKR bruteforce
DB: 35662 itIT bruteforce
DB: 35662 frFR bruteforce
DB: 35662 esMX bruteforce
DB: 35662 esES bruteforce
DB: 35662 deDE bruteforce
* Added a more scripts, mostly creature, to the db.

Also consolidated duplicate scripts in several files.
* Few small fixes in stonetalon moutains

* DB\World: Remove broken and obsolete sai. and fix bpet sql syntax.

* Core/BattlePet Reverse Ability

* Core/Packets Scripts Update Instance Encounter Packets and implement it

* Added many creature and spell missing scripts to the db

* typoooos

* DB\World: Clean database from obsolete quests.
all of these quests have been removed from world of warcraft in previous expansions.
trinity added them to "disables", but they are just waste of space in reality.
(all of these are obsolete quests removed by blizzard.)
* DB\World: Update 2020_10_17_01_world_delete_obsolete_quests.sql

* DB\World: dberror fixes for broken conditions.

* Core/Creature: Script Dread Admiral Tattersail to allow players set sail to BfA zones

* DB\World: dberror fixes.

* ...

* typo

* DB\World: update 2020_10_17_01_world_delete_obsolete_quests.sql a little.

* DB\World: Delete obsolete quests that give error and have been removed from game.

* DB/Creature: Dread-Admiral Tattersail

* QuestID: 26464 The Lost Gem - fixes issue for quest item dropping even if you do not have the quest.

* Fixed a couple typos that were causing an issue.

* DB\World: Fix all rest of the model errors. manually from wowhead :D

* DB\World: add TC 35662 bruteforce data to db, cleaned poi errors after that, fix syntax on 2020_10_16_00_cleanup_error_log_invalid_creatures.sql.

* DB/WarCampaign: Dark Iron Mole Machine

* DB\World: Modify 2020_10_16_00_cleanup_error_log_invalid_creatures.sql
(3300000000000000 are mechagon spawns so we cant delete them, they are working on bfadb.)
* Git please, don't do it.

* Core/WarCampaign: The Fury of the Zandalari

* DB/WarCampaign: The Fury of the Zandalari

* DB\World: Cleanup error log for invalid creatures spawn (not spawned actually cuz they don't exists :P )

* Fixes for warrior spells Devastate and Frothing Berserker

* Fix warrior spell Odyns Fury (Warrior only weapon)

* Fixes for the warrior spells Sudden Death and Victorious

* DB\World: Creature display models - Laur.

* DB\World: Fix inhabittype on Stormwind Gryphon Rider.

* COre\Scripts: Comment out 2 crashes from "freehold" dungeon. (these scripts on freehold are shit, full of crashes).

* DB\World: dberror fixes.

* Fixes for the following warrior spells.

Shield Slam
Sword and Board
Bloodbath
Shield Block
* DB\World: Nazjatar Graveyards (all) Added World Safe Locs (In case some one have them missing. Also delete the one created by Varjgard) + Fix Typo (again.. silly me :D )

* DB\World: Nazjatar Graveyards (all) Added World Safe Locs (In case some one have them missing. Also delete the one created by Varjgard)

* DB\World: Nazjatar Graveyards (all) Fix typo :P

* DB\World: Graveyards Nazjatar (all of them) :P

* DB\World: Dberror fixes.

* Update 2020_10_15_00_world_nazjatar_graveyard.sql

TODO: add graveyard to both factions, this sql is set so that both factions tele to allied side when dying.
* DB\World: Nazjatar gameobject_template entries.

* DB\World: Nazjatar creature and gameobject spawns. danke für damien für sniffs.

* DB/War Campaign: The Fury of the Zandalari 8.1
DB/War Campaign: Lost Honor 8.1
* DB/War Campaign: The Fury of the Zandalari 8.1
DB/War Campaign: Lost Honor 8.1
* DB\World: Allied DK graveyard.

* DB\World: Nazjatar graveyard.

* Core\Scripts: Add Nazjatar alliance intro movie (quest Send the Fleet 56043).

* DB/Conditions: Remove not-working Darkshore terrain swap

* DB/Creature: Assign Grand Admiral Jes-Tereth scriptname

* Core/Creature: Script Grand Admiral Jes-Tereth to allow players set sail to BfA zones

* DB/Quests: Wrath of the Zandalari, fix chains (Thanks to Damien)

* Core/Misc: Revert back to using boost::regex, std::wregex doesn't work for name validation.
(tc cherry-pick)
* Core/battlepet implement EffectGrantBattlePetLevel

* Core/Spells: Shattered Souls, final form

* Core/Spells: Shattered Souls - Healing below pct hp 100

* DB/Spells: Cleanup of spellscripts which we don't need anymore

* Core/Spells: Shattered Souls

* Revert "DB\World: Fix Fishing profession."

This reverts commit 528baf90e6d59264c8d208ec1211b11766ebca18
* DB/Creature: Translate Toki's text to English

* DB\World:Fix Portal spells Stormwind

* Core/Quest: Ride of the Zandalari, improve scripts and finish

* DB/Creature: Some random fixes for Nazmir

* DB\World: Fix Fishing profession.

* Core\Battleground: Fix signed\unsigned mismatch warning.

* DB/BattlePet Fix learn spell revive battle pet

* Core/packet implement SMSG_BATTLEGROUND_POINTS structure

* Core/packet Implement SMSG_BATTLEGROUND_INIT and fix Mistake structure WargameRequestSuccessfullySentToOpponent

* Core/Packet implement CMSG_QUERY_COUNTDOWN_TIMER

* Core/Battlepet Rewrite battlepet_npc_team_member

* DB\Base: Update database to BFADB_2020_10_12 and archive old updates.

* DB\World: Add Vault of wardens graveyard zone and ".tele vaultofwardens".

* DB\World: Adjust mardum and VoW mana stats and fix fel lord caza stats.
TODO: adjust stats of all mardum and VoW bosses with "fel lord caza" query template.
* DB\World: Fix mardum cryptic hollow invisible npcs attacking player.
(they had just invisible aura).
* DB\World, Core\Unit.

DB\World: Fix npc hp and damage on mardum and VoW.
DB\World: Engineering trainer fixes.
Core\Unit: Clean "Void DealDamageMods" and "Void DealDamage".
Core\Unit: Remove legacy buff... it is legacy, just like the shit script.
* DB/Creature: Creature texts for Trade Prince Gallywix, used in Opulence encounter

* DB/Quest: Ride of the Zandalari
Corrected creature templates, weren't updated
Fixed gossip data
Fixed spawns
* DB\World: Fix battlepet_npc_team_member missing columns.
DB\World: Revert mardum npc damage fix (i will push something more permanent today, it is the whole world, not only mardum).
* DB/Creature: Model data (Damien)

* Core/LFGList rewrite LowType Guid to getcounter

* Core/Fix send cinematic on first login

* DB/Update allied race to 8.3.7

* Core/Script, update allied race to 8.3.7

* DB/Creature: Assign scriptname for Captain Rezokun

* Create 2020_10_11_04_update_battle_pet_data.sql

* Core/Fix cleanup and fix OpenAlliedRaceDetails GOSSIP

* Core/Quest: Enum Send the Fleet, Ride of the Zandalari

* DB/Creature: Captain Rez'okun gossip menu option

* Core/Quest: Script Captain Rezokon for quest Send the Fleet, including movie and first part Ride of the Zandalari

* DB/AlliancePortalRoom: Update phases by areaID

* DB/AlliancePortalRoom: (Thanks Damien for sniffs)
Cleanup old stuff
Adjust guids
Corrected UNKNOWN columns
Corrected Creature templates
Corrected Creature models
* Core/Cleanup & set actif SMSG_ALLIED_RACE_DETAILS ... mistake?

* Core/GameTable fix loading

* Core/Update Verify/Rename adventure map poi packet

* DBError.log Creature_loot_template fixed.

* Core/Cleanup in PrepareGossipMenu

* Core/LFGList small update and cleanup

* Core/cleanup

* DB/Mardum: Creatures there should deal to players +- 50% reduced damage (i checked some retail videos)
Note: It's not definitely blizzike fix :P
* Core/Debug AdventureJournal

* Core/update bg code and set unhandled SMSG_REQUEST_SCHEDULED_PVP_INFO_RESPONSE opcode (he's not coded correcly)

* Core/PacketIO Implement correcly wargame packets

* Core/Opcode Set status unhandled where Handle_NULL

* Core/Cleanup Group finder work now correcly

* Core/ fix load db2

* DB/Creature: Assign missing scriptname for Dreadstalkers

* Core/Spells: Update at id for Freezing Trap

* DB/Spells: Assign Freezing Trap

* DB/Spells: Assign script for Lingering Insanity

* Core/Spells: Lingering Insanity

* Core/DB2 Fixed 6 db2 structures loading

i test it before push total commit
* More quest ender fixes.

* Many fixes for quest starters/enders

* DB/Spells: Fix some Feral spells learning when you switch spec

* Core/Spells: Call Dreadstalkers

* DB/Creature: Assign Wild Imp script

* Core/Spells: Wild Imp is now scaled based on caster's hitpoints

* Core/Spells: Void Reaver
Force target to get base points directly from spell effect
* DB/Spells: Assign Void Reaver

* Misc. dberror.log fixes.

* More creature_loot_template fixes

* Core/BattlePet temporary fix battlepet delete pet

* Core/update guild challenge system work & flags for rename is implemented

* Core\Typo: Fix linux build (again :P) damn linux CasESensiTive :D

* Core/PacketIO update/Remove duplicate function in guild challenge update

* CORE/Datbase Fix my mistake, sorry

* Core/Implement Guild Invite Declined

* Core\Typo | Fix linux build again :P

* Core/Implement Guild Shift Rank and update code for opcode SMSG_GUILD_EVENT_RANKS_UPDATED

* Core/Implement Guild flag for rename

* Core/PacketIO Implement Guild Change Name opcode

* Core/Quest: Speaker of the Horde, hardcode and fix another parts of the quest to core

* Core/Quest: Speaker of the Horde, fix movement, gossip flag, crash

* Core/Typo: Fix Linux build

* Core/Quest: Rastakhan, fix killcredit, scene, blackscreen

* Core/Quest: Rastakhan, fixed escortAI

* Core/Quest: Fixed quest Welcome to Zuldazar

* Core/Scenario: Improve Stormwind Extraction skip a little

* DB/Spells: Assign some mage scriptnames and data

* Core/Spells: Update at id for mage meteor

* More creature_loot_template fixes

* Many more creature_loot_template fixes

* Model fixes by Damieninabox

* Many creature_loot_template fixes

* Core/Spells: Searing Touch

* Core/Kezan: Goblins can leave Kezan now and are bound to Lost Isles

* Core/PacketIO update SMSG_NEUTRAL_PLAYER_FACTION_SELECT_RESULT

* Core\Opcodes: SMSG_INTERRUPT_POWER_REGEN

* DB/Creature: Prevent Darnell to be attackable

* Core/Kezan: Goblins can leave Kezan now and are bound to Lost Isles

* DB\World: Fix Quest In the blink of an Eye (Quest ID: 44663)

* DB\World: Object (Portal to Orgrimmar)

* DB\ModelData: add 107 models to db. (By DamienInABox).

* Core\Scripts: Move "onarrival" temp fix scripts to proper place.

RegisterPlayerScript(OnLegionArrival); // TEMP FIX! Quest 40519 and 43926 - "legion returns". remove it when legion start quests are properly fixed.
RegisterPlayerScript(On110Arrival); // TEMP FIX! Quest 43341 - "uniting the isles".
RegisterPlayerScript(OnBfaArrival); // TEMP FIX! remove it when lordaeron battle is properly fixed.
* CoreScripts: Fix npc_eoa_call_the_seas::npc_eoa_call_the_seas_AI::UpdateAI crash.

* Core\Spells: Fix spell_rog_saber_slash::HandleOnHit crash.

* Core\Functions: Remove broken "HandleOverrideZonePVPType" and implement "HandleModOverrideZonePVPType".

* Core\Functions: Implement "bool IsPvPRealm()".
Core\Players: Corrected logic determining contested/friendly/hostile area types. (TC cherry-pick)
* Core\Handlers: Fix BattleGroundHandler.

* Core\Opcodes: Fix, rename, and add opcodes for 8.3.7. :)
* Core/PacketIO: Renamed a bunch of opcodes based on more research (only those added after 6.0)
https://github.com/TrinityCore/TrinityCore/commit/f922c6e7a46a7c712daaaef9b1a72ca865fbe94b
https://github.com/TrinityCore/TrinityCore/commit/1d04d5859a59caf286d71f78a18ec4ed05feb7c2
* More dberror.log fixes (loot templates)

* More dberror.log fixes (quests)

* Continuing the dberror.log fixes campaign

* Core/Opcode Rewrite QueryQuestReward to QueryTreasurePicker World Quest rework after complete first quest

* Various DBError.log fixes.

* DB\Loading: Fix 27000+ loading errors.

* DBError.log fixes. Cleaned up lots of abandoned entries in creature_template_addon table

* Core\Scripts: Fix operation mechagon file names.

* Core\Script: Fix operation mechagon build error.

* Fix sql syntax.

* Core/Operation Mechagon: Rename header

* DB/Operation Mechagon: Assign instance script

* Core/Operation Mechagon: Scriptloader

* Core/Operation Mechagon: Tusle Tonks

* Core/Operation Mechagon: Trixie && Naeno && Mechacycle

* Core/Operation Mechagon: KUJO

* Core/Operation Mechagon: King Mechagon

* Core/Operation Mechagon: HK8

* Core/Operation Mechagon: Head machinist Sparkflux

* Core/Operation Mechagon: Instance

* Core/Operation Mechagon: Gunker

* Core/Operation Mechagon: King Gobbamak

* Core/Operation Mechagon: Header

* Rename Mechagon to Operation Mechagon

* DB/Dungeon: Operation Mechagon
Flags
Texts
Creature AI
Loot
Misc
* Cleaned out some abandoned gameobject_template_addon records.

* Spell fix. Druid Maul spell# 6807

* DB\Base: Merge missing data, revert some dberror fixes, update bases.
* Merge missing data from 837 TDB (411 quests, creatures, gameobjects etc...).* Fix old world dberror fixes from 2020_08_06-2020_09_17 (removed all mass "deletes" and kept only "updates" and "fixes").* Update database to BFADB_2020_10_03 and archive old updates.

I will start again the dberror fixes.
This time only obsolete\bad data will be removed from database, rest of the errors will be fixed properly.

NOTE:
Drop your world db and hotfixes db, and import fresh base sql files from sql\base.
* Core\Misc:

change tc_log_debug to tc_log_error on hotfix_blob, we need that info for db fixes.
change tc_log_info to tc_log_error on gametables.cpp, we need that info for gt structure fixes.
fix datatype warning on creature.cpp (int\uint).
* typo

* DB\Misc: Rename some npcs with "0" as name.

* DB/WQ: Removed wq 51581, causing worldserver to stuck for eternity

* Fix battlepay locale loading

* DB\World: Fix spell Consecreation (by Splose) + added some missing queries :P

* DB\World: Fix spell Retribution (By Splose)

* DB\World: Fix spell Blizzard - Mage (by Splose) also a fix file extension (pardon me :P )

* DB\World: Fix spell Blizzard - Mage (By Splose)

* DB/Fix load battlepey display info

* Core/Big update for implement bases groupFinder, somes modifications of battlepay, rewrite somes Opcodes

* Core/Areatrigger: Prevent custom areatriggers to be removed from the world after one 'use'

* Core/SmartAI Fix Void function

* Core/SmartAI: allow SMART_ACTION_SEND_GOSSIP_MENU to override default gossip

* Core/BattlePet Fix show level of battle pets

* Core/Freehold: Removed unneeded lines, causing also crashes

* update bugtracker address.

* Core\Misc: discord ad

**Varjgard** · 11-09-2020

Hello everyone.

Since some idiots want to share latincore source as bfacore, i made a repo from the "leak".

it is open-source, same as the latincore one, it is not bfacore.

feel free to download it

-BfaCore Discord-
-Make a PayPal Donation-

-Varjgard

Varjgard / BfaCore_old_leak . GitLab

**Varjgard** · 11-11-2020

Hello everyone.

We have battle for azeroth sniffer + parser for sale.
Works on private servers.

price: 20€

send me a private message on discord if you are interested.

-BfaCore Discord-
-Make a PayPal Donation-

**Varjgard** · 11-11-2020

UPDATE:

Greetings everyone.

Donator repack got updated to version 2020_11_11.
(Free Repack got 1 crash fix and database structure change, not compatible with old free repacks!).

NOTE: DONATOR DOWNLOADS CHANGED BACK TO MEDIAFIRE, GITLAB HAS TOO MANY LIMITS.

BfaCore 8.3.7 Free Repack:
Free repack is not updated, no bug fixes, no support.
Advertisement on login, limited to 3 players.
Updates and bug fixes are available only to donator repacks.

BfaCore 8.3.7 Donator Repack:
Donator Repack will get all the latest fixes and updates.
No advertisements, no player limits.
Minimum donation is 25€ for donator repack (1 time donation).

ShadowCore 9.0.1 Donator Repack:
-Not released yet-

-BfaCore Team

Join our discord channel for downloads and updates, and donate to get even more!

-BfaCore Discord-
-Make a PayPal Donation-

-BfaCore Team

Changelog:

Code:

BfaCore 8.3.7 Donator Repack 2020_10_01-2020_11_11.
None of these changes are on free repack.
----------------------------------------------------------------

---2020_11_11---

* DB\World: dberrors.

* Core/Scripts: King Mechagon failcheck

* Core/Criteria: Crash

* DB\World: dberrors.

* Core/Defines: Define BfA raid maps

* typo

* Core\Scripts: add some todo comments to zone_vault_of_wardens.cpp.

* DB/Misc: Some Bugtracker reports

* Core/Scripts: Fix crash in boss Setesh

* Core/Quest: Breaking Out stuck fix

* Core/Movement: MoveForward

* Core/Movement: Define MoveForward

* DB/Misc: Removed outdated and duplicate spawns in Orgrimmar

* DB/Loot: Brood Queen Tyranna

* Mining Supply Vendors fix
Mining Trainers fix

* Very minor fix to keep mysql happy

* DB/Misc: I will need eyeglasses soon

* DB/Misc: Fix

* DB/Misc: Fix LFR spawns

* DB/Instance: Fill all instance encounter data for Nyalotha

* Core/Scripts: Wrathion
Fix Incineration
Fix some crackling shards bugs during phase 2
Fix Wrathion during phase 2
Fix all timers
Fix Gale Blast
Fix Creeping Madness

* Core/Scripts: Nyalotha header

* DB/Spells: Assign Smoke and Mirrors

* Core/Spells: Define Priest spells which needs to be scripted

* DB/Spells: Assign Holy Word: Serenity

* Core/Spells: Holy Word: Serenity will now reduce cooldown of Holy Word: Salvation by 30s, update code standards too

* Core/Spells: Holy Word: Sanctify will now reduce cooldown of Holy Word: Salvation by 30s, update code standards too

* DB/Spells: Assign Holy Word: Salvation

* Core/Spells: Fix Holy Word: Salvation, renew part

* Core/Spells: Define Priest spells which needs to be scripted

* Core/Spells: Fix Twist of Fate proc

* Core/Spells: Fix crash in DK set T17 Frost 4p driver and update to current code standards

* DB/Creature: Wrathion texts related to encounter

* DB/Creature: Two-Shoed Lou, Vanessa Lightning Stalker

* Core/Defines: Define Map Nyalotha

* Coldridge Zone Quest Fixes.
*Quest: A Trip to Ironforge
*Quest: Follow that Gyro-Copter!
*Quest: Pack Your Bags
* Coldridge zone overhaul.
*Added proper quest objective item descriptions and flags
*Updated every creature loot table
*Fixed vendors
*Fixed Battered Chest loot tables and spawns
*Added quests 24496/arcane-rune and 31150/elegant-rune
*Set auras for Milo's Gyro so it is not visible until on the quest 24491/follow-that-gyro-copter

* Core/Defines: Enum Pathfinder spells

* DB/Misc: Assign scriptnames for Uldir and corrections

* Delete 2020_11_01_00_fix_quest_fear_no_evil.sql

* DB\World: Fix QuestPOI 24980
Close issue: https://www.bfacore.com/d/413-the-scarlet-palisade-quest

* DB\World: Fix QuestPOI 24979
Close issue: https://www.bfacore.com/d/414-a-scarlet-letter-quest

* Fixed all profession starter skills.

Upon learning a profession you are provided the starter recipes if applicable.

* DB\World: Fix QuestPOI: QuestID: 935
Close issue: https://www.bfacore.com/d/366-the-waters-of-teldrassil-quest

* DB\World: Fix QuestPOI 28731
Close issue: https://www.bfacore.com/d/361-teldrassil-passing-awareness-quest

* DB\World: Fix Vendor - Nyoma <Cooking Supplies> - Dolanaar (CreatureID: 4265)
Close issue: https://www.bfacore.com/d/363-nyoma-cooking-supplies

* DB\World: Fix Cooking Trainer Zarrin (Dolanaar) (needs improvements)
Close issue: https://www.bfacore.com/d/362-zarrin-cooking-trainer

* DB\World: Fix Creature 32972/Quest 13520
Close issue: https://www.bfacore.com/d/381-the-boon-of-the-seas-quest

* DB\World: Fix Quest POI (Quest: 923)
Close issue: https://www.bfacore.com/d/367-mossy-tumors-quest

* DB\World: Fix Mining Trainer Periale (Lor'Danel)
Close issue: https://www.bfacore.com/d/370-periale-mining-trainer

* DB\Word: Fix Fishing Trainer from Stormwind
No issue reported but it was broken :P

* DB\World: Fix Fishing trainer from Darnassus
Close issue: https://www.bfacore.com/d/371-astaia-fishing-trainer

* DB\World: Fix Quest POI (Quest 483)
Close issue: https://www.bfacore.com/d/368-the-relics-of-wakening-quest

* DB\Word: Fix Gossip Menu Undercity Guards (converted from 3.3.5a :P)
Close issue: https://www.bfacore.com/d/307-general-undercity-guards-does-not-provide-map

* DB\World: Quest: Fear No Evil

* Core/Spells: Guardian Spirit

* Core/Spells: Holy Nova

* DB/Misc: Another Uldir corrections and some bugtracker reports

* Core/CharacterHandler: Another cinematic conflicts

* Missing gossip and trainer id info for Battle Pet Trainers. This prevented them from working with the new trainer system. Had to re-implement the old npc_trainer functionality so Battle Pet Trainer could train. Until we get sniffed data the old system will need to stay in place.

* DB/Misc: Some Uldir corrections

* DB\World: Fix artifact and heirloom vendors.

* Core\Scripts: Rescript nazjatar 120 start quests and move to proper place.
Core\Scripts: Move Worgen Running Wild spell fix to proper place.

* DB/Misc: Assign missing Vectis spells and some corrections for encounter related creatures

* DB\World: Dungeon Forge of Souls Creature PhaseId fix
Close issue: https://www.bfacore.com/d/301-doungen-the-forge-of-souls-bug

* DB/Creature: A little cleanup in Zul encounter space

* Core/AlliedRaces: Info about Allied Races cinematics

* Core/CharacterHandler: Fix Allied DK intro scene

* DB/TerrainSwap: Delete Uldum terrain swapping which isn't working

* Core/AlliedRaces: Fix Allied DK intro scene

* Core/CharacterHandler: Fix mistake

* Core/CharacterHandler: Use script package instead of PlayScene to play scene for Allied Races + Fix Allied DK scene

* Core/AlliedRaces: Delete some cinematics

---2020_10_28---

* Core/AlliedRaces: Info about Allied Races cinematics

* Core/CharacterHandler: Fix Allied DK intro scene

* DB/TerrainSwap: Delete Uldum terrain swapping which isn't working

* Core/AlliedRaces: Fix Allied DK intro scene

* Core/CharacterHandler: Fix mistake

* Core/CharacterHandler: Use script package instead of PlayScene to play scene for Allied Races + Fix Allied DK scene

* Core/AlliedRaces: Delete some cinematics

* DB\Base: Update database to BFADB_837_2020_10_27 and archive old updates.

* DB/AlliedRaces: Correct start positions for 'new' Allied Races

* Core/Quest: Out Like Flynn

* DB/Spells: Frozen Orb

* Fix syntax in sql/updates/world/2020_10_23_09_fix_playercreateinfo_action_monk.sql

* Changed rename table to create new table and transfer data

* Revamp the profession trainers.

Removed the legacy npc_creatures table use.
Switched over to the creature_trainer.
Trainers are now assigned a trainerid and menuid. These id's are then used with the trainer and trainer_spell tables for the greeting and the skills/spells they have to teach. This means that for a group of trains that all have the same skills/spells to available, only a single listing of the skills/spells is needed as each trainer can be assigned to the same trainerid.
* Core/AlliedRaces: Handle Dark Iron Dwarf intro

* Core/AlliedRaces: Handle Dark Iron Dwarf intro

* Fix for syntax in sql/updates/world/2020_10_23_10_fix_playercreateinfo_action_druid.sql

* DB/World: Fix Death Knight Action Bar on new char creation

* DB/World: Fix Druid Action Bar on new char creation

* DB/World: Fix Monk Action Bar on new char creation

* DB/World: Fix Warlock Action Bar on new char creation

* DB/Spells: Assign Shadowbolt script (Affliction)

* Core/Spells: Shadow Embrace

* Core/Spells: Cataclysm

* Core/Spells: Soul Fire

* Core/Spells: Eradication

* DB/SAI: Combat scripts Uldir & Eternal Palace

* DB/World: Fix Mage Action Bar on new char creation

* DB/World: Fix Shaman Action Bar on new char creation

* DB/World: Fix Priest Action Bar on new char creation

* DB/World: Fix Rogue Action Bar on new char creation

* DB/World: Fix Hunter Action Bar on new char creation

* DB/World: Fix Paladin Action Bar on new char creation

* DB/World: Fix Warrior Action Bar on new char creation

* DB\World: Delete custom vendor.

* DB\World: Fix Quest: No Better Than the Zombies
Fix issue: https://www.bfacore.com/d/220-quest-no-better-than-the-zombies
* Core/Creature: Rewrite prehistoric script for quest Fear No Evil

* DB/Quest: Fear no Evil

* DB\World: Fix Quest Fizzled (Quest_ID: 25260)
Close issue: https://www.bfacore.com/d/224-quest-bug-fizzled
* Core/Defines: Enum Currencies

* Core/Transmog: Add remaining hidden appearances (tc cherry-pick).

* Core/Pet: Calculate Chi-Ji base melee damage

* Core/Spells: Rising Mist

* DB/Spells: Assign Essence Font

* Core/Spells: Essence Font

* Core/Spells: Mystic Touch

* Core/Linux Fix Linux build yet again

* DB\Hotfixes: Final hotfixes for 35662 from tc.

* Fix compile

* Core/Spells: Awakening, Register

* Core/Spells: Awakening

* DB/Hotfixes: Update hotfixes to final 35662. (tc cherry-pick)

* Fix syntax on 2020_10_20_fix_rigor_mortis.sql

* DB/Spells: Fix Rigor Mortis on new Undead char creation (thx Damieninabox)

* Core/Spells: Judgment of Light

* Core/Pet: Fix attack speed of pets

* Core/Spells: Define Ring of Peace knockback

* DB\Base: Update database to BFADB_837_2020_10_19 and archive old updates.

* DB/Spells: Assign Ring of Peace

* Core/Spells: Ring of Peace

* Core/Spells: Soothing Mist casted by statue will now properly target owner's target

* DB/Creature: Jade Serpent Statue

* Core/Spells: Despawn Jade Serpent Statue if owner change spec

* Core/Spells: Soothing Mist

* DB/Quests: Finding a Foothold, For the Aliiance! Kill whitespace

* Core/Areatrigger: Set custom id range

* Core/Areatrigger: Areatrigger visuals are now properly removed together with areatrigger

* DB/Quests: Finding a Foothold, For the Aliiance!

* Core/Scripts: For the Alliance!

* Core/Scripts: Finding a Foothold

* Core/Spells: Darkness

* DB\Hotfixes: Item 23472 - Rugged Trappers Boots.

* DB\Hotfixes: Fix syntax on 2020_10_18_00_quest_missing_itemes_errorlogs.sql

* DB\Hotfixes: Fix data on 2020_10_18_00_quest_missing_itemes_errorlogs.sql

* DB\Misc: Move update to right database.

* Core/Garrison Implement GarrisonSwapBuildings opcode without handled more search needed

* DB\World: Creature scripts

* DB\Hotifx: Fix quest errors with missing items from db :P

* Core\Scripts: Clean a little. :)

* Core\Scripts: Final adjustment to "onlegionarrival".

* Core\Scripts: Fix check on "onlegionarrival".

* Core\Script: Adjust "onlegionarrival" for demonhunters.

* Core\Scripts: Handle OnLegionArrival correctly for demonhunters.
(block OnLegionArrival script in dh starting areas if questline is not finished enough).
* DB\World: Mardum spirit healer.

* Core\Scripts: Destroy "legion banner - gob 259043, 250560" for player after use (block multiuse).
Core\Scripts: Destroy "legion communicator - gob 244439, 244440" for player after use (block multiuse).

NOTE TO DEVS:
gameobject_template "type 10" "data20" is broken (questobject multiuse 1\0).
* DB\World: Fix all mardum boss stats.

* DB\World: Fix all mardum quest objective texts to blizzlike.

* DB\Hotfixes, DB\World: TC Bruteforce 35662.

DB: 35662 zhTW bruteforce
DB: 35662 zhCN bruteforce
DB: 35662 ptBR bruteforce
DB: 35662 koKR bruteforce
DB: 35662 itIT bruteforce
DB: 35662 frFR bruteforce
DB: 35662 esMX bruteforce
DB: 35662 esES bruteforce
DB: 35662 deDE bruteforce
* Added a more scripts, mostly creature, to the db.

Also consolidated duplicate scripts in several files.
* Few small fixes in stonetalon moutains

* DB\World: Remove broken and obsolete sai. and fix bpet sql syntax.

* Core/BattlePet Reverse Ability

* Core/Packets Scripts Update Instance Encounter Packets and implement it

* Added many creature and spell missing scripts to the db

* typoooos

* DB\World: Clean database from obsolete quests.
all of these quests have been removed from world of warcraft in previous expansions.
trinity added them to "disables", but they are just waste of space in reality.
(all of these are obsolete quests removed by blizzard.)
* DB\World: Update 2020_10_17_01_world_delete_obsolete_quests.sql

* DB\World: dberror fixes for broken conditions.

* Core/Creature: Script Dread Admiral Tattersail to allow players set sail to BfA zones

* DB\World: dberror fixes.

* ...

* typo

* DB\World: update 2020_10_17_01_world_delete_obsolete_quests.sql a little.

* DB\World: Delete obsolete quests that give error and have been removed from game.

* DB/Creature: Dread-Admiral Tattersail

* QuestID: 26464 The Lost Gem - fixes issue for quest item dropping even if you do not have the quest.

* Fixed a couple typos that were causing an issue.

* DB\World: Fix all rest of the model errors. manually from wowhead :D

* DB\World: add TC 35662 bruteforce data to db, cleaned poi errors after that, fix syntax on 2020_10_16_00_cleanup_error_log_invalid_creatures.sql.

* DB/WarCampaign: Dark Iron Mole Machine

* DB\World: Modify 2020_10_16_00_cleanup_error_log_invalid_creatures.sql
(3300000000000000 are mechagon spawns so we cant delete them, they are working on bfadb.)
* Git please, don't do it.

* Core/WarCampaign: The Fury of the Zandalari

* DB/WarCampaign: The Fury of the Zandalari

* DB\World: Cleanup error log for invalid creatures spawn (not spawned actually cuz they don't exists :P )

* Fixes for warrior spells Devastate and Frothing Berserker

* Fix warrior spell Odyns Fury (Warrior only weapon)

* Fixes for the warrior spells Sudden Death and Victorious

* DB\World: Creature display models - Laur.

* DB\World: Fix inhabittype on Stormwind Gryphon Rider.

* COre\Scripts: Comment out 2 crashes from "freehold" dungeon. (these scripts on freehold are shit, full of crashes).

* DB\World: dberror fixes.

* Fixes for the following warrior spells.

Shield Slam
Sword and Board
Bloodbath
Shield Block
* DB\World: Nazjatar Graveyards (all) Added World Safe Locs (In case some one have them missing. Also delete the one created by Varjgard) + Fix Typo (again.. silly me :D )

* DB\World: Nazjatar Graveyards (all) Added World Safe Locs (In case some one have them missing. Also delete the one created by Varjgard)

* DB\World: Nazjatar Graveyards (all) Fix typo :P

* DB\World: Graveyards Nazjatar (all of them) :P

* DB\World: Dberror fixes.

* Update 2020_10_15_00_world_nazjatar_graveyard.sql

TODO: add graveyard to both factions, this sql is set so that both factions tele to allied side when dying.
* DB\World: Nazjatar gameobject_template entries.

* DB\World: Nazjatar creature and gameobject spawns. danke für damien für sniffs.

* DB/War Campaign: The Fury of the Zandalari 8.1
DB/War Campaign: Lost Honor 8.1
* DB/War Campaign: The Fury of the Zandalari 8.1
DB/War Campaign: Lost Honor 8.1
* DB\World: Allied DK graveyard.

* DB\World: Nazjatar graveyard.

* Core\Scripts: Add Nazjatar alliance intro movie (quest Send the Fleet 56043).

* DB/Conditions: Remove not-working Darkshore terrain swap

* DB/Creature: Assign Grand Admiral Jes-Tereth scriptname

* Core/Creature: Script Grand Admiral Jes-Tereth to allow players set sail to BfA zones

* DB/Quests: Wrath of the Zandalari, fix chains (Thanks to Damien)

* Core/Misc: Revert back to using boost::regex, std::wregex doesn't work for name validation.
(tc cherry-pick)
* Core/battlepet implement EffectGrantBattlePetLevel

* Core/Spells: Shattered Souls, final form

* Core/Spells: Shattered Souls - Healing below pct hp 100

* DB/Spells: Cleanup of spellscripts which we don't need anymore

* Core/Spells: Shattered Souls

* Revert "DB\World: Fix Fishing profession."

This reverts commit 528baf90e6d59264c8d208ec1211b11766ebca18
* DB/Creature: Translate Toki's text to English

* DB\World:Fix Portal spells Stormwind

* Core/Quest: Ride of the Zandalari, improve scripts and finish

* DB/Creature: Some random fixes for Nazmir

* DB\World: Fix Fishing profession.

* Core\Battleground: Fix signed\unsigned mismatch warning.

* DB/BattlePet Fix learn spell revive battle pet

* Core/packet implement SMSG_BATTLEGROUND_POINTS structure

* Core/packet Implement SMSG_BATTLEGROUND_INIT and fix Mistake structure WargameRequestSuccessfullySentToOpponent

* Core/Packet implement CMSG_QUERY_COUNTDOWN_TIMER

* Core/Battlepet Rewrite battlepet_npc_team_member

* DB\Base: Update database to BFADB_2020_10_12 and archive old updates.

* DB\World: Add Vault of wardens graveyard zone and ".tele vaultofwardens".

* DB\World: Adjust mardum and VoW mana stats and fix fel lord caza stats.
TODO: adjust stats of all mardum and VoW bosses with "fel lord caza" query template.
* DB\World: Fix mardum cryptic hollow invisible npcs attacking player.
(they had just invisible aura).
* DB\World, Core\Unit.

DB\World: Fix npc hp and damage on mardum and VoW.
DB\World: Engineering trainer fixes.
Core\Unit: Clean "Void DealDamageMods" and "Void DealDamage".
Core\Unit: Remove legacy buff... it is legacy, just like the shit script.
* DB/Creature: Creature texts for Trade Prince Gallywix, used in Opulence encounter

* DB/Quest: Ride of the Zandalari
Corrected creature templates, weren't updated
Fixed gossip data
Fixed spawns
* DB\World: Fix battlepet_npc_team_member missing columns.
DB\World: Revert mardum npc damage fix (i will push something more permanent today, it is the whole world, not only mardum).
* DB/Creature: Model data (Damien)

* Core/LFGList rewrite LowType Guid to getcounter

* Core/Fix send cinematic on first login

* DB/Update allied race to 8.3.7

* Core/Script, update allied race to 8.3.7

* DB/Creature: Assign scriptname for Captain Rezokun

* Create 2020_10_11_04_update_battle_pet_data.sql

* Core/Fix cleanup and fix OpenAlliedRaceDetails GOSSIP

* Core/Quest: Enum Send the Fleet, Ride of the Zandalari

* DB/Creature: Captain Rez'okun gossip menu option

* Core/Quest: Script Captain Rezokon for quest Send the Fleet, including movie and first part Ride of the Zandalari

* DB/AlliancePortalRoom: Update phases by areaID

* DB/AlliancePortalRoom: (Thanks Damien for sniffs)
Cleanup old stuff
Adjust guids
Corrected UNKNOWN columns
Corrected Creature templates
Corrected Creature models
* Core/Cleanup & set actif SMSG_ALLIED_RACE_DETAILS ... mistake?

* Core/GameTable fix loading

* Core/Update Verify/Rename adventure map poi packet

* DBError.log Creature_loot_template fixed.

* Core/Cleanup in PrepareGossipMenu

* Core/LFGList small update and cleanup

* Core/cleanup

* DB/Mardum: Creatures there should deal to players +- 50% reduced damage (i checked some retail videos)
Note: It's not definitely blizzike fix :P
* Core/Debug AdventureJournal

* Core/update bg code and set unhandled SMSG_REQUEST_SCHEDULED_PVP_INFO_RESPONSE opcode (he's not coded correcly)

* Core/PacketIO Implement correcly wargame packets

* Core/Opcode Set status unhandled where Handle_NULL

* Core/Cleanup Group finder work now correcly

* Core/ fix load db2

* DB/Creature: Assign missing scriptname for Dreadstalkers

* Core/Spells: Update at id for Freezing Trap

* DB/Spells: Assign Freezing Trap

* DB/Spells: Assign script for Lingering Insanity

* Core/Spells: Lingering Insanity

* Core/DB2 Fixed 6 db2 structures loading

i test it before push total commit
* More quest ender fixes.

* Many fixes for quest starters/enders

* DB/Spells: Fix some Feral spells learning when you switch spec

* Core/Spells: Call Dreadstalkers

* DB/Creature: Assign Wild Imp script

* Core/Spells: Wild Imp is now scaled based on caster's hitpoints

* Core/Spells: Void Reaver
Force target to get base points directly from spell effect
* DB/Spells: Assign Void Reaver

* Misc. dberror.log fixes.

* More creature_loot_template fixes

* Core/BattlePet temporary fix battlepet delete pet

* Core/update guild challenge system work & flags for rename is implemented

* Core\Typo: Fix linux build (again :P) damn linux CasESensiTive :D

* Core/PacketIO update/Remove duplicate function in guild challenge update

* CORE/Datbase Fix my mistake, sorry

* Core/Implement Guild Invite Declined

* Core\Typo | Fix linux build again :P

* Core/Implement Guild Shift Rank and update code for opcode SMSG_GUILD_EVENT_RANKS_UPDATED

* Core/Implement Guild flag for rename

* Core/PacketIO Implement Guild Change Name opcode

* Core/Quest: Speaker of the Horde, hardcode and fix another parts of the quest to core

* Core/Quest: Speaker of the Horde, fix movement, gossip flag, crash

* Core/Typo: Fix Linux build

* Core/Quest: Rastakhan, fix killcredit, scene, blackscreen

* Core/Quest: Rastakhan, fixed escortAI

* Core/Quest: Fixed quest Welcome to Zuldazar

* Core/Scenario: Improve Stormwind Extraction skip a little

* DB/Spells: Assign some mage scriptnames and data

* Core/Spells: Update at id for mage meteor

* More creature_loot_template fixes

* Many more creature_loot_template fixes

* Model fixes by Damieninabox

* Many creature_loot_template fixes

* Core/Spells: Searing Touch

* Core/Kezan: Goblins can leave Kezan now and are bound to Lost Isles

* Core/PacketIO update SMSG_NEUTRAL_PLAYER_FACTION_SELECT_RESULT

* Core\Opcodes: SMSG_INTERRUPT_POWER_REGEN

* DB/Creature: Prevent Darnell to be attackable

* Core/Kezan: Goblins can leave Kezan now and are bound to Lost Isles

* DB\World: Fix Quest In the blink of an Eye (Quest ID: 44663)

* DB\World: Object (Portal to Orgrimmar)

* DB\ModelData: add 107 models to db. (By DamienInABox).

* Core\Scripts: Move "onarrival" temp fix scripts to proper place.

RegisterPlayerScript(OnLegionArrival); // TEMP FIX! Quest 40519 and 43926 - "legion returns". remove it when legion start quests are properly fixed.
RegisterPlayerScript(On110Arrival); // TEMP FIX! Quest 43341 - "uniting the isles".
RegisterPlayerScript(OnBfaArrival); // TEMP FIX! remove it when lordaeron battle is properly fixed.
* CoreScripts: Fix npc_eoa_call_the_seas::npc_eoa_call_the_seas_AI::UpdateAI crash.

* Core\Spells: Fix spell_rog_saber_slash::HandleOnHit crash.

* Core\Functions: Remove broken "HandleOverrideZonePVPType" and implement "HandleModOverrideZonePVPType".

* Core\Functions: Implement "bool IsPvPRealm()".
Core\Players: Corrected logic determining contested/friendly/hostile area types. (TC cherry-pick)
* Core\Handlers: Fix BattleGroundHandler.

* Core\Opcodes: Fix, rename, and add opcodes for 8.3.7. :)
* Core/PacketIO: Renamed a bunch of opcodes based on more research (only those added after 6.0)
https://github.com/TrinityCore/TrinityCore/commit/f922c6e7a46a7c712daaaef9b1a72ca865fbe94b
https://github.com/TrinityCore/TrinityCore/commit/1d04d5859a59caf286d71f78a18ec4ed05feb7c2
* More dberror.log fixes (loot templates)

* More dberror.log fixes (quests)

* Continuing the dberror.log fixes campaign

* Core/Opcode Rewrite QueryQuestReward to QueryTreasurePicker World Quest rework after complete first quest

* Various DBError.log fixes.

* DB\Loading: Fix 27000+ loading errors.

* DBError.log fixes. Cleaned up lots of abandoned entries in creature_template_addon table

* Core\Scripts: Fix operation mechagon file names.

* Core\Script: Fix operation mechagon build error.

* Fix sql syntax.

* Core/Operation Mechagon: Rename header

* DB/Operation Mechagon: Assign instance script

* Core/Operation Mechagon: Scriptloader

* Core/Operation Mechagon: Tusle Tonks

* Core/Operation Mechagon: Trixie && Naeno && Mechacycle

* Core/Operation Mechagon: KUJO

* Core/Operation Mechagon: King Mechagon

* Core/Operation Mechagon: HK8

* Core/Operation Mechagon: Head machinist Sparkflux

* Core/Operation Mechagon: Instance

* Core/Operation Mechagon: Gunker

* Core/Operation Mechagon: King Gobbamak

* Core/Operation Mechagon: Header

* Rename Mechagon to Operation Mechagon

* DB/Dungeon: Operation Mechagon
Flags
Texts
Creature AI
Loot
Misc
* Cleaned out some abandoned gameobject_template_addon records.

* Spell fix. Druid Maul spell# 6807

* DB\Base: Merge missing data, revert some dberror fixes, update bases.
* Merge missing data from 837 TDB (411 quests, creatures, gameobjects etc...).* Fix old world dberror fixes from 2020_08_06-2020_09_17 (removed all mass "deletes" and kept only "updates" and "fixes").* Update database to BFADB_2020_10_03 and archive old updates.

I will start again the dberror fixes.
This time only obsolete\bad data will be removed from database, rest of the errors will be fixed properly.

NOTE:
Drop your world db and hotfixes db, and import fresh base sql files from sql\base.
* Core\Misc:

change tc_log_debug to tc_log_error on hotfix_blob, we need that info for db fixes.
change tc_log_info to tc_log_error on gametables.cpp, we need that info for gt structure fixes.
fix datatype warning on creature.cpp (int\uint).
* typo

* DB\Misc: Rename some npcs with "0" as name.

* DB/WQ: Removed wq 51581, causing worldserver to stuck for eternity

* Fix battlepay locale loading

* DB\World: Fix spell Consecreation (by Splose) + added some missing queries :P

* DB\World: Fix spell Retribution (By Splose)

* DB\World: Fix spell Blizzard - Mage (by Splose) also a fix file extension (pardon me :P )

* DB\World: Fix spell Blizzard - Mage (By Splose)

* DB/Fix load battlepey display info

* Core/Big update for implement bases groupFinder, somes modifications of battlepay, rewrite somes Opcodes

* Core/Areatrigger: Prevent custom areatriggers to be removed from the world after one 'use'

* Core/SmartAI Fix Void function

* Core/SmartAI: allow SMART_ACTION_SEND_GOSSIP_MENU to override default gossip

* Core/BattlePet Fix show level of battle pets

* Core/Freehold: Removed unneeded lines, causing also crashes

* update bugtracker address.

* Core\Misc: discord ad

---2020_10_01---

**Varjgard** · 11-18-2020

UPDATE:

Greetings everyone.

Donator repack got updated to version 2020_11_18.
(Free Repack got 1 crash fix and launcher update).

NOTE: Replace your worldserver.conf with the new one!!!
(ahbot changes + logger changes. error messages are now enabled by default to make debugging easier when donator has an issue.)

BfaCore 8.3.7 Free Repack:
Free repack is not updated, no bug fixes, no support.
Advertisement on login, limited to 1 players.
Updates and bug fixes are available only to donator repacks.

BfaCore 8.3.7 Donator Repack:
Donator Repack will get all the latest fixes and updates.
No advertisements, no player limits.
Minimum donation is 25€ for donator repack (1 time donation).

ShadowCore 9.0.1 Donator Repack:
-Not released yet-

-BfaCore Team

Join our discord channel for downloads and updates, and donate to get even more!

-BfaCore Discord-
-Make a PayPal Donation-

-BfaCore Team

Changelog:

Code:

BfaCore 8.3.7 Donator Repack changelog 2020_11_18.
None of these changes are on free repack.
----------------------------------------------------------------

---2020_11_18---

* MySQL updated to newest version.

* OpenSSL updated to newest version

* Launcher optimized

* Worldserver.conf configs updated (REPLACE OLD ONE!!!)

* Update custom_player_script.cpp

* Core\Scripts: Temp fix for violethold assault crash.

* Core\Config: Adjust error logging, write all errors to Error.log. (simpler than multiple files).

* .

* Core\Config: Adjust error reporting.

* Core\Scripts: Move worldquest errors to dberrors.

* DB\World: Fix dberrors.
The rest of the dberrors have either missing data (item, object, creature), or the error logger needs to be verified from c++ before fixing (conditions, smartai).

* Core/Spells: Enum Cold Steel Hot Blood

* DB\World: Revert some dberror fixes from base and update world base to BFADB_837_2020_11_17.
There has been a lot of changes in the core base over time,
but error logging was not updated so core gives some false errors on loading.
Current errors need to be checked first from c++ logger function if the error is false or not,
if it is false, the logging needs to be fixed on that part.

* Core/Scripts: Enum Death's Challenge

* Core/Scripts: Death's Challenge

* DB/Misc: Death's Challenge data

* Core/Spells: Vampiric Blood

* Core\Spells: Spell 49028 - Dancing Rune Weapon (NPC 27893).
Pretty hacky version, but works like a charm :D

* Core\AuctionHouse: Hide useless error message (ah will be refreshed anyway after X seconds if ahbot is enabled).

* Core\Scripts: Clean some scripts from bad stuff.

* DB\World: Update world database to BFADB_837_2020_11_16 and archive old updates.
Some old bad commits reverted (cherry-picks from tc).
This fixes whole deathknight zone. + a lot of other content.

* Core\AHBot: Last finetune.

* Core\AHBot: Fine tune config..

* COre\AHBot: Fine tune config.

* Core\Spells: 49028 - Dancing Rune Weapon.
TODO: make spell hit for x seconds, now it hits only 1 time.

* Core\AHBot: Fine tune config.

* Core\AHBot: Pre-configure AHBot with working config and enable by default.

* Core\AhBot: Fix AHBot. (Thanks to Tymo1993 for info)

* Remove extra paren

* DB\World: Fix some SmartAI errors.
deathknight quests that use sai work now too.
https://www.wowhead.com/quest=12733/deaths-challenge
etc.

* Worgen Starting Area Market Square
Fixes phasing issue (conditions and spell_area)
Updated quest template for the quests in the area
Update lot and pickpocket loot for the area

* Core\SmartAI: Fix false errors caused by SMART_TARGET_ACTION_INVOKER action type.

* DB/Spells: Another 44 spellscripts which needs to be removed also from core

* Core/Scripts: Remove obsolote auras from Naraxas

* DB/Spells: Naraxas aura

* Core/Spells: Annihilate

* Core/Spells: Felfir Missiles

* Core/Spells: Charge Drop

* Core/Spells: Meteor

* Core/Spells: Wand Practice

* typo

* Core/Spells: Stagger

* DB\World: dberrors.

* DB\World: Dberrors......

* Core/Spells: Healing Elixir

* Core/Spells: Barreled Control Aura

* Core/Scripts: Everbloom

* DB/Spells: Create Healthstone

* Update spell_dk.cpp

* DB\Base: Update database to BFADB_837_2020_11_15 and archive old updates.
revert old SmartAI cleanup sql, this will add some loading errors but will fix a lot of quests etc content.

* Core/Spells: Empower Rune Weapon

* Core/Spells: Explode

* DB/Spells: Remove Sword And Board, doesn't exists anymore

* Core/Spells: Remove Warrior spell which doesn't exists anymore

* Core/Spells: Transcendence

* DB/Spells: Spellscripts v.2

* DB/Spells: Explosive Corruption

* DB\World: Delete obsolete Scripts from db.

* DB\Wold: Fix quest giver spawn "Prince Valanaar" 28377
Fixes Quests:
https://www.wowhead.com/quest=12678/if-chaos-drives-let-suffering-hold-the-reins
https://www.wowhead.com/quest=12701/massacre-at-lights-point
https://www.wowhead.com/quest=12706/victory-at-deaths-breach
https://www.wowhead.com/quest=12700/an-attack-of-opportunity
https://www.wowhead.com/quest=12670/the-scarlet-harvest

* DB/Spells: Spellscripts cleanup

* Core/Spells: Sonic Breath

* Core\OpCodes: Enable SMSG_MYTHIC_PLUS_ALL_MAP_STATS.

* Core/Spells: Flarecore

* DB\Wold: Fix quest giver spawn "Gothik the harvester" 28658 and quest 12698 https://www.wowhead.com/quest=12698/the-gift-that-keeps-on-giving

* Core/Spells: Voidform

* Core/Spells: Fire on

* Core/Spells: Wake of Ashes

* Core/Spells: First Blood

* Core/Spells: Fel Lance

* Core\Scripts: Remove temporary fix for runeforging from allied_races.cpp.

* Core/Spells: Drop Stone

* Core/Spells: Archmage Barrier

* Core/Spells: Severe Dusting

* Core/Scripts: Nightbane

* Core/Scripts: Vizaduum

* Core/Scripts: Goroth

* Core/Scripts: Sisters of the Moon

* Core/Spells: Meteor Slash

* Core/SCripts: Maiden of Vigilance

* Core/Scripts: Desolate Host

* Update README.md with newest requirements and add download link for win64 requirements.

* Core/Spells: Void Phased

* Core/Spells: Fuselighter

* Core/Spells: Spatial Rift

* Core/Spells: Whispers of Power

* Core/Spells: Vectis - Contagion

* Core/Spells: Unbound Abomination

* Core/Spells: Lightning Shield

* Core/Spells: Explosive Corruption

* DB\Hotfixes: Fix 2020_11_12_00_hotfixes_dberrors_quest.sql

* Couple minor corrections to solver sql errors

* DB\World: Fix 2020_10_30_01_world_battle_pet_trainers.sql

* DB/Creature: Assign Storm, Earth, and Fire AI script

* DB\World: Fix Quest POI 25541
Close Issue: https://www.bfacore.com/d/627-filling-our-pockets-quest

* DB\World: Fix GameObject loot to fix quest Venomhide Eggs
Close Issue: https://www.bfacore.com/d/629-venomhide-eggs-quest

* DB/Spells: Assign scriptnames

* Core/Spells: Void Torrent & Dark Void & define another priest spells which needs to be scripted

* Update spell_warlock.cpp

* Core\Spells: DemonHunter - 263648 - Soul Barrier.

* Core\Spells: Remove obsolete spell spell_rog_cannonball_barrage.

* Core/Spells: Drain Life

* Core\Spells: Rename and assign rogue spell 193315 "sinister strike".

* Core/Spells: Contagion

* Core/Spells: Crusade

* Core/Spells: Blade of Wrath

* Core/Spells: Essence Drain

* Core/Spells: Explosive Shot

* Core/Spells: Fiery Brand

* Update spell_generic.cpp

* Core/Spells: Desperate Instincts

* Core/Spells: Phantomatic Singularity

* Core/Spells: Soul Effigy

* Core/Spells: Void Torrent

* DB\World: dberrors.

* Core/Spells: Mana Break

* Core/Spells: Prepared

* Core/Spells: Overwhelming Power

* Professions: Fix first aid trainers and skill line. (TODO: fix first aid spell).

* Core/Spells: Drain Soul

* Core/Spells: Soul Harvest

* Core/Spells: Harpoon

* Core\Logs: Fix trainer_spell error messages...

* Core/Spells: Unholy Blight

* DB\Quest: Fix some quests and quest dberrors.

* Core/Spells: Ancestral Guidance

* Core/Spells: Death Siphon

* Core/Spells: Avatar

* Core/Spells: Lava Burst

* Core/Spells: Pillar of Frost

* Core/Spells: Adaptive Warding

* Core/Spells: Create Lunar Festival Invitation

* Core/Spells: Frenzied Regeneration

* Core/Spells: Intimidation

* Core/Spells: Aimed Shot

* Core/Spells: Immolation

* Core/Spells: Blade Flurry

* Core/Spells: Regrowth

* Core/Spells: Healthstone

* Core/Spells: Life Tap

* Core\Spells: Rogue - Backstab.

* DB\World: quest dberrors.