[Compiles] Mangos + YTDB + Scriptdev2 + Changelog

[Dj Aligator]

Mangos 9892 - 9901
Cleanups for BattleGroundEY code
Also prevent send uninitilized mark data in case BATTLEGROUND_EY end.
Simplify related code.
Fixed some spelling typos in function/structure names.
Move GetCastingTimeForBonus and some other code to 
GetSpellCastTimeForBonus.

Important changes:

* Chaged way caluclation "-5% of total per any additional effect" to percent
  apply instead use raw value that correct only for 3500 cast time spells.
* GetSpellCastTimeForBonus result now alwasy not applied to creature casted 
spells
  Before it not applied only to instant spells. Please test if this ok in all 
  cases.
* Leech effect modify spell casting time move into GetCastingTimeForBonus and 
then called
  also for melee spells. But only creature spells exist with melee class damage 
  and its
  not affected by GetCastingTimeForBonus anyway now.
Move DotFactor+GetSpellCastTimeForBonus call to 
CalculateDefaultCoefficient

* This coeff used if not spell_bonus_data provided for spell
* Continue prev. commit line expected that creature casts not affected by 
DotFactor
Cleanup spell bonus coeff use code

* Avoid coeff calculation if target value is 0.0f
* Avoid use spell_bonus_data coeffs for creature damage.
Avoid multiply AP bonus coeff. with spell power bonus.

Problem exist in original code before recent commits.
Implement redundent values check in `spell_bonus_data`

Also do table content cleanup base at added feature.

Original check code provided by nos4r2zod.
Fixed sql update for ptrev. commit.
Fix SPELL_MOD_SPELL_BONUS_DAMAGE applying
Second attempt fix sql update :/
Implement 71342 mount selection

Also added
mangos_scriptname_full
scriptdev2_script_full

[Dj Aligator]

Long time no updates.

Mangos 9903 - 9972
Fixed build problem at *nix.
Add new config option for wait mode at startup error.

Note: it not applied to crashes and shutdowns after mangosd/relamd startup 
completed.
You can continue without delay (as now) and fast exist, or wait <Enter>, or some 
secs
for continue. Last can be helpful for see for example not applied sql update 
revision
data and etc.
Correct SMSG_INSTANCE_DIFFICULTY structure (fixes raid difficulty 
display).
More user friendly output at DB version check fail.
 Make comment really proccessed by doc generator.
Add missing break. Not affect current code work.
Prevent SQL injection in equipment sets code.

Author of original verison: Machiavelli
Implement expected from 3.2.x time limit for BattleGroundWS.

With updates and fixes from zergtmn.
 Check script using and existance at `creature_movement_scripts` load.
Partly revert [9911] :/
Fix TARGET_SCRIPT searcher and also look for objects that are Pet*

Pet (guardian, mini-pet) may also be the target of TARGET_SCRIPT, and are not 
considered a grid object.

 Add script effect of spell 51864, 51889 and 51910

In addition, dummy effect of spell 51866 and 51872 and dummy aura effect of 
spell 51870.
Dummy effect of 51866 might need additional work (see comments).

Code expect additional spell cast by AI (summon dummy at death of related quest 
target creatures).
Clarify game_event field values and fix typos.

Thanks to BrightStone for pointing to ;)
Fixed  .account onlinelist work.
Fixes in loot roll timer work and related cleanups.

* Changes include (in fact as part cleanup) fix got NeedBeforeGreed locked item 
after expire roll timer
  suggested by [email protected].
* Added cancel rolling at creatuer corpse remove.
* For NeedBeforeGreed and GroupLoot sued common code for prepare item roll.
Fixed player's tapped creature loot access by group in diff cases

* If player tap creature in group and leave then group will have access to 
creature loot if not disbanded
* If player tap creature and after join to group then creature loot will 
accesable only by player
* Also RewardPlayerAndGroupAtKill divided to simgle player and group reward 
versions used for group tap
  and single player tap cases.
Output player name in ObjectGuid player output string.
Restore group rewarding at player kill.
In case player who tap creature in group leave group it must anyway 
rewarded with group.
Rename BG_WS_UNK1 -> BG_WS_TIME_ENABLED
Fixed typo in prev commit.
Implement .server log filter and .server log level comamnds.

* .server log filter comamnd let temporary (until config reload or restart)
  set log filters state. Or look at filters state.
* .server log level renamed from .server set loglevel but now let look at log 
level also.
Add more log filters

* damage - different direct damage calculation tracing
* combat - combat state updates, roll attack result and etc
* spell_cast - spell cast progress and aura apply
Typos in Unit::DealDamageMods

Can be source very strange damage/absorb and any near stored/calculated in 
memory values. and crashes also.
Support new raid allowed quest types.
Fix build...
Move apply spell coeffs and level penalties code to new function.

* No reson have 6 copies near to exactly same code.

* This fix problem with apply attack power bonus in some case.
  Thanks to Wowka321 for find and reseach problem.
Move enum QuestTypes to QuestDef.h where it only used.

This is also fix build at GCC
After 3.2.0 expected AllowTwoSide.Accounts = 1 for any realm type by 
default.
Change AllowTwoSide.Accounts default in code also.

And update config version.

Also note: it not has been propertly updated in prev. time
when config version in .conf.in changed. It must be sync changed in
*.conf.in and in SystemConfig.h.in
Call DealDamageMods for leech DoTs damage
Skinning related fixes

* Show skinning tooltip only after creature loot
  (when creature can be explcitly skinned).
* Allow reopen skinning loot if still have not looted items.
ACE realmd, thanks to Zor and Vladimir for windows.
 Remove sockets library from UNIX build
Added copyright notice.
Correct premature call of TalkedToCreature.

Only use TalkedToCreature when gossip does not have any following sub menu (and 
of course when the prepared npc options does not include any gossip)
Sockets library use finally dropped

Specially thanks to Derex for make this possible! :)
Fix typo in AuthSocket.cpp
Add additional check for UNIT_NPC_FLAG_GOSSIP before using 
TalkedToCreature
Output ACE version at realmd start.
Add a small delay for npc despawn related to spell 51840

This will solve problem with summoned GO that does not appear before later, but 
does not solve problem with visual effects (which is a generic problem with many 
spells).
Implement spell 633 and ranks self casting restrictions in 3.3.x
Update mangos_spell_check.sql

* Add all data from Spell.cpp
* Add missing data from recent commist for added parts of SpellEffect.cpp
More skinning fixes.

* Restore work with money loot.
* Old code sometime generate empty loot windows for normal loot and sometime 
skip its.
  Code changed to be more consistent. Added new option Corpse.EmptyLootShow that 
  control
  show empty normal loot window in some cases enabled by default:
   - if creature expected to be lootable but loot generated empty by some 
   reasons.
   - if creature can be skinnable
  If option disabled thne code attempt avoid empty normal loot windows for empty 
  cases.
* Possible fixed case instant despawn non-skinable creature after normal loot 
complete.
Remove a few not needed checks in spell script effect
Add target for TARGET_DUELVSPLAYER_COORDINATES only if not provided by 
another way.

This fix for exmple unexpected empry heal if targeted by spell 48438 and ranks.
Fixed crash at .gobject turn command (at *nix at least)
Fixed bug with raid subgroup size update at move member to another.

Also some code cleanups
Allow update subgroup in raid for offline players.

Also prevent crash and wrong subgroup number send from client.
Remove two not needed cast to Creature* and make code more safe
Lost socket.vcxproj referecne in VS projects.

Thanks to j4r0d for catch this.
Prevent negetive proc events from possitive effects of negative spells.

Some negative spells have positive effects with targets not affected by negative 
effects of spell.
For example spell 45524 cast negative effecst to target and possitive effect to 
caster self.
For like possitive only target of negetive spell will not triggered negative 
proc events.
In last cases will avoid triggering glyph 43537 at caster at spell 43537 cast.
Spell 45524 expected apply debuf 55095 to target at cast.
Alow sell item for money and extanded coset without momey in same time.

npc_vendor.ExtandedCost can be negative now that meaning:
price excluded default item BuyPrice and use only abs(ExtandedCost) items).
For example expected used for item 36908.
Implement item 34753, 43015, 43478, 43480, 46887.
Fixed resent radnom problem with looting related to skinning code 
changes.

Thanks to boxa for help in research problem.
Implement glyph 43390.

Chance unknown and seelcted by more recent comments.
Restore work talent 18213 and ranks.

Thanks also to insider42 for updating.
Modify way 4x damage bonus claculated for spell 1120 and ranks.

* Now apply 4x bonus dependent from target health in time spell cast,
  not from current health in tick.
* 4x bonus applied to own spell damage value, not to total taken damage.
Implement per-tick chance for shard for spell 1120 and ranks.
Implement Treshold in Masterloot.
Fixed triggering of spell 55095 by 45524.

(based on insider42's repo commit 90de00d)

It include reverts commit ca99760e884d82219fff63ecf5f2ca87b02b5924
with less clean implemetation.

[patch 155] Fixed triggering of spell 55095 by 45524. Patch provided by me

(based on commit 90de00d)
Add CharacterDatabaseCleaner to VS2010 filters.
Fix 16164 proc conditions
Allow have reserved entries with empty names in log filters table.
Additional check for HandleAutoBankItemOpcode.
Fixed array free in vmap code
Typo in BattleGroundQueue::AddGroup arg name
Move CharacterDatabaseCleaner.* to Tools group as for VS100 done.


YTDB 323

+ All fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ update fields "*_template" by WDB
+ filling table "creature_movement_scripts"
+ processed 221 caches (3.3.3a)

[poco_digo]

Hi
When I upgraded, I had the following error:
procédure-invalid-parameter-noinfo-noreturn MSVCR100.dll. Any idea which can happen.
Thanks for your work and perseverance.

Best regards

Edit by Solved!!!!
Only need to install:
http://www.microsoft.com/downloads/d...3-37bf0912db84

bye

[Dj Aligator]

Mangos 9973 - 9999
Fixed selection BG map difficulty.

Thanks to insider42 for help in research problem.
Restore raid functionality broken after one from 3.3.x switches.

* Fixed typo in raid converting code that triggering raid disband at server 
restart.
* Fixed current subgroup show for character and update group memebers data at 
move its
  in diff subgroups.
Use special function for honored/xp kill check
Fixed typo in recently added group enums.
Update talent 16180 and ranks work.
Add explicit AP damage bonus for spells 55095, 55095.

Original patch provided johonson.
Update max cooldown length req. for spell casting at arena.
Remove target guid in spell with TARGET_FLAG_DEST_LOCATION

Corrects spell animations and visual going in weird directions for these kind of 
spells
For non-player at "offline" delete hostile references.

This must fix porblem with call message broadcast from unit destructor.
Group out of range member must based at client existances.
Also move empty mask check from build function to caller.
Leave at AFK applied only to battlegrounds (not arena)
Also restore build...
Implement item 43214 work.

* Original version suggested by timmit.
* Required DB support for target requirement.
Send SMSG_CORPSE_NOT_IN_INSTANCE if player in ghost form tries to enter an 
instance without player's corpse.
Talent 51459 and ranks affect only melee auto-attacks.
Restore work talent 12311 and ranks.

Thanks to insider42 for prepare patch for mangos.
Add correct spell chain data for 61024 and 61316.
Use unix styoe line ends in soem files
Use more correct data for prev. sql update.
Next step in fix SMSG_GROUP_LIST structure.

Now assistant/main tank/main assistant show properly
for viewer character also.

Thanks to insider42 for posting patch in Under review section.
Fixed MSG_PARTY_ASSIGNMENT processing.
Limit spell 50988, 59870 targets amounts to expected.
Fixed a bug/typo that prevent to summon a special flying mount.
Move GridMap class (and related structs/enums) to separate cpp/h.

Also rename some structs/enums and fix some code style.
Remove grid state debugging code and move state machine to MapManager.
Some changes in HashMapHolder.

* Use ACE_RW_Thread_Mutex, since there's much more reading than writing.
* Use read lock in Find(), and write lock in Insert() and Remove().
* Correctly lock the hashmap on outside calls.
Fix *nix build.
Remove a piece of trailing whitespace.

YTDB 324

+ All fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ update fields "*_template" by WDB
+ processed 245 caches (3.3.3a)

[Dj Aligator]

Mangos 10000 - 10011

Redundent empty line.
Rename current version sql updates (0.16/root dir) to 5 digits format 
rev.

* order guards not affected in sql updates so this not affect sql guards work.
* TO DEVS: in next sql update commit please check carefully generated by git_is 
-s
  sql guards for correctness
Fixed map loading .map build checks.

Bug exist long time before recent code moves.
But it not affect in cases proper .map files.
Fixed unix* install.

I forgot update sql updatenames in Makefile.am after its rename.
Add script effect of spell 43365, 50217, 50218 and 50238.
Add script effect of spell 41055 and 45206.
Fixed typo in mangos.sql
Fix wrongly initialized value
Fix sqls
Fix realmd to accept more than 64 connections on windows.
Use schoolmask enum in struct SpellNonMeleeDamage, some indents fix.
Check redundent procFlags value in `spell_proc_event`.

[Dj Aligator]

All .NetFramework versions has been added

[Dj Aligator]

Added a program for x86, this one must work if .NetFramework didn't work for you.

Give thanks to poco_digo

[Dj Aligator]

Mangos 10012 - 10025

Fix charges taking for 16246
Implement CONDITION_QUESTTARGET

For cases when loot dependent from some quest objective complete state.
Revert "[10013] Implement CONDITION_QUESTTARGET"

This reverts commit 4e460746c0947f6cfc1f1150a8eb90257819eae2.
More redundant data check in `spell_proc_event`
Remove unused RewardSinglePlayerAtKill result.
Make spell_proc_event.SchoolMask unsigned.

Also use byte length hex for school mask in mangos.sql data.
Add 16246 proc to mangos.sql
Implement glyph 45623.

Thanks to Most_Mangos, DonTomika, darkstalker  for dollution research.
Drop unused member in VisibleNotifier structure and related functions

(based on SilverIce's repo commit e678555)
Also applied mangos code style to GridNotifiersImpl.h
Move item disenchanting static req. checks to server start.
Fix damage for 14278 and 16511 and ranks when dagger is equipped
Change HandleLearnAllMySpellsCommand to learn only player's spells
New LogFilter_DbStrictedCheck filter for DB devs

It's enable by default (prevent show related output) but
in disbled case allow show useful for DB developers different
more stricted DB check output at server loading, including

* Absent GO trap template referecned in some another GO template
* Not set (0) unit class in creature_template
* Absent disenchanting loot for items marked as disanchantble

This all cases can or hard fixed in one step or show false cases y different 
reasons.
That why filter active by default.
Fixed unexpected C++ code parsing with *FILTER_LOG in 'if'

YTDB 325

+ all fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new teplates from WDB;
+ fix stats of NPC: Alterac Valley
+ fix data "disenchant_loot_template"
+ update tables "*_template" by WDB
+ processed 280 caches

[Dj Aligator]

Mangos 10026 - 10032

PDump code fixes and cleanups

* At pdump creating will propertly saved NULL field values.
* At pdump loading will skipped adding `character_declinedname`
  if name in some way will be changed (explicly or at loading)
SPELL_AURA_ADD_TARGET_TRIGGER long time not use spellmod for work.

Drop dead code.
Reward group for shareable quests at cast event to creature/go.
Clarify client dependence for some MeleeHitOutcome values
Add aura remove modes for expire and absorb shield break cases and use 
GetTarget()/GetSpellProto() instead of m_target/m_spellProto
Replace hard coded quest dialog status value with enum value

Some minor code cleanup for readability.
Remove not needed local declaration of dialog status and rename some to 
clarify.

Additional cleanup for readability.

[Reflection]

Good job keeping this alive! +7

[Dj Aligator]

Mangos 10033 - 10049

Use sometime stored in spell data triggred spell info for dummy auras.
In case unknown triggered spell output more known info for location 
problem.
Additinal reqs for spell 49219/51459 and ranks triggering.

* Only at melee attack or spell 56815 hit.
* Spell 49219 and ranks also ignore offhand attack.
Fixed health restore and triggering cooldown for talent 30881 and ranks.
Fixed poison consume by spell 32645 and ranks.

It will consume only caster casted poisons.
Prevent double triggering heal from 63534 and ranks.
Also use more simple and safe checks for added in [10035].
Partly revert [10033] for spell 44394 and ranks related code.

Not all ranks of spell have proper triggered spell info.
Return to old more explicit code.
Expected RAP bonus to damage for spell 1510 and ranks.
Use for spell 49145 and ranks for decrease SPELL_DIRECT_DAMAGE damage.
Implement CONDITION_QUESTAVAILABLE.

Also do come constatification of quest status check functions
and fix one unsafe use std::map operator[].
Never never use std::map operator [] for _read_ access.
Good chance corrupt related structure state ;)
Not in found case but in general.
Fixed share quest in case completed objectives.

* Also fixed CONDITION_QUESTTAKEN for same case.
* Aslo fixed exclusive prev quests check.
 Generate talent related spell_chain data instead storing its in table.

* Drop now redundant part of data from `spell_chain`.
* Allow store in spell_proc_event cusom ranks data for ppm for chained ranks.
* Drop now redundant part of data from `spell_proc_event`.
Frop unexpected custom rank data for 26016.

This make spell rank use first rank data.
Store guids instead slot data for trade items.
Fixed show wrapped gifts in trade windows.

Also some fixes for trading related not full read packet spam.
Move trade data to dynamic created structure.

Also possible fix old bug with spam trade cancel after logout.
Fix SPELL_AURA_MOD_HEALING_DONE healing bonus with 0 misc value

YTDB 326

+ all fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new teplates from WDB;
+ update tables "*_template" by WDB
+ fix spawn for scripts: "Halls of Reflection", "Pit of Saron", "The Forge of Souls"
+ processed 304 caches

[Dj Aligator]

Mangos 10050 - 10059

Implement apply non-trade slot item enchanting at trade complete.

Base at original patch provided by arrai.
Fixed talent 58426 broken after 3.3.3 switch.

Also cleanup character auras from wrong duration auras.
Camera System

(based on SilverIce's repo commit 4f2f4ab + next 3 more)
Use UNIT_STAT_CONTROLED for mark unit state under direct player control.


* This allow prevent move home/to caster at apply
* Also replace AI and reset movegens at control time
* Also stop combat and clear threat/hostile list at lost control for prevent 
combat with freindly units.
Fix crash when not saved action buttons are removed during spec switch
Use creature equipment from normal _template when id is not set for 
difficulty

creature_template of difficulty_entry_N then only need equipment_id when 
equipment should be different from the normal creature entry.
Re-add spell proc sql data from [7879].

* It not has been added in commit time to mangos.sql
* It alsow required data updating in family masks.

Thank you to NoFantasy for reseatch problem :)
Type in UNIT_STAT_CONTROLLED
Add to mangos.sql data from 09720_01_mangos_spell_proc_event.sql

Thank you to NoFantasy for pointing to inconsistance.
Cleanup in Player::m_mover uses

* Also fix triggered by related checks unread packet tail spam cases.
* Fix one case when expected death at fall controlled player
  under ground has been possible avoided

[Dj Aligator]

Mangos 10060 - 10075

Drop unused ACE_Stack_Trace in Error.h

This also can fix possible build problem in case use at system old ACE version.
Implement 49220 and ranks
Added missing return statement.
Revision increase.

I am sorry, i forget to apply git_id :(
Removed wrong method const.
Cleanup recent added code.
Fixed recently show up crash in Unit::StopMoving.
Some return values fixes.
Some tuning in consts.
Allow item INVTYPE_RELIC to be equipped by npc from 
creature_equip_template
Fixes in pet movments

* Use proper stop packet as expected. In case 0 trevel time used before move 
packet
  can generate infinity move forward (at client side).
* Avoid reset top movegen before add idle in pet stay command.
* Avoid assign random move to player owned creatures as default movegen.
* Finish follow movegen init including need-stay case.
Really do "Avoid assign random move to player owned creatures as default 
movegen."
Remove old, commented code no longer needed in SendMonsterMove
Not need add new cases inline for in-class function definition.

This is redundant from current C++ standart point.
More methods for access/modify ObjectGuid update fields.

* Some related cleanups.
* Also drop unused Player::SetFarSightGUID decalration as reported by LordJZ.
Make object active at applying view on it

also isActiveObject check moved to WorldObject - all worldobjects are inactive 
by default, excluding players
this is a final part of cameras implementation
(based on commit efc9623)
Also remove template-way code selection for object for 
Map::AddToActive/Map::RemoveFromActive.
This simplify function use from not Map code.
Add IsPassive(SpellEntry*) function and use in cases wjern entry already 
known.

Some other small code cleanups
Attempt use more expected by result buffs downranking algo.

* In small rate more fast
* Not affect non-buff ranked spells like 10909

YTDB 327

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new teplates from WDB
+ update table "*_template" by WDB
+ processed 333 caches (3.3.3a)

[Dj Aligator]

Mangos 10076 - 10091

Fixed crash at remove from world pet under SPELL_AURA_MOD_POSSESS_PET

* Prevent crash at camera list update at attempt increment end() iterator.
* Properly do unapply SPELL_AURA_MOD_POSSESS_PET (GetPet() can return NULL at 
call, and not need checked)
* Propertly call unapply at delete auras cases for auras that set player-caster 
mover pointer.
Add delayed far teleports for opcode handlers

Some opcode handlers have many code with possible deep calling
far teleports by some reason (death, quest script, etc).
This can be triggering unexpected lost Map context and crashs result.

Note: player login opcode still have disbled delayed teleports (old way work)
just becase Player object created in it and not have flag set.
Calling point look not 100% safe but at this commit this way not chnages for 
while.
Use const referecne to opcode handle.
Don't allow cancel passive spells
Fixed ghost teleport and cleanup code.
Use ACE config library instead dotconfpp

NOTE: all config versions update because in old state
      it's not compatible with new way loading.
      Look for *.conf.dist.in chnages in commit for update configs.
Drop now unused dotconfpp lib code.
Made some Spell.h dependences more explicit.
Resync. opcode names in Opcodes.cpp/.h
Allow loot roll value 100
Implement use .go command with shiftlinks or player name.

* Now if for .go command provided no X Y Z args command will not teleport player 
to nowhere.
* Instead command allow used with player name and work as simplifed .goname
  (teleport to player _point_ in user instance binding, not to player instance)
* Also command can be used with diferent point coordinates provided shift-links:

  - player (result for example .lookup player account)
  - creature (result .list creature command)
  - gameobject (result .list object command)
  - tele (result .lookup tele)
  - taxinode (result .lookup taxinode)
Move table in more expected mangos.sql part
Restore work of 1120 and ranks. (Revert of [9962])
Change in event system work with pool system.

* `game_event_pool` dropped and related in momory data generated
  based by another pool tables content.

* Pool work with spawed at event and despawned at event object now different.
  - If object listed in `game_event_*` as spawned at event start and it's part 
  of some pool
    then all other pool object must be listed as spawned with this event start, 
    and more,
    if pool has mother pool, then all mother pool members must have objects 
    spawned at this
    event start. More short: all object of some top (not have mother pool) mitbe 
    or listed for some event start spawn,
    or not listed for any event start spawn.
  - If object listed in `game_event_*` as DEspawned at event start and it's part 
  of some pool
    then nothing special required for other pool objects. Event systemwil 
    command to pool system exclude for spawning and despawn referenced
    object until event end.

* Many checks has been added at event/pool data loading.
* Changes fix crashes related to event/pool common work.

Thanks to NoFantasy for help in research original problems and ways for improve 
code.
Really output log level at ".server log level" command.
Use ACE for command line options parse.

Note: "--service run" renamed to "-s run"
in consistence with other serrvice options.

[Arutha532]

Thank you!