[Lua] Russian roulette Item. Do you dare?

[slade1000]

This is a script that simulates the game russian roulette, If you miss you die and if you dont you get some gold so ye its pretty simple to understand basicly there are six bullets and you start the game you might win you might not.

This did not have any errors when I ran it but its untested in game I would appreciate someone who could test this for me thanks


http://pastebin.com/m1bc00ad1 ---Updated

Have fun

[stoneharry]

You should test your scripts before you release them; the item:CastSpell will bug, you should get the player to cast it. Apart from that looks good, interesting use of the tables.

[Dynashock]

Why not use metatables instead of keys? Such as RR = {bullet = 6}, access the number with RR.bullet - allows for less errors and easier on the eye.

Besides that, this script won't even work if you did change that item:CastSpell thing. I'll just point the errors out (not correct them as you need to learn from it and I'm lazy :P):
- what's up with all the ifs and elseifs? if (ReturnBulletCount() == 2 or 3 or 4 or 6) is ran and it's a match then the others won't be even ran, it's entirely pointless to have the "elseif (ReturnBulletCount() == 4) then" and the like later on. Either remove the or's or remove the later elseifs.
- then there's your math.random(). Its syntax is math.random(startnumber, endnumber), in the way you're currently using it will only return the number you entered, totally nullifying the point of "random".
- You call the function "UpdateBulletCount", however it doesn't even exist, as it's called AdjustBulletCount
- Why do you even have a "gold" index in that table?
- what happens when the bulletcount is 1 (happens when bullet count is 2, you win and the count gets updated) - any way to reset the game?
- incorrect usage of 'or' - if something == 5 or 6 or 7 or 9 doesn't work. It isn't comparing the 6, 7 and 9 to something, it's only comparing the something to 5, and then it's just 'if 6', or 'if 7' etc. Correct usage would be: if something == 5 or something == 6 or something == 7 or something == 9.
- your logic with the randomisation is wrong too, I think: if I have 4 bullets and there's 6 places for bullets in a gun, I have 16.7*4% chance to get the bullet. Not 25% as it is with your current math.random(1, 4).

[slade1000]

I have no way to test them stoneharry sadly as I am on a mac and I will fix the item cast spell


Update: I fiixed the item cast spell to player cast spell

[Hellgawd]

It might be worth paying 18$ a month to get a basic VPS where you can test scripts on, (just connect using RDP) or, you can always Boot Camp windows (like I do.)

There's plenty of solutions, you can also try using ArceMux (I posted it in the programs section a while ago, just do a search for 'ArceMux') it's an ArcEmu - for Mac OSX.

As for the script, it's a basic but intriguing idea. Keep em up!

Cheers,
hellgawd

[Mr.Ice.Cold]

Rather than "You have lost the game, try again if you dare!" you should have put "BOOM HEADSHOT!" Anyway nice script slade, +rep

[slade1000]

Haha ok I will do that

[Link_S]

This idea is brilliant, easy and brilliant.

[slade1000]

Thank you Im glad you thought so

[RyeRye]

Also, if they lose you could make them loose some health, or make them die or something.

[slade1000]

if they lose they do die

[facka138b]

Usefull. I will add this to my server with credits!

[slade1000]

Nice hope you like it and it works well