[Help] One part of my lua script doesn't work correctly

[dude891]

I made a lua script, here it is:

function Hand_ShadowBoltVolley(pUnit, Event) 
  pUnit:FullCastSpellOnTarget(45770, pUnit:GetMainTank()) 
end

  function Hand_Phase1(pUnit, Event)
    pUnit:RegisterEvent("Hand_ShadowBoltVolley", 20000, 0)
  pUnit:RegisterEvent("Hand_ShadowInfusion", 1000, 0)
end

function Hand_ShadowInfusion(pUnit, Event)
 if pUnit:GetHealthPct() < 20 then
  pUnit:CastSpell(45772)
 end
end

function Hand_Entercombat(pUnit, Event)
  pUnit:RemoveAura(30540)
  pUnit:RegisterEvent("Hand_Phase1", 1000, 0)
end

function Hand_Leavecombat(pUnit, Event)
  pUnit:RemoveEvents()
  pUnit:CastSpell(30540)
end

function Hand_Died(pUnit, Event)
  pUnit:SpawnCreature(25320, 1698.799072, 628.254517, 27.533756, 5.559829, 1771, 999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999)
end

function Hand_Spawn(pUnit, Event)
  pUnit:CastSpell(30540)
end

RegisterUnitEvent(25321, 1, "Hand_Entercombat")
RegisterUnitEvent(25321, 2, "Hand_Leavecombat")
RegisterUnitEvent(25321, 4, "Hand_Died")
RegisterUnitEvent(25321, 6, "Hand_Spawn")

The mob is supposed to cast Shadow Bolt Volley every 20 seconds at one part. Instead, it waits 20 seconds then it starts casting about every millisecond I believe. Can anyone tell me what I'm doing wrong?

Edit: Sorry that the post got a little messed up. The edit feature isn't working that good for some things.

[Power of Illuminati]

Not sure, but the variables doesn't match eachother

pUnit:RegisterEvent("Hand_ShadowBoltVolley", 20000, 0)

function Hand_ShadowBoltVolley(pUnit, Event)

I think you need to add something to the function name, like cooldown (or something like that)

function Hand_ShadowBoltVolley(pUnit, Event, Cooldown)

(Note that I have no clue if Cooldown is the right variable to add)

[Gastricpenguin]

Proper script:

    local plr = pUnit:GetMainTank()
       if (plr ~= nil) then
        pUnit:FullCastSpellOnTarget(45770, plr) 
    end

[bill45]

The way you do your script to me is confusing but i think the problem is this(red part)

function Hand_Entercombat(pUnit, Event)
  pUnit:RemoveAura(30540)
  pUnit:RegisterEvent("Hand_Phase1", 1000, 0)

Which means knowing there is only one phase it means your telling him to cast it or do that phase every second.

[dude891]

Proper script:

    local plr = pUnit:GetMainTank()
       if (plr ~= nil) then
        pUnit:FullCastSpellOnTarget(45770, plr) 
    end

Knowing you this will most likely work. The only problem is I'm a noob to this stuff and don't know where or how to put this in my script. Can you explain it a little bit more to me? I'm new to this and still learning.

[bill45]

You just put it in there like this.

function Hand_ShadowBoltVolley(pUnit, Event) 
local plr = pUnit:GetMainTank()
       if (plr ~= nil) then
        pUnit:FullCastSpellOnTarget(45770, plr) 
    end
end

[dude891]

I don't know what's wrong. I tried that piece of code gastric but it still continues to wait 20 seconds before casting the spell every millisecond.

[Bapesy]

Be more specific on what you need fixed.

Bapes

Edit: What LUA engine are you using?

[bill45]

Just a guess but try setting this

  pUnit:RegisterEvent("Hand_Phase1", 1000, 0)

to this

 pUnit:RegisterEvent("Hand_Phase1", 1000, 1)

tell me if that stops the non stop shadow bolts.

[TheSpidey]

*sigh*
Here's your problem.

As the mob enters battle, the function Hand_Phase1 gets called every second.
Function Hand_Phase1 registers the volley to be every 20 seconds.
BUT because it gets called every 1 second, after 20 seconds you'll have 20 events with 20 second interval and 1 second between each one.

[dude891]

Thanks it worked. I just wasn't using my mind right. +Rep