GetLocalizedText Problem

[Creepwalker]

I've been having a problem with getting return values of variables passed by DoString. My DoString works flawlessly, I'm able to call protected functions, ect, but every time I try using getLocalizedText it never returns anything.

Doing everything through my console using also works, ex: playerName = UnitName("player"); ----- print(playerName)
Example:

        public string CharacterName()
        {
            DoString("playerName = UnitName(\"player\");");

            var playername = (GetLocalizedText("playerName"));

            return playername;
        }

        public ulong PlayerGuid()
        {
        DoString("guid = UnitGUID(\"player\")");
        string guid = GetLocalizedText("guid");

        return (Convert.ToUInt64(guid, 16));
}

Both calls return nothing.

Here is GetLocalizedText:

        public string GetLocalizedText(string variable)
        {

            uint codeCave = _wowHook.Memory.AllocateMemory(Encoding.UTF8.GetBytes(variable).Length + 1);
            _wowHook.Memory.WriteBytes(codeCave, Encoding.UTF8.GetBytes(variable));

            String[] asm = new String[]
            {
                "call " + (Offsets.lua.ClntObjMgrGetActivePlayerObj + _wowHook.Process.BaseOffset()) ,                            
                "mov ecx, eax",
                "push -1",
                "mov edx, " + codeCave + "",
                "push edx",
                "call " + (Offsets.lua.FrameScript__GetLocalizedText + _wowHook.Process.BaseOffset()) ,
                "retn",
            };

            

            string varResult = Encoding.ASCII.GetString(_wowHook.InjectAndExecute(asm));
            _wowHook.Memory.FreeMemory(codeCave);

            return varResult;
        }

I know there are different methods, and this one is prone to UI taint, but I'd really like to be able to get this too work.


Thanks

[JuJuBoSc]

string varResult = Encoding.ASCII.GetString(_wowHook.InjectAndExecute(asm));

This is wrong, GetLocalizedText return a pointer to a string, so you need to read it from here.

[Jadd]

You should also use FrameScript_GetText, it's faster and works without relying on an active player pointer (ie. can be used out of game).

Try this:

            String[] asm = new String[]
            {
                "push 0",
                "push -1",
                "mov edx, " + codeCave,
                "push edx",
                "call " + (Offsets.lua.FrameScript_GetText + _wowHook.Process.BaseOffset()) ,
                "add esp, 0Ch",
                "retn"
            };

Also, what JuJuBoSc said - the string is located at the address in the return value. You need to read it from there.

Btw, your code has a huge memory leak and is slow. I would also suggest that you install the execution assembly once and reuse it with each time it needs to run GetText.

[Creepwalker]

string varResult = Encoding.ASCII.GetString(_wowHook.InjectAndExecute(asm));

This is wrong, GetLocalizedText return a pointer to a string, so you need to read it from here.

Ahh, thank you for spotting that!

You should also use FrameScript_GetText, it's faster and works without relying on an active player pointer (ie. can be used out of game).

Try this:

            String[] asm = new String[]
            {
                "push 0",
                "push -1",
                "mov edx, " + codeCave,
                "push edx",
                "call " + (Offsets.lua.FrameScript_GetText + _wowHook.Process.BaseOffset()) ,
                "add esp, 0Ch",
                "retn"
            };

Also, what JuJuBoSc said - the string is located at the address in the return value. You need to read it from there.

Btw, your code has a huge memory leak and is slow. I would also suggest that you install the execution assembly once and reuse it with each time it needs to run GetText.

Can you elaborate on the memory leak please?

[Jadd]

Can you elaborate on the memory leak please?

You're not freeing the memory which was allocated for the execution assembly.. and this happens every time you call your GetLocalizedText function. Like I said, you should install the assembly once and reuse it, this would take care of this problem and would be much faster than injecting and freeing the code every time.