[snippet]Get Object By GUID

[J0llyGr33n]

Hey all, just occurred to me that I have not actually posted anything or really given anything back so I decided I wanted to post some simple code I have been using.
First Id like you to note its kinda messy, but it puts the basic idea out there. Its basically a replica of how you would get an object by GUID from object manager except I moved it over to check the Display ID as well. This way I can find anything in Object Manager by Model - This specific piece of code was used in my fishing program but with minor tweaking could be easily used to check for anything via Display ID.

Edit: Just noticed I ****ed up on title. Its meant to be GetObjectbydisplay

Edit: Removed a silly mistake I just noticed

DWORD ObjectManager::GetObjectByDisplay(HANDLE hProcess, DWORD BaseAddress, int DisplayId, DWORD s_curMgr, UINT64 localGUID)
{
	// The code below finds the object based on its display id and returns its object base.
	DWORD BytesRead;
	DWORD cObj, lObj, nObj;
	UINT64 cGUID;
	DWORD DescriptorFields;
	//DWORD ObjectEnd =0x20;
	DWORD Object_CreatedByOffset = 0x20;
	DWORD DisplayId_Offset = 0x28;
	int count = 0;
	ReadProcessMemory(hProcess, (LPCVOID)(s_curMgr + 0xC0), &cObj, 4, &BytesRead);
	while (cObj != 0 && (cObj & 1) == 0)
	{
		ReadProcessMemory(hProcess, (LPCVOID)(cObj + 0xC), &DescriptorFields, 4, &BytesRead);
		ReadProcessMemory(hProcess, (LPCVOID)(DescriptorFields + Object_CreatedByOffset), &cGUID, 8, &BytesRead);
		ReadProcessMemory(hProcess, (LPCVOID)(DescriptorFields +  DisplayId_Offset), &DisplayId, 4, &BytesRead);
		
		if (cGUID == localGUID)
		{
			count = count + 1;
			if(DisplayId == 668)
			{
				lObj = cObj; // lObj is our fishing bobbers object.
				return lObj;
				break;
			}
		}

		ReadProcessMemory(hProcess, (LPCVOID)(cObj + 0x3C), &nObj, 4, &BytesRead);
		if (nObj == cObj)
		{
			//std::cout << "returned";
			return -1;
		}
		else
		{
			cObj = nObj;
		}
	}
	return -1;
}

I hope this is helpful to someone. Feel free to comment on the code, or anything - I'm always open to constructive criticism and want to improve because I understand I am far from perfect. Just keep in mind that the main point of this is to point out the idea, and show a way to do it.

Note no real error checking.

[Reflexes]

Hi, i wanna send you a message but icant because u have too many messages inside the meassagebox.

[J0llyGr33n]

Hey Reflexes should be better now. Try again.

[Master674]

<something used to be here... its gone now>

[J0llyGr33n]

@Master
I've been working with this way because I am still new to dealing with WoW and I have yet to explore my options entirely. While I do experiment with different things I've yet to update my classes because I don't like implementing things I don't understand well. I'm not amazing at C++ but have enough to get by and am working on improving on it.

Thanks for your feedback