EnumVisibleObjects problem

[TOM_RUS]

Haven't looked at the original code but I assume it's because ForEach cannot iterate over a modified collection.

Exactly that.

well that doesn't change anything about the fact that there are no objects getting stored in that list i changed it so it'll work when there are objects in it, but all the functions, the activeplayer as well as the enum objects funktion, are returning nothing.

Are you sure that Pulse() method being called at all? Try to put some logging methods inside and check that it's being called.

[MaiN]

Exactly that.

And where again is he modifying the iterating collection?

[TOM_RUS]

And where again is he modifying the iterating collection?

No idea, but it's throwing exceptions :P I tested his code and it fails here.

[MaiN]

No idea, but it's throwing exceptions :P I tested his code and it fails here.

There shouldn't. What was the exception?

[TOM_RUS]

There shouldn't. What was the exception?

System.InvalidOperationException was unhandled
Message="Collection was modified; enumeration operation may not execute."

[YetiHunter]

curiously i have the exact same problem at the moment and i've been following the thread

Are you sure that Pulse() method being called at all? Try to put some logging methods inside and check that it's being called.

that is interesting. like suggested im checking if i'm in world

            if (ObjectManager.IsInWorld)
                ObjectManager.Pulse();

IsInWorld returns false, but the objectmanager.pulse() method is still called. i just put a 1 second sleep in there and the game starts "lagging" ...

[MaiN]

System.InvalidOperationException was unhandled
Message="Collection was modified; enumeration operation may not execute."

Well, that I didn't see coming.. I find that very strange. Oh well.

[Nesox]

do something like that, iterate it backwards and use RemoveAt and it shouldn't throw the InvalidOperationException.
That's just a poor example don't think it will work properly but you get the idea (do it backwards)

 private static void RemoveInvalidEntries()
        {
            var guids = (from o in RealObjects
                         where !o.Value.IsValid
                         select o.Key).ToArray();

            for(int i = guids.Length - 1; i >= 0; i--)
            { 
                RealObjects.RemoveAt(i);
            }
        }

[Robske]

do something like that, iterate it backwards and use RemoveAt and it shouldn't throw the InvalidOperationException.
That's just a poor example don't think it will work properly but you get the idea (do it backwards)

 private static void RemoveInvalidEntries()
        {
            var guids = (from o in RealObjects
                         where !o.Value.IsValid
                         select o.Key).ToArray();

            for(int i = guids.Length - 1; i >= 0; i--)
            { 
                RealObjects.RemoveAt(i);
            }
        }

Well that's wrong. There's no guarantee that the (n-i)'th guid in your guids collection was the i'th guid in the RealObjects collection.

Did you perhaps mean

RealObjects.Remove(guids[i]);

?

[YetiHunter]

i made a litte bit of progress. i was able to trace the problem to the get object by guid function. i get the guid, but the getObjByGuid funktion returns 0. the address is correct and if i try to filter for a type (for example players, so i use 4 as filter) it crashes. TOM_RUS mentioned something that the filter isn't actually a int if i understood correct but a pointer to an int. I tried it, but no success and no crashing. am i doing it wrong or is the pointerapproach wrong?

[Nesox]

Well that's wrong. There's no guarantee that the (n-i)'th guid in your guids collection was the i'th guid in the RealObjects collection.

Did you perhaps mean

RealObjects.Remove(guids[i]);

?

No.
If ure gonna modify a collection while iterating it you need to do it backwards otherwise you would change the size of it and cause the "System.InvalidOperationException was unhandled
Message="Collection was modified; enumeration operation may not execute."excetion to get thrown,

var guids = (from o in ObjectManager.ObjectList
             where !o.IsValid
             select o).ToArray();

for (int i = ObjectManager.ObjectList.Count - 1; i >= 0; i--)
{
    if(guids.Contains(ObjectManager.ObjectList[i]))
        ObjectManager.ObjectList.RemoveAt(i);
}

[amadmonk]

Erm... you guys DO know about List<T>.RemoveAll, right?

List(T).RemoveAll Method (System.Collections.Generic)

This neatly bypasses all of the "modified collection" issues by simply removing all items that match a predicate (o => !o.IsValid, in this case).

Otherwise, to sidestep the modified collection issue, I usually just clone the input collection as a source for invalids (in other words: I have a list, Foo. I clone it and make Foo2. Then, for each "bad" item in Foo2, I remove the corresponding item from Foo). For small lists -- like the list of "bad" objects in WoW -- this is perfectly reasonable.

Still, RemoveAll is better.

[suicidity]

Now I didn't read the thread; Just this last page..

But why would anyone try iterating a list and try removing everything themselves? Do what amadmonk said, List.RemoveAll with a predicate that you want removed.

[YetiHunter]

i'm sorry to interrupt the discussion but does anyone know why my getObjByGuid function call is not working properly?

[TOM_RUS]

ObjectList isn't List. It's Dictionary and doesn't have RemoveAll implementation.
I already posted solution on previous page: http://www.mmowned.com/forums/wow-me...ml#post1820129

i'm sorry to interrupt the discussion but does anyone know why my getObjByGuid function call is not working properly?

That means that EnumVisibleObjects also doesn't work properly. Try to dig it.