[QUESTION] isDead() or unit dead

[mordok]

Im having a hard time at creating a good way too check if a unit is dead (The flag way).

I tried UNIT_DYNAMIC_FLAGS and 0x20 to find out if the unit im targeting is dead but, it always returns false.

I guess I could always determine if a unit is dead by checking if its lootable, but I wouldnt like to do this knowing that there´s a flag for that single purpose.

Any Ideas??? Would it be the same for unit than for my player?

[Apoc]

Lol. GJ cleaning up after yourself. I moved the thread for ya.

public bool Dead { get { return CurrentHealth == 0; } }

[mordok]

Thanks APOC, but Im searching for the flag way. Checking if the unit health is 0 sometimes worked bad for me in the past.

BTW, epic thread movment XD.

[Oowafas]

Health is zero always seemed to work for me as long as the unit didn't despawn. I think on despawns you can just check to see if it isn't in the object list though (not 100% on that).

[flo8464]

UnitIsDead 0x594370

signed int __cdecl wowlua_UnitIsDead(int luastate)
{
  int ST2C_4_0; // ST2C_4@0
  int luastate_c; // esi@1
  int object; // eax@3
  int v5; // ecx@4
  int v6; // eax@8
  char *unitkeyword; // eax@3
  double v8; // ST24_8@7
  __int64 guid; // [sp+14h] [bp-8h]@3
  __int64 guid_c; // [sp+Ch] [bp-10h]@3

  luastate_c = luastate;
  if ( !lua_isString(luastate, 1) )
  {
    lua_reportError(luastate_c, "Usage: UnitIsDead(\"unit\")", ST2C_4_0);
    return 0;
  }
  unitkeyword = (char *)lua_toString(luastate_c, 1, 0);
  guid = 0i64;
  getGuidByKeyword(unitkeyword, &guid, 0);
  guid_c = guid;
  object = getObjectByGuidFiltered(guid, 8);
  if ( object )
  {
    v5 = *(_DWORD *)(object + 0xD0);
    if ( *(_DWORD *)(v5 + 0x44) <= 0
      || (*(_DWORD *)(v5 + 0x120) >> 5) & 1 && (guid = **(_QWORD **)(object + 8), !sub_4B2B40(&guid)) )
    {
LABEL_7:
      __asm
      {
        fld1
        fstp    [esp+1Ch+var_1C]
      }
      lua_pushNumber(luastate_c, v8);
      return 1;
    }
  }
  else
  {
    v6 = sub_4B3A10(&guid_c);
    if ( v6 && *(_BYTE *)(v6 + 8) & 4 )
      goto LABEL_7;
  }
  lua_pushNil(luastate_c);
  return 1;
}

[Apoc]

signed int __cdecl lua_UnitIsDead(int *pL)
{
  int *v1; // esi@1
  WoWUnit *v3; // eax@3
  UnitDescriptors *v4; // ecx@4
  int v5; // eax@8
  char *v6; // eax@3
  double v7; // ST24_8@7
  WGUID guid; // [sp+14h] [bp-8h]@3
  WGUID v9; // [sp+Ch] [bp-10h]@3

  v1 = pL;
  if ( !FrameScript__IsString(pL, 1) )
  {
    FrameScript_DisplayError(v1, "Usage: UnitIsDead(\"unit\")");
    return 0;
  }
  v6 = FrameScript_ToLString(v1, 1, 0);
  guid = 0i64;
  GetGUIDByKeyword(v6, &guid, 0);
  v9 = guid;
  v3 = (WoWUnit *)ClntObjMgrObjectPtr(guid, OT_UNIT);
  if ( v3 )
  {
    v4 = v3->UnitInfo;
    if ( v4->UNIT_FIELD_HEALTH <= 0
      || (v4->UNIT_DYNAMIC_FLAGS >> 5) & 1
      && (*(_QWORD *)&guid = *(_QWORD *)v3->Object.ObjInfo, !sub_4B2B40((int)&guid)) )
    {
LABEL_7:
      __asm
      {
        fld1                    ; 
        fstp    [esp+1Ch+var_1C]; 
      }
      FrameScript_PushNumber(v1, v7);
      return 1;
    }
  }
  else
  {
    v5 = sub_4B3A10(&v9);
    if ( v5 && *(_BYTE *)(v5 + 8) & 4 )
      goto LABEL_7;
  }
  FrameScript_pushnil(v1);
  return 1;
}

[mordok]

if ( v4->UNIT_FIELD_HEALTH <= 0 || (v4->UNIT_DYNAMIC_FLAGS >> 5)

So you check if its health is <= 0 or (dynamiflag inputed to 5) & 1

Im trying to do it without injection, btw(not that im scared of it, its just a mater of personal taste XD)

Im not sure whats the >> equivalent in C# ill try to find that first.

Many thanks for your efforts helping me.

[Apoc]

if ( v4->UNIT_FIELD_HEALTH <= 0 || (v4->UNIT_DYNAMIC_FLAGS >> 5)

So you check if its health is <= 0 or (dynamiflag inputed to 5) & 1

Im trying to do it without injection, btw(not that im scared of it, its just a mater of personal taste XD)

Im not sure whats the >> equivalent in C# ill try to find that first.

Many thanks for your efforts helping me.

1 << 5 == 0x20

Anyhow; just check if health <= 0. It will always work if the unit is valid. (The other check is a sanity check, which hardly ever gets used anyway)

[mordok]

Thanks apoc and flo8464. That would do the trick ^^.

[adaephon]

Im not sure whats the >> equivalent in C# ill try to find that first.

Many thanks for your efforts helping me.

Not sure if you found it, but in that context '<<' and '>>' are binary or bit shift operators and they are the same in C# and C++

[arthanos2]

Any idea why UNIT_FIELD_HEALTH reads 0 immediately after dismounting and performing mining? After remounting it reads the correct value again.


Tested with JUST the single memoryread to verify nothing else was rotten in my code, same results, dismount - mine -> UNIT_FIELD_HEALTH == 0.
This seems to make absolutely no sense to me.

[lanman92]

You're obviously doing something wrong. Try re-grabbing pointers to your player object when you need it. It's not really a performance issue. Don't cache shit. This is my best guess.