[CODE] IsMounted

[miceiken]

Thought I'd share something for once. I use Therm's HasAura function:

        public bool HasBuff(int BuffId)
        {
            uint
                buff = 1,
                address = BaseAddress + BuffStartOffset;
            while (buff != 0)
            {
                buff = core.WBM.ReadUInt(address);
                if (buff == BuffId)
                    return true;
                address += 0x4;
            }
            return false;
        }

and here's the code:

public bool IsMounted(PlayerObject plr)
        {
            // Mount test based on spell ID - Updated: 11.21.2008
            int[] mountBuffsID = {
                43688, //   Amani War bear
                48778, //   Archerus Deathcharger
                60114, //   Armored Brown Bear (Alliance)
                60116, //   Armored Brown Bear (Horde)
                51412, //   Big Battle Bear
                58999, //   Big Blizzard Bear (Blizzcon 2008)
                58997, //   Big Blizzard Bear (Blizzcon 2007)
                35022, //    Black Hawkstrider
                59572, //   Black Polar Bear
                6896, //    Black Ram
                17461, //    Black Ram
                60119, //   Black War Bear (Alliance)
                60118, //   Black War Bear (Horde)
                22718, //    Black War Kodo
                59788, //   Black War Mammoth (Alliance)
                59785, //   Black War Mammoth (Horde)
                22720, //    Black War Ram
                22721, //    Black War Raptor
                22717, //    Black War Steed
                22723, //    Black War Tiger
                22724, //    Black War Wolf
                578, //    Black Wolf
                35020, //    Blue Hawkstrider
                10969, //    Blue Mechanostrider
                33630, //    Blue Mechanostrider
                6897, //    Blue Ram
                17463, //    Blue Skeletal Horse
                43899, //    Brewfest Ram
                34406, //    Brown Elekk
                458, //    Brown Horse
                18990, //    Brown Kodo
                59573, //   Brown Polar Bear
                6899, //    Brown Ram
                17464, //    Brown Skeletal Horse
                6654, //    Brown Wolf
                6648, //    Chestnut Mare
                39315, //    Cobalt Riding Talbuk
                34896, //    Cobalt War Talbuk
                39316, //    Dark Riding Talbuk
                34790, //    Dark War Talbuk
                17481, //    Deathcharger
                6653, //    Dire Wolf
                8395, //    Emerald Raptor
                36702, //    Fiery Warhorse
                23509, //    Frostwolf Howler
                16060, //    Golden Sabercat
                61465, //   Grand Black War Mammoth (Alliance 2 Passengers)
                59811, //   Grand Black War Mammoth (Horde 2 Passengers)
                59810, //   Grand Black War Mammoth (Alliance 2 Vendors)
                61467, //   Grand Black War Mammoth (Horde 2 Vendors)
                59804, //   Grand Ice Mammoth (Horde)
                59802, //   Grand Ice Mammoth (Alliance)
                35710, //    Gray Elekk
                18989, //    Gray Kodo
                6777, //    Gray Ram
                459, //    Gray Wolf
                35713, //    Great Blue Elekk
                23249, //    Great Brown Kodo
                34407, //    Great Elite Elekk
                23248, //    Great Gray Kodo
                35712, //    Great Green Elekk
                35714, //    Great Purple Elekk
                23247, //    Great White Kodo
                18991, //    Green Kodo
                15780, //    Green Mechanostrider
                17453, //    Green Mechanostrider
                17465, //    Green Skeletal Warhorse
                824, //    Horse Riding
                6743, //    Horse Riding
                59797, //   Ice Mammoth (Horde)
                59799, //   Ice Mammoth (Alliance)
                17459, //    Icy Blue Mechanostrider
                16262, //    Improved Ghost Wolf
                16287, //    Improved Ghost Wolf
                10795, //    Ivory Raptor
                17450, //    Ivory Raptor
                18995, //    Kodo Riding
                18996, //    Kodo Riding
                16084, //    Mottled Red Raptor
                16055, //    Nightsaber
                10798, //    Obsidian Raptor
                42936, //    Ornery Ram
                44370, //    Pink Elekk Call
                472, //    Pinto Horse
                35711, //    Purple Elekk
                35018, //    Purple Hawkstrider
                17455, //    Purple Mechanostrider
                23246, //    Purple Skeletal Warhorse
                826, //    Ram Riding
                6744, //    Ram Riding
                17456, //    Red & Blue Mechanostrider
                34795, //    Red Hawkstrider
                10873, //    Red Mechanostrider
                17462, //    Red Skeletal Horse
                22722, //    Red Skeletal Warhorse
                43883, //    Rental Racing Ram
                18363, //    Riding Kodo
                30174, //    Riding Turtle
                39317, //    Silver Riding Talbuk
                34898, //    Silver War Talbuk
                8980, //    Skeletal Horse
                10921, //    Skeletal Horse Riding
                29059, //    Skeletal Steed
                42776, //    Spectral Tiger
                10789, //    Spotted Frostsaber
                15781, //    Steel Mechanostrider
                23510, //    Stormpike Battle Charger
                8394, //    Striped Frostsaber
                10793, //    Striped Nightsaber
                897, //    Summon Angry Programmer
                44369, //    Summon Baby Pink Elekk
                31700, //    Summon Black Qiraji Battle Tank
                26655, //    Summon Black Qiraji Battle Tank
                26656, //    Summon Black Qiraji Battle Tank
                25863, //    Summon Black Qiraji Battle Tank
                25953, //    Summon Blue Qiraji Battle Tank
                32723, //    Summon Bonechewer Riding Wolf
                34767, //    Summon Charger
                23214, //    Summon Charger
                23215, //    Summon Charger
                34766, //    Summon Charger
                23261, //    Summon Darkreaver's Fallen Charger
                31331, //    Summon Dire Wolf
                23161, //    Summon Dreadsteed
                38311, //    Summon Eclipsion Hawkstrider
                1710, //    Summon Felsteed
                5784, //    Summon Felsteed
                5968, //    Summon Ghost Saber
                6084, //    Summon Ghost Saber
                26056, //    Summon Green Qiraji Battle Tank
                30829, //    Summon Kessel's Elekk
                30837, //    Summon Kessel's Elekk
                30840, //    Summon Kessel's Elekk Trigger
                39782, //    Summon Lightsworn Elekk
                18166, //    Summon Magram Ravager
                26054, //    Summon Red Qiraji Battle Tank
                41543, //    Summon Reins (Jorus)
                41544, //    Summon Reins (Malfas)
                41546, //    Summon Reins (Onyxien)
                41547, //    Summon Reins (Suraku)
                41548, //    Summon Reins (Voranaku)
                41549, //    Summon Reins (Zoya)
                39783, //    Summon Scryer Hawkstrider
                7910, //    Summon Tamed Raptor
                7915, //    Summon Tamed Turtle
                4946, //    Summon Tamed Wolf
                13819, //    Summon Warhorse
                13820, //    Summon Warhorse
                34768, //    Summon Warhorse
                34769, //    Summon Warhorse
                23241, //    Swift Blue Raptor
                43900, //    Swift Brewfest Ram
                23238, //    Swift Brown Ram
                23229, //    Swift Brown Steed
                23250, //    Swift Brown Wolf
                23220, //    Swift Dawnsaber
                23221, //    Swift Frostsaber
                23239, //    Swift Gray Ram
                23252, //    Swift Gray Wolf
                35025, //    Swift Green Hawkstrider
                23225, //    Swift Green Mechanostrider
                33184, //   Swift Magic Broom
                23219, //    Swift Mistsaber
                23242, //    Swift Olive Raptor
                23243, //    Swift Orange Raptor
                23227, //   Swift Palomino
                33660, //    Swift Pink Hawkstrider
                35027, //    Swift Purple Hawkstrider
                24242, //    Swift Razzashi Raptor
                42777, //    Swift Spectral Tiger
                23338, //    Swift Stormsaber
                23251, //    Swift Timber Wolf
                35028, //    Swift War Hawkstrider
                23223, //    Swift White Mechanostrider
                23240, //    Swift White Ram
                23228, //    Swift White Steed
                23222, //    Swift Yellow Mechanostrider
                24252, //    Swift Zulian Tiger
                49322, //    Swift Zhevra
                39318, //    Tan Riding Talbuk
                34899, //    Tan War Talbuk
                16059, //    Tawny Sabercat
                18992, //    Teal Kodo
                22480, //    Tender Wolf Steak
                10790, //    Tiger
                61447, //   Traveler's Tundra Mammoth (Alliance)
                61425, //   Traveler's Tundra Mammoth (Horde)
                10796, //    Turquoise Raptor
                77, //    Turtle's Shell
                17454, //    Unpainted Mechanostrider
                10799, //    Violet Raptor
                15779, //    White Mechanostrider
                54753, //   White Polar Bear Mount (WotLK Dailies Reward)
                6898, //    White Ram
                39319, //    White Riding Talbuk
                34897, //    White War Talbuk
                17229, //    Winterspring Frostsaber
                59793, //   Wooly Mammoth (Alliance)
                59791, //   Wooly Mammoth (Horde)
            };

            foreach (int MountID in mountBuffsID)
            {
                if (plr.HasBuff(MountID))
                    return true;
            }
            return false;
        }

There's some 3.1 mounts missing etc, but haven't added them as I don't have them

Enjoy!

[Apoc]

Nicely done. I sure hope your player object has a way to get current buff IDs so you can cache them. (Personally, I'd just use the IsMounted() LUA)

[miceiken]

Yeah, I need implement caching and buffsnapshots, looping through all buffs for each id is certainly one unnecessary resource hog.

[Cypher]

Wow... Slow method is sloooooooooooooooooooooow.

Just rip the logic from the LUA API:

.text:006A4800 LuaImpl_IsMounted proc near             ; DATA XREF: .data:00A35AC4o
.text:006A4800
.text:006A4800 var_8           = qword ptr -8
.text:006A4800 arg_0           = dword ptr  8
.text:006A4800
.text:006A4800                 push    ebp
.text:006A4801                 mov     ebp, esp
.text:006A4803                 call    sub_7B7B10
.text:006A4808                 push    0A1h
.text:006A480D                 push    offset aCBuildserve_14 ; "c:\\BuildServer\\bs1\\work\\WoW-code\\branch"...
.text:006A4812                 push    10h
.text:006A4814                 push    edx
.text:006A4815                 push    eax
.text:006A4816                 call    sub_7B93A0
.text:006A481B                 add     esp, 14h
.text:006A481E                 test    eax, eax
.text:006A4820                 jz      short loc_6A4852
.text:006A4822                 cmp     dword ptr [eax+9C0h], 0
.text:006A4829                 jle     short loc_6A4852
.text:006A482B                 test    dword ptr [eax+0A30h], 10000000h
.text:006A4835                 jnz     short loc_6A4852
.text:006A4837                 fld1
.text:006A4839                 mov     eax, [ebp+arg_0]
.text:006A483C                 sub     esp, 8
.text:006A483F                 fstp    [esp+8+var_8]
.text:006A4842                 push    eax             ; int
.text:006A4843                 call    sub_916250
.text:006A4848                 add     esp, 0Ch
.text:006A484B                 mov     eax, 1
.text:006A4850                 pop     ebp
.text:006A4851                 retn
.text:006A4852 ; ---------------------------------------------------------------------------
.text:006A4852
.text:006A4852 loc_6A4852:                             ; CODE XREF: LuaImpl_IsMounted+20j
.text:006A4852                                         ; LuaImpl_IsMounted+29j ...
.text:006A4852                 mov     ecx, [ebp+arg_0]
.text:006A4855                 push    ecx
.text:006A4856                 call    sub_916230
.text:006A485B                 add     esp, 4
.text:006A485E                 mov     eax, 1
.text:006A4863                 pop     ebp
.text:006A4864                 retn
.text:006A4864 LuaImpl_IsMounted endp

Would seem like the obvious thing to do imo...

Faster and more reliable. Where's the bad?

[miceiken]

The bad is: I have no idea on how to inject to the assembly nor how or what I am doing.

[g3gg0]

injecting?

interpreting:
.text:006A4822 cmp dword ptr [eax+9C0h], 0

does not need any injection.
thats more like copy-pasta

[jjaa]

006A4822 |. 83B8 C0090000 >CMP DWORD PTR DS:[EAX+9C0],0

^^^
that's what you want

*(DWORD*)(pBase + 0x9C0) ? printf("True") : printf("False");

[Nesox]

Or you can just check ure mountdisplayid it it's nonzero wont work for druids and fo druids u can just compare the displayid to a array =)

[Cypher]

You don't need to inject anything, its comprehension....

If you can't read ASM then please go learn to do that so we don't have to spoonfeed you information.

[kynox]

You don't need to inject anything, its comprehension....

If you can't read ASM then please go learn to do that so we don't have to spoonfeed you information.

It's rather apparent he doesn't.

[miceiken]

006A4822 |. 83B8 C0090000 >CMP DWORD PTR DS:[EAX+9C0],0

^^^
that's what you want

*(DWORD*)(pBase + 0x9C0) ? printf("True") : printf("False");

Thanks, will this also work for other units, like players or NPCs?

It's rather apparent he doesn't.

As I already admitted.

[Cypher]

It's rather apparent he doesn't.

Indeed.

Thanks, will this also work for other units, like players or NPCs?


As I already admitted.

We don't care whether you've admitted it. We care whether you're going to fix it.

Also, stop asking for ****ing spoonfeeding, how about checking shit for yourself? Not like its hard to test that code.

[Therrm]

Haha I wish I knew what happened during Cypher's childhood ^^ It is so funny to read your posts

Anyway nice job Miceiken That's how everyone (including you Cypher) had started to learn more things... So no problem with this guy

[miceiken]

Haha, good one Therrm.
Thanks for understanding, I will shape up however.
Good job on the function by the way

[Cypher]

Haha I wish I knew what happened during Cypher's childhood ^^ It is so funny to read your posts

Anyway nice job Miceiken That's how everyone (including you Cypher) had started to learn more things... So no problem with this guy

Haha, good one Therrm.
Thanks for understanding, I will shape up however.
Good job on the function by the way

When you two are done, I'd like to point out that its irrelevant whether you're a beginner or a programming god who can code in machine language whilst solving complex equations and juggling.

This section has stringent rules and guidelines that transcend any of your "but i'm just a beginner" (for lack of a better word) bullshit.