World 2 Screen in BFA

[WiNiFiX]

Hi all,
Does anyone know the new struct for BFA for CGCamera? as my one for Vanilla in the below code no longer works

    public static class Camera
    {
        public static ProcessSharp ProcessSharp { get; private set; }


        public static int CameraOffset { get; } = 0x3330;


        internal static IntPtr BaseAddress
        {
            get
            {
                var ptr = ProcessSharp.Memory.Read<IntPtr>(Offsets.CameraBase);
                return ProcessSharp.Memory.Read<IntPtr>(ptr + CameraOffset);
            }
        }


        [StructLayout(LayoutKind.Sequential)]
        public unsafe struct CGCamera
        {
            private readonly IntPtr vTable;     // 0x0
            private readonly int unk0;          // 0x4
            public Vector3 Position;            // 0x8
            private fixed float Facing[9];      // 0x14 (3x3 Matrix)
            public readonly float NearClip;     // 0x38
            public readonly float FarClip;      // 0x3C
            public readonly float FieldOfView;  // 0x40
            public readonly float Aspect;       // 0x44
        }


        private static CGCamera cam => ProcessSharp.Memory.Read<CGCamera>(BaseAddress);
        public static float X => cam.Position.X;
        public static float Y => cam.Position.Y;
        public static float Z => cam.Position.Z;
        public static float FOV => cam.FieldOfView;
        public static float NearClip => cam.NearClip;
        public static float FarClip => cam.FarClip;
        public static float Aspect => cam.Aspect;


        private static Matrix Matrix
        {
            get
            {
                var bCamera = ProcessSharp.Memory.Read(BaseAddress + 0x1C, 36);  // was 0x14 not 0x1C in 1.12.1
                var m = new Matrix();
                m[0, 0] = BitConverter.ToSingle(bCamera, 0);
                m[0, 1] = BitConverter.ToSingle(bCamera, 4);
                m[0, 2] = BitConverter.ToSingle(bCamera, 8);
                m[1, 0] = BitConverter.ToSingle(bCamera, 12);
                m[1, 1] = BitConverter.ToSingle(bCamera, 16);
                m[1, 2] = BitConverter.ToSingle(bCamera, 20);
                m[2, 0] = BitConverter.ToSingle(bCamera, 24);
                m[2, 1] = BitConverter.ToSingle(bCamera, 28);
                m[2, 2] = BitConverter.ToSingle(bCamera, 32);


                return m;
            }
        }


        public static Vector2 WorldToScreen(float x, float y, float z)
        {
            var Projection = Matrix.PerspectiveFovRH(FOV * 0.5f, Aspect, NearClip, FarClip);


            var eye = new Vector3(X, Y, Z);
            var lookAt = new Vector3(X + Matrix[0, 0], Y + Matrix[0, 1], Z + Matrix[0, 2]);
            var up = new Vector3(0f, 0f, 1f);


            var View = Matrix.LookAtRH(eye, lookAt, up);
            var World = Matrix.Identity;


            var WorldPosition = new Vector3(x, y, z);


            var ScreenPosition = Vector3.Project(WorldPosition, 0f, 0f, WindowHelper.WindowWidth, WindowHelper.WindowHeight, NearClip, FarClip, World * View * Projection);
            return new Vector2(ScreenPosition.X, ScreenPosition.Y - 20f);
        }


        public static void Initialize(ProcessSharp processSharp)
        {
            ProcessSharp = processSharp;
            WindowHelper.Initialize(processSharp);


            Log.Write("Camera Ready", Color.Green);
            Log.Write($"Camera Base 0x{BaseAddress.ToString("X")}");
            Log.Write($"FOV          = {FOV}");
            Log.Write($"Aspect       = {Aspect}");
            Log.Write($"NearClip     = {NearClip}");
            Log.Write($"FarClip      = {FarClip}");
            Log.Write($"Camera X     = {X}");
            Log.Write($"Camera Y     = {Y}");
            Log.Write($"Camera Z     = {Z}");
            Log.Write($"Matrix[0, 0] = {Matrix[0, 0]}");
            Log.Write($"Matrix[0, 1] = {Matrix[0, 1]}");
            Log.Write($"Matrix[0, 2] = {Matrix[0, 2]}");
            Log.Write($"WindowWidth  = {WindowHelper.WindowWidth}");
            Log.Write($"WindowHeight = {WindowHelper.WindowHeight}");
        }
   }

[Sychotix]

Check https://www.ownedcore.com/forums/wor...ml#post3879642 ([Wow] [8.0.1.27219])

I use these offsets. Obviously the camera base needs updating.

[WiNiFiX]

Check https://www.ownedcore.com/forums/wor...ml#post3879642 ([Wow] [8.0.1.27219])


I use these offsets. Obviously the camera base needs updating.

Thanks I saw those CameraBase is a pattern

CameraBase = GetAddressFromPattern("48 8B 0D ?? ?? ?? ?? 48 8B 74 24 48 48", 3, 4);

but can't figure out how to get some values like Aspect?

Details         Hex    Dec
CameraOriginX : 0x10 = 16
CameraOriginY : 0x14 = 20
CameraOriginZ : 0x18 = 24
CameraMatrix  : 0x1C = 28
CameraFov     : 0x40 = 64
CameraAspect  : ?

[Sychotix]

Thanks I saw those CameraBase is a pattern

CameraBase = GetAddressFromPattern("48 8B 0D ?? ?? ?? ?? 48 8B 74 24 48 48", 3, 4);

but can't figure out how to get some values like Aspect?

Details         Hex    Dec
CameraOriginX : 0x10 = 16
CameraOriginY : 0x14 = 20
CameraOriginZ : 0x18 = 24
CameraMatrix  : 0x1C = 28
CameraFov     : 0x40 = 64
CameraAspect  : ?

Well, based off the original offsets you posted, aspect was 4 bytes after FoV. I'd assume its 0x44 still, but worst case... you know the aspect ratio of your screen.

[WiNiFiX]

Well, based off the original offsets you posted, aspect was 4 bytes after FoV. I'd assume its 0x44 still, but worst case... you know the aspect ratio of your screen.

Edit: after lots of fiddling I got most reading correctly - but now I have 3 unknowns NearClip, FarClip and Aspect, anyone got methods to find those?

Camera Base 0x17126FD0E40
Camera vTable = 7FF787242D78
Camera X      = -895.1711
Camera Y      = 4344.633
Camera Z      = 766.7753
Matrix[0, 0]  = -0.598479
Matrix[0, 1]  = -0.2134038
Matrix[0, 2]  = -0.7721928
Matrix[1, 0]  = 0.3358636
Matrix[1, 1]  = -0.9419107
Matrix[1, 2]  = 0
Matrix[2, 0]  = -0.7273366
Matrix[2, 1]  = -0.2593514
Matrix[2, 2]  = 0.635388
NearClip      = ?
FarClip       = ?
FOV           = 1.570796
Aspect        = 5.170791E-43 ?
WindowWidth   = 2560
WindowHeight  = 1080

        public unsafe struct CGCamera
        {
            public readonly IntPtr vTable;     // 0x0
            public readonly int unk0;          // 0x4
            public readonly int unk1;          // 0x8
            public Vector3 Position;           // 0x10
            public fixed float Facing[9];      // 0x14 (3x3 Matrix)            
            public readonly float FieldOfView; // 0x40
            public readonly float Aspect;      // 0x44
        }