Originally Posted by
derfred
Ithink I found something that maybe could be improved; when in cleave-mode(holding key) it doesnt seem to be prioritizing flame shock on focus as much as when doing pure single target?
I basically need to let it dot up in single target and after I can start to cleave
so i think the issue is that you have more stacks of lightning shield / fulmination but you shouldn't on cleave as chain lightning has a 1/3 modifier
Code:
local FSHOCK,_,_,_,_,_,FSHOCKTIMER = UnitDebuffID("focus",8050,"PLAYER")
local LSH1, LSH2, LSH3, LSH4 = UnitBuffID("player",324)
-----------------------------------------------------------------------------
if PQI_MavminsELEMENTALFUNCTIONS_AutoFlameShockFocus_enable then
if AOE_MODE == false
and UnitBuffID( "player", 114049 ) == nil then
if (FSHOCK == nil or FSHOCKTIMER - GetTime() <= 5)
and GetSpellCooldown(8050) == 0
and UnitIsUnit("target", "focus") ~= 1
and UnitCanAttack("player","focus") ~= nil
and IsSpellInRange(tostring(GetSpellInfo(8050)), "focus") == 1 then
-- and not LineOfSight("focus") then
if LSH1 ~= nil
and LSH4 <= 5 then
CastSpellByName(GetSpellInfo(8050), "focus")
return true
end
end
end
end
So what it currently does is first check if we are not in aoe mode, cause we should just be spamming chain lightning in that,
then if flameshock isnt on focus or it has less than 5s remaining,
then is flameshock off CD, make sure my target isn't the same as my focus, is it a unit I can attack, is it in range
then if i have less than 5 stacks of lightning shield it will do it
the thing is you dont want to cast flameshock on focus and then be stuck with extra stacks of lightning shield you cant use cause shock is on CD< well that was my thinking anyway, so what I could do is alter the lightning shield stack check maybe, depends, how much of a dps benefit is it using flame shock focus versus being stuck with 1 or 2 extra stacks on lightning shield ?
but yeah we can tweak it and you can test if you like ?