ProbablyEngine Addon - Warlords

[StinkyTwitch]

Thanks Hackinte.

[Rubim]

Then how do you suggest it work? Simcraft includes death runes in with all other rune types and it seems like everyone uses Simcraft for a rotation base.

For some skills you have to check certain runes.

You should not use Blood Boil as a DK Blood with Death Runes for example.

Make a new condition for Blood Runes, i'm using a custom one so that update does not affect me.

And about simcraft, you're kinda wrong.

actions+=/blood_boil,if=Blood=2
is DIFFERENT than
actions+=/blood_boil,if=blood=2

In addition, capitalizing the first letter of the rune type expression (e.g., Blood) will evaluate the number of ready base type runes, and additionally, the number of any ready death runes.

What we trully need is to check if a Death Rune is Frost or something else.

[ImogenOC]

For some skills you have to check certain runes.

You should not use Blood Boil as a DK Blood with Death Runes for example.

Make a new condition for Blood Runes, i'm using a custom one so that update does not affect me.

And about simcraft, you're kinda wrong.

actions+=/blood_boil,if=Blood=2
is DIFFERENT than
actions+=/blood_boil,if=blood=2


What we trully need is to check if a Death Rune is Frost or something else.

AWWWWWWWWWWW Snap, rubim is back

[Hackinte]

For some skills you have to check certain runes.

You should not use Blood Boil as a DK Blood with Death Runes for example.

Make a new condition for Blood Runes, i'm using a custom one so that update does not affect me.

And about simcraft, you're kinda wrong.

actions+=/blood_boil,if=Blood=2
is DIFFERENT than
actions+=/blood_boil,if=blood=2


What we trully need is to check if a Death Rune is Frost or something else.

That's how it works in the current edge version with regards to capitalization, also has rune.cooldown_min and rune.cooldown_max available.

[MrBrain1]

Blizzard seems to have added some new Detection Methods to the WoW Client, be careful out there.

It looks like HB User got hit the hardest. But as of now nothing can be said for sure.

[Drinksbeer]

Tried the update off of git, didn't work for me, so I went back to the older version (last push before the update) and now none of the profiles are working for me. Is anyone else getting this?

[turtlemans]

Latest edge version throwing this error:

244x Probably\system\conditions\core.lua:35: Usage: UnitBuff("unit", [index] or ["name", "rank"][, "filter"])
[C]: in function `UnitBuff'
Probably\system\conditions\core.lua:35: in function <Probably\system\conditions\core.lua:21>
Probably\system\conditions\core.lua:84: in function <Probably\system\conditions\core.lua:82>
Probably\system\core\dsl.lua:52: in function <Probably\system\core\dsl.lua:20>
(tail call): ?
Probably\system\core\parser.lua:195: in function `nested'
Probably\system\core\parser.lua:261: in function `table'
Probably\system\core\parser.lua:333: in function `table'
Probably\system\timers\rotation.lua:71: in function `cycle'
Probably\system\timers\rotation.lua:131: in function `event'
Probably\system\core\timer.lua:16: in function <Probably\system\core\timer.lua:11>

Locals:

[StinkyTwitch]

I just issued another merge request to fix this. But prior to it getting pushed you can do this.

Edit the file Probably/system/conditions/core.lua. Change line 83.

from:
spell = GetSpellInfo(spell)

to:
if type(spell) == "number" then spell = GetSpellInfo(spell) end

[aeonz]

I just issued another merge request to fix this. But prior to it getting pushed you can do this.

Edit the file Probably/system/conditions/core.lua. Change line 83.

from:
spell = GetSpellInfo(spell)

to:
if type(spell) == "number" then spell = GetSpellInfo(spell) end

This worked ty!

[StinkyTwitch]

Glad it worked. Here's the actual right way to do it . Who knew such a small thing would be so much of a cluster f? :P.

Edit the file Probably/system/conditions/core.lua. Change line 83.

From:
spell = GetSpellInfo(spell)
To:
if tonumber(spell) then spell = GetSpellInfo(spell) end

Additionally if you'd already changed the line to my previous suggestion then it would be:

From:
if type(spell) == "number" then spell = GetSpellInfo(spell) end
To:
if tonumber(spell) then spell = GetSpellInfo(spell) end

[Drinksbeer]

Is that change on the latest download ST? I hate editing LUA files, so so so novice at this stuff.

[StinkyTwitch]

this is for R15 yeah.

[Tiger23078001]

Rotations stop working on Kromag when you're in the hands. Is the game registering that as mounted? If so, how can I set it so that it doesn't stop working?

[Drinksbeer]

this is for R15 yeah.

but that's not the latest git download, right? That's just the next upcoming change?

[Hackinte]

Download 6.1r16

6.1r16
    * Fixes for fights where the game might think you're in a vehicle
    * Fixes for item usage
    * Fix LoS check on Grasping Earth
    * Fix lastcast for channeled spells
    * Fix logic for picking which units can be tanks
    * Fix saving addon settings
    * Added better rune conditions, now works just like simcraft
    * Added player.eclipseRaw (-100 to 100)
    * Added unit.stealable to check if a unit has a stealable spell, and optinally if it matches the name
    * Full support for WoWSX ( a new cross-platform lua unlocker with support for all features )
    * Many other bug internal fixes