[BETA] PQRotation - an automated ability priority queue.

[TehVoyager]

OK guys. Got some MAJOR CHANGES done to my Feral Tank Profile. Now here is the CHANGLOG:

BY THE WAY, THIS IS EXPERIMENTAL, NEED FEEDBACK!!! READ FULL POST

Changes:
- Removed Raid Mode/Heroic Mode Completely
- Fixed a couple problems where it wanted to Print Enrage Active/Berserk Active on Screen(This was my bad. Was testing other code and needed to know if it was executing it right and just never removed it )
- Added Cat DPS Support to Profile (SEE BELOW!!!!)
- Pulled Berserk Out of the profile for manual use in case of the player switching between cat/bear a lot during a boss fight.
- Maybe more? Don't remember off the top of my head

Bear/Cat Mode Explained:
- Press Right Alt to switch between Bear Mode and Cat Mode
- Depending on mode is what moves it will cast. Will automatically change the player to the respective shape-shift form
- Uses my Updated FireKitteh Profile without the Berserk added in. This is now on manual use (player clicks themselves) because of the nature of the profile.
- Cat AoE will be added in completely at a later date. Swipe code is in, just not coded yet to the specs of the profile.

Little info on the profile. This is EXPERIMENTAL and I need people to give feedback on how it is working out. While in combat, shape-shift forms land on the 1 second GCD, so for now, try and hit the Right Alt Key right before the GCD is up. This will promise the most percentage of it switching between rotations without fail. If you don't get it, just hit the button 2 more times to cycle between Bear/Cat mode and it will land on your desired rotation. I will add in, in the coming day or so, Holding Left alt to Pause the rotation to make it much much much easier to switch between rotations on a whim .

LINK IN MY SIGNATURE

EDIT* This profile was tested with a stock download of PQRotation, no other profiles loaded, so no settings should have skewed my outcome of the test any. But, again, I still want people to report feedback of how the code works. And if it works great, IT will replace the current Bear profile I have uploaded as well.

EDIT** Went ahead and added in Holding Left Alt to Pause rotation to make it much easier. So, hold Left Alt, then Hit right alt to switch between Bear Form/Cat Form.

I r teh excite.

Does your cat info include using the T13 4pc to full advantage?

-Pulled Berserk Out of the profile for manual use in case of the player switching between cat/bear a lot during a boss fight.
This is good for Spine too! nice change!

i'll run some Heroics and LFR when i get home and let you know how the Bear side feels. for the kitty side, i'll go smack a dummy for a while, or tell the other tank that i'll dps. i've been thinking about fully setting up a Bearcat set anyways.

[deadpanstiffy]

@Valma: The GCD is added to every spell regardless if it has a cooldown or not. Hence why GetSpellCoodlwon, hell, even select(2,GetSpellCooldown(spellID/name)) returns a random number right after you've launched an ability.

You're doing it wrong though by adding + 1.2 to your profile as people with less haste rating than you would effectively be screwed over. There's a way around this though.

The global cooldown can be calculated like this:

GCD = (1.5*((1 + GetCombatRating(19) / (128.057 * 100))^-1))

In other words; Base cast time * ((1 + Haste Rating / (Rating Conversion * 100))^-1) -- This turns out (with my 3035 haste rating) to be ~1.212...... seconds.

Simply subtracting this from any castable spell and using "<= 0" when you're checking if something is on cooldown will always be accurate as when something is affected by the GCD, the number returned with select(2,GetSpellCooldown()) will always be 0, otherwise it'll be a negative number. (Hence checking if a cooldown is 0 or under; i.e. negative)

This should in essence always return:
- The actual cooldown
- 0
- -gcd

GCD = (1.5*((1 + GetCombatRating(19) / (128.057 * 100))^-1))
ShadowfiendCD = (select(1,GetSpellCooldown(34433)) + select(2,GetSpellCooldown(34433)) - GetTime()) - GCD

Because it always takes the global cooldown into account, the actual global cooldown of the user (and not just some random number. Easy huh?)

Just thought I'd share a bit. :P

Why would you use combat ratings as they don't update with current buffs?

UnitSpellHaste("player") / 100

[bu_ba_911]

Why would you use combat ratings as they don't update with current buffs?

UnitSpellHaste("player") / 100

hmm that's interesting, it would register a change in haste when I tested using that method of reading haste for HPally Judgement buff...

[js1974]

Can anyone give me a little help with this ability?

if IsSpellInRange("Judgement", "target") ~= 1 then
 return false
end 

if PQ_HolyPower == 3 or PQ_Buffs[PQ_DivinePurpose].hasBuff or PQ_Buffs[PQ_Zealotry].hasBuff then
	return true
end

So what I'm attempting to do here is the following, If the player has 3 Holy Power or Divine Purpose or Zealotry active then do not use judgement, If none of those 3 variables are present then use judgement. I've tried the code a number of ways I can get it to judge if any of those 3 variables are present but I need just the opposite, Can anyone point me in the direction of what I need to do to correct this?

[bu_ba_911]

Can anyone give me a little help with this ability?

if IsSpellInRange(GetSpellInfo(20217), "target") == 1 then
  if PQ_HolyPower == 3 or PQ_Buffs[PQ_DivinePurpose].hasBuff or PQ_Buffs[PQ_Zealotry].hasBuff then
	return false
  else
                  return true
  end
end

I'm going to assume this is your Judgement spell's lua code correct? this should work

[firepong]

Can anyone give me a little help with this ability?

if IsSpellInRange("Judgement", "target") ~= 1 then
 return false
end 

if PQ_HolyPower == 3 or PQ_Buffs[PQ_DivinePurpose].hasBuff or PQ_Buffs[PQ_Zealotry].hasBuff then
	return true
end

So what I'm attempting to do here is the following, If the player has 3 Holy Power or Divine Purpose or Zealotry active then do not use judgement, If none of those 3 variables are present then use judgement. I've tried the code a number of ways I can get it to judge if any of those 3 variables are present but I need just the opposite, Can anyone point me in the direction of what I need to do to correct this?

Well, obviously, you want it to be PQ_HolyPower ~= 3 and not PQ_HolyPower == 3. With the latter set, it will only cast Judgement when he HAS 3 Holy Power. With what I said to change it to, it will then not cast unless the player has LESS than 3 holy power.

And ye, what Bubba said, you had the Return true and Return false backwards

[happydado]

I live in California.... I normally am sleeping from 1 am PST (- to 9am at least. Have I ever not answered a pm? And I recommend asking sheuron first and me second, currently being asked a lot of XD



He mentioned something about not being opposed to the idea... I'm still just slowly updating my PvP code, we'll see who's done first in this instance the slow guy, or the boss

Sent from my Xoom

ok i have send u pm about this

[MastaRage]

Interesting, I've been pondering code of some sort so that my hunter profiles will use deterrence when hour of twilight comes up and it's my turn to soak it. This is for heroic mode, have you got any suggestions? Right now I just turn my rotation off, and manually use deterrence, but I would like to flawlessly do it with minimal interaction. Maybe something that checks the Loaming Darkness debuff or something.

Hope to see this soon, I'm doing it manually also. Something like a toggle switch to stop rotation and use deterrence might work.

[thrylas]

Hey guys - I asked here the other day for a decent lock profile, and someone kindly pointed me in the right direction with Valma's or whatever it is - However ive been having trouble with it, it stops casting randomly and just stands around and if it runs out of soulshards it hangs trying to use them. atm the regular ones pull 14k in lfr (i have shit gear) and valmas only 11k on the same fight. I was wondering if anyone can tell me what im doing wrong with valma's as i see many people really like it.


Just checked PQD and when it stops doing stuff its trying to spamm soulfire but cant because its out of shards - thats one problem im having anyway sometimes it still locks when i have SS so i will keep waiting for it to happen again

[deadpanstiffy]

hmm that's interesting, it would register a change in haste when I tested using that method of reading haste for HPally Judgement buff...

For melee classes use:

GetMeleeHaste()

and hunters:

GetRangedHaste()

[wtfnix]

@Valma.... Did you modify any of your code? Seems to stop working on some bosses within LFR and Norm now under your OMFG IMBA WARLOCK. I noticed that it stood there on the boss, then on trash it would work just fine...

[thrylas]

@Valma.... Did you modify any of your code? Seems to stop working on some bosses within LFR and Norm now under your OMFG IMBA WARLOCK. I noticed that it stood there on the boss, then on trash it would work just fine...

Same problem i am having - When it happens type /PQD in your chat window and it will bring up the debug - see what it says - i find its either stuck casting soulburn or demon soul.

[merrikh]

@firepong im having a hard time with your new firebear profile. I was trying to test it out on a dummie and it wouldnt start attacking till i thrashed and then it still was a good 5 sec. after it started attacking it stopped at 3 lacerate and auto attack. this goes for cat as well

[firepong]

@firepong im having a hard time with your new firebear profile. I was trying to test it out on a dummie and it wouldnt start attacking till i thrashed and then it still was a good 5 sec. after it started attacking it stopped at 3 lacerate and auto attack. this goes for cat as well

When you start it up, before you even start attacking, try cycling through both button pushes I have. Push Right Alt to cycle through Bear Form/Cat Form and push Right Control to cycle through Single Target/AoE Mode. Let me know if this fixes it. I found this out earlier that when I started up a fresh copy of WoW and a fresh copy of PQRotation, it would just sit there, till I cycled through the buttons.

I THINK I might know why it's doing it, but I'm not 100% positive. I'll be checking it out tomorrow when I get around to playing WoW. Tonight, I missed my guild raid, so I'm going to stay off to let them cool down a little cause I'm sure their going to be pissed. But hell, what can I say, Family matters more than the game

[merrikh]

When you start it up, before you even start attacking, try cycling through both button pushes I have. Push Right Alt to cycle through Bear Form/Cat Form and push Right Control to cycle through Single Target/AoE Mode. Let me know if this fixes it. I found this out earlier that when I started up a fresh copy of WoW and a fresh copy of PQRotation, it would just sit there, till I cycled through the buttons.

I THINK I might know why it's doing it, but I'm not 100% positive. I'll be checking it out tomorrow when I get around to playing WoW. Tonight, I missed my guild raid, so I'm going to stay off to let them cool down a little cause I'm sure their going to be pissed. But hell, what can I say, Family matters more than the game

haha yea i tend to do that as well. and yea i found that out in ptr and i also tested ur cat profile part of it and it was only pulling 8k dps on ultaxion where as kittycleave pulls 18k. sadly i forgot to save the log do i could repair so ill do moer testing on it tonight. oh and lastly it doesnt shift back to bear or cat after it buffs itself