-
Contributor
-
Post Thanks / Like - 7 Thanks
-
Active Member
Is it possible to add max life and highest 4 GRift level?
Last edited by bm206; 08-27-2017 at 11:07 AM.
-
Contributor
Originally Posted by
bm206
Is it possible to add max life and highest 4 GRift level?
You can modify the column contents yourself
highest 4 GRift level There's no way to get it
-
Member
Very usefull. How I can modify it though? f.e. to add attack speed of the player, not just pets?
-
Contributor
Originally Posted by
cherouvim13
Very usefull. How I can modify it though? f.e. to add attack speed of the player, not just pets?
attack speed pet = attack speed of the player * Tasker and Theo
So, in order to save location, display attack speed pet
-
Savvy ? 🐒
Well, no wonder why you have once more a 'memory leak' here.
What's wrong :
You define a new table each frame.... (more than 60 freaking time per second !!)
What to do :
You need to move the table/lines definition outside of PaintTopInGame!
How to do it ?
- at load you define the table and only one line for you
- Inside PaintTopInGame you check if it's the same player count as previous frame => if not you redefine the lines
Result :
- no more useless memory pressure
- happy users
- bonus : happy Jack
Ps: I take no responsibility for a bad usage of my helpers
-
Post Thanks / Like - 1 Thanks
SeaDragon (1 members gave Thanks to JackCeparou for this useful post)
-
Contributor
Originally Posted by
JackCeparou
Well, no wonder why you have once more a 'memory leak' here.
What's wrong :
You define a new table each frame.... (more than 60 freaking time per second !!)
What to do :
You need to move the table/lines definition outside of PaintTopInGame!
How to do it ?
- at load you define the table and only one line for you
- Inside PaintTopInGame you check if it's the same player count as previous frame => if not you redefine the lines
Result :
- no more useless memory pressure
- happy users
- bonus : happy Jack
Ps: I take no responsibility for a bad usage of my helpers
I need tables to refresh with the number of players
Let me have a try
Thank you for your reply, JACK
-
Contributor
Originally Posted by
JackCeparou
Well, no wonder why you have once more a 'memory leak' here.
What's wrong :
You define a new table each frame.... (more than 60 freaking time per second !!)
What to do :
You need to move the table/lines definition outside of PaintTopInGame!
How to do it ?
- at load you define the table and only one line for you
- Inside PaintTopInGame you check if it's the same player count as previous frame => if not you redefine the lines
Result :
- no more useless memory pressure
- happy users
- bonus : happy Jack
Ps: I take no responsibility for a bad usage of my helpers
I don't know how to get the data
I can't compare the data on the line
-
Savvy ? 🐒
-
Post Thanks / Like - 1 Thanks
SeaDragon (1 members gave Thanks to JackCeparou for this useful post)
-
Contributor
Hi, nice work. Will be great if there will be elite and elemental dmg
-
Contributor
Originally Posted by
JackCeparou
It works, but a little BUG, and when there is a player exiting from the team, the hoveredPlayerIndex may be wrong,Cannot highlight correctly
-
Contributor
Originally Posted by
MrOne
Hi, nice work. Will be great if there will be elite and elemental dmg
You can add or modify this form yourself
-
Savvy ? 🐒
Originally Posted by
SeaDragon
It works, but a little BUG, and when there is a player exiting from the team, the hoveredPlayerIndex may be wrong,Cannot highlight correctly
Well, this bug was there before my refactoring... Gist updated with PortraitIndex, i guess this should work.
-
Contributor
Originally Posted by
JackCeparou
Well, this bug was there before my refactoring... Gist updated with PortraitIndex, i guess this should work.
Now hoveredPlayerIndex does not correspond to the player index
The player's index will not be rebuilt after the player leaves
-
Savvy ? 🐒
Oh god..
Seriously i think i'm not helping you but make you an assisted by rewriting all you make.
- You don't even search solution by yourself anymore but beg for it.
- You don't learn from your mistake and this begin to annoy me.
Back on topic :
I just came home & tested in a public game, Line hightlight in my version with PortraitIndex is working perfectly here.
Edit, changed game and it's mixed up, fix incoming.
Last edited by JackCeparou; 08-28-2017 at 11:35 AM.