[Help] with legendary count

[Csavo]

Hello everyone. I was working on a plugin that counts legendary drops (normal, ancient and primal too), and I came across an issue I don't know how to fix. Here is the plugin: Pastebin

The issue is, when a legendary drops, the counter is increasing like crazy until its picked up. If you can advise me how to make it increase only by 1 for each dropped legendary, please share your idea

Thank you

[JackCeparou]

[C#] LegendaryCountPlugin (Csavo) - Pastebin.com

[Csavo]

Thanks Jack, but there seems to be an issue still. The normal legendary counter is counting every single item dropped on the ground by monsters. Even gold stacks increase it
The Ancient/Primal counter seems to work OK (got 1 ancient while testing, and it increased by 1)

Changing the line

if (item.AncientRank == 0) LegendaryCount++;  

results in the same thing. every single dropped item is counted.

[JackCeparou]

results in the same thing. every single dropped item is counted.

Not true, this is not the same thing, your previous version was increasing till you pickup the item..

Tbh, you should be able to spot the error and fix it yourself.
Pastebin from my previous post updated.

[Csavo]

Not true, this is not the same thing, your previous version was increasing till you pickup the item..

Sorry if I was confusing, but I meant changing the line if (item.AncientRank >= 0) LegendaryCount++; to if (item.AncientRank == 0) LegendaryCount++; resulted in the same manner (from your first version). I know my original code was increasing the count until the item was picked up.

Tbh, you should be able to spot the error and fix it yourself.

I think you overestimate my coding skills I never saw that OnLootGenerated method before, I had no idea about it and what it does, and I assumed if the counter worked with .AncientRank == 1 and 2, it should be working with 0 too (I thought .AncientRank == 0 means legendary item)

Pastebin from my previous post updated.

Thank you once again! I had to remove the item.SetSno != uint.MaxValue (what does this even do?) filter from the if though, because it filtered out some legos (first test run got about 10 legs, but the counter only showed 3). After removing it, the counter correctly showed 9 / 1 / 0 on a 2nd test run where 9 legs dropped, 1 of them being an ancient.

I will soon post the plugin in the review section, and give credits to you.

[JackCeparou]

I had to remove the item.SetSno != uint.MaxValue (what does this even do?)

This is to get only set items, not legendaries.
As it was in your 1st version i assumed you wanted it like this.

[Csavo]

This is to get only set items, not legendaries.
As it was in your 1st version i assumed you wanted it like this.

Oh lol, had no idea, I just stole it from your MinimapLeftAlertListPlugin config

[Csavo]

God dang it! Something is still not right...


Current code: Pastebin

It didnt count the very first drop (Chanon Bolter), and the 5th (Tyrael's Might) or 6th (Sash of Knives), not exactly sure.