FH + UnitsAroundUnit invalid? menu

User Tag List

Results 1 to 8 of 8
  1. #1
    bfwlegend's Avatar Member
    Reputation
    4
    Join Date
    Jul 2007
    Posts
    71
    Thanks G/R
    0/1
    Trade Feedback
    1 (100%)
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)

    FH + UnitsAroundUnit invalid?

    So in BRF on some fights like hans & franz and flamebender, and probably a few others I haven't noticed yet the count for UnitsAroundUnit seems to be invalid sometimes, I'm guessing on the fights it's registering mechanics (like the stamps and hot plates during hans&franz and the weapons during flamebender) as enemy units thus giving an invalid count and causing the rotation to trigger AoE spells while not actually at the required units.

    Hans & Franz (Max of only two targets at any given time)
    https://i.imgur.com/GOkdfB4.jpg
    https://i.imgur.com/MgiOMwT.jpg

    Flamebender (Max of only 1 target as the wolfs weren't spawn at the time of the dump)
    https://i.imgur.com/la1nUTF.jpg

    FH + UnitsAroundUnit invalid?
  2. #2
    StinkyTwitch's Avatar Active Member
    Reputation
    40
    Join Date
    Nov 2014
    Posts
    172
    Thanks G/R
    19/13
    Trade Feedback
    1 (100%)
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    There's a couple of issues. The first is that UnitsAroundUnit doesn't do a health check and so before a corpse disappears it gets counted. Second is the issue of UnitAffectingCombat. A lot of these add fights have adds that do not trigger the UnitAffectingCombat. I'm testing some different checks that should fix both issues.
    "Shootings easy, Aimings hard!" Stinky

  3. #3
    ImogenOC's Avatar Contributor ProbablyEngine Community Manager
    Reputation
    173
    Join Date
    Nov 2013
    Posts
    364
    Thanks G/R
    0/8
    Trade Feedback
    1 (100%)
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Originally Posted by StinkyTwitch View Post
    There's a couple of issues. The first is that UnitsAroundUnit doesn't do a health check and so before a corpse disappears it gets counted. Second is the issue of UnitAffectingCombat. A lot of these add fights have adds that do not trigger the UnitAffectingCombat. I'm testing some different checks that should fix both issues.
    This is correct. You can circumvent this with a unit manager... Which no one has made insofar.
    ProbablyEngine - Developer and Lead Support
    A Powerful Rotation Bot: ProbablyEngine

  4. #4
    StinkyTwitch's Avatar Active Member
    Reputation
    40
    Join Date
    Nov 2014
    Posts
    172
    Thanks G/R
    19/13
    Trade Feedback
    1 (100%)
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Originally Posted by ImogenOC View Post
    This is correct. You can circumvent this with a unit manager... Which no one has made insofar.
    You mean no one has released one yet .
    "Shootings easy, Aimings hard!" Stinky

  5. #5
    svs's Avatar Active Member
    Reputation
    15
    Join Date
    Feb 2012
    Posts
    89
    Thanks G/R
    9/1
    Trade Feedback
    0 (0%)
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Originally Posted by bfwlegend View Post
    like the stamps and hot plates during hans&franz and the weapons during flamebender[/url]
    On Ka'graz it's dead wolves

  6. #6
    StinkyTwitch's Avatar Active Member
    Reputation
    40
    Join Date
    Nov 2014
    Posts
    172
    Thanks G/R
    19/13
    Trade Feedback
    1 (100%)
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Working on it Svs .
    "Shootings easy, Aimings hard!" Stinky

  7. #7
    bfwlegend's Avatar Member
    Reputation
    4
    Join Date
    Jul 2007
    Posts
    71
    Thanks G/R
    0/1
    Trade Feedback
    1 (100%)
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Found out that the hot plates and stampers on the hans and franz fight return false to UnitCanAttack("player", object) while the bosses return true, I'm sure this will fix some of the issues on some fights where it detects non attack-able objects as enemies.

    But I'm just starting to dab into WoWs Lua so I'm just winging it, gonna try to add a check in the UnitsAroundUnit to fix some of the issues. I'll be running all the wings of LFR and see if I notice any other fights throwing an incorrect value from the UAU function.


    results from a print 'debug' in the UAU function (only 1 boss was down at the time of the screenshot and hot plates were rolling out)

    FH + UnitsAroundUnit invalid?-mxvsjmy-png

    Let me know if I'm headed in the wrong direction, I'm trying to contribute back to the community for making my raiding life easy.
    Last edited by bfwlegend; 03-06-2015 at 04:31 PM.

  8. #8
    Garden's Avatar Member
    Reputation
    1
    Join Date
    Mar 2015
    Posts
    21
    Thanks G/R
    0/0
    Trade Feedback
    0 (0%)
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    Hey !

    Any ETA on this ?

Similar Threads

  1. Custom items invalid ingame????
    By pioneer1337 in forum World of Warcraft Emulator Servers
    Replies: 5
    Last Post: 03-31-2008, 10:09 PM
  2. [Help] "Invalid Instance"
    By Gorge in forum World of Warcraft Emulator Servers
    Replies: 3
    Last Post: 02-25-2008, 12:52 PM
  3. Information You have entered is invalid
    By djblade17 in forum World of Warcraft Emulator Servers
    Replies: 9
    Last Post: 12-24-2007, 03:21 AM
  4. Invalid Instances?
    By DarthFly in forum World of Warcraft Emulator Servers
    Replies: 0
    Last Post: 10-12-2007, 01:57 PM
  5. Invalid MPQ
    By ZLau in forum WoW ME Questions and Requests
    Replies: 0
    Last Post: 05-25-2007, 12:31 PM
All times are GMT -5. The time now is 09:19 AM. Powered by vBulletin® Version 4.2.3
Copyright © 2024 vBulletin Solutions, Inc. All rights reserved. User Alert System provided by Advanced User Tagging (Pro) - vBulletin Mods & Addons Copyright © 2024 DragonByte Technologies Ltd.
Digital Point modules: Sphinx-based search