Difference between CastSpellByID() and CastSpellByName(GetSpellInfo())

[MrHeroe]

Hey,

while trying to find that nasty code thats taint my profile im experimenting with different calls.

The strange thing is - when i use CastSpellByName(GetSpellInfo(xx),xx) everything works. I can use a table entry as target for example. CastSpellByName(GetSpellInfo(xx),members[x].Unit) (Thx Nova Team )

now, when i changed my ability execution to CastSpellByID(xxx,xxx) only a few spells works. That is strange. There are no errors the spells just wont be executed under its conditions. The spells that works are (MOST TIMES!) global strings like "player". But String like "target" or "mouseover" didnt.

CastSpellByID(xxx,"player") -> works
CastSpellByID(xxx,"focus") -> didnt work
CastSpellByID(xxx,members[x].Unit) -> didnt work

As i said no errors (even tested with PQR_Debug and ZeroBrane Syntax check)!

Can you help me? Those unlogic nightmares makes me crazy!!!!!!!!!!!!!!!!!

[crystal_tech]

pqr uses/used castspellbyid in the spellid box when you create the ability. with mop they started to share ids(morphed ids) and thats where byid breaks on pqr, if you use the root spellid it would work but for some profiles it locked up till you move your toon around. I just created my own cast function that makes it easy to input unitid and spellid that all i need to do is add before a return true.

just a note:
don't put a return true in the cast function as you'll run into casting 2 times.

_shorthand = nil
function _shorthand()
	_Chat = PQR_WriteToChat
	_UB = UnitBuffID
	_UDB = UnitDebuffID
	_Mod = Nova_Mod
	_SA = PQR_SpellAvailable
	_PS = IsPlayerSpell
	_SIR = IsSpellInRange
	_GI	= GetSpellInfo
	_UE = UnitExists
	_CSN = CastSpellByName
end

_shorthand()
	
	_checkSpell = nil
	function _checkSpell(sid, tar)
		if _UE(tar) then
			if _PS(sid) and _SA(sid) then
				if tar ~= nil then
					if _SIR(_GI(78), tar) == 1 then return true else return false end 
                                       --atm its set to warriors heroic strike, just change the number to a common melee/ranged spell (ie: arcane shot for hunters)
				elseif tar == nil then
					return true
				end
			else
				return false
			end
		end
	end
	
	_Cast = nil
	function _Cast(sid, tar)
		_CSN(_GI(sid), tar)
	end